From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C4FC433EF for ; Tue, 26 Oct 2021 15:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD1C760F02 for ; Tue, 26 Oct 2021 15:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232783AbhJZPbd (ORCPT ); Tue, 26 Oct 2021 11:31:33 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:40237 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230523AbhJZPbb (ORCPT ); Tue, 26 Oct 2021 11:31:31 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MSKly-1mCt9W2ZC4-00Semh for ; Tue, 26 Oct 2021 17:29:06 +0200 Received: by mail-wm1-f43.google.com with SMTP id 67-20020a1c1946000000b0030d4c90fa87so2580214wmz.2 for ; Tue, 26 Oct 2021 08:29:06 -0700 (PDT) X-Gm-Message-State: AOAM530jVwSXp+jG1155YfWWb/pa40ORdSjwpyc2o5TQAnMaIU0UqgYw tM4Zb0NHPflOPahbgQinN3eL902efAWJBE8vO5g= X-Google-Smtp-Source: ABdhPJwUHpsOrThxJ7PMSi5UMOgHC/s6cLM5xggqEP9OYbwlu2E+PpcpuWQjE6DvwVvK2nJqeunCdT5x05N4/EDXuMM= X-Received: by 2002:a7b:ce93:: with SMTP id q19mr15403059wmj.98.1635262146250; Tue, 26 Oct 2021 08:29:06 -0700 (PDT) MIME-Version: 1.0 References: <20210901123557.1043953-1-liu.yun@linux.dev> <957585d9-2f0f-7181-bba3-69c690c92f6f@canonical.com> In-Reply-To: <957585d9-2f0f-7181-bba3-69c690c92f6f@canonical.com> From: Arnd Bergmann Date: Tue, 26 Oct 2021 17:28:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc() To: Krzysztof Kozlowski Cc: Arnd Bergmann , Jackie Liu , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Linux ARM , Jackie Liu Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:cQ+Of3HJw6ktGhxncg51t5DVQfzAAqFL5/Jh9l3E7ijrQYj10Nn QHpHXUB7MSYRmMfzAzRciYRNGAmZ3T8YSPd+/Bt+bUy+C7N+Q2hSa30I9UWphVC64UIydvm 7n4eRH0qUffJc34KyYZFpch5vmxGsHQk+lSegWFw1+6t7DNadJNVo7IJRwVgTLv36xn+m/A lJj87fmXya4MoXBDn4CjQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:sK5JzR4WDHc=:V3djjVp94wOdq2Iu2/p79h pPZfjhvtLTvyGfREgn2KKIfkWjFKoZzLubl1CXTyEKlzYbms4531vM45hcQKLdXyNanoaENFN rQaw5anr7vv0PaRH4U+8cy7STiZempyQsbrHht1mRZuCgyTeK7bHDQtxThIo/VqzPheaBbmL7 J+XDonpOvGNQzXHCj1k/T2flki+Mwp9uBXo7GX0cgt5YzmHyGX+MeCP6IVMzwHQnRBL8swZXG WmDbPeznJSnF7IPQG4Ll5HEGAHx8+UkCmegecsycv/6MjTL4o9N9Ea19fLPsOlgIt5BKMcJ+J herZq1uOjbGrtnZpTonCJvi8oacN34788L7TYY1p9/o2TWYOFnkQzEs7SG+fyC8WTixpISZyL m13riz2C4uW7uhdB4J7S7qZnQDtnmos3AVVd9SUgPY/VpldpZMAZV+Aq6S3afOeF/7DTFQyPX Bh8U6JV7lEFdO2VXsoZZ1jDAoz/5M04RVcj8to4Tuh9X5yA0W4FQwT+iXEB/4Rt681sb4d6Kj 1DUNjpLXgXS1AQF+f7ao2WGaKo4cnjDoblai5QTGxQ+6czmo2qeXNj82ut8YuqTc3Xcs5r7em hIZMEucl7h6Z3ly+KUoHfkzXr8rRHx/z/n8qYK+9hIITjG+O5QpVKPEdBZ2OT7r9eAgptK5sm IMxZdOCJauGwXJjPcR7/ptwbRIwbMVLzoLvMTitI7SAqlRv99g4bGQk2n7MfmFH+ZAAiIX9hl JTZG4nMLbnHi3Gm6WlYSRuY2oHC/sWHAPmUwULozToc7xW5mmrXLQZP2WrxvdpVvJCZk8a/hg pNSpR4lsddg+FXr1yz2YQ63QD+ZIIrVnRoOpPjNDIwweOMH6W4= Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Tue, Oct 26, 2021 at 5:22 PM Krzysztof Kozlowski wrote: > On 26/10/2021 17:10, Arnd Bergmann wrote: > > On Wed, Sep 1, 2021 at 2:35 PM Jackie Liu wrote: ... > > Nothing actually uses the return code of s3c24xx_init_intc(), so returning > > NULL on error there and changing all the checks to that would be a much > > more straightforward solution. > > > > Any chance you could send a follow-up to do that? > > I can work on this but you know this is a legacy platform and none of us > can test it? Sure. I was actually hoping for Jackie to send you that follow-up. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96348C433EF for ; Tue, 26 Oct 2021 15:30:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66DAA60EDF for ; Tue, 26 Oct 2021 15:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 66DAA60EDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i/FgoOu746QYB2snd/zU1G00duCZ4rrBner3CKihRZM=; b=UNbnF4Hl30yOh+ xKBSogOmxpCNxCEXdEdHz5dLgSteXGY1YyZkPaGn5r8zTx9pABQV3JzCVtIel7/BEK29JAonJKTxn 0AdB5fKEx5qmW+tixKyDjGJ+y75gV1e4E/zSemTcxY4nAg57s5yU31mWWWYvj7UHyofOxrtpkOKgR teLB6FJTjp9hxxR1hRXuQrX977cF2IZr5+qm9jogwgJz8kxdG2C1+/6kYYCv28PGgqdCmvuMOwTnb otnLVPKBV3ykNNRsvIrY4Dxn2KEk3pwDcQ7AVD6MyVBofo5Mspci/k8o+CDdhDieMmv+Nr+Yz6zwZ oXAlLovmhxZ9WVgZtQQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfOO1-002BIS-Ks; Tue, 26 Oct 2021 15:29:13 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfONx-002BHG-VG for linux-arm-kernel@lists.infradead.org; Tue, 26 Oct 2021 15:29:11 +0000 Received: from mail-wm1-f44.google.com ([209.85.128.44]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MeD1l-1nGe972yVb-00bM5E for ; Tue, 26 Oct 2021 17:29:06 +0200 Received: by mail-wm1-f44.google.com with SMTP id 67-20020a1c1946000000b0030d4c90fa87so2580215wmz.2 for ; Tue, 26 Oct 2021 08:29:06 -0700 (PDT) X-Gm-Message-State: AOAM530xXcKWF/a0H2ca7X/vHVn7tGRc+q7NqX4ZX7g79MMfDgiYgd+7 NBElQlMib0A+FPe4DeV0ZnYS0u/6tyf8OUti/YM= X-Google-Smtp-Source: ABdhPJwUHpsOrThxJ7PMSi5UMOgHC/s6cLM5xggqEP9OYbwlu2E+PpcpuWQjE6DvwVvK2nJqeunCdT5x05N4/EDXuMM= X-Received: by 2002:a7b:ce93:: with SMTP id q19mr15403059wmj.98.1635262146250; Tue, 26 Oct 2021 08:29:06 -0700 (PDT) MIME-Version: 1.0 References: <20210901123557.1043953-1-liu.yun@linux.dev> <957585d9-2f0f-7181-bba3-69c690c92f6f@canonical.com> In-Reply-To: <957585d9-2f0f-7181-bba3-69c690c92f6f@canonical.com> From: Arnd Bergmann Date: Tue, 26 Oct 2021 17:28:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc() To: Krzysztof Kozlowski Cc: Arnd Bergmann , Jackie Liu , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Linux ARM , Jackie Liu X-Provags-ID: V03:K1:gSgiQqU7nhZ2rtcT4+ZeFJpAWrRdd684oTD3BT2if6iYPlVxco6 nYT14nql8FPUNwRlddmpEBOihHZxoJ1lhNsSXCZePChn6wiRHz7w4dQIGlbFt7lyPgJWflB hLAMnGhavVYuaz30XBTQhjPEKdx24a+of3UXSgh1YhfM07EBWcAmkPUD1PBwN/k15gjAvIO S8PxoejxXmOGbg5gwQdYw== X-UI-Out-Filterresults: notjunk:1;V03:K0:VVFsx8DfMsg=:gUdR3OZefZPd6K7SoQ/Ndq M+TqCWLJZxwsf7Tq+yn1/RfLUC93BeH1CHO+7HxN2Mi0VIeDYGkTiJLZg+PRchIe7CnQLSWl+ Yr2oA3lMS6RK0+J7KbKLpA67VgLNL37tp7kArSQJTt8ZMA7Zc+QwXa/OOgdOQFNdEoofH5vQb Xj7tVJjm6eZQBpCYenymF577IVq7cwD3skIP6RabR5QZya0F1WgcMcJyyCQW+4WxMroCrCaPl ICRsL8T6hU8y3kRZFPOWyAauf51RfFSjUpL63vAkM8F8X1o8oTZmC9nIBRLk2RaiALIC+IEj/ zmMSIpF6rtvg9PAgCLxxPeuw1CXZy9OF3Voefg3G9SlaoGbwYoeWQ+uHCWq1g8VWimSnO4boN Vt7x7PNidkaJZCivrptxYT8epO68mdnFOJJBs/C/IavIQRRHcjkmpL4J53nvUjKdD4XTRNNt+ G50O02l/gfMS36M/gWE1+y39ObFo1TKlKACgl9gmtOssE6NcykvQ5t3YZSu2lQVnuzaZ2DsAl Bt8p1xh8jAKaD/1zcOhqZOvkNrnT0aJCalxEkhLhzhJ5RweBNfqciC5ii2Sko6Gm20QklAmGr BMO2bRDghXkONotG4hcLNCs/4MS1Rpyc5Eh0hLem/f4bKuCBpibDyUOMbsaaCx1HG/Gqr38Rl cvt1+78JR7X5hSXxsT5wsUVqxMJ0ZL6GWKBZ/ny6EdvwaGg85nM8x5ZuQTQvtkeRhtQm3M3S1 rX/NyyQF3X+8yVKNnaFMoFZvyIELbMCo9SEOHqAkftTeWN1d3SN+ay+SoFMJCbWxlUR8k/kDf J89Q6T1GARg3ZxI/HksPsQkqrKvATjvY7X3ncQnbmHfARoXCZM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_082910_320526_23F1840A X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 26, 2021 at 5:22 PM Krzysztof Kozlowski wrote: > On 26/10/2021 17:10, Arnd Bergmann wrote: > > On Wed, Sep 1, 2021 at 2:35 PM Jackie Liu wrote: ... > > Nothing actually uses the return code of s3c24xx_init_intc(), so returning > > NULL on error there and changing all the checks to that would be a much > > more straightforward solution. > > > > Any chance you could send a follow-up to do that? > > I can work on this but you know this is a legacy platform and none of us > can test it? Sure. I was actually hoping for Jackie to send you that follow-up. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel