From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 036165A0A; Tue, 1 Mar 2022 14:46:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A050EC36AE2; Tue, 1 Mar 2022 14:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646145969; bh=O7PMjYoyVgpMGjTVJdUqo4vjOgkMH6zVD28CMdfxejY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ScbK0J6pozv/c2GDJYHlIZpbvfONFwSIK/2j9QTvGy0h6OxUAoFSJS7ACLBifahWv DcEHKw3lZtb+uu9XBfWLbqlt4501Amp6VUN+Dzs96ZiZLJ0WrXZIhbPfc31qIWMyNy ATq4x+Oqa8aCq2GW5gs+Y/j2lbHCJQUV8G4qbfbhkoke2or1lVhj8owINILXGePjRZ R7WocAjuMhKmJQAgH9JZzvEWwPneWdjxvB9/qREXxhHUchmngRvsvQS8MYiNKoAhTS lRIGGo0c7PSqmvXlDIU+2nV4tRgWSUE8CyjB1CiW2iruBEJHgJWl3+5y31XDNWkEo7 0CfBGfIlQclkw== Received: by mail-wm1-f44.google.com with SMTP id 6-20020a05600c024600b0038125fa8e43so1355097wmj.0; Tue, 01 Mar 2022 06:46:09 -0800 (PST) X-Gm-Message-State: AOAM5324vdhdnlX9Y7zwap3VcClGHpDNe9H1/H/zQWVMtGt9CeEvTuIR /aRsC4g7Ty0MmWRpxnP78cS7YpfeWmTAo4SLpn8= X-Google-Smtp-Source: ABdhPJxXTbyRPUGWO5ZqEHYDoeKGRHcrrv5eZPJqecMQqdHX7hdx2ouYJfmaJG1ZffheKZ5NWAXaiF6wK5E6lkn8a4k= X-Received: by 2002:a7b:c001:0:b0:381:1afd:5caa with SMTP id c1-20020a7bc001000000b003811afd5caamr17359158wmb.35.1646145967920; Tue, 01 Mar 2022 06:46:07 -0800 (PST) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220228103142.3301082-1-arnd@kernel.org> <20220228214145.o37bgp3zl3rxpeo4@google.com> In-Reply-To: <20220228214145.o37bgp3zl3rxpeo4@google.com> From: Arnd Bergmann Date: Tue, 1 Mar 2022 15:45:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11 To: Fangrui Song Cc: Nick Desaulniers , Linux Kbuild mailing list , Arnd Bergmann , Linus Torvalds , Masahiro Yamada , llvm@lists.linux.dev, Jonathan Corbet , Federico Vaga , Alex Shi , Hu Haowen , Michal Marek , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-doc-tw-discuss@lists.sourceforge.net, Linux ARM , Intel Graphics , dri-devel , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-btrfs Content-Type: text/plain; charset="UTF-8" On Mon, Feb 28, 2022 at 10:41 PM Fangrui Song wrote: > > > >More precisely, the semantics of "extern inline" functions changed > >between ISO C90 and ISO C99. > > Perhaps a clearer explanation to readers is: "extern inline" and "inline" swap > semantics with gnu_inline (-fgnu89-inline or __attribute__((__gnu_inline__))). > > >That's the only concern I have, which I doubt is an issue. The kernel > >is already covered by the function attribute as you note. > > > >Just to have some measure: > >$ git grep -rn "extern inline" | wc -l > >116 > > "^inline" behaves like C99+ "extern inline" > > Agree this is handled by > > #define inline inline __gnu_inline __inline_maybe_unused notrace > Ok, I've reworded it again, but kept it a bit shorter, I don't think we need the full explanation in this patch description in the end. Thanks, Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1953DC433F5 for ; Tue, 1 Mar 2022 14:46:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7827C10E588; Tue, 1 Mar 2022 14:46:12 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8B6310E588; Tue, 1 Mar 2022 14:46:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 409F361520; Tue, 1 Mar 2022 14:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A403BC36AE3; Tue, 1 Mar 2022 14:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646145969; bh=O7PMjYoyVgpMGjTVJdUqo4vjOgkMH6zVD28CMdfxejY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ScbK0J6pozv/c2GDJYHlIZpbvfONFwSIK/2j9QTvGy0h6OxUAoFSJS7ACLBifahWv DcEHKw3lZtb+uu9XBfWLbqlt4501Amp6VUN+Dzs96ZiZLJ0WrXZIhbPfc31qIWMyNy ATq4x+Oqa8aCq2GW5gs+Y/j2lbHCJQUV8G4qbfbhkoke2or1lVhj8owINILXGePjRZ R7WocAjuMhKmJQAgH9JZzvEWwPneWdjxvB9/qREXxhHUchmngRvsvQS8MYiNKoAhTS lRIGGo0c7PSqmvXlDIU+2nV4tRgWSUE8CyjB1CiW2iruBEJHgJWl3+5y31XDNWkEo7 0CfBGfIlQclkw== Received: by mail-wm1-f44.google.com with SMTP id l2-20020a7bc342000000b0037fa585de26so1125809wmj.1; Tue, 01 Mar 2022 06:46:09 -0800 (PST) X-Gm-Message-State: AOAM5339YuVfddwoXv8HOO/Q/VnPwTmUhSbv1XR37SyQoXGyA5ElLI+1 DgbcJBWcWC64jiUfc0IgZrzI8hsZ6on+lfpoJXw= X-Google-Smtp-Source: ABdhPJxXTbyRPUGWO5ZqEHYDoeKGRHcrrv5eZPJqecMQqdHX7hdx2ouYJfmaJG1ZffheKZ5NWAXaiF6wK5E6lkn8a4k= X-Received: by 2002:a7b:c001:0:b0:381:1afd:5caa with SMTP id c1-20020a7bc001000000b003811afd5caamr17359158wmb.35.1646145967920; Tue, 01 Mar 2022 06:46:07 -0800 (PST) MIME-Version: 1.0 References: <20220228103142.3301082-1-arnd@kernel.org> <20220228214145.o37bgp3zl3rxpeo4@google.com> In-Reply-To: <20220228214145.o37bgp3zl3rxpeo4@google.com> From: Arnd Bergmann Date: Tue, 1 Mar 2022 15:45:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11 To: Fangrui Song Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Corbet , Michal Marek , "open list:DOCUMENTATION" , Arnd Bergmann , Linux Kbuild mailing list , linux-staging@lists.linux.dev, Masahiro Yamada , llvm@lists.linux.dev, Nick Desaulniers , Linux Kernel Mailing List , dri-devel , greybus-dev@lists.linaro.org, Linux ARM , Federico Vaga , Hu Haowen , Intel Graphics , linux-btrfs , Linus Torvalds , linux-doc-tw-discuss@lists.sourceforge.net, Alex Shi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 28, 2022 at 10:41 PM Fangrui Song wrote: > > > >More precisely, the semantics of "extern inline" functions changed > >between ISO C90 and ISO C99. > > Perhaps a clearer explanation to readers is: "extern inline" and "inline" swap > semantics with gnu_inline (-fgnu89-inline or __attribute__((__gnu_inline__))). > > >That's the only concern I have, which I doubt is an issue. The kernel > >is already covered by the function attribute as you note. > > > >Just to have some measure: > >$ git grep -rn "extern inline" | wc -l > >116 > > "^inline" behaves like C99+ "extern inline" > > Agree this is handled by > > #define inline inline __gnu_inline __inline_maybe_unused notrace > Ok, I've reworded it again, but kept it a bit shorter, I don't think we need the full explanation in this patch description in the end. Thanks, Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36710C433EF for ; Tue, 1 Mar 2022 14:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EOHLvjRSJ2f1hTmWfVcScKxx9LmyVGox8pUe0zH0Jjw=; b=Ok6ktrPeud7KVA /5NW8vVX45ofmn25l+x2PWV+UhCNHQMjleA5YSuCCMBQPwpoxdlW5Js0g52BEXYErsw1hwXr49bGH U6vXC8tR0HOOvxGLk04eJlWAb6/jE1qgygLme0qUawkQ4vMjhFA6ep09/h+cIUPKPty3GBV8zFevS Ev5p2VC3klI4coOjmgEkljBnmMwLtTtMB0zYEA9eFDlDy3wW0BZOOjoEWVUxWEGqV2hpgXJp6HHEa ZwReaoLjgpS+xqYIBJDsW0OL2ckirO5y9SHWUm3m9ZlTuWO0yQry3ubNGfgdf5uY+65gsy5ENAN3A Dl2pfX7J8mub3aYaHjyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP3lX-00H818-ID; Tue, 01 Mar 2022 14:46:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP3lT-00H7zK-9Y for linux-arm-kernel@lists.infradead.org; Tue, 01 Mar 2022 14:46:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4C32615F7 for ; Tue, 1 Mar 2022 14:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A35D3C340F3 for ; Tue, 1 Mar 2022 14:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646145969; bh=O7PMjYoyVgpMGjTVJdUqo4vjOgkMH6zVD28CMdfxejY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ScbK0J6pozv/c2GDJYHlIZpbvfONFwSIK/2j9QTvGy0h6OxUAoFSJS7ACLBifahWv DcEHKw3lZtb+uu9XBfWLbqlt4501Amp6VUN+Dzs96ZiZLJ0WrXZIhbPfc31qIWMyNy ATq4x+Oqa8aCq2GW5gs+Y/j2lbHCJQUV8G4qbfbhkoke2or1lVhj8owINILXGePjRZ R7WocAjuMhKmJQAgH9JZzvEWwPneWdjxvB9/qREXxhHUchmngRvsvQS8MYiNKoAhTS lRIGGo0c7PSqmvXlDIU+2nV4tRgWSUE8CyjB1CiW2iruBEJHgJWl3+5y31XDNWkEo7 0CfBGfIlQclkw== Received: by mail-wm1-f50.google.com with SMTP id q7-20020a7bce87000000b00382255f4ca9so871187wmj.2 for ; Tue, 01 Mar 2022 06:46:09 -0800 (PST) X-Gm-Message-State: AOAM532OOxLSmkNhTfobfScnTjvW024X+QQI/MQrm88Z+7uxMoc/7US1 wxLsR2APWWQitI/YwsZfqrFm6FH3NZCHr4W18ag= X-Google-Smtp-Source: ABdhPJxXTbyRPUGWO5ZqEHYDoeKGRHcrrv5eZPJqecMQqdHX7hdx2ouYJfmaJG1ZffheKZ5NWAXaiF6wK5E6lkn8a4k= X-Received: by 2002:a7b:c001:0:b0:381:1afd:5caa with SMTP id c1-20020a7bc001000000b003811afd5caamr17359158wmb.35.1646145967920; Tue, 01 Mar 2022 06:46:07 -0800 (PST) MIME-Version: 1.0 References: <20220228103142.3301082-1-arnd@kernel.org> <20220228214145.o37bgp3zl3rxpeo4@google.com> In-Reply-To: <20220228214145.o37bgp3zl3rxpeo4@google.com> From: Arnd Bergmann Date: Tue, 1 Mar 2022 15:45:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11 To: Fangrui Song Cc: Nick Desaulniers , Linux Kbuild mailing list , Arnd Bergmann , Linus Torvalds , Masahiro Yamada , llvm@lists.linux.dev, Jonathan Corbet , Federico Vaga , Alex Shi , Hu Haowen , Michal Marek , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-doc-tw-discuss@lists.sourceforge.net, Linux ARM , Intel Graphics , dri-devel , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-btrfs X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_064611_416104_1124F0AE X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 28, 2022 at 10:41 PM Fangrui Song wrote: > > > >More precisely, the semantics of "extern inline" functions changed > >between ISO C90 and ISO C99. > > Perhaps a clearer explanation to readers is: "extern inline" and "inline" swap > semantics with gnu_inline (-fgnu89-inline or __attribute__((__gnu_inline__))). > > >That's the only concern I have, which I doubt is an issue. The kernel > >is already covered by the function attribute as you note. > > > >Just to have some measure: > >$ git grep -rn "extern inline" | wc -l > >116 > > "^inline" behaves like C99+ "extern inline" > > Agree this is handled by > > #define inline inline __gnu_inline __inline_maybe_unused notrace > Ok, I've reworded it again, but kept it a bit shorter, I don't think we need the full explanation in this patch description in the end. Thanks, Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CEE5C433FE for ; Tue, 1 Mar 2022 20:03:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B2A810E821; Tue, 1 Mar 2022 20:03:02 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8B6310E588; Tue, 1 Mar 2022 14:46:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 409F361520; Tue, 1 Mar 2022 14:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A403BC36AE3; Tue, 1 Mar 2022 14:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646145969; bh=O7PMjYoyVgpMGjTVJdUqo4vjOgkMH6zVD28CMdfxejY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ScbK0J6pozv/c2GDJYHlIZpbvfONFwSIK/2j9QTvGy0h6OxUAoFSJS7ACLBifahWv DcEHKw3lZtb+uu9XBfWLbqlt4501Amp6VUN+Dzs96ZiZLJ0WrXZIhbPfc31qIWMyNy ATq4x+Oqa8aCq2GW5gs+Y/j2lbHCJQUV8G4qbfbhkoke2or1lVhj8owINILXGePjRZ R7WocAjuMhKmJQAgH9JZzvEWwPneWdjxvB9/qREXxhHUchmngRvsvQS8MYiNKoAhTS lRIGGo0c7PSqmvXlDIU+2nV4tRgWSUE8CyjB1CiW2iruBEJHgJWl3+5y31XDNWkEo7 0CfBGfIlQclkw== Received: by mail-wm1-f44.google.com with SMTP id l2-20020a7bc342000000b0037fa585de26so1125809wmj.1; Tue, 01 Mar 2022 06:46:09 -0800 (PST) X-Gm-Message-State: AOAM5339YuVfddwoXv8HOO/Q/VnPwTmUhSbv1XR37SyQoXGyA5ElLI+1 DgbcJBWcWC64jiUfc0IgZrzI8hsZ6on+lfpoJXw= X-Google-Smtp-Source: ABdhPJxXTbyRPUGWO5ZqEHYDoeKGRHcrrv5eZPJqecMQqdHX7hdx2ouYJfmaJG1ZffheKZ5NWAXaiF6wK5E6lkn8a4k= X-Received: by 2002:a7b:c001:0:b0:381:1afd:5caa with SMTP id c1-20020a7bc001000000b003811afd5caamr17359158wmb.35.1646145967920; Tue, 01 Mar 2022 06:46:07 -0800 (PST) MIME-Version: 1.0 References: <20220228103142.3301082-1-arnd@kernel.org> <20220228214145.o37bgp3zl3rxpeo4@google.com> In-Reply-To: <20220228214145.o37bgp3zl3rxpeo4@google.com> From: Arnd Bergmann Date: Tue, 1 Mar 2022 15:45:51 +0100 X-Gmail-Original-Message-ID: Message-ID: To: Fangrui Song Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 01 Mar 2022 20:02:59 +0000 Subject: Re: [Intel-gfx] [PATCH] [v2] Kbuild: move to -std=gnu11 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Corbet , Michal Marek , "open list:DOCUMENTATION" , Arnd Bergmann , Linux Kbuild mailing list , linux-staging@lists.linux.dev, Masahiro Yamada , llvm@lists.linux.dev, Nick Desaulniers , Linux Kernel Mailing List , dri-devel , greybus-dev@lists.linaro.org, Linux ARM , Federico Vaga , Hu Haowen , Intel Graphics , linux-btrfs , Linus Torvalds , linux-doc-tw-discuss@lists.sourceforge.net, Alex Shi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 28, 2022 at 10:41 PM Fangrui Song wrote: > > > >More precisely, the semantics of "extern inline" functions changed > >between ISO C90 and ISO C99. > > Perhaps a clearer explanation to readers is: "extern inline" and "inline" swap > semantics with gnu_inline (-fgnu89-inline or __attribute__((__gnu_inline__))). > > >That's the only concern I have, which I doubt is an issue. The kernel > >is already covered by the function attribute as you note. > > > >Just to have some measure: > >$ git grep -rn "extern inline" | wc -l > >116 > > "^inline" behaves like C99+ "extern inline" > > Agree this is handled by > > #define inline inline __gnu_inline __inline_maybe_unused notrace > Ok, I've reworded it again, but kept it a bit shorter, I don't think we need the full explanation in this patch description in the end. Thanks, Arnd