From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C35C433E0 for ; Mon, 29 Jun 2020 21:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA4E320720 for ; Mon, 29 Jun 2020 21:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732749AbgF2VBY (ORCPT ); Mon, 29 Jun 2020 17:01:24 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:57627 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390117AbgF2VBQ (ORCPT ); Mon, 29 Jun 2020 17:01:16 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MKsax-1jWq9I1guT-00LHp8; Mon, 29 Jun 2020 13:33:33 +0200 Received: by mail-qk1-f180.google.com with SMTP id l6so14863002qkc.6; Mon, 29 Jun 2020 04:33:33 -0700 (PDT) X-Gm-Message-State: AOAM5328dsWrDwEGKaYKF55sT8S/iBqgzomm53AU8WinhIgcfmtr0EpS vo9u6IrVjdO5h7GYjOgm9H4DZvkmVz4uDOMJbZ4= X-Google-Smtp-Source: ABdhPJye1KWp3fw6Y9xHkgeRSfS3PyrD8nrjYY7J24blGVdz8f1gm/UtrzMRZEXgieMS3379QDGNnd1Ku5iv2TMFnu8= X-Received: by 2002:a37:b484:: with SMTP id d126mr14557185qkf.394.1593430412219; Mon, 29 Jun 2020 04:33:32 -0700 (PDT) MIME-Version: 1.0 References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> From: Arnd Bergmann Date: Mon, 29 Jun 2020 13:33:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build To: Anson Huang Cc: Russell King - ARM Linux , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Michael Turquette , Stephen Boyd , oleksandr.suvorov@toradex.com, Stefan Agner , Peng Fan , Abel Vesa , Dong Aisheng , Andy Duan , Daniel Baluta , YueHaibing , Stephen Rothwell , Al Viro , Linux ARM , "linux-kernel@vger.kernel.org" , linux-clk , NXP Linux Team Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:07GlrRMWmO5DvLo7yBHmrip+tsbslFabumF1hH9WCHW3OEHg9B0 gXZwj36mzUSffIjIBWLCKPSYTHvew7iFkk3H7u/5Q5cBo92PcUzsX898z+7cbaRUnneb15d FKmxOB1TsQ+a7c5U88lgUCThx63kWVWf4edm7LRUJdjnzixuMM6pP4u0BJnZm9FqwX/4iPP dCB+AUSFttLsKuQdBdbZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:cut6NnEb7eY=:n4VyG8vxiQxJPJxagmrYp5 h+PjDDYquSdLoygHweSVsCjyOuu19SU8qs3MSxvWDPfnj/nGNd0ZJNro5Olzuio3sTxU5aknL r0oHQ9AZsXjIrK81NBWyNkrpZzS1z9ghGByQ4qzEEWaZOb2JkIt9IPvJDDnC02n5+hNQrJ0bN nfKxVRnJrnKBJS/TxPiO/m+79EMFMn7U3zBtEGXawjoggtaeJSCPxcfe1WC9KSO9De7C+hPZG +kX7tM5fnPOB++3/9GHVKYMZYOoV8CFwI9VJY4l1cYg5sNc4Rl4J6yPwXlMaFfSNkAWHo8tc+ OMpGCnFj0AF6yvqi7I6mymoZvMhtc+uZ4v+BevKQCI6QhfLiEKpGaKLpv9aqyY5bkwNmDqNSx NJm6BvcWKISwMOdaVrxrseYYbKSr7BN1GpWBC4iZ1prgyYR52HxdjUcO8J6xd0HLf/CbfvvWZ nNOFxB4tYZEo3MN5+mLFT5nidNSYXezxZo7KC+p25ce+eYbw89NW9xUKR1NFtU58lYL8H3uC0 KZ+7gsmNefLgmsgQ8BRtc1BEupHeM/svWp799ah8Yyhndf/dZLWj4NeYwRuOpXXTRQ4loWBK+ TFKES6oDUKrRSLzaKlksTDi4RWCX+WvEiRz2p0W93DhReFzmx/ztMF5J2rVFS03p3BCCjeyen DUOnEp//GHZwe9gRgSXqVmAW4WtKpwyy85519E9jq3gpMgriAEp9adrM6ZbWi0k0H03CgAKJ2 cG0BV147K7YZ8wa/BR/Hs/MfcpwYKH6in6ge0+dVdUn3FtcV202ubJJ4/+uF67mY6IHpfDxXU /HFMPTayINqZA+BvEe5O3MUxIRmu9nRhTtzIqQcGVfPN0kq9Is= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 8:06 AM Anson Huang wrote: > > Keep __setup_param() to use same parameters for both built in > and built as module, it can make the drivers which call it easier > when the drivers can be built in or built as module. > > Signed-off-by: Anson Huang I wonder if we should instead drop the __setup() and __setup_param() definitions from the #else block here. This was clearly not used anywhere, and it sounds like any possible user is broken and should be changed to not use __setup() anyway. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 512A7C433DF for ; Mon, 29 Jun 2020 11:34:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F990235F7 for ; Mon, 29 Jun 2020 11:34:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QACykU0Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F990235F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=msB4oC+N2YP4xzkc1xOBwei86skwZQDWZphU+YrbhQ0=; b=QACykU0Z3Tbdw0PQXl9RKApQ3 BtokamJlDQUcFnH4gV4/Q5VSQKSXzI+po/6qFRpeZWOCbEEznU2e42otuv2G2RBJpA/jSNdQNwV4V 18OrPl4DBtSuy68Y3cahL81zaUU7ftIWIqF4d3ao/71kxnuQT4QiXh6H0c119YOuergAlolCk1dqM D+G5uSUoVhFAeUfvHQhgPNqgmpdFycJKT1bBPME03uFn7hAdXVStVIbKpy/cW9TOVeayTS0V6iTmZ XHHv61jgmy/BPWPR88XPZVyupnTSC8pSdDBjotwrcUdYM7JNMKkOHJxa0Wv5awIqel6lrJnK6Sv2B 6MEUr6Fbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jps2c-0001t9-6O; Mon, 29 Jun 2020 11:33:38 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jps2Y-0001sP-W8 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 11:33:35 +0000 Received: from mail-qk1-f179.google.com ([209.85.222.179]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MEmpp-1jam1e1FCV-00GHh1 for ; Mon, 29 Jun 2020 13:33:33 +0200 Received: by mail-qk1-f179.google.com with SMTP id b185so4271579qkg.1 for ; Mon, 29 Jun 2020 04:33:33 -0700 (PDT) X-Gm-Message-State: AOAM532gmLAz/9P5I7+7nN/KYTk06zPxuGkT7Xo2YD6TquK7dGe676p5 l0cnxtVYO3x582Z8O5AVhhCeyoQMtAlOpDGvkCU= X-Google-Smtp-Source: ABdhPJye1KWp3fw6Y9xHkgeRSfS3PyrD8nrjYY7J24blGVdz8f1gm/UtrzMRZEXgieMS3379QDGNnd1Ku5iv2TMFnu8= X-Received: by 2002:a37:b484:: with SMTP id d126mr14557185qkf.394.1593430412219; Mon, 29 Jun 2020 04:33:32 -0700 (PDT) MIME-Version: 1.0 References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> From: Arnd Bergmann Date: Mon, 29 Jun 2020 13:33:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build To: Anson Huang X-Provags-ID: V03:K1:RXs6dWfw2soyp7eMSZkJYtyzDoG9zBMV+pRtMzRUMYz4JOxq9iS HATjHqi5LIfSckEYlt3WOibrvgHsYVexrN6K6amp7pMGVj2prWoUhMOdGMW03LI4mof2Ju/ pM8fFFhVxk5p/aN0F/+ilCyQOcY3ANgJ2l6czCs1VCVDcJGCY+7VAiodKKNyWi9UhwAo1WM lqH8Kypl7wU8sZMT/yOYQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:VWmredlRB0w=:IJx0IPJp8yXN6baPlhjAwV 0J2tKT7LG+jnVmwzxeICpM+5lm70Z7Hx2O6xRHmidgScKzCcDbOOAwAFO6ZiT9ZHpOYOGq9Qn wK/GEo8CD2w4oOstWtMhK/IgIFBXEzO2pSNkU3xb4uZ4ugPx7RiafKEBSqQBcOivhZ9paeDcj /qT95iiUkXZVrxgktMP85LT8nSwExACDHSq68+ve0fQ7KLgNY5JnA7/MhCBkHHIrcCND+A/4m D3jP2js5/DH8BxiUSPLQvdLNDDmaFIxJKxTDFcU9QErrYoim8jXkDQoyaYaz18vXHxorQ9aES au2iuSlt4bF3+djvkgmBJCOUYHv5iri+LEtVj1+MMUCYdfRspZ54oFgrCW4JBmwF4FlE25phz cT69faZ3b/kzT1nINkpsAlXKZRBXBsu1UbuK6pwRk/8vRSN5P2LRs9wvu32TxWOrmME7RuZgG 39zw6oLf2F/g/jJUjCkdaDooWjKgNDRNh2WARvEAq+OhRhRMbzATOrAjmf/5JBrtLnFdsxQqf 7frckzE9+5iisbORVNUZEBHS0PspwunVx/VMcxISs7YbmmBQPIewby08tkKV2Apl2S68YJ1zI iVccJ6y4rtF95LYgmgcm6W3OIVkD2GT4r0MSwF9du+6YuyAWqzC5nXlINFX4sy8bssZXmTnx3 vNxsnJH6sbnCVhuKF8JXIROySKqQocD0PAttbp1dKoehv1EKa/+nYSDYM6TgGKSH5LMRQesM7 EfdD/54ivCUkDgm7r24bue+Fg/IfsOH8NRJpAu78v19gFkUVyf9RmyUg7RVs26DwoUR9al5iG RlWlHWvk/CHc4PTgLpwgCTHkwm0nxEvHdHZQ38fGxDHWOlIPFA= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Stephen Rothwell , Peng Fan , linux-clk , Andy Duan , Abel Vesa , Stefan Agner , Stephen Boyd , Shawn Guo , Sascha Hauer , YueHaibing , Russell King - ARM Linux , Daniel Baluta , "linux-kernel@vger.kernel.org" , oleksandr.suvorov@toradex.com, Al Viro , Sascha Hauer , Fabio Estevam , Michael Turquette , Linux ARM , NXP Linux Team Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 8:06 AM Anson Huang wrote: > > Keep __setup_param() to use same parameters for both built in > and built as module, it can make the drivers which call it easier > when the drivers can be built in or built as module. > > Signed-off-by: Anson Huang I wonder if we should instead drop the __setup() and __setup_param() definitions from the #else block here. This was clearly not used anywhere, and it sounds like any possible user is broken and should be changed to not use __setup() anyway. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel