From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Mon, 11 Nov 2019 10:31:05 +0000 Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Message-Id: List-Id: References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B1AC17445 for ; Mon, 11 Nov 2019 10:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 961D6214E0 for ; Mon, 11 Nov 2019 10:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbfKKKb1 (ORCPT ); Mon, 11 Nov 2019 05:31:27 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:60767 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbfKKKb0 (ORCPT ); Mon, 11 Nov 2019 05:31:26 -0500 Received: from mail-qv1-f46.google.com ([209.85.219.46]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1M1YxX-1iSBIl08Wh-00394l; Mon, 11 Nov 2019 11:31:24 +0100 Received: by mail-qv1-f46.google.com with SMTP id y18so4653500qve.2; Mon, 11 Nov 2019 02:31:22 -0800 (PST) X-Gm-Message-State: APjAAAUxlJXW97+1cBVSkWYmUR6nUAyzY7pFnWR1j64svdk137UqnkjB L3rL1AV0PwZOn0xobSNrp1i1ToAK7xZJ7ywQxfA= X-Google-Smtp-Source: APXvYqxD4F/fwy7LIVnyFzyiMun+f+kScDaMuxMbPMHFdHwTAmNy4Oax48ObAzH1ZmZyCVG2W0sxl5/9Apu79krhc7g= X-Received: by 2002:a0c:a9cc:: with SMTP id c12mr4561842qvb.222.1573468282069; Mon, 11 Nov 2019 02:31:22 -0800 (PST) MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , "the arch/x86 maintainers" , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu , MTD Maling List , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , linux-mips@vger.kernel.org, alpha , "moderated list:NIOS2 ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:GhVqUNVJ6NcFflSOEwN3xNZ+WDbcZEBsdfOJy5lHGcUzStPON3S sdvrlkVnzJ4K/x3cf5tYPugN5XhSBeh1PoZWPALuD9vHbiqs7LkvRtku4dgNCYPfg2hTWD3 aVB9H4AYQg+3P/o5HUXDoffXlGofXmGsR9gAnSPoqG/6NQQYwaLa49lQwiosiJF/NEYAPps lqR0sQiFoqXofI25s5XJA== X-UI-Out-Filterresults: notjunk:1;V03:K0:URlU+6+rc6w=:y5PGJEge8OBUWHMAmN3LJO jIxpuP7dwcb+ik9HrK0VliiW2etopAEFn7uaY69aK9jGrqr7zmd1UGZJRBqB6CpVskEG/zCmk BUxZlaXSP2HfoBeDI1gCu7bYcY4fzXvLBrG9aPN+zildJOs7QeBcOfLC01M7htudy1pUPdFtA dR7SDHkntfBffPPssOnu6ozRPDnU6vL2KUZ/ZH/UXiHM1JH0SCQi3S+xNy26Z9u7aOGtjVuuO PboGcUnXnq3UHc+4dGBkWnBZqMiP3HYXGf5s9IXYstXi/3xPJcP434DY79oHGBb5Q5QCS7pK3 Uh0sK/c6JlDeEuv/gL/RRCD0bvXv2SlkehmX2f9FT7bNgJYnNvApyh/P0EK+ylKyicCH785sG xC8SI2udds3P3++DOPOSazbC3AFpHQUODsb9TOd8/7q76Uvk2Q8Cx7y4Bpi6wlIxtGNHhFxG+ GrbYr9XnYxkfFIfbc09D32LUFSRMlQbiKhK+f9ulUq1+DzdAaz5KJQCOdG8j5T2PMF+tZQKOX fxrqTQQnVV5QO3UZ9eprc58Gh9+a+JmAzuRVILazR9h+Q4YMNvlH6mMi2Y6SEyIlDBf75q2Kb ssAh+zE1KqjhRdsofdjkMYHkRgsTuR/y6OSetAY5mWDaBpp0F/+tlvsTaWXWGYx9ipHHQyRQe h1E8Nf2100ZVK2stQXODwrwsTyFzK6/Jxt9vt/fi8F6opD9MMsohnz1+WQLVVQfS0XnJiJhtc LNLskA15FjzURVAbK5EZaI1b5UJGTHvdRXycVdprQUsFnJ7JZaPMWksiXLm9r+Ndyaeklwakd OhiMwOoJE6qrOjB9QpYGAepCg/KlNGFz3AaQBpWbKb0wXzSS4NfVpn80UjiPCOnoHPmJ6ogZ8 Hg9JY1zIFq3kTEw9eITg== Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.130]:60767 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbfKKKb0 (ORCPT ); Mon, 11 Nov 2019 05:31:26 -0500 MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Content-Type: text/plain; charset="UTF-8" Sender: linux-s390-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu , MTD Maling List , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , linux-mips@vger.kernel.org, alpha , "moderated list:NIOS2 ARCHITECTURE" On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Date: Mon, 11 Nov 2019 11:31:05 +0100 Message-ID: References: <20191029064834.23438-12-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu List-Id: linux-arch.vger.kernel.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C86CC43331 for ; Mon, 11 Nov 2019 10:32:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA2420659 for ; Mon, 11 Nov 2019 10:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P75wjuJB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA2420659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Ji4mbzbWdnWw7gsrReKtL4zS/YUleHsoxORAjjfK80=; b=P75wjuJBofI26A nvLJPDcbhyUOJTpSkOwPqq4cAvWGtSV8Oj8ttsRiGzVpcTYK6kBE7cbQ+/psDvJCO2pX7wCJznIXk nkWtq97a0pSTXE6QVungZFihtK5xTTwHbYYjrGnVHWnsYFc2pa+cnuhF6RAQGK8GUEobqI0wYiY+M 4ekXyp5isjPeFbpCsKZTwLmklJGjPI6oO9aEy7EOJian+lGtawGk3YGVbCyx/8j3mHqWq+ChpLc+Y fzZCJftJgr+ntjDqIvVZxyJra5doxCAliRHVxg1kKLvyIX8nmEFrPUdpgb0AEDY7kTYxueO5tCb3/ 5eB4HTlVQOOpz6mSUunw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6zO-0004n6-VS; Mon, 11 Nov 2019 10:32:07 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6yj-0004jG-Ca; Mon, 11 Nov 2019 10:31:27 +0000 Received: from mail-qv1-f53.google.com ([209.85.219.53]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MVMuN-1iMjEK225v-00SLBi; Mon, 11 Nov 2019 11:31:23 +0100 Received: by mail-qv1-f53.google.com with SMTP id cg2so4636703qvb.10; Mon, 11 Nov 2019 02:31:23 -0800 (PST) X-Gm-Message-State: APjAAAV1uHu6Q9+5m/uXVIpS6aLRZNpwjsRLO7wPNQ86ddVV0hzCMTr6 87gTGnuJHk7ow0OQV4tIW5MidzrDPQyych2ZXgs= X-Google-Smtp-Source: APXvYqxD4F/fwy7LIVnyFzyiMun+f+kScDaMuxMbPMHFdHwTAmNy4Oax48ObAzH1ZmZyCVG2W0sxl5/9Apu79krhc7g= X-Received: by 2002:a0c:a9cc:: with SMTP id c12mr4561842qvb.222.1573468282069; Mon, 11 Nov 2019 02:31:22 -0800 (PST) MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU To: Geert Uytterhoeven X-Provags-ID: V03:K1:jKdc7SN7TlzrItssvWUahVJz3hDP5Cd0ZmKt98s8caMUYUIeg1a XJXJHK48OYgZsi5ooE+SHRbls5mfsDSjjzdKxqV+7TQ0haWZIl00SRFE+1uHGmmMSiQQEjk j4XE6F0yAlv0Od2pv/6TeFS/cNJKAI4Ztq4dRUpnq4tr/aod/9rdK+VMdZt8elxgT1Pk7Jn b+CGKaZnlfyAqgTx7I6VA== X-UI-Out-Filterresults: notjunk:1;V03:K0:9bijUwidQcU=:k4e4fsccf7b1kQBRUXFfF7 2x6C2BMR87xGd6DUQHtPI68UisFEiQ3fhUeQ8z9c9f0LWWCM00QB+Q6QuX3q4oAMTsC17HKyE OS9U7UukFKmm19uDbnHKZfQmXJk51+VlZberOhVicpewkMPELJACdUHCAmPGR3V3e6fVRVJq8 14ERn9U4sYWuG8ug7rEGcNxN7YRPcZgbngeeCgEhiKqqVZnKK0pCzpcUEOzOKz6vRBB5OfJDA l4UwCJ5roQnrlHNOfjtwMXdOmsofksZPZzV0yEuVt91QLmxq8X97yfgMfWfUoBvsU00+ctxho mobkd5fIjNBhz/CEyr/zwRCWk9VKbT95UUYTmHhKHgcHNu0XvvGNoRAMlRURXS13K7cWivOOb ADCx4ENJaBl5f2ZJi9ObpaxMYKMcXguX0qigZ1XXUDOVKOFjWKrBjpm5GEB9gFbWntqC3muuP n3LqZOhnhUGgCjLTs9yPPvTcUrsnqJIaSKeqI0WJ6ci9kU/jM//kc8xhn6qVDe8DqqJ4vl4yu IM53gbIB1IagmQ8ijskWfXjGAs1TubKWj0Jyqvn22RhLH59CdoBF237PzFTIqYm0PlzTKoXJw k1lTucluSyDydUojgOKhDG8f7fHj3mZeiP6QLPCufVDPYLEl7Nd5Nwy2pHtUO38YQ2NyQnWF2 LFkyYjl5yjdRTdwV7F3JvL0QncNnzYQ/Xme/aIk3YFUpea4Xcx9nd+T3rvqgk1ufAx5SMqStT kf3OGv3Anm04oi+e3bn8VN7IiLiykMJ4vEIsZNL6CY714bZUdIHdOmxJxnWHA9u3umW42//MQ PMaCuSA5nXjKNjyAHTQ7XJ/OJoXhkbmUaFFiX4di26SFdmNnFMf4EdBdbmKzjRwv3E7LEmWvP uGNX4U82rMksGM+SEnQw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_023125_719658_C481EF63 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , linux-mips@vger.kernel.org, Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Christoph Hellwig , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu , "moderated list:NIOS2 ARCHITECTURE" , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , Linux Kernel Mailing List , Palmer Dabbelt , alpha , MTD Maling List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 882B5C43331 for ; Mon, 11 Nov 2019 10:32:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59864214DB for ; Mon, 11 Nov 2019 10:32:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NJZ6vZkW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59864214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7vPmep0oQToP+VqwcArm/buUc90WM9C27uCYA9RgfdQ=; b=NJZ6vZkWbD/Vqe aqApSah9U8WnYYKsPP645/1KJHgsKg2kFZP8n+kGdxOWG9NhAt5KpjMbwjsEU6UQYzw8p8Woj8gYG HLsOZvCcEoszMc9fL0vfx+wMeybFsk+zcpBICvK2D++/PPYQs2V/lVfqWjYl98KHQaUGwVRoYGmBf etnSTSbBQ9eeRchjVNq/OLB5b+49RksY9kzra8hsK6Trs1SSh1vekou5eiEU4sQLRZpwdQ2Wvx27o K48ZPLmQU0v1rUd62AwPqJirTLhXORT6FUw4OEd2FZAxGf/MIIXHyRTTns3xHMQ3CaIH8tXJDFHXz u45PY0RQGIYuIxh4l4WA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6za-0004rI-Sg; Mon, 11 Nov 2019 10:32:18 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6yj-0004jG-Ca; Mon, 11 Nov 2019 10:31:27 +0000 Received: from mail-qv1-f53.google.com ([209.85.219.53]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MVMuN-1iMjEK225v-00SLBi; Mon, 11 Nov 2019 11:31:23 +0100 Received: by mail-qv1-f53.google.com with SMTP id cg2so4636703qvb.10; Mon, 11 Nov 2019 02:31:23 -0800 (PST) X-Gm-Message-State: APjAAAV1uHu6Q9+5m/uXVIpS6aLRZNpwjsRLO7wPNQ86ddVV0hzCMTr6 87gTGnuJHk7ow0OQV4tIW5MidzrDPQyych2ZXgs= X-Google-Smtp-Source: APXvYqxD4F/fwy7LIVnyFzyiMun+f+kScDaMuxMbPMHFdHwTAmNy4Oax48ObAzH1ZmZyCVG2W0sxl5/9Apu79krhc7g= X-Received: by 2002:a0c:a9cc:: with SMTP id c12mr4561842qvb.222.1573468282069; Mon, 11 Nov 2019 02:31:22 -0800 (PST) MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU To: Geert Uytterhoeven X-Provags-ID: V03:K1:jKdc7SN7TlzrItssvWUahVJz3hDP5Cd0ZmKt98s8caMUYUIeg1a XJXJHK48OYgZsi5ooE+SHRbls5mfsDSjjzdKxqV+7TQ0haWZIl00SRFE+1uHGmmMSiQQEjk j4XE6F0yAlv0Od2pv/6TeFS/cNJKAI4Ztq4dRUpnq4tr/aod/9rdK+VMdZt8elxgT1Pk7Jn b+CGKaZnlfyAqgTx7I6VA== X-UI-Out-Filterresults: notjunk:1;V03:K0:9bijUwidQcU=:k4e4fsccf7b1kQBRUXFfF7 2x6C2BMR87xGd6DUQHtPI68UisFEiQ3fhUeQ8z9c9f0LWWCM00QB+Q6QuX3q4oAMTsC17HKyE OS9U7UukFKmm19uDbnHKZfQmXJk51+VlZberOhVicpewkMPELJACdUHCAmPGR3V3e6fVRVJq8 14ERn9U4sYWuG8ug7rEGcNxN7YRPcZgbngeeCgEhiKqqVZnKK0pCzpcUEOzOKz6vRBB5OfJDA l4UwCJ5roQnrlHNOfjtwMXdOmsofksZPZzV0yEuVt91QLmxq8X97yfgMfWfUoBvsU00+ctxho mobkd5fIjNBhz/CEyr/zwRCWk9VKbT95UUYTmHhKHgcHNu0XvvGNoRAMlRURXS13K7cWivOOb ADCx4ENJaBl5f2ZJi9ObpaxMYKMcXguX0qigZ1XXUDOVKOFjWKrBjpm5GEB9gFbWntqC3muuP n3LqZOhnhUGgCjLTs9yPPvTcUrsnqJIaSKeqI0WJ6ci9kU/jM//kc8xhn6qVDe8DqqJ4vl4yu IM53gbIB1IagmQ8ijskWfXjGAs1TubKWj0Jyqvn22RhLH59CdoBF237PzFTIqYm0PlzTKoXJw k1lTucluSyDydUojgOKhDG8f7fHj3mZeiP6QLPCufVDPYLEl7Nd5Nwy2pHtUO38YQ2NyQnWF2 LFkyYjl5yjdRTdwV7F3JvL0QncNnzYQ/Xme/aIk3YFUpea4Xcx9nd+T3rvqgk1ufAx5SMqStT kf3OGv3Anm04oi+e3bn8VN7IiLiykMJ4vEIsZNL6CY714bZUdIHdOmxJxnWHA9u3umW42//MQ PMaCuSA5nXjKNjyAHTQ7XJ/OJoXhkbmUaFFiX4di26SFdmNnFMf4EdBdbmKzjRwv3E7LEmWvP uGNX4U82rMksGM+SEnQw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_023125_719658_C481EF63 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , linux-mips@vger.kernel.org, Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Christoph Hellwig , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu , "moderated list:NIOS2 ARCHITECTURE" , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , Linux Kernel Mailing List , Palmer Dabbelt , alpha , MTD Maling List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEBC8C43331 for ; Mon, 11 Nov 2019 10:32:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CEEE214DB for ; Mon, 11 Nov 2019 10:32:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CtQZFAgQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CEEE214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZNMlKBww4g0/6EXBm3mqU91ixOT9q4WAhtswP+OmThQ=; b=CtQZFAgQH/Niql IiKXSjgz5Z2SzqvgSC8VYxGUzyJ/dyeDQ2SmnjaPmimDMBJR+KamowFwMgzy641xboRDqjhWcZJcl /0gw82Q4W10OhfMoyKP6O8hU3O+sU5z/P09Qe9QAozx5MkYNvFHfekf6RFg6DVd+2AZNxo+d0O3rP 53eRDFjccxZVJ/3wZ//pxYIhaa5CP88HU96jUQ+S+va9QeTukaLPsX+v4w3hREi9op7bDFIRkmZ71 vStBBXW0ecUi15pRnR17/hN/H4QbPm4LffdVxr7/0X1g5+zKfyPDmsPvzIBCS8bwZw1KPj+5PREfk O2+bd55c5OSTvcQToXxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6zh-000510-Ho; Mon, 11 Nov 2019 10:32:25 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6yj-0004jG-Ca; Mon, 11 Nov 2019 10:31:27 +0000 Received: from mail-qv1-f53.google.com ([209.85.219.53]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MVMuN-1iMjEK225v-00SLBi; Mon, 11 Nov 2019 11:31:23 +0100 Received: by mail-qv1-f53.google.com with SMTP id cg2so4636703qvb.10; Mon, 11 Nov 2019 02:31:23 -0800 (PST) X-Gm-Message-State: APjAAAV1uHu6Q9+5m/uXVIpS6aLRZNpwjsRLO7wPNQ86ddVV0hzCMTr6 87gTGnuJHk7ow0OQV4tIW5MidzrDPQyych2ZXgs= X-Google-Smtp-Source: APXvYqxD4F/fwy7LIVnyFzyiMun+f+kScDaMuxMbPMHFdHwTAmNy4Oax48ObAzH1ZmZyCVG2W0sxl5/9Apu79krhc7g= X-Received: by 2002:a0c:a9cc:: with SMTP id c12mr4561842qvb.222.1573468282069; Mon, 11 Nov 2019 02:31:22 -0800 (PST) MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU To: Geert Uytterhoeven X-Provags-ID: V03:K1:jKdc7SN7TlzrItssvWUahVJz3hDP5Cd0ZmKt98s8caMUYUIeg1a XJXJHK48OYgZsi5ooE+SHRbls5mfsDSjjzdKxqV+7TQ0haWZIl00SRFE+1uHGmmMSiQQEjk j4XE6F0yAlv0Od2pv/6TeFS/cNJKAI4Ztq4dRUpnq4tr/aod/9rdK+VMdZt8elxgT1Pk7Jn b+CGKaZnlfyAqgTx7I6VA== X-UI-Out-Filterresults: notjunk:1;V03:K0:9bijUwidQcU=:k4e4fsccf7b1kQBRUXFfF7 2x6C2BMR87xGd6DUQHtPI68UisFEiQ3fhUeQ8z9c9f0LWWCM00QB+Q6QuX3q4oAMTsC17HKyE OS9U7UukFKmm19uDbnHKZfQmXJk51+VlZberOhVicpewkMPELJACdUHCAmPGR3V3e6fVRVJq8 14ERn9U4sYWuG8ug7rEGcNxN7YRPcZgbngeeCgEhiKqqVZnKK0pCzpcUEOzOKz6vRBB5OfJDA l4UwCJ5roQnrlHNOfjtwMXdOmsofksZPZzV0yEuVt91QLmxq8X97yfgMfWfUoBvsU00+ctxho mobkd5fIjNBhz/CEyr/zwRCWk9VKbT95UUYTmHhKHgcHNu0XvvGNoRAMlRURXS13K7cWivOOb ADCx4ENJaBl5f2ZJi9ObpaxMYKMcXguX0qigZ1XXUDOVKOFjWKrBjpm5GEB9gFbWntqC3muuP n3LqZOhnhUGgCjLTs9yPPvTcUrsnqJIaSKeqI0WJ6ci9kU/jM//kc8xhn6qVDe8DqqJ4vl4yu IM53gbIB1IagmQ8ijskWfXjGAs1TubKWj0Jyqvn22RhLH59CdoBF237PzFTIqYm0PlzTKoXJw k1lTucluSyDydUojgOKhDG8f7fHj3mZeiP6QLPCufVDPYLEl7Nd5Nwy2pHtUO38YQ2NyQnWF2 LFkyYjl5yjdRTdwV7F3JvL0QncNnzYQ/Xme/aIk3YFUpea4Xcx9nd+T3rvqgk1ufAx5SMqStT kf3OGv3Anm04oi+e3bn8VN7IiLiykMJ4vEIsZNL6CY714bZUdIHdOmxJxnWHA9u3umW42//MQ PMaCuSA5nXjKNjyAHTQ7XJ/OJoXhkbmUaFFiX4di26SFdmNnFMf4EdBdbmKzjRwv3E7LEmWvP uGNX4U82rMksGM+SEnQw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_023125_719658_C481EF63 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , linux-mips@vger.kernel.org, Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Christoph Hellwig , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu , "moderated list:NIOS2 ARCHITECTURE" , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , Linux Kernel Mailing List , Palmer Dabbelt , alpha , MTD Maling List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B04C43331 for ; Mon, 11 Nov 2019 10:34:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A67D214DB for ; Mon, 11 Nov 2019 10:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sl/soHLc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A67D214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j9lCVvbxht/KkJgYqp0DweTypg+H8bUDaKbQBIAPedw=; b=sl/soHLchEvUNq oYkpXIzt4DdXbg67XXHqWVj1Ta5Xgb0euZx1atbNWPocQAO6PCENFfIT/ref4evE3aj7S42knREq6 X/OCcOdr363/vIdKv+cvK71c8vqxzjAyoMauKG4d6r0ajbEE3+trruiQWB45VABNe66QRvJ3XIWRe +p/q5L+c7a1ve4mcPQAnRSDc+J6D5bgbn3rgeoea8J1uFKs7L0ygdq6wurFVWcBagf5G8pENiCf0V PeO2ECFSJ1DBePznUC7I1nJROS8Dyq43sPrtkq4QJpiKvlCOebmoWfce1xINgUEfQu0lp3JRRIdf7 rosvB58ow5D/orL8PMzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU71V-0005iN-27; Mon, 11 Nov 2019 10:34:17 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU6yj-0004jG-Ca; Mon, 11 Nov 2019 10:31:27 +0000 Received: from mail-qv1-f53.google.com ([209.85.219.53]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MVMuN-1iMjEK225v-00SLBi; Mon, 11 Nov 2019 11:31:23 +0100 Received: by mail-qv1-f53.google.com with SMTP id cg2so4636703qvb.10; Mon, 11 Nov 2019 02:31:23 -0800 (PST) X-Gm-Message-State: APjAAAV1uHu6Q9+5m/uXVIpS6aLRZNpwjsRLO7wPNQ86ddVV0hzCMTr6 87gTGnuJHk7ow0OQV4tIW5MidzrDPQyych2ZXgs= X-Google-Smtp-Source: APXvYqxD4F/fwy7LIVnyFzyiMun+f+kScDaMuxMbPMHFdHwTAmNy4Oax48ObAzH1ZmZyCVG2W0sxl5/9Apu79krhc7g= X-Received: by 2002:a0c:a9cc:: with SMTP id c12mr4561842qvb.222.1573468282069; Mon, 11 Nov 2019 02:31:22 -0800 (PST) MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU To: Geert Uytterhoeven X-Provags-ID: V03:K1:jKdc7SN7TlzrItssvWUahVJz3hDP5Cd0ZmKt98s8caMUYUIeg1a XJXJHK48OYgZsi5ooE+SHRbls5mfsDSjjzdKxqV+7TQ0haWZIl00SRFE+1uHGmmMSiQQEjk j4XE6F0yAlv0Od2pv/6TeFS/cNJKAI4Ztq4dRUpnq4tr/aod/9rdK+VMdZt8elxgT1Pk7Jn b+CGKaZnlfyAqgTx7I6VA== X-UI-Out-Filterresults: notjunk:1;V03:K0:9bijUwidQcU=:k4e4fsccf7b1kQBRUXFfF7 2x6C2BMR87xGd6DUQHtPI68UisFEiQ3fhUeQ8z9c9f0LWWCM00QB+Q6QuX3q4oAMTsC17HKyE OS9U7UukFKmm19uDbnHKZfQmXJk51+VlZberOhVicpewkMPELJACdUHCAmPGR3V3e6fVRVJq8 14ERn9U4sYWuG8ug7rEGcNxN7YRPcZgbngeeCgEhiKqqVZnKK0pCzpcUEOzOKz6vRBB5OfJDA l4UwCJ5roQnrlHNOfjtwMXdOmsofksZPZzV0yEuVt91QLmxq8X97yfgMfWfUoBvsU00+ctxho mobkd5fIjNBhz/CEyr/zwRCWk9VKbT95UUYTmHhKHgcHNu0XvvGNoRAMlRURXS13K7cWivOOb ADCx4ENJaBl5f2ZJi9ObpaxMYKMcXguX0qigZ1XXUDOVKOFjWKrBjpm5GEB9gFbWntqC3muuP n3LqZOhnhUGgCjLTs9yPPvTcUrsnqJIaSKeqI0WJ6ci9kU/jM//kc8xhn6qVDe8DqqJ4vl4yu IM53gbIB1IagmQ8ijskWfXjGAs1TubKWj0Jyqvn22RhLH59CdoBF237PzFTIqYm0PlzTKoXJw k1lTucluSyDydUojgOKhDG8f7fHj3mZeiP6QLPCufVDPYLEl7Nd5Nwy2pHtUO38YQ2NyQnWF2 LFkyYjl5yjdRTdwV7F3JvL0QncNnzYQ/Xme/aIk3YFUpea4Xcx9nd+T3rvqgk1ufAx5SMqStT kf3OGv3Anm04oi+e3bn8VN7IiLiykMJ4vEIsZNL6CY714bZUdIHdOmxJxnWHA9u3umW42//MQ PMaCuSA5nXjKNjyAHTQ7XJ/OJoXhkbmUaFFiX4di26SFdmNnFMf4EdBdbmKzjRwv3E7LEmWvP uGNX4U82rMksGM+SEnQw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_023125_719658_C481EF63 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , linux-mips@vger.kernel.org, Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Christoph Hellwig , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, linux-m68k , Openrisc , Greentime Hu , "moderated list:NIOS2 ARCHITECTURE" , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , Linux Kernel Mailing List , Palmer Dabbelt , alpha , MTD Maling List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Mon, 11 Nov 2019 11:31:05 +0100 Subject: [OpenRISC] [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU In-Reply-To: References: <20191029064834.23438-12-hch@lst.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven wrote: > > Hi Palmer, > > On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > > It looks like the difference in prototype between the architectures is between > > > > void __iomem *ioremap(resource_size_t, size_t) > > void __iomem *ioremap(phys_addr_t, size_t) > > void __iomem *ioremap(phys_addr_t, unsigned long) > > void __iomem *ioremap(unsigned long, unsigned long) > > > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Right, phys_addr_t is the correct type here, resource_size_t is just a generic type that is at least as long as any resource, and usually the same as phys_addr_t, which is supposed to be used for physical addresses. Arnd