All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	John Crispin <john@phrozen.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 1/5] PCI: let 'pcibios_root_bridge_prepare()' access to 'bridge->windows'
Date: Wed, 1 Dec 2021 21:50:34 +0100	[thread overview]
Message-ID: <CAK8P3a2bb3w+6G4W0OAv1ASmfeOr0NTHMPpJ2An-ms2Vk7VnhQ@mail.gmail.com> (raw)
In-Reply-To: <20211201202433.GA2837547@bhelgaas>

On Wed, Dec 1, 2021 at 9:24 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Fri, Nov 19, 2021 at 05:20:17PM -0600, Bjorn Helgaas wrote:
> >
> > Arnd added this with 37d6a0a6f470 ("PCI: Add
> > pci_register_host_bridge() interface") [1].
> >
> > I can't remember why this was done, but we did go to some trouble to
> > move things around, so there must have been a good reason.
> >
> > Arnd or Thierry, do you remember?
>
> Nobody seems to remember, so I think we should go ahead and make this
> change after the usual due diligence (audit the code between the old
> site and the new site to look for any uses of bridge->windows).
>
> I think this would be material for v5.17.

Sorry I forgot to reply to your earlier mail. I think this is fine, as far as I
remember, the only reason the bridge windows are moved from the list
and added back one at a time was to preserve the exact orderorks.

We could probably even skip that step entirely and iterate throughing
that was there originally, to keep the behavior after a series of reworks.

We could probably even skip that step entirely and iterate through
bridge->windows instead of the local list to simplify this.

For Sergio's patch:

Acked-by: Arnd Bergmann <arnd@arndb.de>

  reply	other threads:[~2021-12-01 20:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  7:08 [PATCH 0/5] PCI: mt7621: remove specific MIPS code from driver Sergio Paracuellos
2021-11-15  7:08 ` [PATCH 1/5] PCI: let 'pcibios_root_bridge_prepare()' access to 'bridge->windows' Sergio Paracuellos
2021-11-19 23:20   ` Bjorn Helgaas
2021-12-01 20:24     ` Bjorn Helgaas
2021-12-01 20:50       ` Arnd Bergmann [this message]
2021-12-01 20:56       ` Sergio Paracuellos
2021-12-01 21:12         ` Bjorn Helgaas
2021-12-01 20:27   ` Bjorn Helgaas
2021-11-15  7:08 ` [PATCH 2/5] MIPS: ralink: implement 'pcibios_root_bridge_prepare()' Sergio Paracuellos
2021-11-15  7:08 ` [PATCH 3/5] PCI: mt7621: avoid custom MIPS code in driver code Sergio Paracuellos
2021-12-01 18:16   ` Bjorn Helgaas
2021-12-01 19:25     ` Sergio Paracuellos
2021-11-15  7:08 ` [PATCH 4/5] PCI: mt7621: Add missing 'MODULE_LICENSE()' definition Sergio Paracuellos
2021-11-15 12:44   ` Krzysztof Wilczyński
2021-11-15 13:00     ` Arnd Bergmann
2021-11-15 13:51       ` Sergio Paracuellos
2021-11-15 13:55         ` Arnd Bergmann
2021-11-15 21:50       ` Krzysztof Wilczyński
2021-11-15 21:52   ` Krzysztof Wilczyński
2021-11-15  7:08 ` [PATCH 5/5] PCI: mt7621: Kconfig: completely enable driver for 'COMPILE_TEST' Sergio Paracuellos
2021-12-01 20:12   ` Bjorn Helgaas
2021-12-01 20:33     ` Sergio Paracuellos
2021-11-17 12:41 ` [PATCH 0/5] PCI: mt7621: remove specific MIPS code from driver Thomas Bogendoerfer
2021-11-17 12:48   ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a2bb3w+6G4W0OAv1ASmfeOr0NTHMPpJ2An-ms2Vk7VnhQ@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=sergio.paracuellos@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.