From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE12C43219 for ; Thu, 5 May 2022 14:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380946AbiEEPDg (ORCPT ); Thu, 5 May 2022 11:03:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233400AbiEEPDe (ORCPT ); Thu, 5 May 2022 11:03:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A1C25A15F; Thu, 5 May 2022 07:59:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B827661CC5; Thu, 5 May 2022 14:59:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2171EC385BA; Thu, 5 May 2022 14:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651762794; bh=IhPlTG/RSP+SotNFea7Fr39MZz0OjsoIPseiihaGxkc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=skKE7CkSWJipKAwKJCBrR71hl9l5yOYjQoARS41ioF8PPh7bxColWxsD4vdtmnrMC mQBIqAunoSnIAL+eTFw6a87TENu1OZL3J0unpwvAapDjehQbL4dIYPVxYDr5E0f8H2 2Ut88XHuXmqK6oXMnJsfP9eSc86Q5HJlHS7nBYfK8IZe39hShNsGm5F+uG6l3Ohx8q Y2qhl3pfwWmUs7JTRVGH5vJD27kQLOf6she+YLgBmzISzF3PWnvMRiH84FZiN5pT9f vZW1FeaKkpy+VomhCOcOZ66ZN31g3fbgxTh0Rr9f2+J3tXb9yK6yeSyrs1M6tkoYJl i07arWsPlHMPw== Received: by mail-wr1-f47.google.com with SMTP id e2so6474486wrh.7; Thu, 05 May 2022 07:59:54 -0700 (PDT) X-Gm-Message-State: AOAM530MYMU8o7FNtrhlIEiSgBAJYTWan5euWHydKoFdBgiQSVdyQ1Ay JyrECOUz9sQ7Dzw/+vBjIHbF09LRhwsqD32VXeM= X-Google-Smtp-Source: ABdhPJyKl/lyubFIqlgFQkig5zNAs/zvVqV8InTOhcfpAoriY4j8URNODYiLewygje3f2WDNulvuU9Rfg/N1L0FjaiU= X-Received: by 2002:a05:6000:707:b0:20c:4fd8:1d61 with SMTP id bs7-20020a056000070700b0020c4fd81d61mr21866057wrb.407.1651762791921; Thu, 05 May 2022 07:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 May 2022 16:59:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Mark Brown Cc: Linus Walleij , Robert Jarzmik , Linux ARM , Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , IDE-ML , linux-clk , Linux PM list , "open list:HID CORE LAYER" , patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc , linux-mtd , linux-rtc@vger.kernel.org, USB list , Linux Fbdev development list , dri-devel , ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > /* Headphones jack detection DAPM pin */ > > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > > { > > > .pin = "Headphone Jack", > > > .mask = SND_JACK_HEADPHONE, > > > }, > > > { > > > .pin = "Speaker", > > > /* disable speaker when hp jack is inserted */ > > > .mask = SND_JACK_HEADPHONE, > > > .invert = 1, > > > }, > > > Hm some ASoC thingie. No idea what that is, but I suppose another > > place where a subsystem for legacy reasons try to do the gpiolib > > inversion on it's own accord. That one isn't flagged as active low in the > > descriptor so it's fine I guess. > > It's saying that when the headphone is inserted the headphone output > should be enabled and the speaker output should be disabled, and vice > versa. Ok, that sounds like I should remove the flag here if I declare the GPIO line as GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH, right? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50FF9C433F5 for ; Thu, 5 May 2022 14:59:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48EEF10E476; Thu, 5 May 2022 14:59:58 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB71510E4C3 for ; Thu, 5 May 2022 14:59:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F06BB82D82 for ; Thu, 5 May 2022 14:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE05AC385AE for ; Thu, 5 May 2022 14:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651762793; bh=IhPlTG/RSP+SotNFea7Fr39MZz0OjsoIPseiihaGxkc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XJlLANSBhBQidSLyIN3yrDU4IPbB/XHn0sC/EiuYCYow1pSZuwUL9RL7kUdqha4a5 TcZwUvlSFBjq9APojye7LJhrzoz3yJ1Ko0vn9bx+hzpMIKK1bpwEinzLoso9szamoU kt+btKxs0bHl5LryHinLhmeOqshoLiof4tF0E/+fz0OqXBqxiiNxRhqua3QhXT1gQ9 FZipVJ1eZuG5o8dbsSJoiqjohKH/oez5kM37x1L64XAIvA0K2/0Rnw6ymC8BCVOm/J AVlpwubLtD+RPAMcU/M895m2znx/K5SL30vRlO5ThZta1c3MM+UqdWVtRQXT105Row Q/EgykBswo6Gg== Received: by mail-wr1-f51.google.com with SMTP id i5so6462709wrc.13 for ; Thu, 05 May 2022 07:59:53 -0700 (PDT) X-Gm-Message-State: AOAM530MFJn7E/MivfMjg34fWfINFxANaUPYpZvouHPr87Q51YjXrVOF ElEyoMVi2ZpMD/ObiLNvgwEeUlSUOHkAeIXBwDc= X-Google-Smtp-Source: ABdhPJyKl/lyubFIqlgFQkig5zNAs/zvVqV8InTOhcfpAoriY4j8URNODYiLewygje3f2WDNulvuU9Rfg/N1L0FjaiU= X-Received: by 2002:a05:6000:707:b0:20c:4fd8:1d61 with SMTP id bs7-20020a056000070700b0020c4fd81d61mr21866057wrb.407.1651762791921; Thu, 05 May 2022 07:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 May 2022 16:59:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Mark Brown Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , USB list , "Rafael J. Wysocki" , Viresh Kumar , Linux Fbdev development list , Dominik Brodowski , "open list:BROADCOM NVRAM DRIVER" , IDE-ML , linux-mtd , Tomas Cech , Robert Jarzmik , linux-clk , linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Michael Turquette , Sergey Lapin , Arnd Bergmann , Linux PM list , "open list:HID CORE LAYER" , Haojian Zhuang , Lubomir Rintel , dri-devel , Linux ARM , Thomas Bogendoerfer , Stephen Boyd , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc , Linux Kernel Mailing List , ALSA Development Mailing List , Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > /* Headphones jack detection DAPM pin */ > > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > > { > > > .pin = "Headphone Jack", > > > .mask = SND_JACK_HEADPHONE, > > > }, > > > { > > > .pin = "Speaker", > > > /* disable speaker when hp jack is inserted */ > > > .mask = SND_JACK_HEADPHONE, > > > .invert = 1, > > > }, > > > Hm some ASoC thingie. No idea what that is, but I suppose another > > place where a subsystem for legacy reasons try to do the gpiolib > > inversion on it's own accord. That one isn't flagged as active low in the > > descriptor so it's fine I guess. > > It's saying that when the headphone is inserted the headphone output > should be enabled and the speaker output should be disabled, and vice > versa. Ok, that sounds like I should remove the flag here if I declare the GPIO line as GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH, right? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC1D4C433F5 for ; Thu, 5 May 2022 15:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nug2aQ+bL7VxogVS9CT4BPHUfliji6Mjb+QD4hutjbo=; b=QTxvD0NUtsvmol YbI42d46RmiBla6BUNx3783DyPxisG85CQuBDjlnLBsCGk7fcuSXM99Oclm3Kej4siU41c3g6xx2a 1PJNs4N7YT2Oi3B+A+73Ah+uE30PjcSrfkrh8e7/5TrgIgMISlB0LuciNaPIm6q8aXTjIYNRF+9/r esP6Ac3LIxxGwKpBfZTEAw72xXIgfHavF5WnEWVWmLuXHIxZV7FxwdOEiydPoVpezVpTHEqz0Lw0h e6rV87Opyde/7leegvuOWn9dhQHTedeOWEzWt1HzE+KsJO74JifgVbKlz/MFUTd0TsJ3XJm5VU4Wx oNxr362OBYajwvdTZLHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmcxq-00GVtC-B1; Thu, 05 May 2022 15:00:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmcxQ-00GVhk-A1; Thu, 05 May 2022 14:59:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AD0F61CD1; Thu, 5 May 2022 14:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51F3CC385C1; Thu, 5 May 2022 14:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651762794; bh=IhPlTG/RSP+SotNFea7Fr39MZz0OjsoIPseiihaGxkc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=skKE7CkSWJipKAwKJCBrR71hl9l5yOYjQoARS41ioF8PPh7bxColWxsD4vdtmnrMC mQBIqAunoSnIAL+eTFw6a87TENu1OZL3J0unpwvAapDjehQbL4dIYPVxYDr5E0f8H2 2Ut88XHuXmqK6oXMnJsfP9eSc86Q5HJlHS7nBYfK8IZe39hShNsGm5F+uG6l3Ohx8q Y2qhl3pfwWmUs7JTRVGH5vJD27kQLOf6she+YLgBmzISzF3PWnvMRiH84FZiN5pT9f vZW1FeaKkpy+VomhCOcOZ66ZN31g3fbgxTh0Rr9f2+J3tXb9yK6yeSyrs1M6tkoYJl i07arWsPlHMPw== Received: by mail-wr1-f42.google.com with SMTP id v12so6460281wrv.10; Thu, 05 May 2022 07:59:54 -0700 (PDT) X-Gm-Message-State: AOAM5332KSIoaFfeCXY7uXmuhyJbxSAlfNnQkvD71gz12Dx/SEZoSXVt TTxVjV9hS3KmoLCaOgeySEVviSYQyI5usl/OeGg= X-Google-Smtp-Source: ABdhPJyKl/lyubFIqlgFQkig5zNAs/zvVqV8InTOhcfpAoriY4j8URNODYiLewygje3f2WDNulvuU9Rfg/N1L0FjaiU= X-Received: by 2002:a05:6000:707:b0:20c:4fd8:1d61 with SMTP id bs7-20020a056000070700b0020c4fd81d61mr21866057wrb.407.1651762791921; Thu, 05 May 2022 07:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 May 2022 16:59:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Mark Brown Cc: Linus Walleij , Robert Jarzmik , Linux ARM , Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , IDE-ML , linux-clk , Linux PM list , "open list:HID CORE LAYER" , patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc , linux-mtd , linux-rtc@vger.kernel.org, USB list , Linux Fbdev development list , dri-devel , ALSA Development Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_075956_464264_87D971F1 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > /* Headphones jack detection DAPM pin */ > > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > > { > > > .pin = "Headphone Jack", > > > .mask = SND_JACK_HEADPHONE, > > > }, > > > { > > > .pin = "Speaker", > > > /* disable speaker when hp jack is inserted */ > > > .mask = SND_JACK_HEADPHONE, > > > .invert = 1, > > > }, > > > Hm some ASoC thingie. No idea what that is, but I suppose another > > place where a subsystem for legacy reasons try to do the gpiolib > > inversion on it's own accord. That one isn't flagged as active low in the > > descriptor so it's fine I guess. > > It's saying that when the headphone is inserted the headphone output > should be enabled and the speaker output should be disabled, and vice > versa. Ok, that sounds like I should remove the flag here if I declare the GPIO line as GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH, right? Arnd ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A37B2C433EF for ; Thu, 5 May 2022 15:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cNxp4DlrEKLo+0xOWcOodW0UaO6eiubyo3E5uy2mwdg=; b=y6+dCKe64afHgY qa6bVgYn0eaUxMFCLDd6ZMFFu2u54/qDm7kCjcPnDr5K14Ka1tSzTARxtv15hW2aLf2oJ5IX18lQP IohczuhPdC2bG8MrdRK79mKXtcj82aLl84hXtg7EZ3vfV1H2tB0ObBWnj3VdbgDupELj6xS+PQSCi Rdd6myC7Rd8TXuwl/GyUDdETySJAkSAsANTHIrLP+JiPku1MIVTI6EOPAvspyXOhfEZm3Lpiz0NCL jYtPXLuHgwrl70DqCuzMXu2zmg/xHNs2dCuNtBoCy6RzE/RyOf+yyrdateEPlTe3Dz0Uuo3KrB204 aRtVVXEaNsNUj9Pk/AXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmcxU-00GVjG-31; Thu, 05 May 2022 15:00:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmcxQ-00GVhk-A1; Thu, 05 May 2022 14:59:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AD0F61CD1; Thu, 5 May 2022 14:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51F3CC385C1; Thu, 5 May 2022 14:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651762794; bh=IhPlTG/RSP+SotNFea7Fr39MZz0OjsoIPseiihaGxkc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=skKE7CkSWJipKAwKJCBrR71hl9l5yOYjQoARS41ioF8PPh7bxColWxsD4vdtmnrMC mQBIqAunoSnIAL+eTFw6a87TENu1OZL3J0unpwvAapDjehQbL4dIYPVxYDr5E0f8H2 2Ut88XHuXmqK6oXMnJsfP9eSc86Q5HJlHS7nBYfK8IZe39hShNsGm5F+uG6l3Ohx8q Y2qhl3pfwWmUs7JTRVGH5vJD27kQLOf6she+YLgBmzISzF3PWnvMRiH84FZiN5pT9f vZW1FeaKkpy+VomhCOcOZ66ZN31g3fbgxTh0Rr9f2+J3tXb9yK6yeSyrs1M6tkoYJl i07arWsPlHMPw== Received: by mail-wr1-f42.google.com with SMTP id v12so6460281wrv.10; Thu, 05 May 2022 07:59:54 -0700 (PDT) X-Gm-Message-State: AOAM5332KSIoaFfeCXY7uXmuhyJbxSAlfNnQkvD71gz12Dx/SEZoSXVt TTxVjV9hS3KmoLCaOgeySEVviSYQyI5usl/OeGg= X-Google-Smtp-Source: ABdhPJyKl/lyubFIqlgFQkig5zNAs/zvVqV8InTOhcfpAoriY4j8URNODYiLewygje3f2WDNulvuU9Rfg/N1L0FjaiU= X-Received: by 2002:a05:6000:707:b0:20c:4fd8:1d61 with SMTP id bs7-20020a056000070700b0020c4fd81d61mr21866057wrb.407.1651762791921; Thu, 05 May 2022 07:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 May 2022 16:59:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Mark Brown Cc: Linus Walleij , Robert Jarzmik , Linux ARM , Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , IDE-ML , linux-clk , Linux PM list , "open list:HID CORE LAYER" , patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc , linux-mtd , linux-rtc@vger.kernel.org, USB list , Linux Fbdev development list , dri-devel , ALSA Development Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_075956_464264_87D971F1 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > /* Headphones jack detection DAPM pin */ > > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > > { > > > .pin = "Headphone Jack", > > > .mask = SND_JACK_HEADPHONE, > > > }, > > > { > > > .pin = "Speaker", > > > /* disable speaker when hp jack is inserted */ > > > .mask = SND_JACK_HEADPHONE, > > > .invert = 1, > > > }, > > > Hm some ASoC thingie. No idea what that is, but I suppose another > > place where a subsystem for legacy reasons try to do the gpiolib > > inversion on it's own accord. That one isn't flagged as active low in the > > descriptor so it's fine I guess. > > It's saying that when the headphone is inserted the headphone output > should be enabled and the speaker output should be disabled, and vice > versa. Ok, that sounds like I should remove the flag here if I declare the GPIO line as GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH, right? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel