From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdFFJlN (ORCPT ); Tue, 6 Jun 2017 05:41:13 -0400 Received: from mail-ot0-f194.google.com ([74.125.82.194]:36709 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbdFFJlM (ORCPT ); Tue, 6 Jun 2017 05:41:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170605074846.30925-1-andrew@aj.id.au> From: Arnd Bergmann Date: Tue, 6 Jun 2017 11:41:11 +0200 X-Google-Sender-Auth: ZVXhP_Jkz229qUDUw6mhdyvHn44 Message-ID: Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node To: Joel Stanley Cc: Andrew Jeffery , Linux ARM , Linux Kernel Mailing List , Linus Walleij , Daniel Lezcano Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: > On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: >> The merging of a number of clocksource drivers into fttmr010 means we >> require clock-names to be specified in the Aspeed timer node, else the >> clocksource fails to probe and boot hangs. > > Arnd, > > Linus' reworked timer driver will go into 4.13. > > Can we get this patch merged into 4.12 as a fix so we don't end up > with a broken boot at any stage? Hmm, can't we make the driver backward-compatible and have it fall back on the first clock if no clk named "PCLK" is found? Otherwise you still have an incompatible change in the DT binding and it will break if someone uses an older dtb with a newer kernel. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 6 Jun 2017 11:41:11 +0200 Subject: [PATCH] arm: aspeed: Add clock-names property to timer node In-Reply-To: References: <20170605074846.30925-1-andrew@aj.id.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: > On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: >> The merging of a number of clocksource drivers into fttmr010 means we >> require clock-names to be specified in the Aspeed timer node, else the >> clocksource fails to probe and boot hangs. > > Arnd, > > Linus' reworked timer driver will go into 4.13. > > Can we get this patch merged into 4.12 as a fix so we don't end up > with a broken boot at any stage? Hmm, can't we make the driver backward-compatible and have it fall back on the first clock if no clk named "PCLK" is found? Otherwise you still have an incompatible change in the DT binding and it will break if someone uses an older dtb with a newer kernel. Arnd