From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD7EC433ED for ; Sat, 17 Apr 2021 10:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10386611C2 for ; Sat, 17 Apr 2021 10:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235455AbhDQKcV (ORCPT ); Sat, 17 Apr 2021 06:32:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbhDQKcU (ORCPT ); Sat, 17 Apr 2021 06:32:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D813A61209; Sat, 17 Apr 2021 10:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618655513; bh=bKkHYDWEnUxH4+NZsQzc9XdOBx/eAasVlApeofpvQ3M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=F8vK55v7UAeYClMXwewtQLHQ0TzAI75Gda/Ijyqb1bmDwdQP0a9qNJCXMN7YbFjAS dG8/5lw8Oh/K1rCPVqp5z1w7J4kKWAX0DkrnhWpkRSTuwOC7TPzuxif0+RqWn8cqRX pZUZxJgGN2u31XYsKolc/RRqCot3uzixXu+xCEwO9gitdkvxQC6D/X0UdL/QXE36np iD8Zr5qX8eqgiDJ8foVPlr+kPJNA1ItqyDhMGuNuBHDo9yh0U368iVOPkCABjyVsAC C3JEgc3qOIsozYto2rSELYyYwBSIA8CHj7yzKeDCuHRrrcWelfXpNbZ8dp+qY4qF47 TbQLKsvP+wzrw== Received: by mail-wr1-f51.google.com with SMTP id c15so20076620wro.13; Sat, 17 Apr 2021 03:31:53 -0700 (PDT) X-Gm-Message-State: AOAM531A/Ralkr5Ef+2lVwSBGEoVJlcbZhxe/rCXiWY/fIFgKSBFosAk et490+SZLCHJFTU6LoY0sitPb1R++jCrTuUTobE= X-Google-Smtp-Source: ABdhPJycE8LG0z9YxCgms5+k71EBmr9DkHzd41Oc6z9ytag0KDWOSXF5lk8cL6Kn2M30kai4QRK7X3xc1d9fGPyxl30= X-Received: by 2002:adf:db4f:: with SMTP id f15mr3734418wrj.99.1618655512568; Sat, 17 Apr 2021 03:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210410205246.507048-2-willy@infradead.org> <20210411114307.5087f958@carbon> <20210411103318.GC2531743@casper.infradead.org> <20210412011532.GG2531743@casper.infradead.org> <20210414101044.19da09df@carbon> <20210414115052.GS2531743@casper.infradead.org> <20210414211322.3799afd4@carbon> <20210414213556.GY2531743@casper.infradead.org> <20210415200832.32796445@carbon> <20210416152755.GL2531743@casper.infradead.org> In-Reply-To: <20210416152755.GL2531743@casper.infradead.org> From: Arnd Bergmann Date: Sat, 17 Apr 2021 12:31:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems To: Matthew Wilcox Cc: Jesper Dangaard Brouer , Grygorii Strashko , "netdev@vger.kernel.org" , Ilias Apalodimas , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , David Laight , Matteo Croce , "linuxppc-dev@lists.ozlabs.org" , Christoph Hellwig , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 5:27 PM Matthew Wilcox wrote: > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index b5b195305346..db7c7020746a 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -198,7 +198,17 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + ret |= (dma_addr_t)page->dma_addr[1] << 32; > + return ret; > +} Have you considered using a PFN type address here? I suspect you can prove that shifting the DMA address by PAGE_BITS would make it fit into an 'unsigned long' on all 32-bit architectures with 64-bit dma_addr_t. This requires that page->dma_addr to be page aligned, as well as fit into 44 bits. I recently went through the maximum address space per architecture to define a MAX_POSSIBLE_PHYSMEM_BITS, and none of them have more than 40 here, presumably the same is true for dma address space. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F9C8C43460 for ; Sat, 17 Apr 2021 10:31:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F2F9A610CD for ; Sat, 17 Apr 2021 10:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2F9A610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CBF0E6B006C; Sat, 17 Apr 2021 06:31:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6EA36B006E; Sat, 17 Apr 2021 06:31:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B36616B0070; Sat, 17 Apr 2021 06:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 9874A6B006C for ; Sat, 17 Apr 2021 06:31:55 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3A5B55833 for ; Sat, 17 Apr 2021 10:31:55 +0000 (UTC) X-FDA: 78041493390.40.868818F Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP id 9C52BA0000FF for ; Sat, 17 Apr 2021 10:31:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D4D4361152 for ; Sat, 17 Apr 2021 10:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618655513; bh=bKkHYDWEnUxH4+NZsQzc9XdOBx/eAasVlApeofpvQ3M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=F8vK55v7UAeYClMXwewtQLHQ0TzAI75Gda/Ijyqb1bmDwdQP0a9qNJCXMN7YbFjAS dG8/5lw8Oh/K1rCPVqp5z1w7J4kKWAX0DkrnhWpkRSTuwOC7TPzuxif0+RqWn8cqRX pZUZxJgGN2u31XYsKolc/RRqCot3uzixXu+xCEwO9gitdkvxQC6D/X0UdL/QXE36np iD8Zr5qX8eqgiDJ8foVPlr+kPJNA1ItqyDhMGuNuBHDo9yh0U368iVOPkCABjyVsAC C3JEgc3qOIsozYto2rSELYyYwBSIA8CHj7yzKeDCuHRrrcWelfXpNbZ8dp+qY4qF47 TbQLKsvP+wzrw== Received: by mail-wr1-f48.google.com with SMTP id w4so25302220wrt.5 for ; Sat, 17 Apr 2021 03:31:53 -0700 (PDT) X-Gm-Message-State: AOAM531LzQdFTqvMNla2+65ax2Qtn8wiTY0Vn+PwwYEGfDf5JNSIQ9Eh htZPY4Eiuk5hbao/5mDXVreEloua+j9/A4GSwn0= X-Google-Smtp-Source: ABdhPJycE8LG0z9YxCgms5+k71EBmr9DkHzd41Oc6z9ytag0KDWOSXF5lk8cL6Kn2M30kai4QRK7X3xc1d9fGPyxl30= X-Received: by 2002:adf:db4f:: with SMTP id f15mr3734418wrj.99.1618655512568; Sat, 17 Apr 2021 03:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210410205246.507048-2-willy@infradead.org> <20210411114307.5087f958@carbon> <20210411103318.GC2531743@casper.infradead.org> <20210412011532.GG2531743@casper.infradead.org> <20210414101044.19da09df@carbon> <20210414115052.GS2531743@casper.infradead.org> <20210414211322.3799afd4@carbon> <20210414213556.GY2531743@casper.infradead.org> <20210415200832.32796445@carbon> <20210416152755.GL2531743@casper.infradead.org> In-Reply-To: <20210416152755.GL2531743@casper.infradead.org> From: Arnd Bergmann Date: Sat, 17 Apr 2021 12:31:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems To: Matthew Wilcox Cc: Jesper Dangaard Brouer , Grygorii Strashko , "netdev@vger.kernel.org" , Ilias Apalodimas , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , David Laight , Matteo Croce , "linuxppc-dev@lists.ozlabs.org" , Christoph Hellwig , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9C52BA0000FF X-Stat-Signature: 3h5kutmpz5dzb1h8uf5wm47w7pan4y9y Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618655514-144533 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 16, 2021 at 5:27 PM Matthew Wilcox wrote: > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index b5b195305346..db7c7020746a 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -198,7 +198,17 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + ret |= (dma_addr_t)page->dma_addr[1] << 32; > + return ret; > +} Have you considered using a PFN type address here? I suspect you can prove that shifting the DMA address by PAGE_BITS would make it fit into an 'unsigned long' on all 32-bit architectures with 64-bit dma_addr_t. This requires that page->dma_addr to be page aligned, as well as fit into 44 bits. I recently went through the maximum address space per architecture to define a MAX_POSSIBLE_PHYSMEM_BITS, and none of them have more than 40 here, presumably the same is true for dma address space. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1EFC433ED for ; Sat, 17 Apr 2021 10:32:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 777F5610CD for ; Sat, 17 Apr 2021 10:32:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 777F5610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FMqCD0NW6z3c2f for ; Sat, 17 Apr 2021 20:32:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=F8vK55v7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=arnd@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=F8vK55v7; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FMqBj1b19z309s for ; Sat, 17 Apr 2021 20:31:57 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id DDAD561248 for ; Sat, 17 Apr 2021 10:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618655513; bh=bKkHYDWEnUxH4+NZsQzc9XdOBx/eAasVlApeofpvQ3M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=F8vK55v7UAeYClMXwewtQLHQ0TzAI75Gda/Ijyqb1bmDwdQP0a9qNJCXMN7YbFjAS dG8/5lw8Oh/K1rCPVqp5z1w7J4kKWAX0DkrnhWpkRSTuwOC7TPzuxif0+RqWn8cqRX pZUZxJgGN2u31XYsKolc/RRqCot3uzixXu+xCEwO9gitdkvxQC6D/X0UdL/QXE36np iD8Zr5qX8eqgiDJ8foVPlr+kPJNA1ItqyDhMGuNuBHDo9yh0U368iVOPkCABjyVsAC C3JEgc3qOIsozYto2rSELYyYwBSIA8CHj7yzKeDCuHRrrcWelfXpNbZ8dp+qY4qF47 TbQLKsvP+wzrw== Received: by mail-wr1-f45.google.com with SMTP id e7so20052257wrs.11 for ; Sat, 17 Apr 2021 03:31:53 -0700 (PDT) X-Gm-Message-State: AOAM532qAN4MZSbqSPPRRig2cra8bq3gsQOLo3O2ICcLMe0sVlaIaaR+ VfDpiThym/sDBGtq5WVJaDfxKSFG1PmWlxMsdz0= X-Google-Smtp-Source: ABdhPJycE8LG0z9YxCgms5+k71EBmr9DkHzd41Oc6z9ytag0KDWOSXF5lk8cL6Kn2M30kai4QRK7X3xc1d9fGPyxl30= X-Received: by 2002:adf:db4f:: with SMTP id f15mr3734418wrj.99.1618655512568; Sat, 17 Apr 2021 03:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210410205246.507048-2-willy@infradead.org> <20210411114307.5087f958@carbon> <20210411103318.GC2531743@casper.infradead.org> <20210412011532.GG2531743@casper.infradead.org> <20210414101044.19da09df@carbon> <20210414115052.GS2531743@casper.infradead.org> <20210414211322.3799afd4@carbon> <20210414213556.GY2531743@casper.infradead.org> <20210415200832.32796445@carbon> <20210416152755.GL2531743@casper.infradead.org> In-Reply-To: <20210416152755.GL2531743@casper.infradead.org> From: Arnd Bergmann Date: Sat, 17 Apr 2021 12:31:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems To: Matthew Wilcox Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grygorii Strashko , "netdev@vger.kernel.org" , Ilias Apalodimas , "linux-mips@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , David Laight , Jesper Dangaard Brouer , Matteo Croce , "linuxppc-dev@lists.ozlabs.org" , Christoph Hellwig , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 16, 2021 at 5:27 PM Matthew Wilcox wrote: > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index b5b195305346..db7c7020746a 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -198,7 +198,17 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + ret |= (dma_addr_t)page->dma_addr[1] << 32; > + return ret; > +} Have you considered using a PFN type address here? I suspect you can prove that shifting the DMA address by PAGE_BITS would make it fit into an 'unsigned long' on all 32-bit architectures with 64-bit dma_addr_t. This requires that page->dma_addr to be page aligned, as well as fit into 44 bits. I recently went through the maximum address space per architecture to define a MAX_POSSIBLE_PHYSMEM_BITS, and none of them have more than 40 here, presumably the same is true for dma address space. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09180C433ED for ; Sat, 17 Apr 2021 10:33:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 849DE610C8 for ; Sat, 17 Apr 2021 10:33:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 849DE610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UJqdNCrabVz8lfoziBraZIDwDpPHc3YvI6vQCvRI/OE=; b=EzBa2+60K1XnZqb2iu2ed91LM Q5OhlD2IN9FV1u6m0/hc/T62ga9B1/w5bnwcw4bP17uzyAEq/AIkkW6+vrgWmjTQUKL9F+pzM3ybQ 0ObsGvPLNobWjFBITaGUE4T1gG3PNKJsoSUD+hrwCyQRbWV7G+uicC8Ad3LX5hrd4UisPxiiHaKcv kblddgioj9dBI+Gc+1s3VqdqAo+9aRcGjfhf4D3zHWmB94vz2BxewDJQDJqVZx9gSBuvssgdT8mzQ uBbX5jnJEgHLJad57g3Ulqu5mmmWzINQ42DYiOKdUxreuBm9ktPoUUAHvfV+CmahtqZXsM4KeSD5p ZZfCUu/Tg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXiF6-0050s0-4T; Sat, 17 Apr 2021 10:32:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXiF2-0050rV-LU for linux-arm-kernel@desiato.infradead.org; Sat, 17 Apr 2021 10:31:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=exyTl+vtBb+fvovHbYo/IU/8zZrzrkd4DsDn1X/F4oc=; b=rCJMCZfR2ZRJN2UAa0mc8iEOXK nJIIW2s7jqSnhipUSCS5W8Bl/cOcVGbOhcvqaY+aeewgm4x5lNoTSG/VoX0VKrCgmpKmX9DghdaIb fNhxxpry/B7dRwir0EaWiisuzLDl3jXidEcMEbCfnDr6rLmQlV4C/xtAwUjK/T6iNkTg4r2xlw++C kIikJBnaMiWdezhcgpjgvgqL3Y+oz9Dnwqe4SPm2KMfEtLStRA05q2IZgV36MrQ5UdZNtSfuebZAN bIKYq7ckZqNWpVA9mIQ6YluNN4RF8mcO9I6LLVMT8Ff3iWWlswJdOL2MqBtB3TjV3JlxAiJ2RLodL xb2M5+Rw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXiF0-009yu0-80 for linux-arm-kernel@lists.infradead.org; Sat, 17 Apr 2021 10:31:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFB60610CC for ; Sat, 17 Apr 2021 10:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618655513; bh=bKkHYDWEnUxH4+NZsQzc9XdOBx/eAasVlApeofpvQ3M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=F8vK55v7UAeYClMXwewtQLHQ0TzAI75Gda/Ijyqb1bmDwdQP0a9qNJCXMN7YbFjAS dG8/5lw8Oh/K1rCPVqp5z1w7J4kKWAX0DkrnhWpkRSTuwOC7TPzuxif0+RqWn8cqRX pZUZxJgGN2u31XYsKolc/RRqCot3uzixXu+xCEwO9gitdkvxQC6D/X0UdL/QXE36np iD8Zr5qX8eqgiDJ8foVPlr+kPJNA1ItqyDhMGuNuBHDo9yh0U368iVOPkCABjyVsAC C3JEgc3qOIsozYto2rSELYyYwBSIA8CHj7yzKeDCuHRrrcWelfXpNbZ8dp+qY4qF47 TbQLKsvP+wzrw== Received: by mail-wr1-f43.google.com with SMTP id e5so366069wrg.7 for ; Sat, 17 Apr 2021 03:31:53 -0700 (PDT) X-Gm-Message-State: AOAM532bdDb2bSuAZrCa2wIEePpIKVJ+0IT8w4M0dXMvqVkA3oNZpINB jS95spUrPboM+awwnrtUE1n2h/34cr/AzzIajS8= X-Google-Smtp-Source: ABdhPJycE8LG0z9YxCgms5+k71EBmr9DkHzd41Oc6z9ytag0KDWOSXF5lk8cL6Kn2M30kai4QRK7X3xc1d9fGPyxl30= X-Received: by 2002:adf:db4f:: with SMTP id f15mr3734418wrj.99.1618655512568; Sat, 17 Apr 2021 03:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210410205246.507048-2-willy@infradead.org> <20210411114307.5087f958@carbon> <20210411103318.GC2531743@casper.infradead.org> <20210412011532.GG2531743@casper.infradead.org> <20210414101044.19da09df@carbon> <20210414115052.GS2531743@casper.infradead.org> <20210414211322.3799afd4@carbon> <20210414213556.GY2531743@casper.infradead.org> <20210415200832.32796445@carbon> <20210416152755.GL2531743@casper.infradead.org> In-Reply-To: <20210416152755.GL2531743@casper.infradead.org> From: Arnd Bergmann Date: Sat, 17 Apr 2021 12:31:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems To: Matthew Wilcox Cc: Jesper Dangaard Brouer , Grygorii Strashko , "netdev@vger.kernel.org" , Ilias Apalodimas , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , David Laight , Matteo Croce , "linuxppc-dev@lists.ozlabs.org" , Christoph Hellwig , "linux-arm-kernel@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210417_033154_329143_331FA9F5 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 16, 2021 at 5:27 PM Matthew Wilcox wrote: > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index b5b195305346..db7c7020746a 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -198,7 +198,17 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + ret |= (dma_addr_t)page->dma_addr[1] << 32; > + return ret; > +} Have you considered using a PFN type address here? I suspect you can prove that shifting the DMA address by PAGE_BITS would make it fit into an 'unsigned long' on all 32-bit architectures with 64-bit dma_addr_t. This requires that page->dma_addr to be page aligned, as well as fit into 44 bits. I recently went through the maximum address space per architecture to define a MAX_POSSIBLE_PHYSMEM_BITS, and none of them have more than 40 here, presumably the same is true for dma address space. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel