From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation) Date: Tue, 7 Jan 2020 18:08:18 +0100 Message-ID: References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-6-git-send-email-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1578415992-24054-6-git-send-email-krzk@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , open list:SYNOPSYS ARC ARC List-Id: linux-arch.vger.kernel.org On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks good, but I think this has to be done together with the powerpc version and the header that declares the function, for bisectibility. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75661C33C8C for ; Tue, 7 Jan 2020 17:30:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 319E820678 for ; Tue, 7 Jan 2020 17:30:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 319E820678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47sfXt6dyQzDqSw for ; Wed, 8 Jan 2020 04:30:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=217.72.192.75; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47sf3Z48MXzDqLn for ; Wed, 8 Jan 2020 04:08:42 +1100 (AEDT) Received: from mail-qk1-f176.google.com ([209.85.222.176]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MEV7U-1ivxl91YRm-00Fzr7 for ; Tue, 07 Jan 2020 18:08:37 +0100 Received: by mail-qk1-f176.google.com with SMTP id z14so42030057qkg.9 for ; Tue, 07 Jan 2020 09:08:36 -0800 (PST) X-Gm-Message-State: APjAAAVjQGuGLh+aCGVYqzPP/KlGLDkXhQ9ifda2kOcxAKqccLoR/h7x dioabjLRgS6MUXhYirSxNEn16nP2ArWbq2SA9r4= X-Google-Smtp-Source: APXvYqzRk52Ew2lmsQMfvghk3ylFHcEIR88yL70qbdC0HVK9etbYRWgu7fgyXH4+189J3IyWZY+dkJGnvq1XjVlLM+A= X-Received: by 2002:a05:620a:a5b:: with SMTP id j27mr335658qka.286.1578416914895; Tue, 07 Jan 2020 09:08:34 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-6-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-6-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:08:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Pc+uNUsKJ6LpMdeclnvqWBGuzhlAGWGcKkZV+MO/UViIa/kOBuq BnfRR3xPxhbhgEnT4IysYvmOkwyw8jo9sFSj6NwoR9SsG8Zdc7NAo3fUfTcvBqu2wWq8f8q Rb32+H23/H7e4/HBANG7bgT1LtyG7NdTeGOJrB5Cutkufdkiqkvbquv5tKXVJ+X4yG/PtYQ Fyi1Dj/BtHT/WZSvoNgwA== X-UI-Out-Filterresults: notjunk:1;V03:K0:mCRuz20hYAw=:sycK1h5A8tjVP3UcEj+C+/ ZAKdzJ7jY8xNxe55RG7je/HiTYkK/BAKwEa/9WsoeNc/BlgufFBSaJnF31LWhE7H5abPpZgRw KDIEIC3C99kdp1wN3kJreN1NvX+FOT0IP3XxrkxnR/+BBaZNWXhXxHtd5IY+/+cPC+IDUCm+S fgpB2yImjiOu1M/mAykewHHF+G2veZuEs7354yAG7UaMzWNZPjcY/qfFLulHvXnT+Q3sns8km 7GIamM0F1dUmsFnZr2/I9GYj/B9mE+AQZi5lj4fiTRo5pwhlUhxI8rDCuva7yWUCOKjuO5rJB Im4RgeTP94icKsKpxQWolNUTQkIYkgcJtG6adWcCUEKrX8Dg8wYvVPMYfmoXgKEp7n7Ekd2+A DeamrDV7ebwTID25E7WZu2i50em0Spvm8IfBaPzMsRjk1h/MQ0V4Vf53fLnOVzq3gT8MveDXe EiAH5Sgy9FRUWklkW3kIu94c7QgUdAKuuiQbqBhEfyd1oXL5tA7cJNWahD6pkvWaKHYb50hbj 5eU39VvWAiENvWQ2DClvqdU7uLPOUpCrPSY1PkC54SYKULqAVLvfuSGW3LGsUymYoM8SmvWXY 6fxHY7zuYBbYOj8WozuLoA1Sq7bBRSYK8t/EctO2ShafcniSB5Z6xh9c/axsXBpulS5TRWmy4 Djp6oNU0d1yGOroYSNVGCHdump0KkD8GbcSveDE7jXs0wU7x+Fd2mTkbwq5jykpxs+WaDKVYY Ek8ahYmf4JDGh11S1G1mNSLErdHFSjM+w9hl8w8n2/MBdx63IkCixcwSjLXx1kbjxFg73I6Bk leTr/vLSkDBAzZ0U7ZCMgEshPVQe5L+kea2gyfw9omy0dky/86QI2Qt7EbrkfgPYcXb2ecNDG /0LVqhn5AayWwkgM+ePw== X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks good, but I think this has to be done together with the powerpc version and the header that declares the function, for bisectibility. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5178C33C8C for ; Tue, 7 Jan 2020 17:08:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96CC22087F for ; Tue, 7 Jan 2020 17:08:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QSH34SUg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96CC22087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=otDwHjdxxXx1gtCZM6ZydM4i5jquLIYc/Rex3Kzu864=; b=QSH34SUgUo3SDu OZ5fe2YzB98i9D4bbJ2LSKWrCgQ63nemo9xxXcijZj5tu4f+jHeYjNHKzEGD52FPCAF4txPxErrqb y79FnEdGjlTG6AOTa3YrgMr/RPENkyJGGS7neVNxOEApMYooDU2ySjtsKdhgkEgSpMzt4Cdgsce3o omnDVJMHQQ6pt/kq3PjdwtyhRO/qR1M2t3lYmuO+WQbwTpR2YvZsf8wEsOWi6CMiq36S3IBK9qVvj 5UHyoebx75gMwqTcrC1Xpudojaqx1DvCXvCLE+oEZUpPpIfJcDUscw63hYgVNod1aPkPTWJTSKr0D 33Ramw4sonap91saY73w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iosLU-0007Xr-Cz; Tue, 07 Jan 2020 17:08:44 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iosLQ-0007XO-SX for linux-snps-arc@lists.infradead.org; Tue, 07 Jan 2020 17:08:42 +0000 Received: from mail-qt1-f178.google.com ([209.85.160.178]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N32y5-1jpjsP3w4b-013NZh for ; Tue, 07 Jan 2020 18:08:37 +0100 Received: by mail-qt1-f178.google.com with SMTP id l12so320705qtq.12 for ; Tue, 07 Jan 2020 09:08:36 -0800 (PST) X-Gm-Message-State: APjAAAXYoWU/m/HO8lUq/Jnbvhp79VpelWiY61w6Pk6AkNdwL+hBzWTZ aZWTMgrsKEvZ2cssGYFpjcV/jegJcCv/6Ep4qQ0= X-Google-Smtp-Source: APXvYqzRk52Ew2lmsQMfvghk3ylFHcEIR88yL70qbdC0HVK9etbYRWgu7fgyXH4+189J3IyWZY+dkJGnvq1XjVlLM+A= X-Received: by 2002:a05:620a:a5b:: with SMTP id j27mr335658qka.286.1578416914895; Tue, 07 Jan 2020 09:08:34 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-6-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-6-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:08:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski X-Provags-ID: V03:K1:VSOcPbuZrtE9z0G4t6qthjXAXiG2KCwZ1PDwLMYkJy6Sj8ApYSe lZvI5krNPhwAKzQOQE/yMgmJrsTCzF/2Gpf91xFTLf8tV5VDrvpznwp5lY4dBefB5wy/ump bKFUjHwcyeZFQjABOkO36hOUPUpBCHc8POhBfnfyCEqiwwPlasXBKnnKFixL9WEceeeUYhY UXYQQt8PDlrt2Ahr4clHQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:0gXiqiY6ngg=:E6RWff7mNCNRcH/mlDju0b bHDTwXPb4DqSpgWAqoKiroDZB4QAXrut/hZKah0nlTv3YOw5M5uYE0d8p6H+52S/Du08+Aw9Y T20j6U0xM6DpdwL+2SZgQOLUhD98U3BzvDh1/JOpsIqhcyERuMhc+UtR0W1xQllhuXIb01lkq kZiIonuRayYyOpAQP6KyKtQ7/V9Dp4wGXD2vXeY5rKdw5W4X+45r7Idf5VvcTQ4PBa5bDNzkW CjkGbcBgg4YoGy9Whc4AaCTGLC9vCDCyTEmKaIJrn6vYBZelA5w00EhVaa0LYS6ijVc38A3S8 RHWv+Xe0hB7vAUJNn0SW20MDtIlUnA9Oa8S0A5WNRZ6gRG72vVNog7nIHncQqI+03YnUZYluE uipXGznKI2kCAySXLnfI48wildBn9ugklznFXs70BImoggpHF4zl3NaTb/Vo4XWfKjhlOUh9D cDPkX+WKDFTNG67JGJ6vtk4IlZ9bUPusZL5a3dLGbuojv6WH5RxOxu5wRe1LQd3Qamj8SfiBW OSPgxmRCrUqQecovDsfHc/p/yVzvqkvjsnkgZMXuscs4cJ/uAACAsCDQpVQAqnXs7sxMY2Fds TQNBXuhMcWZcspX6Ff1R1f6E+J2JJ3iZNADfT+ZmYmNpepFL/kQ+Ncp667RQtg8wSB7rnjT1I qOkiFz3lFdzREwt6erBHSsMwhjGzhQIDmWFwLwd2Juv2dAwtkGpqyEc+WH9uhrHDSEydWwy4t y8bgrW50e28dTPCaI1gRh8Kg5VMnFdj6MGCEHYEQ+UhsUGhSvdcUUOFN38daPY+e57qYwyzfB VH//O2dR2v563lLH4noQB0xS3GXC+YQpXZAYcwBBgy28hR7YBVsTq/VwrZExFyO4XJRbAvxNs C92PARpDBSKEv7NR7pHA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_090841_212670_CDE78ED9 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Benjamin Herrenschmidt , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks good, but I think this has to be done together with the powerpc version and the header that declares the function, for bisectibility. Arnd _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE0BC33C8C for ; Tue, 7 Jan 2020 17:08:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B5592087F for ; Tue, 7 Jan 2020 17:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B5592087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DBBE6E82C; Tue, 7 Jan 2020 17:08:39 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC9E86E82C for ; Tue, 7 Jan 2020 17:08:38 +0000 (UTC) Received: from mail-qt1-f176.google.com ([209.85.160.176]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N4eOd-1jo5yt39WR-011iUd; Tue, 07 Jan 2020 18:08:36 +0100 Received: by mail-qt1-f176.google.com with SMTP id e12so383065qto.2; Tue, 07 Jan 2020 09:08:36 -0800 (PST) X-Gm-Message-State: APjAAAXqTVI9wmEOoULoNlRQy3R9GNmCICUVYlUn8yBG7qDMh+EO8x9j mcjhreC9V3O3I+qznkNXp9QBMZed/SfwiFv6ZzI= X-Google-Smtp-Source: APXvYqzRk52Ew2lmsQMfvghk3ylFHcEIR88yL70qbdC0HVK9etbYRWgu7fgyXH4+189J3IyWZY+dkJGnvq1XjVlLM+A= X-Received: by 2002:a05:620a:a5b:: with SMTP id j27mr335658qka.286.1578416914895; Tue, 07 Jan 2020 09:08:34 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-6-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-6-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:08:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski X-Provags-ID: V03:K1:IDMrLgC3H0ekmK6SwU9PMUPDAlZ6fljKTY5XMWA8Myz/jUHSKWE pXwUQZK18iHBuQPyaE7xSxkyKwdHREvojqcA9MEODrB/MbXHbg85sr+aRj/zFD4vz53ck5J FWTz9ZovYLhMwd21BkrUqaYI4DcqD19BcLadoJ45YmK9GH0tK/vVTscAqoPrzAkd9yBShIg t6XFKKvd4xI7+zETbAxkg== X-UI-Out-Filterresults: notjunk:1;V03:K0:mR/c4lj8xd8=:Ncy4Vv6lgUVoMBjg+pvFIx rvJhbWimU8pv0OWpqelzbkmfEb8GypCJZVwEQcflUfgsn6poAN5ltQw4UWr1VLZajhpIfQLgt 26L4BzxOuzUX4pP6vhS+C3p2PSTxspu6i7I/cYPbkRMZWNv/+vgQsX1BQjy38+0RCee3EXZaJ 2sxAqgf6yCLCcgUjC5FyttUdPSIALicyPBGq/e7bhnht1cCuunP9ucOrsitSn3nVdqlBv+COd 2ByLRWl41vMPrv+cJ5h31jQzl/A42B1qpnJ72AGbrvoCnUIb7Bv8uaOo9KxxEc+hjH0tBOuYS VFfWu4/D89snYQygPGIxajO63Wvz11lIQAEJG4WpMxYQskqVJCx6xHCh8D6j9slewTUzDLRf8 7oxrztwudLzhy96QvSgL4fM2OV9TtgFkFnOkbylRp96emFjx0RQQ+LrhBqCfRyD1VZfP5upDY NRkRahONsaah53v8o2hVjtu84pvXT01GIiX2dplWboz+69Ioy+s3TII6HW45szsuQAk12qtlJ LSoj4lAe+YNVVXGu8JPwaO2ifPwPFAion7NNO9OrHVAGE4LgYYEJBCroNz7gZ5g5sTL12LSp6 OjQfbRMTYYoca6xEs2feADrOk1g3W6gGQLw4rjOkouINhi139FUtNOvIWFJTxG+u3OAECiKiF qGi3PpKfl3TqvWgZbjmDi/C/ZWeNh7uWEPt7dH03aI7tpaJ3C0MxSP3GBCXHWvvxbDchHWu03 v8IoJImYtPj3XcvdzpSIGcnq1ufIPHh4RUBqSwUPBpOF9jdUD8gTXhSvSXqIbRoDQBap6NurC oqUrxImD958kzip88Y8lw505r46OEbOfAfphmQ0plTPE+bNrBunzX3K9s5CnNjYfmO/Q4UPhs 60QT3OGoJfOmuFxbqqJw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks good, but I think this has to be done together with the powerpc version and the header that declares the function, for bisectibility. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.130]) by gmr-mx.google.com with ESMTPS id s82si10934wme.0.2020.01.07.09.08.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 09:08:37 -0800 (PST) Received: from mail-qk1-f181.google.com ([209.85.222.181]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MtwIW-1jghS51Gu4-00uMpU for ; Tue, 07 Jan 2020 18:08:37 +0100 Received: by mail-qk1-f181.google.com with SMTP id d71so59617qkc.0 for ; Tue, 07 Jan 2020 09:08:37 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-6-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-6-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:08:18 +0100 Message-ID: Subject: Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation) Content-Type: text/plain; charset="UTF-8" To: Krzysztof Kozlowski Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Thomas Gleixner , Geert Uytterhoeven , alpha , "linux-kernel@vger.kernel.org" , "open list:SYNOPSYS ARC ARCHITECTURE" , Parisc List , linuxppc-dev , Linux-sh list , dri-devel , ML nouveau , Linux Media Mailing List , linux-wireless , Networking , linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, linux-arch List-ID: On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks good, but I think this has to be done together with the powerpc version and the header that declares the function, for bisectibility. Arnd