From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbdBOTyC (ORCPT ); Wed, 15 Feb 2017 14:54:02 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36788 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbdBOTv7 (ORCPT ); Wed, 15 Feb 2017 14:51:59 -0500 MIME-Version: 1.0 In-Reply-To: <20170215171732.GA4548@kroah.com> References: <1487156981-4550-1-git-send-email-user@thloh-VirtualBox> <20170215171732.GA4548@kroah.com> From: Arnd Bergmann Date: Wed, 15 Feb 2017 20:51:53 +0100 X-Google-Sender-Auth: GkNcvdGL85lDPvYuzGkUYBAwz0w Message-ID: Subject: Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver To: Greg KH Cc: "Loh, Tien Hock" , Linux Kernel Mailing List , thloh85@gmail.com, matthew.gerlach@intel.com, dinh.nguyen@intel.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 6:17 PM, Greg KH wrote: > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: >> From: "Loh, Tien Hock" >> >> This patch is to add Altera System ID driver. >> User can obtain the system ID and timestamp of the system by >> reading the sysfs entry. >> >> Usage: >> cat /sys/bus/platform/devices/[addr].sysid/sysid/id >> cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp > > If you add new sysfs attributes, you need to also add a > Documentation/ABI/ description as well. Maybe we could pretend that this is for a SoC and use the standard soc_device attributes as well as moving the driver into drivers/soc/? Arnd