From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D29FC83004 for ; Wed, 29 Apr 2020 20:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 405C62076B for ; Wed, 29 Apr 2020 20:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbgD2UNh (ORCPT ); Wed, 29 Apr 2020 16:13:37 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60299 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgD2UNh (ORCPT ); Wed, 29 Apr 2020 16:13:37 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MlO5j-1ikOiA2IEH-00lklT; Wed, 29 Apr 2020 22:13:35 +0200 Received: by mail-qk1-f181.google.com with SMTP id g74so3381207qke.13; Wed, 29 Apr 2020 13:13:35 -0700 (PDT) X-Gm-Message-State: AGi0PuZKJeyQsi5vXdTIxqcwhP1iOQ+UkecM3VWIOihlJWoBwrN1Q7Bs 5y+Eu/6G/l1icwPhX7HSHrW1FNWLbwBMk1b5rIk= X-Google-Smtp-Source: APiQypLgwNCOWXi8lqhZ+IOv19XxfH/9iluwOOMdrmf8VHOif7vlkTCUTHkDgO4JZEVtkCieIyzUDvCFIORJYDtFE+I= X-Received: by 2002:ae9:f712:: with SMTP id s18mr204482qkg.394.1588191214238; Wed, 29 Apr 2020 13:13:34 -0700 (PDT) MIME-Version: 1.0 References: <20200429132349.1294904-1-arnd@arndb.de> <20200429133512.GE1551@shell.armlinux.org.uk> In-Reply-To: <20200429133512.GE1551@shell.armlinux.org.uk> From: Arnd Bergmann Date: Wed, 29 Apr 2020 22:13:18 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [v2] ARM: oabi-compat: fix epoll_ctl build failure To: Russell King - ARM Linux admin Cc: Christoph Hellwig , Linux ARM , "linux-kernel@vger.kernel.org" , Linux API Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:zqjB0K5itibZQxDrMZXbU6dnX9nPzRmtRkBND1WinO3L0z3plWD 9u5ckpGOQBLolZ2lG/bNXZJq3mpAi4a8VWLQ5Yji8cKAntBsXFlOHYR0OAKjKavW5i/lSHf YIdWwMNkY5rXRO8vDKPEX27XBH45Qmi9Aqq7QbSOa2VFv70Cfu2wAO/quqYtYZEa+dx6rvA TStcjRw1udFVmJFUzJppg== X-UI-Out-Filterresults: notjunk:1;V03:K0:BWh5PdHHxKQ=:MpYawQD1ciBPVEX2das18A utk58HKgTGlFGALiNtOAHZO1g5dDgTLCRB+BufUCxdQPSfVjvM9+HFnPAniHVkYZKZ1JY2Ofh chB3FyJgNoOuBLbg+EBgorrDgXqWXpPV8XMUuBG1tEEfa86Iw3OVZK0piwR/VAakS276/CFGx 0I6VsLwPif+2Bum9+CtjP1UxV3oJ+3AFCjxVMzykl++qbjZIYlybXFHJi+q8Hpr2cNtm5Lyaz X2fpCgwtIq9FpHP/PKyhf3ie/Ab0zN5HmmDxmfem7TMRjD0lL1dCdcmqEwHfHlOV5UZnFE1s0 t1NfnZYcBPItIFNLwn06l5UuIOqEYqfxbKiN7kA3z57+0NDFx/tub4XSi0qM7mt8VD1rQZqcF RMKSq8Bhfi+72KNBRXC1BVqw9BbSyOtVnmO0Yy9endtw+DazyFCHdhp6lW8oq6XKLrHqBuKx3 3SWTk0srTyDCBa8Dr4fHR0r0AnuTU4SaUcH8c1sLNQFxvq1DpVQAQ0eB8Paz5Sp+7XOt+2D92 1284OhQe2ifSuo2P56O64Lu6PlcgalfSsatr1Y7JFwgeqMrOfRZ65Im7kg6E5G/HeXbhmabt2 J7dw/1Jhbg7o1uW2jqJzYBveIL8eeY7lb9ib7bOKiDuRgm4p19M8tp4nEal5VNcA61+9XvEvF Xn3VZXlp+C9ZeJrDCEI+ncmtIlTGnZe1c5zs4YrfyTOFssM9xgWTCdWvKP7LVP5O1kq1jHhiW uK3j2H3SCGeOqJsrEqSRw6rblfw27I1pFPUD6kWrbcfqMJHVjz5xSbSC3DUwAuRk10OiDjRS0 52ytQN8K55Pv22f7FSwYI+0tdDEwKhfX2ECnUoXALHRTjisNYY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 3:35 PM Russell King - ARM Linux admin wrote: > On Wed, Apr 29, 2020 at 03:23:24PM +0200, Arnd Bergmann wrote: > > Two functions are not declared or defined when CONFIG_EPOLL is > > disabled: > > > > I know what Chris said, but do we really want to be polluting generic > kernel files with arch specific stuff like this? The file already has a couple of architecture specific syscalls listed already, so it shouldn't be a big deal. If you prefer the first version of my patch, or have another suggestion, I don't mind sending a v3 that does it differently again. Unfortunately, COND_SYSCALL() is a locally defined macro in that file, so we can't easily use it elsewhere without duplicating it like in kernel/time/posix-stubs.c. As I mentioned in v1, it's also possible to just make this function compile without #ifdefs by having conditional stub definitions of the missing interfaces. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B2AC83000 for ; Wed, 29 Apr 2020 20:13:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B7542076B for ; Wed, 29 Apr 2020 20:13:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W0BTizTA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B7542076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kYVwiWPKWfjhpWAawUcM67C4GEj+3aWEFas01+Zxhdk=; b=W0BTizTABAtoob oiHHHiZz6fRMzA+nIs3BDBNZBOmbjAI1wbuErsVXqL8w8ceCTOMpEOAtCOMW1O9sDBdCm28FLygoT lTsKtJvjx3F3K+7iqlMUIgq8C34hpAI9Q96azMRiIM8IH+ev503tEm8ms1HcXHcd8PmgqjZLx70Tg G1IqeDU1OJBD5MKmVibE5DZU3kXXHU6O/kiRqU4VDrvdMkP2MYBHowe9LZK3djCQ/o1IXJqJU4Vgc HQA6Yfpb0It8+Rbl0dCQuCwuvGBVVmzv91FIagxvJBiCszSVt30738olS988PlM73HmzNuDLNx6fl BPhIC0SDdCEr3iqDnnGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTt5X-0003i5-74; Wed, 29 Apr 2020 20:13:47 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTt5S-0003gP-FI for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 20:13:46 +0000 Received: from mail-qk1-f169.google.com ([209.85.222.169]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N30VJ-1j1vYw3Tll-013QKE for ; Wed, 29 Apr 2020 22:13:36 +0200 Received: by mail-qk1-f169.google.com with SMTP id h124so3387643qke.11 for ; Wed, 29 Apr 2020 13:13:35 -0700 (PDT) X-Gm-Message-State: AGi0PuZvtT79Sqz8op/4C2xTY2tJbIcR9mIAXDz2k/4EGqruQcBbZlNH P2IO1kx2XDKnQu2oiyvmSDuVScrE+UzOl0ICwMQ= X-Google-Smtp-Source: APiQypLgwNCOWXi8lqhZ+IOv19XxfH/9iluwOOMdrmf8VHOif7vlkTCUTHkDgO4JZEVtkCieIyzUDvCFIORJYDtFE+I= X-Received: by 2002:ae9:f712:: with SMTP id s18mr204482qkg.394.1588191214238; Wed, 29 Apr 2020 13:13:34 -0700 (PDT) MIME-Version: 1.0 References: <20200429132349.1294904-1-arnd@arndb.de> <20200429133512.GE1551@shell.armlinux.org.uk> In-Reply-To: <20200429133512.GE1551@shell.armlinux.org.uk> From: Arnd Bergmann Date: Wed, 29 Apr 2020 22:13:18 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [v2] ARM: oabi-compat: fix epoll_ctl build failure To: Russell King - ARM Linux admin X-Provags-ID: V03:K1:+oO50dFHuxVKMpkW8DnBmwtIqs7+ZZXXP4G+2ML39jkcvM9XZc/ BLKZw/wEWQjYIB3IF+2URTYe8R0WnvWPgATI+P9UX/7QKcSJTwcNVYB93dd1I8mT2mQmDgN z0ay48TjMxpLqUEJsfxpWE0uprZOzKnLwZOAnee1IL0K4gMwwXv/I+dUHYW0AGfacMgGKHD 34h3HPLXVhvIjEj+bEAdw== X-UI-Out-Filterresults: notjunk:1;V03:K0:MRRdgMgAqGg=:PpkUvrr8QJVJ4TEN4XPiv9 OKFMnryeAozvCbn+WQPCChq3smBHOG7H+3vmBtZ8VklMuni6qYbrD2LHLNVVKqCour73v/CXq YVsp4q0e0WgrxFgFsQ+lymMfWPBjgcKPfPjhSCOZy9n/uWTUB9KSPQZpsW6Ept6Wv6w7YsLHE 02zZkMSZxLUK5IGJjrdKsus6jIjSeZuL5lr97HMMXCrHRa2iVOTQzfGpOb3I0Ds3BUNk/bGEM SBEbl7g5AMtM3qRtqq3ivaRL42yoaCstXMA73uh+KtykwIc0XCvg1wDjId0wNOD1bmv9NBPil eSeA795nnVcB7Yit9yQf36MoqnosWLLiuww40Sh9If7YPaajz6FH8WOJT9l9pC7x+If9B8pp2 a3jxxd7qu6jlmlLZvCaQXMPmcfNfrHiF39eoarkhnjrDMStZSqTl6O+mDdgNc08inRbTfF/bD Mu5A7/zR/N7FdeX4gMV6WMeWVqM0mTSnBuWMQAOrpAEqfHnZi6Y19SWuKgwIL+SaQ/+ej+mcS 7wadAcpZCkSqqTFtwqtz3N0D2QMgFE/VbfqHHD2yfv+dfejA5BtYRsxWfY1JnDEp2mGAvqjkl lQeTU/g5JNNjkTrCiP9EwumMKEzzlytWXKcZevVG4/NGbFwBtbpWdAU23/PavIvIHSIICLP8T 9lOgukVYAZp4auhImMSbA+F2uHCgfefwBceILgny32p4w6PFVtnFgGFstLNFqVFd5QhcI9paz ekm+7Je3ePTTISGhcMkjAbGyKJrzhFFcKtCblvCmnVOKbI8lkt+HzUj0Vnz+oW+ROvO3v3CCr TARJLAj8QYOIe1AuGMaCmZPPZuiT7hVhgFUa+imJc++B58DNqA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_131342_803992_DCE7EA77 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux API , Christoph Hellwig , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2020 at 3:35 PM Russell King - ARM Linux admin wrote: > On Wed, Apr 29, 2020 at 03:23:24PM +0200, Arnd Bergmann wrote: > > Two functions are not declared or defined when CONFIG_EPOLL is > > disabled: > > > > I know what Chris said, but do we really want to be polluting generic > kernel files with arch specific stuff like this? The file already has a couple of architecture specific syscalls listed already, so it shouldn't be a big deal. If you prefer the first version of my patch, or have another suggestion, I don't mind sending a v3 that does it differently again. Unfortunately, COND_SYSCALL() is a locally defined macro in that file, so we can't easily use it elsewhere without duplicating it like in kernel/time/posix-stubs.c. As I mentioned in v1, it's also possible to just make this function compile without #ifdefs by having conditional stub definitions of the missing interfaces. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel