All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Eric Sandeen <sandeen@sandeen.net>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [GIT PULL] xfs: new code for 5.5
Date: Tue, 3 Dec 2019 21:46:45 +0100	[thread overview]
Message-ID: <CAK8P3a2rrTN=ZED4pHX1WLCV+RUitN3G5XKSt5ZC20TUoB_TZA@mail.gmail.com> (raw)
In-Reply-To: <20191202235821.GF7335@magnolia>

On Tue, Dec 3, 2019 at 12:59 AM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> On Mon, Dec 02, 2019 at 03:22:31PM -0800, Linus Torvalds wrote:
> Yeah, that looks correct to me.  Stephen's solution backed out the
> changes that Arnd made for the !x86_64 compat ioctl case, so I or
> someone would have had to re-apply them.
>
> > There was some other minor difference too, but it's also possible I
> > could have messed up, so cc'ing Stephen and Arnd on this just in case
> > they have comments.
>
> <nod> Thanks for sorting this out.

Yes, this is the right solution. Note that this part of the series originally
came from Al Viro, but I added more patches following the same idea.

While working on a follow-up series, I now also noticed that the
FS_IOC_RESVSP compat handler has always been broken for
x32 user space. I don't think anyone cares, but my series in [1]
addresses this as well by handling FS_IOC_RESVSP/
FS_IOC_UNRESVSP/FS_IOC_ZERO_RANGE on x86-64 as
well, in addition to FS_IOC_RESVSP_32 etc.

       Arnd

[1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
compat-ioctl-endgame

      reply	other threads:[~2019-12-03 20:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01 18:48 [GIT PULL] xfs: new code for 5.5 Darrick J. Wong
2019-12-02 23:20 ` pr-tracker-bot
2019-12-02 23:22 ` Linus Torvalds
2019-12-02 23:58   ` Darrick J. Wong
2019-12-03 20:46     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a2rrTN=ZED4pHX1WLCV+RUitN3G5XKSt5ZC20TUoB_TZA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.