From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6B2C433DB for ; Thu, 7 Jan 2021 21:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A535C235FD for ; Thu, 7 Jan 2021 21:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727655AbhAGVtE (ORCPT ); Thu, 7 Jan 2021 16:49:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:37198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbhAGVtD (ORCPT ); Thu, 7 Jan 2021 16:49:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE3E923406; Thu, 7 Jan 2021 21:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610056103; bh=TQDWjh3f5pNnQ2t5MjxQ5TqLIEAU1dudzHdK0zBk+Ns=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iD+ZK/lfojmMkxhXnyH/1v8Tb0AwiXwyMFfxZhtAIZgz0HAke5gQ1BQxg7lVHp9TI gAdpITwTpkBqqsroyiceqy/xOW06ifTk4RCD4LdxhCin8jH5ninfACplB869eaWj56 hQbubbiixp2WEM1jJcIFTIxzmxmotz+Xke8JTSV3jPycIBMLSjfEpuCozaSEv3HzqT WXwiw2vKOAwe2NN3ljw0hT5F4Qabo2Tnj8NBEzzeD5M6JuHuxYSDQcbwR3uBtpvQNK lpnVGmcDiM5jsCTzQvTuYSIiA9zg5G4dIY1dyOQifQm8BXopQbA4xcakFyzcS8PVXg 05/ozQdCD06ug== Received: by mail-ot1-f50.google.com with SMTP id i6so7806129otr.2; Thu, 07 Jan 2021 13:48:22 -0800 (PST) X-Gm-Message-State: AOAM532JjXRaFQ1Y3e7ztIpKwAtdyXWYq3eg4k0OEMdRvlvLPjb4QKAm g3pR9+m5bzEO5YZ3m8y9/cKRS7st18LWfUVHApU= X-Google-Smtp-Source: ABdhPJxnaJA141e20BKd4OL7t+qWGvU0o8rWnel2LS/2PmbZGYBn/q94i+4iN0Vo1bv8tzTS+O8U0EFHizJ+9FdNAio= X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr421259otm.305.1610056102295; Thu, 07 Jan 2021 13:48:22 -0800 (PST) MIME-Version: 1.0 References: <20210105154726.GD1551@shell.armlinux.org.uk> <20210106115359.GB26994@C02TD0UTHF1T.local> <20210106135253.GJ1551@shell.armlinux.org.uk> <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> In-Reply-To: From: Arnd Bergmann Date: Thu, 7 Jan 2021 22:48:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues To: "Theodore Ts'o" Cc: Russell King - ARM Linux admin , Will Deacon , linux-toolchains@vger.kernel.org, Mark Rutland , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2021 at 5:27 PM Theodore Ts'o wrote: > > On Thu, Jan 07, 2021 at 01:37:47PM +0000, Russell King - ARM Linux admin wrote: > > > The gcc bugzilla mentions backports into gcc-linaro, but I do not see > > > them in my git history. > > > > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > > or just for aarch64? > > Russell, Arnd, thanks so much for tracking down the root cause of the > bug! There is one more thing that I wondered about when looking through the ext4 code: Should it just call the crc32c_le() function directly instead of going through the crypto layer? It seems that with Ard's rework from 2018, that can just call the underlying architecture specific implementation anyway. > I will note that RHEL 7 uses gcc 4.8. I personally don't have an > objections to requiring developers using RHEL 7 to have to install a > more modern gcc (since I use Debian Testing and gcc 10.2.1, myself, > and gcc 5.1 is so five years ago :-), but I could imagine that being > considered inconvenient for some. The main users of gcc-4.9 that I recall from previous discussions were Android and Debian 8, but both of them are done now: Debian 8 has reached its end of life last summer, and Android uses clang for building new kernels. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92134C43333 for ; Thu, 7 Jan 2021 21:50:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57B6923406 for ; Thu, 7 Jan 2021 21:50:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57B6923406 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fa4M30KrH7rgVkzRJed/UhPhn6drb2ZPWIXBMI9I4Nk=; b=UQyDkoHjOuKvCeunb6/kNMtLp M2+9le/zNcl5wS0ZahghNwnKzhX6pMxTQCX7ycVyqsoPMlm5/1vzhkSVl4CmYGdRwKqp8Bya9nPkp lNczEZtdctz5HM7L21Jqla3FoSUIK4srjTuYOxPPOrZaxGHuJRL/yxcOip/r6KI+Bgp017LK0CLxs AKb0yo1qIiCUCTUSb0dH6QVEqjh6F6KPWwJvFcYiP8uiHxsuILUwtjMTSYAopDRo9pT9TU9wQ4c4n nLZsfWoWbrdMmiP8ye13oi/vdSHuCbWVH+hdtae/vtIL0Hn3CauoOUhfdfY36TS/HZ7TlWQ88H/gA KQNfGbtSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxd8s-0004y6-Mm; Thu, 07 Jan 2021 21:48:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxd8p-0004xe-Ty for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 21:48:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DF20E235FD for ; Thu, 7 Jan 2021 21:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610056103; bh=TQDWjh3f5pNnQ2t5MjxQ5TqLIEAU1dudzHdK0zBk+Ns=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iD+ZK/lfojmMkxhXnyH/1v8Tb0AwiXwyMFfxZhtAIZgz0HAke5gQ1BQxg7lVHp9TI gAdpITwTpkBqqsroyiceqy/xOW06ifTk4RCD4LdxhCin8jH5ninfACplB869eaWj56 hQbubbiixp2WEM1jJcIFTIxzmxmotz+Xke8JTSV3jPycIBMLSjfEpuCozaSEv3HzqT WXwiw2vKOAwe2NN3ljw0hT5F4Qabo2Tnj8NBEzzeD5M6JuHuxYSDQcbwR3uBtpvQNK lpnVGmcDiM5jsCTzQvTuYSIiA9zg5G4dIY1dyOQifQm8BXopQbA4xcakFyzcS8PVXg 05/ozQdCD06ug== Received: by mail-ot1-f49.google.com with SMTP id d20so7817372otl.3 for ; Thu, 07 Jan 2021 13:48:22 -0800 (PST) X-Gm-Message-State: AOAM533cnKGrjy+O9BB0BQugTNUgwqaXClxt3Y3F8CYlB2BCZFKnuHul O4h0uR0MZVCYPdIk6X0/JfyilOZxh3BMRPIrhxw= X-Google-Smtp-Source: ABdhPJxnaJA141e20BKd4OL7t+qWGvU0o8rWnel2LS/2PmbZGYBn/q94i+4iN0Vo1bv8tzTS+O8U0EFHizJ+9FdNAio= X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr421259otm.305.1610056102295; Thu, 07 Jan 2021 13:48:22 -0800 (PST) MIME-Version: 1.0 References: <20210105154726.GD1551@shell.armlinux.org.uk> <20210106115359.GB26994@C02TD0UTHF1T.local> <20210106135253.GJ1551@shell.armlinux.org.uk> <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> In-Reply-To: From: Arnd Bergmann Date: Thu, 7 Jan 2021 22:48:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues To: "Theodore Ts'o" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_164824_053208_8825F6FE X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , Andreas Dilger , linux-toolchains@vger.kernel.org, Ext4 Developers List , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 7, 2021 at 5:27 PM Theodore Ts'o wrote: > > On Thu, Jan 07, 2021 at 01:37:47PM +0000, Russell King - ARM Linux admin wrote: > > > The gcc bugzilla mentions backports into gcc-linaro, but I do not see > > > them in my git history. > > > > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > > or just for aarch64? > > Russell, Arnd, thanks so much for tracking down the root cause of the > bug! There is one more thing that I wondered about when looking through the ext4 code: Should it just call the crc32c_le() function directly instead of going through the crypto layer? It seems that with Ard's rework from 2018, that can just call the underlying architecture specific implementation anyway. > I will note that RHEL 7 uses gcc 4.8. I personally don't have an > objections to requiring developers using RHEL 7 to have to install a > more modern gcc (since I use Debian Testing and gcc 10.2.1, myself, > and gcc 5.1 is so five years ago :-), but I could imagine that being > considered inconvenient for some. The main users of gcc-4.9 that I recall from previous discussions were Android and Debian 8, but both of them are done now: Debian 8 has reached its end of life last summer, and Android uses clang for building new kernels. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel