From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbdLKRFg (ORCPT ); Mon, 11 Dec 2017 12:05:36 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:42435 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbdLKRFe (ORCPT ); Mon, 11 Dec 2017 12:05:34 -0500 X-Google-Smtp-Source: ACJfBotwrGeBOog+M8M+nXUIUmR7u+0Zdx2PRr77eTPW3PSjyCaq9nzovK3kwpYikrKJb01j+Z8DWDsU/O5vAAL3QPA= MIME-Version: 1.0 In-Reply-To: <20171211170149.GD9454@kroah.com> References: <20171211112806.3415781-1-arnd@arndb.de> <70603a0e-15dd-8970-54c9-4f1ac1d005e2@linux.intel.com> <20171211170149.GD9454@kroah.com> From: Arnd Bergmann Date: Mon, 11 Dec 2017 18:05:33 +0100 X-Google-Sender-Auth: 7KGztUQ4zWONchofuLGHc8KrEc0 Message-ID: Subject: Re: [PATCH] usb: xhci: fix incorrect memset() To: Greg Kroah-Hartman Cc: Mathias Nyman , Mathias Nyman , Lu Baolu , linux-usb@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 6:01 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote: >> On 11.12.2017 13:27, Arnd Bergmann wrote: >> > gcc-8 warnings about the new driver using a memset with a bogus length: >> > >> > drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': >> > drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] >> > >> > It looks like the author meant to use sizeof() rather than ARRAY_SIZE() >> > here, so use that. >> > >> > Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver") >> > Signed-off-by: Arnd Bergmann >> > --- >> >> Another patch to fix the same thing was sent earlier as a follow up to the original series. >> https://marc.info/?l=linux-usb&m=151298133524873&w=2 >> >> But your patch includes the Fixes line with the commit id, which is nice. >> >> Both fix the problem, It doesn't matter for me which one gets applied > > They fix it in different ways, which is correct? Both are correct, 'sizeof(dbc->eps)' is the same as 'sizeof(struct dbc_ep) * ARRAY_SIZE(dbc->eps)'. > And Arnd probably doesn't have the hardware to do so? Right. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: xhci: fix incorrect memset() From: Arnd Bergmann Message-Id: Date: Mon, 11 Dec 2017 18:05:33 +0100 To: Greg Kroah-Hartman Cc: Mathias Nyman , Mathias Nyman , Lu Baolu , linux-usb@vger.kernel.org, Linux Kernel Mailing List List-ID: T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgNjowMSBQTSwgR3JlZyBLcm9haC1IYXJ0bWFuCjxncmVn a2hAbGludXhmb3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4gT24gTW9uLCBEZWMgMTEsIDIwMTcgYXQg MDI6NTk6MTNQTSArMDIwMCwgTWF0aGlhcyBOeW1hbiB3cm90ZToKPj4gT24gMTEuMTIuMjAxNyAx MzoyNywgQXJuZCBCZXJnbWFubiB3cm90ZToKPj4gPiBnY2MtOCB3YXJuaW5ncyBhYm91dCB0aGUg bmV3IGRyaXZlciB1c2luZyBhIG1lbXNldCB3aXRoIGEgYm9ndXMgbGVuZ3RoOgo+PiA+Cj4+ID4g ZHJpdmVycy91c2IvaG9zdC94aGNpLWRiZ2NhcC5jOiBJbiBmdW5jdGlvbiAneGhjaV9kYmNfZXBz X2V4aXQnOgo+PiA+IGRyaXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYzozNjk6MjogZXJyb3I6 ICdtZW1zZXQnIHVzZWQgd2l0aCBsZW5ndGggZXF1YWwgdG8gbnVtYmVyIG9mIGVsZW1lbnRzIHdp dGhvdXQgbXVsdGlwbGljYXRpb24gYnkgZWxlbWVudCBzaXplIFstV2Vycm9yPW1lbXNldC1lbHQt c2l6ZV0KPj4gPgo+PiA+IEl0IGxvb2tzIGxpa2UgdGhlIGF1dGhvciBtZWFudCB0byB1c2Ugc2l6 ZW9mKCkgcmF0aGVyIHRoYW4gQVJSQVlfU0laRSgpCj4+ID4gaGVyZSwgc28gdXNlIHRoYXQuCj4+ ID4KPj4gPiBGaXhlczogZGZiYTIxNzRkYzQyICgidXNiOiB4aGNpOiBBZGQgRGJDIHN1cHBvcnQg aW4geEhDSSBkcml2ZXIiKQo+PiA+IFNpZ25lZC1vZmYtYnk6IEFybmQgQmVyZ21hbm4gPGFybmRA YXJuZGIuZGU+Cj4+ID4gLS0tCj4+Cj4+IEFub3RoZXIgcGF0Y2ggdG8gZml4IHRoZSBzYW1lIHRo aW5nIHdhcyBzZW50IGVhcmxpZXIgYXMgYSBmb2xsb3cgdXAgdG8gdGhlIG9yaWdpbmFsIHNlcmll cy4KPj4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtdXNiJm09MTUxMjk4MTMzNTI0ODczJnc9 Mgo+Pgo+PiBCdXQgeW91ciBwYXRjaCBpbmNsdWRlcyB0aGUgRml4ZXMgbGluZSB3aXRoIHRoZSBj b21taXQgaWQsIHdoaWNoIGlzIG5pY2UuCj4+Cj4+IEJvdGggZml4IHRoZSBwcm9ibGVtLCBJdCBk b2Vzbid0IG1hdHRlciBmb3IgbWUgd2hpY2ggb25lIGdldHMgYXBwbGllZAo+Cj4gVGhleSBmaXgg aXQgaW4gZGlmZmVyZW50IHdheXMsIHdoaWNoIGlzIGNvcnJlY3Q/CgpCb3RoIGFyZSBjb3JyZWN0 LCAnc2l6ZW9mKGRiYy0+ZXBzKScgaXMgdGhlIHNhbWUgYXMgJ3NpemVvZihzdHJ1Y3QKZGJjX2Vw KSAqIEFSUkFZX1NJWkUoZGJjLT5lcHMpJy4KCj4gQW5kIEFybmQgcHJvYmFibHkgZG9lc24ndCBo YXZlIHRoZSBoYXJkd2FyZSB0byBkbyBzbz8KClJpZ2h0LgoKICAgICAgQXJuZAotLS0KVG8gdW5z dWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4 LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5v cmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRv bW8taW5mby5odG1sCg==