From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0234DC433F5 for ; Wed, 27 Oct 2021 10:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAA0860F56 for ; Wed, 27 Oct 2021 10:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239634AbhJ0Kkt convert rfc822-to-8bit (ORCPT ); Wed, 27 Oct 2021 06:40:49 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:37073 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236074AbhJ0Kks (ORCPT ); Wed, 27 Oct 2021 06:40:48 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MlO5j-1n4nTM3YLd-00ljfu; Wed, 27 Oct 2021 12:38:21 +0200 Received: by mail-wm1-f43.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso5842776wmd.3; Wed, 27 Oct 2021 03:38:21 -0700 (PDT) X-Gm-Message-State: AOAM533T6KMXll3ZrO5qtGVi3o7TSGnCsK0AmTex4VqFCYeAZC+TUFOf NHD0TvWo8t/A/e7HbxVmHTE1vmkn6CQUUulAqzA= X-Google-Smtp-Source: ABdhPJzWVmMJRu6Nz/rjaD9BGMlTJTXmWs4kciJksMzsWQT3KiOawx9iTDk2eBtfMChr7uV7l5Br7Iq8uFXkQjkfCiM= X-Received: by 2002:a05:600c:1548:: with SMTP id f8mr4852836wmg.35.1635331101366; Wed, 27 Oct 2021 03:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20211027080849.3276289-1-geert@linux-m68k.org> In-Reply-To: <20211027080849.3276289-1-geert@linux-m68k.org> From: Arnd Bergmann Date: Wed, 27 Oct 2021 12:38:05 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] usb: gadget: Mark USB_FSL_QE broken on 64-bit To: Geert Uytterhoeven Cc: Li Yang , Felipe Balbi , Greg Kroah-Hartman , Arnd Bergmann , USB list , linuxppc-dev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:977zZkHhQJaxSarzoX+MR9G0xluBYVdMBh6F4U5fjgpQ+lABTwh lapMD1fGalsvx2dDFu9HgqG5VwfQdL87TVGSq+CEcW8cnYIbmh4d6EyZAEVTq7yNpJPbAwt Dcm2qI/3BqaT1+E1wyygVaBs4dfdbEsL8Tc55Uc35T2q0xret+9ph3iQHJ8SvW/r/cK34dh 2q+sGi9W69BRrdREfoYqQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:oQA6l8nLBSY=:qGuxqGpsLsMXWhN9LuMm1y 7em73T326vPryxf/5CSF0l79nbH5sAmPZ92COu6mt4sh3376Z88DcN/ZgyvXjMM5p2nLvQq3I 4dlOUfwHuOzKkCkAnqbwgoK1Oy9u1xKby262k3eSCOrVlwAVAvza5+1C3NLw28Bh/rK/uMXsv FR7nAw82NwOmZRkvV6pR0AYEmIN1jB/GeE2e6pc1gygoj0o+l1/b93HNM/cD5c/OkLAOVMhH+ abfkUry8riB7+anqZ2QhOztyLvRjWYM5VliOYOSxYh2Il4SI1dqt4T+868JjHJKoejpZ7bGqh 9R5zVTPbW6fJdvBeY3rjjhn06ju7K97L3/AXsdmzvqBAdWv3jldQmLkZHCwzTBITHK2BwNXNS z56s+THLBFDizpwMJBI8c6tuTFhemGIhPfnu9XXVH3nTMQnb/77Q9MNjsl1hAV5WFLCmr0/LF EKIqVI9M/8PqfinIr0aFzwNei8BFsbx5vRrcMXnUlKuFWQJ8iqZbkcQ8hQKJz/AYpNpH2iOC1 O6PZnlaMUsC50rteThhQhQFp7F1xyVg3mhZTCR3uKFmaKiflO8BWY9hRAc7bzkphZAl32Ps44 sXv0DjzelL+1iteEeUhJiNOW1IoXBINkSzj2g3tORgSRSmdx31ZgqAiI0ykJ4/2KhJZwHmvME 0j+Ge/mg9aJVbU4lnv/iBjM6pi9vXc2jaxspV5QnUBIOpIrkS4K62fgpbeIz48pf1Rho= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 27, 2021 at 10:08 AM Geert Uytterhoeven wrote: > > On 64-bit: > > drivers/usb/gadget/udc/fsl_qe_udc.c: In function ‘qe_ep0_rx’: > drivers/usb/gadget/udc/fsl_qe_udc.c:842:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > 842 | vaddr = (u32)phys_to_virt(in_be32(&bd->buf)); > | ^ > In file included from drivers/usb/gadget/udc/fsl_qe_udc.c:41: > drivers/usb/gadget/udc/fsl_qe_udc.c:843:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > 843 | frame_set_data(pframe, (u8 *)vaddr); > | ^ > > The driver assumes physical and virtual addresses are 32-bit, hence it > cannot work on 64-bit platforms. > > Signed-off-by: Geert Uytterhoeven > --- Interesting, I have not seen this one in randconfig builds. It looks like the driver also assumes that physical addresses are the same as bus addresses, so maybe it should also be marked broken when CONFIG_IOMMU is enabled? Maybe that takes it too far, as this driver could still be used on a machine without IOMMU in a kernel that supports IOMMUs on other machines. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9049CC433EF for ; Wed, 27 Oct 2021 10:38:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C884C60F39 for ; Wed, 27 Oct 2021 10:38:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C884C60F39 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HfQCh2cmtz3bhx for ; Wed, 27 Oct 2021 21:38:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=212.227.126.130; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HfQC86DXdz2xXb for ; Wed, 27 Oct 2021 21:38:27 +1100 (AEDT) Received: from mail-wm1-f53.google.com ([209.85.128.53]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MQgtC-1mLPuS20IA-00NeY1 for ; Wed, 27 Oct 2021 12:38:22 +0200 Received: by mail-wm1-f53.google.com with SMTP id g205-20020a1c20d6000000b0032cc6bbd505so5256040wmg.5 for ; Wed, 27 Oct 2021 03:38:21 -0700 (PDT) X-Gm-Message-State: AOAM5326YG/0QJgMesvNa44Gnx0qXcF3ZDVfzRErEI9l7V4igHbtBbAE ShQ2ylNNj3IYO+rtLqURmglc/2so2JrdWYCpabM= X-Google-Smtp-Source: ABdhPJzWVmMJRu6Nz/rjaD9BGMlTJTXmWs4kciJksMzsWQT3KiOawx9iTDk2eBtfMChr7uV7l5Br7Iq8uFXkQjkfCiM= X-Received: by 2002:a05:600c:1548:: with SMTP id f8mr4852836wmg.35.1635331101366; Wed, 27 Oct 2021 03:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20211027080849.3276289-1-geert@linux-m68k.org> In-Reply-To: <20211027080849.3276289-1-geert@linux-m68k.org> From: Arnd Bergmann Date: Wed, 27 Oct 2021 12:38:05 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] usb: gadget: Mark USB_FSL_QE broken on 64-bit To: Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:tslZVbKYIyPtZ8eXl2DjNtfCFk5ardkgwb6D+Xtm6RjoUP7Ul5U Xa4UlwKrHNzXAOIiE6OXEVLiF9LMcEubNFOVivLoczNTctb6tmI18GVMOCMfoCFQtQhIAsp i7E9agFYxEc7fjCkUZ9n2+G4qYZXiM+MT1v797NLyTUvY8Co7OlZR3uox41+BDOebNSkQka dUh79af8nqk2WxnTnRITg== X-UI-Out-Filterresults: notjunk:1;V03:K0:ipqW22eF9mY=:gWvYMGc7murHrzOgSphzYu AJKnlnodc8SkHqp2PxljZRshDkwPr0RHh2n2SMf10LVOCbMpF+aJibnIWNS9M15givAaok1Ky JJat7vtOU49wF4+AbTqJBHIy0D6zBSaDIrBRLoGJWLrMJc+XiuXK6NtW2JedKLh87fEKCwvXM WgQeC0kcJysdMsA7HhQn3CqnTErrN0nBOnto9HCy4qGMWuTkygrGMcIiEb5EyP+FrhjCB2uBs WleOPd+B5K+l5fpsn6FcR1BaCCigy94z4ImvvKWRzBbtBr4M5oy83xDvdjdNCWlUCD7JBIUbT joSjuVi0JnFiXMa4hxs6psi1oe4h4TFYinRTu43B1ljr6zzOYsW+xQsCXlwelTFkryz5tu0z8 Xb7tdoL+kGKO4gkKqmaodTwh24nCfbNCDfzxXyLk5Bmz9nyd5crOkDsDmE/M2V/l+SfwGlpUR kTsCIzJIcpbrqjU2+S5Q8qxkPxyJJTpbsyDvih5Pxo8kEpkFon+AP2qNbgO65WYJtIRQ7Hw1l 2c5Zys+Dl5bXvHdOtvwc4o/FVEsSPaaP54bOVK7KKzMoLXeU0udRvkAC+pJ8al2MiPiBSXNCS ZXZjELKpVMB0F3snKnnzHBBq63JOIdj+9qjnLg+DI0b0o5o+WYstuwaxSQGmjnW50B8gxu68N vby2LRLB0mbD6PfTe17xsTxSTgZcQGE5rPG4NR0V+hX29Vy0igA9XashnbjfmxW43fSnkEFPl 0wOsPEqIuuvHtMPJpfdVc+SszttrrXpZlZELfXwvfc7u6Yk37c3d3MGkYALXfTGaro83WevsH Fh/ZC3hxo+oDoQpEPwkzpnPg3gtSynsx5o9+YgYJZjp3sbFvlQ= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Arnd Bergmann , Greg Kroah-Hartman , USB list , Linux Kernel Mailing List , Li Yang , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Oct 27, 2021 at 10:08 AM Geert Uytterhoeven wrote: > > On 64-bit: > > drivers/usb/gadget/udc/fsl_qe_udc.c: In function =E2=80=98qe_ep0_rx= =E2=80=99: > drivers/usb/gadget/udc/fsl_qe_udc.c:842:13: error: cast from pointer = to integer of different size [-Werror=3Dpointer-to-int-cast] > 842 | vaddr =3D (u32)phys_to_virt(in_be32(&bd->buf)); > | ^ > In file included from drivers/usb/gadget/udc/fsl_qe_udc.c:41: > drivers/usb/gadget/udc/fsl_qe_udc.c:843:28: error: cast to pointer fr= om integer of different size [-Werror=3Dint-to-pointer-cast] > 843 | frame_set_data(pframe, (u8 *)vaddr); > | ^ > > The driver assumes physical and virtual addresses are 32-bit, hence it > cannot work on 64-bit platforms. > > Signed-off-by: Geert Uytterhoeven > --- Interesting, I have not seen this one in randconfig builds. It looks like the driver also assumes that physical addresses are the same = as bus addresses, so maybe it should also be marked broken when CONFIG_IOMMU is enabled? Maybe that takes it too far, as this driver could still be used on a machine without IOMMU in a kernel that supports IOMMUs on other machines. Arnd