From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466572CA6 for ; Tue, 7 Dec 2021 13:00:58 +0000 (UTC) Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MJmCV-1n9cvo0DP7-00K9MU for ; Tue, 07 Dec 2021 14:00:57 +0100 Received: by mail-wr1-f50.google.com with SMTP id d9so29325980wrw.4 for ; Tue, 07 Dec 2021 05:00:56 -0800 (PST) X-Gm-Message-State: AOAM530fFvsVJY+iszT6n/4lR03tiiKWXJt4oaGINcfPWd/SYEuPNMdA oXJFWoO8ASUWP6odofvfQRTuU1+L2j57tEHZE5g= X-Google-Smtp-Source: ABdhPJxPTZb1NEgHTgiRZ5k7TV56wTLpaTAV0tigTfyAj6yjgVEdlWqbHmbxec81GQE5rsfdo8Evow6Ud4USOVQhzcM= X-Received: by 2002:a5d:4107:: with SMTP id l7mr50868012wrp.209.1638882056495; Tue, 07 Dec 2021 05:00:56 -0800 (PST) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211207110228.698956-1-anders.roxell@linaro.org> In-Reply-To: <20211207110228.698956-1-anders.roxell@linaro.org> From: Arnd Bergmann Date: Tue, 7 Dec 2021 14:00:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough To: Anders Roxell Cc: Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , linuxppc-dev , Linux Kernel Mailing List , llvm@lists.linux.dev, Naresh Kamboju Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:zxfBt54wGeli7+VFvbphP0bz002ieVxkjTYOJoPuKotCJeUd+YM CmTD4fbx/TcS9cw3Pcq9EOoHPy1SKZc3uXExnFPKw+Z4huae47X8HgaIIJdo9wv3oB9DSYF z21641370vbjt74lp4s1fE5lxg7+peutgR2vJ1aHaQIYUDiOvv2Fk0bCtfyn9RLAr3g1AbS Of/nduQW6w2jU9kKRWCVA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:IRJWMDMO3G0=:bRL2aqAQhAnYJjUq+tvk2v AieYMGGUOmVzHRL0zVbHWck+zrJ4wJSm1ulZVeGFPAOmfsNjVPQ4o6Q9oLwD3KlEVT/FYOalr zi0OOcyiqwKB9Xhd8WDUSA3ORGCjx29e6HlBAMu1nq2pMvbt+YeLVv8y60aMeog7HbLUJOvBO Jr4oCtCduhH/iPPpRGC5FHeoW3Yb3IEtEm52NaJa8gUpj0H0v8Y3R0IPfKHTdoxQzXYymcUMV KwC+DS/BHilZ7OwoQ4iubSVq7Pb+U9pa1LFcxPpllD4Au9rBVZDW9dSpJhOnU+v98y1KWkJxi 0OPgsdRu9VA1cqK7Tvm4widceLrP8t2XNgyX1ebAmWE0EEnNs14arbh02uBItWwdsCYkSuIgf ZqxyAzxN5JP3680vU30/h+3KewzpFyWVVYr6zZliRXcJ1FgSY8ZTiEiYmU1+gK7H+tgVbncqI 4RU14qtwB6gguJB86QX59/ddHmokNoGlN+Z4GMpAA0rA4vTxTS/N1ZvWd8cLqeMwMQ2DLFIQt qUWzNzaLq1TYmMfmIVJmM/RJ2hbHPhIiGDYbQ6rh891C5/dr10wC/7q+MgdshotEPF/zohXid w7vaAzyKyzKQWnWmmPFaWS7GX0dqqzP9zrXH0aa4BdocBlSxhMCHz1rMoRKXhusKWnxLBr1l/ YwisqzUBldwKfT4rd9VFTbVAqyCDA4ZdjWca+R3ZcW+cDY6zj3HPh30YSF3YdScerDVXw8Mag WhOFT3Vln4Q4k64BPJ9cW76UbDSn16m7XK/gSJbU5fr82UwunEFvBKDoPsfIo0Ga8vBJF5Arn VxOGSposkZE1qgOPEA0W80qXjHh5seTUpGL3QjkzQrc47+7ntU= On Tue, Dec 7, 2021 at 12:02 PM Anders Roxell wrote: > > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > Clang is more pedantic than GCC, which does not warn when failing > through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst. > Add athe missing break to silence the warning. > > Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") > Reported-by: Naresh Kamboju > Signed-off-by: Anders Roxell Thanks for the fix! Reviewed-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C5A9C433EF for ; Tue, 7 Dec 2021 13:06:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J7gY860wyz3c8x for ; Wed, 8 Dec 2021 00:06:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=217.72.192.73; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J7gXf6Ltqz2xXy for ; Wed, 8 Dec 2021 00:06:10 +1100 (AEDT) Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MVMNF-1n1QH016M3-00SRyH for ; Tue, 07 Dec 2021 14:00:57 +0100 Received: by mail-wr1-f47.google.com with SMTP id o13so29246579wrs.12 for ; Tue, 07 Dec 2021 05:00:56 -0800 (PST) X-Gm-Message-State: AOAM531Lbg+xCbu8z9/UR/Gp1ECdCO30AQLxfzb14cfaqDPaAN06C/h0 1p21D1oLdyM0U81utrabrmunvJsddSLDcixMML4= X-Google-Smtp-Source: ABdhPJxPTZb1NEgHTgiRZ5k7TV56wTLpaTAV0tigTfyAj6yjgVEdlWqbHmbxec81GQE5rsfdo8Evow6Ud4USOVQhzcM= X-Received: by 2002:a5d:4107:: with SMTP id l7mr50868012wrp.209.1638882056495; Tue, 07 Dec 2021 05:00:56 -0800 (PST) MIME-Version: 1.0 References: <20211207110228.698956-1-anders.roxell@linaro.org> In-Reply-To: <20211207110228.698956-1-anders.roxell@linaro.org> From: Arnd Bergmann Date: Tue, 7 Dec 2021 14:00:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough To: Anders Roxell Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:hEF2dA95KtrAXYgxX9iHiiiPc2TzE9uJKkEfm5eeut2yNnh/fyN W5U0AkqB/TTGQbxBqdlCj8D8qN/VwUf74qRQ+fCym3dh3eLoErSjAoH2VQLr31xE16l0WDa zaG0WE5Ssm5mp50anLcICBOKWsd9gOIvHMNQTKYuAc6AmfR+ImnXYxJ1aMd8vF4dIRIeyrn FqVXBgnNRmZINuIEvrW0g== X-UI-Out-Filterresults: notjunk:1;V03:K0:MvIe23BErLc=:nP4v4ZXVOlMTfuArqad779 W7EuFwMD6FUACy67qMatJL/BcwmuoQsLB626UW+uoICxzP/u4MTw8ysbyMAizj+C+++6xXzhT WkRRno8cJNS7ykybBlJFhCka5B1R2Kzm8NlsnbnTi1uv/ZJ6mivZMOQ4Z9bqPg/HWrbJX/adf OHzloxW1Lrs+eS9RwT3R/uQNiZO6v3tfGZLwyR/qCIXkPAQWfnBtEJqW7lZ1PWHIaw3hiKUx6 aif2shA5RdfSxPNrXjKmAPt/4TErqkkNZOVuIokWXV0tWpJzrBmSeijIXmi3KEvbcE7d0YRrL Kfe1DPCZNSOLB79DM9bnAVfVw4ZZClMGkMBbv4qilI455LeZSUqL5S4+Mkt0wczhLLqDYilUB p5y51SRit15gYlQEHFWKrKA9tF9L5JyFDcV9bg5V6JndgMVfXuMmY40313+NFUmJnbnZWCFMO 9PO+0t0jlb2ZcboOeUFhIlnO1Ey9Wx7e6f/LZRSNY48M/sbgCwrggW/a80P6oQ25mhobVrIqg 0ns1GeCAvzxIx2BKkkrZnO9xOgCQa0YYG6D6teVLQ9YVAL2L6ypyfLtY0sfWgqzZ1tzk6/Kv2 UyJKH7KQK60FE7HQ7yFMajcy1JqnJ09AecPq7XI7p24sC9HulTgE+Y/pHyXh21dH3CcD0b3kg cr2aUd2lfdT1McXxdaTaNhHb/VNlO2pG1n1RUHeAq+0RKKgmSXFhu8hfz0sOYW0t5Bs0= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Naresh Kamboju , llvm@lists.linux.dev, Nick Desaulniers , Linux Kernel Mailing List , Nathan Chancellor , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Dec 7, 2021 at 12:02 PM Anders Roxell wrote: > > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > Clang is more pedantic than GCC, which does not warn when failing > through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst. > Add athe missing break to silence the warning. > > Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") > Reported-by: Naresh Kamboju > Signed-off-by: Anders Roxell Thanks for the fix! Reviewed-by: Arnd Bergmann