From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1049CC07E96 for ; Tue, 6 Jul 2021 14:39:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECE11611AD for ; Tue, 6 Jul 2021 14:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232480AbhGFOlt (ORCPT ); Tue, 6 Jul 2021 10:41:49 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:52733 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232527AbhGFOls (ORCPT ); Tue, 6 Jul 2021 10:41:48 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1Mae7u-1lUSTw2pJq-00cChf for ; Tue, 06 Jul 2021 16:30:50 +0200 Received: by mail-wm1-f47.google.com with SMTP id g10so7873806wmh.2 for ; Tue, 06 Jul 2021 07:30:50 -0700 (PDT) X-Gm-Message-State: AOAM530V2E2JrD4gCbBLxGuxnVCf1jvCYBayjQSHVccbfU18QLkkDS3D WTW9s33YXT9y5OI6TauFexHll+uHi2BpI6Ja7lI= X-Google-Smtp-Source: ABdhPJwjGcsb8QX7KR+y5dhq1rdJJfs2xmRDD56swcSUod9PkkjY20gqBu2JjgAr8kkaWEAWJO9jcpljutP9zo7GaRw= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr1126879wmb.142.1625581850346; Tue, 06 Jul 2021 07:30:50 -0700 (PDT) MIME-Version: 1.0 References: <20210527124356.22367-1-will@kernel.org> <20210706102634.GB24903@arm.com> <59800d6c-364a-f4be-e341-c5b531657ba3@arm.com> <20210706133314.GB20327@willie-the-truck> In-Reply-To: From: Arnd Bergmann Date: Tue, 6 Jul 2021 16:30:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES) To: Marc Zyngier Cc: Will Deacon , Robin Murphy , Catalin Marinas , Yassine Oudjana , Ard Biesheuvel , Android Kernel Team , Linux ARM , Mark Rutland , Vincent Whitchurch , linux-arm-msm Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:/mWEPK4Z+zy5bjPjyvfCSuehQCBBwX9NsFo8lNrvyc2B3io5q0i zGuHvo98JHLQ5NggNNftIseuML+CeAq8t37hR34Kj4+CGxr3Wx29/v87NQPKBA7Rt4y7XiV tDDJLFLXWHn8R2cM8omDoD+Pjlw01SkDFdjgZ7jNUFpW/L2xgEHKo4PT6dMv1vNd4lQEHx0 jqNlA7/6COlq4ajdb1JIw== X-UI-Out-Filterresults: notjunk:1;V03:K0:vfojltf3ngc=:thQja4WO6/vJHt2hGZIjzm G3Kf6mf8VzZ+mhMuiLy5VVkhjZkBlPzDH2yHetVgPgElgDahGDuSjZ1+Xyntvj1mgORU5QZoW Qeb4caszOjVJV2opVvVh63jNgFE1qxwX1wdvtfe68wXZNXOppr/tuOJp5U6ARCeyL27MH0NvA upEN6g3FeUHkYkdNyh7RdMWDKJg+t7Cmcxe77KTl2xgnvIpYdV3TWfLdWR4rgpK1//+p6ExaI oYy/DJoqblKbMvPjWuLJ8GMUXd0EDS7N2LlO8rw0syaO36e6qzJ44O2jDtLO2cMPCaJdPsSac 2SX1r9ldwc02U41GWZSkXvTycVwKjG1pzwBzk5COGfQd/ww1UeqMR5H+aeRN9ZqyHbSTHEK+x NOgXxbHlGSaEDnOuEp+uiqwqaNNOzicA2QQVPA6Oss++8oENLr4LUNOHtnf/RCaIZPp/Q7uLJ NMo1Uba2rdBBiMLhU9TL42+TsPNJkdr9QOIwCPcGdfgAGMf4C/ZOiXCVn3Yc9pM6+2ruR2a+J hxkUFHzPFGy0PgGftdU29m1vzCtyoF1GcgHJ8cQfOyGluOhsSWNv+id9nfx7tyNwkEBCE+m1W y6gKpBhHxIY7zfp7dWvWyvGOwf+ys6PpzxLPG+q7bJLGbdM3it/tNZxOS9O+ThxkF/gU4bY7y fOEBxwUIN5EK3XsN0tm43vW4qpIXUl5aiPDt5DXKNS9UNYaObEIH4qdeZ6Q9RFbGMoH6P4U09 wnS4mxK5/XExq8/QhfsXZ6mVlEht7J1U+ceCfkCIrqf2Zp4cFyyVkik5fhq3zOYOv7WEZHodb nFsAOGLIVHSUJx0JnFIa2vBGB0aB8n9ML+ZRS0H2ZZiKub2F58Z6SlShWQZQAY6bexCdD1L Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 6, 2021 at 3:44 PM Marc Zyngier wrote: > > On 2021-07-06 14:33, Will Deacon wrote: > > On Tue, Jul 06, 2021 at 02:29:07PM +0100, Robin Murphy wrote: > > > > I can't find much information about the original Kryo core at all... > > I have similar issues with my QDF2400. The UART, RTC and DMA controllers > are all screaming at me. I'm confident that the UART doesn't do any > DMA (it is handled by the SBSA driver), but the DMA controllers are > probably doing what it says on the tin. But that's a server chip, surely the DMA controller is fully cache coherent as required by SBSA? (please?) Maybe just a misannotation on the device node? > Do we know whether Falkor and Kryo share any part of their design? I'm fairly sure the Snapdragon 821 / msm8996 is not cache coherent. I can only speculate on how much got reused between the two, but as Falkor was released only after they had already given up on the full-custom Kryo core, it's plausible that it incorporates bits from that one. In particular the cache controller is probably easy to reuse even if the rest of it was a new design. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9121CC07E96 for ; Tue, 6 Jul 2021 14:38:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5547D611AD for ; Tue, 6 Jul 2021 14:38:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5547D611AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PZasoMZf0W7dJ7dcxb498asfgFV1dFdY0OmUUP7vHzA=; b=n0Nm4hxO75zEGX RaYJTX6XY4INABeQL4gAcp7vEFcOAKYe0qCd4X11q+UStcIZDmZG191Ra3vdsXNaNqpn93Dy/HBdb /xZ90MzhjpDjRIcqmWqX8+ZSzgRWXT8eBnTABNvS048RWiLzcvVSaeWqnnEeq/jHUifwfmY5B7o1j U4WnDtrjjKLCxOMgobI0xpa6VtfRy8b84O5RgwJ0bvT8GffAD6Q1zRmGmNbamPiL3wbVgIsUwEYnX OmlmUkCoda+bVag0UYGthAYTdTwHKdJOw3OcfaP2YRY+0mNNhxQZPgUv40dg8JkEuaRBz47BV7pvD 19EQrZ9Cbn2c9r6mX1Dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0mBh-00C2jV-0D; Tue, 06 Jul 2021 14:36:37 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0mBd-00C2iR-1J for linux-arm-kernel@lists.infradead.org; Tue, 06 Jul 2021 14:36:35 +0000 Received: from mail-wm1-f47.google.com ([209.85.128.47]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MgzWP-1lXVNR3R5J-00hRRy for ; Tue, 06 Jul 2021 16:36:28 +0200 Received: by mail-wm1-f47.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso1673579wmc.1 for ; Tue, 06 Jul 2021 07:36:28 -0700 (PDT) X-Gm-Message-State: AOAM5300gGzxpCrMtPhiqx3hZij2hYff1kGk04NVR2sRNsjFo3aovBTI watjW9yYzyBMVPIUuLr31ItD4Jbi9NBB8s93/tg= X-Google-Smtp-Source: ABdhPJwjGcsb8QX7KR+y5dhq1rdJJfs2xmRDD56swcSUod9PkkjY20gqBu2JjgAr8kkaWEAWJO9jcpljutP9zo7GaRw= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr1126879wmb.142.1625581850346; Tue, 06 Jul 2021 07:30:50 -0700 (PDT) MIME-Version: 1.0 References: <20210527124356.22367-1-will@kernel.org> <20210706102634.GB24903@arm.com> <59800d6c-364a-f4be-e341-c5b531657ba3@arm.com> <20210706133314.GB20327@willie-the-truck> In-Reply-To: From: Arnd Bergmann Date: Tue, 6 Jul 2021 16:30:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES) To: Marc Zyngier Cc: Will Deacon , Robin Murphy , Catalin Marinas , Yassine Oudjana , Ard Biesheuvel , Android Kernel Team , Linux ARM , Mark Rutland , Vincent Whitchurch , linux-arm-msm X-Provags-ID: V03:K1:sMJ+LYzjiBDNY38hXOGfJOmON0jlNPdJg8622pBt+rvJTkvNjz5 wGBw+bnUWm1eBxxsfcXTzv1VSdFb0i3EZCw3/yx0BREFubvSORmxZmKQq8JTmmK461WA61X sao4qj/+B8paPWoNihPtGw/gWayCFzKUMGDrA9kGFFH3ZQLe/XSIdPDZz+lz6omveibACnx 81NTl0Cy+hirbQgZASgnw== X-UI-Out-Filterresults: notjunk:1;V03:K0:P7pJr9Br4KQ=:2tXPyxS6a1SfZi1HNREu0a spWXKxHa/l3Qo2c/BiFkZxYl/kleujvP3+HR+EEtg7izuL0Io4ZwFJI8RiBDmqrF5ozO0wKbv qWSI25ABxmBBuXPKXKOefY1XT/+Tf5TfzbDoUHI6eSbpOq6lLVW5hlcZmHupu5wxc46/pA767 dG1asveaVZcqsKQB5htg6OOpbFfJIeNeOPi3rZ7mEcrUNVu5Xhiv5euHnpKZ5mvuw5f0XUU11 srHVxYxxKOtpcjckyqTBc2QEG7T7K7QCyHUkhigV15+0S7vqs0RSazJmBcL0QLGN2hLjV5Uto wE33IuscmtU8BMMrLHB2vwmvjCIJjzyi5YABu7jmePZu1PgtRu4wRd3D7TdR2bwRhxofTI+4R LH4KfzSSTPXzGxbcxz1/VdskrTWPkGU04evPg/3+xv+uWfT2VE/kiyd52lZPkAZJr9cUw3Elk eGyJOfUV02Y9VN9hR4hvtLBc8LH+lFgEHXIFadx1/+aqiTCMBDL/h4StumIRW8oXrEFLis7ds ojpaZJpOh3/4vxJjUbHQYgvOZqOpMzo9fMe81bTSw8SSWquqq0GcJmpzaJThwHfMS6sLYSJI1 +jQtrHZNgm2E5qIvKR6gEAicBIBHFfrmLlXjoAjfNzoiVTM/J3/iQGm2TXv1cPSxqtIMqcOrJ FulTd6myrqaiVWsz9r56sbxnR5pF33KlJEd6UkwKhGTNtO3JlXwm6JbKH2WnlZS92v8aNNZKZ Hnsrl3Itwq5FNI/yhm76MP3f+3mdVug1YPuFaIu4YSP4QMKrZxxtrljYbXuo9IJuvHWHJEC5e ae8jrAajP139vTtP9Ij6v2iIwnAiiCSXEHNK1LFIDfK6tTaLz7+6RvdgKo7Y8qYDgf5zOmS X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_073633_432707_48545330 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 6, 2021 at 3:44 PM Marc Zyngier wrote: > > On 2021-07-06 14:33, Will Deacon wrote: > > On Tue, Jul 06, 2021 at 02:29:07PM +0100, Robin Murphy wrote: > > > > I can't find much information about the original Kryo core at all... > > I have similar issues with my QDF2400. The UART, RTC and DMA controllers > are all screaming at me. I'm confident that the UART doesn't do any > DMA (it is handled by the SBSA driver), but the DMA controllers are > probably doing what it says on the tin. But that's a server chip, surely the DMA controller is fully cache coherent as required by SBSA? (please?) Maybe just a misannotation on the device node? > Do we know whether Falkor and Kryo share any part of their design? I'm fairly sure the Snapdragon 821 / msm8996 is not cache coherent. I can only speculate on how much got reused between the two, but as Falkor was released only after they had already given up on the full-custom Kryo core, it's plausible that it incorporates bits from that one. In particular the cache controller is probably easy to reuse even if the rest of it was a new design. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel