From: Arnd Bergmann <arnd@arndb.de>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: am335x: 5.18.x: system stalling
Date: Sat, 28 May 2022 09:53:24 +0200 [thread overview]
Message-ID: <CAK8P3a2yaKcEiO-LvH5z5azTEX1XTh=9U2MChRS92dtatceY5g@mail.gmail.com> (raw)
In-Reply-To: <CAGm1_kta63UM8um5BB5jOh+r9uFMiGwAiYsrNDOwG3dN-Oo47Q@mail.gmail.com>
On Sat, May 28, 2022 at 7:48 AM Yegor Yefremov
<yegorslists@googlemail.com> wrote:
>
> On Fri, May 27, 2022 at 4:13 PM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Fri, May 27, 2022 at 3:12 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > On Fri, 27 May 2022 at 14:54, Arnd Bergmann <arnd@arndb.de> wrote:
> > > > On Fri, May 27, 2022 at 11:50 AM Yegor Yefremov <yegorslists@googlemail.com> wrote:
> > >
> > > Not just per-cpu data: there is also the 'current' global variable
> > > which gets used now instead of the user thread ID register, and this
> > > is also different between modules and the core kernel (unless
> > > CONFIG_ARM_MODULE_PLTS is disabled)
> >
> > Right, so if the percpu hack doesn't address it, this one might:
> >
> > diff --git a/arch/arm/include/asm/current.h b/arch/arm/include/asm/current.h
> > index 1e1178bf176d..306d1a4cae40 100644
> > --- a/arch/arm/include/asm/current.h
> > +++ b/arch/arm/include/asm/current.h
> > @@ -18,6 +18,8 @@ static __always_inline __attribute_const__ struct
> > task_struct *get_current(void)
> > {
> > struct task_struct *cur;
> >
> > + return __current;
> > +
> > #if __has_builtin(__builtin_thread_pointer) && \
> > defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) && \
> > !(defined(CONFIG_THUMB2_KERNEL) && \
>
> I have tried this patch and the system still stalls.
Ok, thanks for testing. To clarify: did you test with both the get_current() and
__my_cpu_offset() changes applied, or just the get_current() one?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: am335x: 5.18.x: system stalling
Date: Sat, 28 May 2022 09:53:24 +0200 [thread overview]
Message-ID: <CAK8P3a2yaKcEiO-LvH5z5azTEX1XTh=9U2MChRS92dtatceY5g@mail.gmail.com> (raw)
In-Reply-To: <CAGm1_kta63UM8um5BB5jOh+r9uFMiGwAiYsrNDOwG3dN-Oo47Q@mail.gmail.com>
On Sat, May 28, 2022 at 7:48 AM Yegor Yefremov
<yegorslists@googlemail.com> wrote:
>
> On Fri, May 27, 2022 at 4:13 PM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Fri, May 27, 2022 at 3:12 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > On Fri, 27 May 2022 at 14:54, Arnd Bergmann <arnd@arndb.de> wrote:
> > > > On Fri, May 27, 2022 at 11:50 AM Yegor Yefremov <yegorslists@googlemail.com> wrote:
> > >
> > > Not just per-cpu data: there is also the 'current' global variable
> > > which gets used now instead of the user thread ID register, and this
> > > is also different between modules and the core kernel (unless
> > > CONFIG_ARM_MODULE_PLTS is disabled)
> >
> > Right, so if the percpu hack doesn't address it, this one might:
> >
> > diff --git a/arch/arm/include/asm/current.h b/arch/arm/include/asm/current.h
> > index 1e1178bf176d..306d1a4cae40 100644
> > --- a/arch/arm/include/asm/current.h
> > +++ b/arch/arm/include/asm/current.h
> > @@ -18,6 +18,8 @@ static __always_inline __attribute_const__ struct
> > task_struct *get_current(void)
> > {
> > struct task_struct *cur;
> >
> > + return __current;
> > +
> > #if __has_builtin(__builtin_thread_pointer) && \
> > defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) && \
> > !(defined(CONFIG_THUMB2_KERNEL) && \
>
> I have tried this patch and the system still stalls.
Ok, thanks for testing. To clarify: did you test with both the get_current() and
__my_cpu_offset() changes applied, or just the get_current() one?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-28 7:53 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 10:35 am335x: 5.18.x: system stalling Yegor Yefremov
2022-05-05 5:08 ` Tony Lindgren
2022-05-11 14:16 ` Yegor Yefremov
2022-05-12 5:41 ` Tony Lindgren
2022-05-12 5:41 ` Tony Lindgren
2022-05-12 8:14 ` Arnd Bergmann
2022-05-12 8:14 ` Arnd Bergmann
2022-05-12 8:42 ` Arnd Bergmann
2022-05-12 8:42 ` Arnd Bergmann
2022-05-12 10:20 ` Yegor Yefremov
2022-05-12 10:20 ` Yegor Yefremov
2022-05-19 16:52 ` Yegor Yefremov
2022-05-19 16:52 ` Yegor Yefremov
2022-05-21 19:41 ` Arnd Bergmann
2022-05-21 19:41 ` Arnd Bergmann
2022-05-24 13:38 ` Yegor Yefremov
2022-05-24 13:38 ` Yegor Yefremov
2022-05-24 14:19 ` Tony Lindgren
2022-05-24 14:19 ` Tony Lindgren
2022-05-26 5:49 ` Yegor Yefremov
2022-05-26 5:49 ` Yegor Yefremov
2022-05-26 6:20 ` Tony Lindgren
2022-05-26 6:20 ` Tony Lindgren
2022-05-26 8:19 ` Ard Biesheuvel
2022-05-26 8:19 ` Ard Biesheuvel
2022-05-26 12:37 ` Yegor Yefremov
2022-05-26 12:37 ` Yegor Yefremov
2022-05-26 14:15 ` Arnd Bergmann
2022-05-26 14:15 ` Arnd Bergmann
2022-05-27 4:44 ` Yegor Yefremov
2022-05-27 4:44 ` Yegor Yefremov
2022-05-27 6:38 ` Arnd Bergmann
2022-05-27 6:38 ` Arnd Bergmann
2022-05-27 6:50 ` Tony Lindgren
2022-05-27 6:50 ` Tony Lindgren
2022-05-27 6:57 ` Arnd Bergmann
2022-05-27 6:57 ` Arnd Bergmann
2022-05-27 8:17 ` Yegor Yefremov
2022-05-27 8:17 ` Yegor Yefremov
2022-05-27 8:38 ` Arnd Bergmann
2022-05-27 8:38 ` Arnd Bergmann
2022-05-27 9:50 ` Yegor Yefremov
2022-05-27 9:50 ` Yegor Yefremov
2022-05-27 12:53 ` Arnd Bergmann
2022-05-27 12:53 ` Arnd Bergmann
2022-05-27 13:12 ` Ard Biesheuvel
2022-05-27 13:12 ` Ard Biesheuvel
2022-05-27 14:12 ` Arnd Bergmann
2022-05-27 14:12 ` Arnd Bergmann
2022-05-28 5:48 ` Yegor Yefremov
2022-05-28 5:48 ` Yegor Yefremov
2022-05-28 7:53 ` Arnd Bergmann [this message]
2022-05-28 7:53 ` Arnd Bergmann
2022-05-28 8:29 ` Yegor Yefremov
2022-05-28 8:29 ` Yegor Yefremov
2022-05-28 9:07 ` Ard Biesheuvel
2022-05-28 9:07 ` Ard Biesheuvel
2022-05-28 13:01 ` Yegor Yefremov
2022-05-28 13:01 ` Yegor Yefremov
2022-05-28 13:13 ` Arnd Bergmann
2022-05-28 13:13 ` Arnd Bergmann
2022-05-28 19:28 ` Yegor Yefremov
2022-05-28 19:28 ` Yegor Yefremov
2022-05-30 10:16 ` Ard Biesheuvel
2022-05-30 10:16 ` Ard Biesheuvel
2022-05-30 12:09 ` Yegor Yefremov
2022-05-30 12:09 ` Yegor Yefremov
2022-05-30 13:54 ` Arnd Bergmann
2022-05-30 13:54 ` Arnd Bergmann
2022-05-30 15:14 ` Ard Biesheuvel
2022-05-30 15:14 ` Ard Biesheuvel
2022-05-31 8:36 ` Yegor Yefremov
2022-05-31 8:36 ` Yegor Yefremov
2022-05-31 14:16 ` Yegor Yefremov
2022-05-31 14:16 ` Yegor Yefremov
2022-05-31 15:22 ` Arnd Bergmann
2022-05-31 15:22 ` Arnd Bergmann
2022-06-01 7:36 ` Yegor Yefremov
2022-06-01 7:36 ` Yegor Yefremov
2022-06-01 7:59 ` Arnd Bergmann
2022-06-01 7:59 ` Arnd Bergmann
2022-06-01 8:08 ` Ard Biesheuvel
2022-06-01 8:08 ` Ard Biesheuvel
2022-06-01 9:27 ` Ard Biesheuvel
2022-06-01 9:27 ` Ard Biesheuvel
2022-06-01 10:03 ` Yegor Yefremov
2022-06-01 10:03 ` Yegor Yefremov
2022-06-01 10:06 ` Ard Biesheuvel
2022-06-01 10:06 ` Ard Biesheuvel
2022-06-01 10:46 ` Yegor Yefremov
2022-06-01 10:46 ` Yegor Yefremov
2022-06-01 10:49 ` Ard Biesheuvel
2022-06-01 10:49 ` Ard Biesheuvel
2022-06-02 10:17 ` Yegor Yefremov
2022-06-02 10:17 ` Yegor Yefremov
2022-06-02 10:37 ` Ard Biesheuvel
2022-06-02 10:37 ` Ard Biesheuvel
2022-06-02 12:27 ` Yegor Yefremov
2022-06-02 12:27 ` Yegor Yefremov
2022-06-03 8:54 ` Yegor Yefremov
2022-06-03 8:54 ` Yegor Yefremov
2022-06-03 9:32 ` Arnd Bergmann
2022-06-03 9:32 ` Arnd Bergmann
2022-06-03 19:11 ` Yegor Yefremov
2022-06-03 19:11 ` Yegor Yefremov
2022-06-03 20:46 ` Arnd Bergmann
2022-06-03 20:46 ` Arnd Bergmann
2022-06-05 14:59 ` Ard Biesheuvel
2022-06-05 14:59 ` Ard Biesheuvel
2022-06-07 8:55 ` Yegor Yefremov
2022-06-07 8:55 ` Yegor Yefremov
2022-08-12 7:35 ` Arnd Bergmann
2022-08-12 7:35 ` Arnd Bergmann
2022-05-24 14:36 ` Arnd Bergmann
2022-05-24 14:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2yaKcEiO-LvH5z5azTEX1XTh=9U2MChRS92dtatceY5g@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.