From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750936AbdALQX7 (ORCPT ); Thu, 12 Jan 2017 11:23:59 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:33259 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdALQX6 (ORCPT ); Thu, 12 Jan 2017 11:23:58 -0500 MIME-Version: 1.0 In-Reply-To: <20276.1484237654@warthog.procyon.org.uk> References: <107420020.65PPp1ZfLz@wuerfel> <148422219487.9419.2588525606361566422.stgit@warthog.procyon.org.uk> <13021.1484230376@warthog.procyon.org.uk> <6962749.4mk109advR@wuerfel> <20276.1484237654@warthog.procyon.org.uk> From: Arnd Bergmann Date: Thu, 12 Jan 2017 17:23:57 +0100 X-Google-Sender-Auth: z2XGYTwUXpgGMnm7GC3gplYyyJk Message-ID: Subject: Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h To: David Howells Cc: Linux Kernel Mailing List , Tina Ruchandani , linux-afs@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 5:14 PM, David Howells wrote: >> > reply.ia.uuid[3] = htonl((s8) afs_uuid.clock_seq_hi_and_reserved); >> > reply.ia.uuid[4] = htonl((s8) afs_uuid.clock_seq_low); >> > for (loop = 0; loop < 6; loop++) >> >> Shouldn't this be ntohs() instead of ntohl(), like this: >> >> reply.ia.uuid[1] = htonl(ntohl(afs_uuid.time_mid)); >> reply.ia.uuid[2] = htonl(ntohl(afs_uuid.time_hi_and_version)); > > I think you forgot to change ntohl() to ntohs() in that - and you're right. > > Okay, how about the attached? Yes, looks good to me. Arnd