From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940D4C43217 for ; Wed, 20 Apr 2022 11:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378157AbiDTLfV (ORCPT ); Wed, 20 Apr 2022 07:35:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378151AbiDTLfU (ORCPT ); Wed, 20 Apr 2022 07:35:20 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DA4F419A3; Wed, 20 Apr 2022 04:32:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D8E4FCE1D78; Wed, 20 Apr 2022 11:32:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EAF9C385AC; Wed, 20 Apr 2022 11:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650454351; bh=SVJ1k2v3tWdUGg+iydyQsi4Bq8zjjEYtWiKbWgwFaLw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sQ6L9Sz7HsTeFplAqNVVqZ6QvDLXO7taCfdy4bCI083iKPBu4Tu1W3tAjRXjBMJP+ vEnLCGH51YORxEsFGOcZi/zoMsoYQoogO656Bx3dJCN3iokeUHMcZ/sRdJXG/FEfPy OVbCsNPPUvMBA4ygYO3ABwIPljbcDkM69w6wy8bq4hi0dZRIAMv8YMoKSdGB49RoPV 7T06gmGwLx2hqcDTbF36X1GFj0Gux2+ukzAt7yv7JaGdNy5Qv43jNDhgQacW6a+5lC 7ziU5CwWVIqq9dL54xJaRWmMjZZOJMF8J98DaHAPKZKsUB+PqhqrA4wPmQhlfKvBIW qSWfkWYIEhJww== Received: by mail-wr1-f42.google.com with SMTP id x18so1882237wrc.0; Wed, 20 Apr 2022 04:32:31 -0700 (PDT) X-Gm-Message-State: AOAM530NWB0Xph9prkK8MhpzZZvtjev6lzNibywcjlBDFqkXONBxzEmC BAB2nVGC+z7kHjbSFQYnKjVNHwqTkjcmslDX/Zg= X-Google-Smtp-Source: ABdhPJyiDPtmjdTUE7gVl98mXVlPUP43tSlAHIUMCCxTRsYmEILlWV1BOcaVw3t9k0Uq80bvmC166gAUNNWM192dlCo= X-Received: by 2002:a5d:64a3:0:b0:20a:7931:5b84 with SMTP id m3-20020a5d64a3000000b0020a79315b84mr15873027wrp.407.1650454349319; Wed, 20 Apr 2022 04:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-2-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 20 Apr 2022 13:32:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/41] video: fbdev: omapfb: lcd_ams_delta: fix unused variable warning To: Sergei Shtylyov Cc: linux-omap , Tony Lindgren , Aaro Koskinen , Janusz Krzysztofik , Arnd Bergmann , Russell King , Paul Walmsley , Kevin Hilman , Peter Ujfalusi , Vinod Koul , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Mark Brown , Felipe Balbi , Alan Stern , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Linus Walleij , Krzysztof Kozlowski , Linux ARM , Linux Kernel Mailing List , USB list , dmaengine@vger.kernel.org, "open list:HID CORE LAYER" , linux-mmc , "open list:SERIAL DRIVERS" , dri-devel , Linux Fbdev development list , ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, Apr 20, 2022 at 11:24 AM Sergei Shtylyov wrote: > On 4/19/22 4:36 PM, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > A recent cleanup patch removed the only reference to a local variable > > in some configurations. > > > > Move the variable into the one block it is still used in, inside > > of an #ifdef, to avoid this warning. > > > > Fixes: 9d773f103b89 ("video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe()") > > Signed-off-by: Arnd Bergmann > > --- > > drivers/video/fbdev/omap/lcd_ams_delta.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c > > index bbf871f9d862..01944ce46aa1 100644 > > --- a/drivers/video/fbdev/omap/lcd_ams_delta.c > > +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c > [...] > > @@ -145,7 +144,7 @@ static int ams_delta_panel_probe(struct platform_device *pdev) > > &ams_delta_lcd_ops); > > > > if (IS_ERR(lcd_device)) { > > - ret = PTR_ERR(lcd_device); > > + int ret = PTR_ERR(lcd_device); > > How about inserting an empty line after declaration? Ok, done. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0653FC4332F for ; Wed, 20 Apr 2022 11:32:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3657310F24F; Wed, 20 Apr 2022 11:32:39 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21A6E10F24F for ; Wed, 20 Apr 2022 11:32:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E2BA5CE1D7E for ; Wed, 20 Apr 2022 11:32:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5904FC385BB for ; Wed, 20 Apr 2022 11:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650454351; bh=SVJ1k2v3tWdUGg+iydyQsi4Bq8zjjEYtWiKbWgwFaLw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sQ6L9Sz7HsTeFplAqNVVqZ6QvDLXO7taCfdy4bCI083iKPBu4Tu1W3tAjRXjBMJP+ vEnLCGH51YORxEsFGOcZi/zoMsoYQoogO656Bx3dJCN3iokeUHMcZ/sRdJXG/FEfPy OVbCsNPPUvMBA4ygYO3ABwIPljbcDkM69w6wy8bq4hi0dZRIAMv8YMoKSdGB49RoPV 7T06gmGwLx2hqcDTbF36X1GFj0Gux2+ukzAt7yv7JaGdNy5Qv43jNDhgQacW6a+5lC 7ziU5CwWVIqq9dL54xJaRWmMjZZOJMF8J98DaHAPKZKsUB+PqhqrA4wPmQhlfKvBIW qSWfkWYIEhJww== Received: by mail-wr1-f50.google.com with SMTP id g18so1820147wrb.10 for ; Wed, 20 Apr 2022 04:32:31 -0700 (PDT) X-Gm-Message-State: AOAM531AO7sh5PMX0VyLXfFe/5qYPJ8I3YxI+s42FFkxHgP0gOms8Hqp HMnnYegOUK8XDUgY8r49E4bfV/FSYXO4XsU/6AA= X-Google-Smtp-Source: ABdhPJyiDPtmjdTUE7gVl98mXVlPUP43tSlAHIUMCCxTRsYmEILlWV1BOcaVw3t9k0Uq80bvmC166gAUNNWM192dlCo= X-Received: by 2002:a5d:64a3:0:b0:20a:7931:5b84 with SMTP id m3-20020a5d64a3000000b0020a79315b84mr15873027wrp.407.1650454349319; Wed, 20 Apr 2022 04:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-2-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 20 Apr 2022 13:32:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/41] video: fbdev: omapfb: lcd_ams_delta: fix unused variable warning To: Sergei Shtylyov Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , USB list , Tony Lindgren , Linux Fbdev development list , Dominik Brodowski , Lee Jones , Daniel Thompson , Aaro Koskinen , Peter Ujfalusi , Helge Deller , Janusz Krzysztofik , Russell King , Krzysztof Kozlowski , Alan Stern , "open list:SERIAL DRIVERS" , "open list:HID CORE LAYER" , Arnd Bergmann , Mark Brown , dri-devel , linux-omap , Linux ARM , Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc , Linux Kernel Mailing List , Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, ALSA Development Mailing List Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 20, 2022 at 11:24 AM Sergei Shtylyov wrote: > On 4/19/22 4:36 PM, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > A recent cleanup patch removed the only reference to a local variable > > in some configurations. > > > > Move the variable into the one block it is still used in, inside > > of an #ifdef, to avoid this warning. > > > > Fixes: 9d773f103b89 ("video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe()") > > Signed-off-by: Arnd Bergmann > > --- > > drivers/video/fbdev/omap/lcd_ams_delta.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c > > index bbf871f9d862..01944ce46aa1 100644 > > --- a/drivers/video/fbdev/omap/lcd_ams_delta.c > > +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c > [...] > > @@ -145,7 +144,7 @@ static int ams_delta_panel_probe(struct platform_device *pdev) > > &ams_delta_lcd_ops); > > > > if (IS_ERR(lcd_device)) { > > - ret = PTR_ERR(lcd_device); > > + int ret = PTR_ERR(lcd_device); > > How about inserting an empty line after declaration? Ok, done. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02D00C433F5 for ; Wed, 20 Apr 2022 11:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uQCEZQgZ8N7MZ64wJIc2zKF7XDGcc+LViOAdyxrSGMs=; b=CrpmKRKtvxkNff EEhZWJuyOPv7hFcqZ8HdsyrrJ0yq10AJd81Aqs/C4IPTdSVzYwzLrfyuee2poXTT1LXVcLh0Sg6z+ D1fVwGssp6r+t8eLJGGtiIwafY5IHsyNA9Lcs/FWSXuG/RfCiNKX1mt5IV0KffYH+oB15WhJEVNe/ Zp4hz4jX2zLzvBy6WkBR2H5+sJJ4fXcRDZZ6mxoxdXJHz9TpkFZY9HjVdQvhfV4dzTw5Pg2PSKUS0 XdKt6oo77cHb2I3afzs1Htfa/MR/RlxjpK6T7RK2yRmMaBuzc4yxnpI0Ly2FF4QZM92lG3y5hQM3N Kqrybfw1CDVq6b+miTlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh8ZZ-008n46-0E; Wed, 20 Apr 2022 11:32:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh8ZW-008n28-3j for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 11:32:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0BD061908 for ; Wed, 20 Apr 2022 11:32:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59504C385BC for ; Wed, 20 Apr 2022 11:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650454351; bh=SVJ1k2v3tWdUGg+iydyQsi4Bq8zjjEYtWiKbWgwFaLw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sQ6L9Sz7HsTeFplAqNVVqZ6QvDLXO7taCfdy4bCI083iKPBu4Tu1W3tAjRXjBMJP+ vEnLCGH51YORxEsFGOcZi/zoMsoYQoogO656Bx3dJCN3iokeUHMcZ/sRdJXG/FEfPy OVbCsNPPUvMBA4ygYO3ABwIPljbcDkM69w6wy8bq4hi0dZRIAMv8YMoKSdGB49RoPV 7T06gmGwLx2hqcDTbF36X1GFj0Gux2+ukzAt7yv7JaGdNy5Qv43jNDhgQacW6a+5lC 7ziU5CwWVIqq9dL54xJaRWmMjZZOJMF8J98DaHAPKZKsUB+PqhqrA4wPmQhlfKvBIW qSWfkWYIEhJww== Received: by mail-wr1-f49.google.com with SMTP id c10so1867582wrb.1 for ; Wed, 20 Apr 2022 04:32:31 -0700 (PDT) X-Gm-Message-State: AOAM532taX7ymNh+HrZT9O0VfkuzIez5X4253+tkYU5Rcj+EClGDubix VXyz1z/tolVck2MjVv5Zy16XI4ZlWfalwh3RvbY= X-Google-Smtp-Source: ABdhPJyiDPtmjdTUE7gVl98mXVlPUP43tSlAHIUMCCxTRsYmEILlWV1BOcaVw3t9k0Uq80bvmC166gAUNNWM192dlCo= X-Received: by 2002:a5d:64a3:0:b0:20a:7931:5b84 with SMTP id m3-20020a5d64a3000000b0020a79315b84mr15873027wrp.407.1650454349319; Wed, 20 Apr 2022 04:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-2-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 20 Apr 2022 13:32:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/41] video: fbdev: omapfb: lcd_ams_delta: fix unused variable warning To: Sergei Shtylyov Cc: linux-omap , Tony Lindgren , Aaro Koskinen , Janusz Krzysztofik , Arnd Bergmann , Russell King , Paul Walmsley , Kevin Hilman , Peter Ujfalusi , Vinod Koul , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Mark Brown , Felipe Balbi , Alan Stern , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Linus Walleij , Krzysztof Kozlowski , Linux ARM , Linux Kernel Mailing List , USB list , dmaengine@vger.kernel.org, "open list:HID CORE LAYER" , linux-mmc , "open list:SERIAL DRIVERS" , dri-devel , Linux Fbdev development list , ALSA Development Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_043234_245510_808175E7 X-CRM114-Status: GOOD ( 26.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 20, 2022 at 11:24 AM Sergei Shtylyov wrote: > On 4/19/22 4:36 PM, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > A recent cleanup patch removed the only reference to a local variable > > in some configurations. > > > > Move the variable into the one block it is still used in, inside > > of an #ifdef, to avoid this warning. > > > > Fixes: 9d773f103b89 ("video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe()") > > Signed-off-by: Arnd Bergmann > > --- > > drivers/video/fbdev/omap/lcd_ams_delta.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c > > index bbf871f9d862..01944ce46aa1 100644 > > --- a/drivers/video/fbdev/omap/lcd_ams_delta.c > > +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c > [...] > > @@ -145,7 +144,7 @@ static int ams_delta_panel_probe(struct platform_device *pdev) > > &ams_delta_lcd_ops); > > > > if (IS_ERR(lcd_device)) { > > - ret = PTR_ERR(lcd_device); > > + int ret = PTR_ERR(lcd_device); > > How about inserting an empty line after declaration? Ok, done. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3FE9C433EF for ; Fri, 22 Apr 2022 13:51:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0B00883A; Fri, 22 Apr 2022 15:50:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0B00883A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650635476; bh=SVJ1k2v3tWdUGg+iydyQsi4Bq8zjjEYtWiKbWgwFaLw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MJs+MIN9lgddF85PrcjiY46u8Ljf2pVd0u3WGOu8IoDYgp9BRw9JdiSBp3v0WhUrt u/Y2zJHLHg8fDsuIPsFjQlsazbLBkZnLoe1W8iI5BFgoE7yB0kU+qn0DIuAOEHY3ab J1DzybYZyeNImAixHU9MCjL4zmVrUpZOi/tSnZ34= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7CF4BF80834; Fri, 22 Apr 2022 15:32:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 42DD2F80125; Wed, 20 Apr 2022 13:32:43 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B7F98F8010B for ; Wed, 20 Apr 2022 13:32:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B7F98F8010B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sQ6L9Sz7" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4773661939 for ; Wed, 20 Apr 2022 11:32:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B6B3C385A0 for ; Wed, 20 Apr 2022 11:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650454351; bh=SVJ1k2v3tWdUGg+iydyQsi4Bq8zjjEYtWiKbWgwFaLw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sQ6L9Sz7HsTeFplAqNVVqZ6QvDLXO7taCfdy4bCI083iKPBu4Tu1W3tAjRXjBMJP+ vEnLCGH51YORxEsFGOcZi/zoMsoYQoogO656Bx3dJCN3iokeUHMcZ/sRdJXG/FEfPy OVbCsNPPUvMBA4ygYO3ABwIPljbcDkM69w6wy8bq4hi0dZRIAMv8YMoKSdGB49RoPV 7T06gmGwLx2hqcDTbF36X1GFj0Gux2+ukzAt7yv7JaGdNy5Qv43jNDhgQacW6a+5lC 7ziU5CwWVIqq9dL54xJaRWmMjZZOJMF8J98DaHAPKZKsUB+PqhqrA4wPmQhlfKvBIW qSWfkWYIEhJww== Received: by mail-wr1-f48.google.com with SMTP id m14so1846759wrb.6 for ; Wed, 20 Apr 2022 04:32:31 -0700 (PDT) X-Gm-Message-State: AOAM530/q3Oxqqh6/0QvG1CUvmLevtNHP4YEzvy6Re5hT5/3YwIdkC/T v2ABII7Z3KXKYb6/W0TgZcDH2jizOLVIuPjmel0= X-Google-Smtp-Source: ABdhPJyiDPtmjdTUE7gVl98mXVlPUP43tSlAHIUMCCxTRsYmEILlWV1BOcaVw3t9k0Uq80bvmC166gAUNNWM192dlCo= X-Received: by 2002:a5d:64a3:0:b0:20a:7931:5b84 with SMTP id m3-20020a5d64a3000000b0020a79315b84mr15873027wrp.407.1650454349319; Wed, 20 Apr 2022 04:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-2-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 20 Apr 2022 13:32:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/41] video: fbdev: omapfb: lcd_ams_delta: fix unused variable warning To: Sergei Shtylyov Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Fri, 22 Apr 2022 15:31:42 +0200 Cc: Ulf Hansson , USB list , Tony Lindgren , Linus Walleij , Linux Fbdev development list , Dominik Brodowski , Lee Jones , Daniel Thompson , Aaro Koskinen , Peter Ujfalusi , Helge Deller , Janusz Krzysztofik , Russell King , Krzysztof Kozlowski , Alan Stern , "open list:SERIAL DRIVERS" , "open list:HID CORE LAYER" , Arnd Bergmann , Mark Brown , dri-devel , linux-omap , Linux ARM , Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc , Linux Kernel Mailing List , Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, ALSA Development Mailing List X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Apr 20, 2022 at 11:24 AM Sergei Shtylyov wrote: > On 4/19/22 4:36 PM, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > A recent cleanup patch removed the only reference to a local variable > > in some configurations. > > > > Move the variable into the one block it is still used in, inside > > of an #ifdef, to avoid this warning. > > > > Fixes: 9d773f103b89 ("video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe()") > > Signed-off-by: Arnd Bergmann > > --- > > drivers/video/fbdev/omap/lcd_ams_delta.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c > > index bbf871f9d862..01944ce46aa1 100644 > > --- a/drivers/video/fbdev/omap/lcd_ams_delta.c > > +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c > [...] > > @@ -145,7 +144,7 @@ static int ams_delta_panel_probe(struct platform_device *pdev) > > &ams_delta_lcd_ops); > > > > if (IS_ERR(lcd_device)) { > > - ret = PTR_ERR(lcd_device); > > + int ret = PTR_ERR(lcd_device); > > How about inserting an empty line after declaration? Ok, done. Arnd