From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8FBEC433E0 for ; Thu, 21 May 2020 09:31:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC9102072C for ; Thu, 21 May 2020 09:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728774AbgEUJbL (ORCPT ); Thu, 21 May 2020 05:31:11 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:55829 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728704AbgEUJbK (ORCPT ); Thu, 21 May 2020 05:31:10 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N9cDF-1ixPAH2wTN-015dNM for ; Thu, 21 May 2020 11:31:08 +0200 Received: by mail-qk1-f171.google.com with SMTP id y22so6583673qki.3 for ; Thu, 21 May 2020 02:31:08 -0700 (PDT) X-Gm-Message-State: AOAM532y3FNcqsntLRaUqXSoNiqDwPKPwbOQju4Osxi9q1xx0BXOx6fb kO+6HkQGwy7bCcCCigxInMZh3BaPpP3Uv/z/JbU= X-Google-Smtp-Source: ABdhPJzbgF8kpiHY8jbqJbvHdKF89SdmVVSXNL4nMi/iekVliG7vUiFck8VHCIJH+/J+6YUDtXi2c8Eovdt4IzQ+dlw= X-Received: by 2002:a37:434b:: with SMTP id q72mr9455175qka.352.1590053467616; Thu, 21 May 2020 02:31:07 -0700 (PDT) MIME-Version: 1.0 References: <20200518091222.27467-1-sudeep.holla@arm.com> <158999823818.135150.13263761266508812198.b4-ty@kernel.org> <20200521070629.GB1131@bogus> <20200521075755.GA4668@willie-the-truck> <20200521081055.GD1131@bogus> <20200521091736.GA5091@willie-the-truck> In-Reply-To: <20200521091736.GA5091@willie-the-truck> From: Arnd Bergmann Date: Thu, 21 May 2020 11:30:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support To: Will Deacon Cc: Sudeep Holla , Linux ARM , Catalin Marinas , Mark Rutland , Lorenzo Pieralisi , Steven Price , harb@amperecomputing.com, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:j5rGUQ73rrDexC1lnHcB1RpiEDo35jQL/y8gAGtBCC9Lbxmxv23 r5eGf2EsLg5w4cXiQDdz7gHVibZJxtz7uKgmUnA8d+GD7/i+piciZGUfbmuaFHuVZ54h8rv pAFqkePGbuVSit3Abkaqps8xtVDUiDLUUzI6avSOA6NP8cWLB13XOZXpOwPIm+so6qkM4pT 4vFV2COVGAhiz72Bt0zxg== X-UI-Out-Filterresults: notjunk:1;V03:K0:bRGBE2Z6qFc=:5Rm06osgW0jNoU/v6k9BWf s6SUAtcgWJK/Oxn6+jL/lJo3vO7CcyFZTRrfQhNX1be24+tYp6wwIqGC/Ny5AIzBSSKvo29mz rUoAFskyYt+hvQR63CjkfyrwkGBQyiGkljRnyRFJAPHfdlvzyboCk8wFpd6tnJf5u7nsaq8jI GuHrbwgXPjEItnWXXAYhGjt6mCRowkfykKNpUX8Ha5mHvCYHQrL2FDygjUshqrW33ps1E3VgP nDsT3fEn6ggCwCtY2xIRCupA8JgVYOgsS3foJq3QBWmqzhY4TnitjUAF0nICtN05n3SHGXCr/ +eMY4JDD5fGeNZxPo9eOm21fXh523FlzQ7oPGmjwG/4pTzZ19oaSSy0knN/4wxoesnYxYio8c zqOIfzB7QM47aob1/3QWgcoG2TzLQAloAZdkbMZAxC2ITmiKlZkPmT4z1zb0r6m1kes3nZs2B 48gN6z6B/VQzxEeTaJtwOo6pPMWqQn05s/yL/OYwhrirKycDUzcccDKbM0SOH9MCo1DJsKNYe 6qobyObkVM2YPbdCJrNIOi2NlwnNB8yhRyTjuCMWWFhse9b4X2IjcMVj+GRT4fnW2UDPMqIjo 5IP/RdMe5vxrnmr8EkSkLwk7RpHMb/W7zdhlcp8Ah3zTYq798Gaf4fXtjJI7VpZO12G5swmcE 3McF+KMh9DKhpEeoZ9qynFPiKHdv4YU+Ub0D8aY7Uz97ip6U2WYrbj2USew2BvwxQbNZsaQTK XNcqq7mzkbEA8reGTyRC2RLnhs9LtPx7ZEssNxgVmGaL2EFJDOl40NZGEcunW6KkSwFHHwSQZ 0T/GSHNPB/wnHE4vGhKjX76D154VtpQNo9rttdc2PnkZhPTN0o= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2020 at 11:17 AM Will Deacon wrote: > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote: > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla wrote: > > Note that the warning should come up for either W=1 or C=1, and I also > > think that > > new code should generally be written sparse-clean and have no warnings with > > 'make C=1' as a rule. > > Fair enough. Is anybody working on a tree-wide sweep for this, like we've > done for other things such as zero-length arrays? If so, I can start > enforcing this in the arch code as well (I haven't been so far, even though > I do run sparse on every commit). I've done some work on that a few years ago, and there are always some cleanup patches for C=1 and W=1 warnings, most recently with an increase from Huawei's automated build testing + manual patching. I have not looked in a while, but it always seemed to be somewhere between "too much to do by myself" and "small enough that it should really be done" as build warnings go. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 501A4C433DF for ; Thu, 21 May 2020 09:31:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DBB52072C for ; Thu, 21 May 2020 09:31:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HRoTFSxW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DBB52072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nYm5EQrP0vHY6WaeEWphdqRuVzo7CRSJPEmYxnEp+UU=; b=HRoTFSxWkkhZo2 ArAbetXv5TMmr5VMBbZp7qQDKWqlBZWMukfJu+vQFo/FB2gFfManDsazcP+56gu0JQXIX/WjCvuOJ n/R7RuogFA8XiAI/rleyho3X1sKkGAeW36HfslNLQZzzzKnsk+Ej2iaZ2taF3Glp4tTMqU6gs9EfN GHbvP4UveyWmj9CUODYFdgw5CIuP8XpWiYwxfRaz2AkCv6DCBgOSKWqCjp+fxLu6sVdWWzwr/XU2O 5opLE8Ln8pKTo8voHUODR/aCQsCRiroQtnIP7DmEBlKv/d8Naxiib7df6u3mQH4mwaXCa7Ut0OUPa glFxlNqJQew2/XWZI75Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbhXm-00075R-KF; Thu, 21 May 2020 09:31:14 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbhXj-00074I-7S for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2020 09:31:12 +0000 Received: from mail-qk1-f172.google.com ([209.85.222.172]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MYvHa-1jXHgK3LPc-00UqjZ for ; Thu, 21 May 2020 11:31:09 +0200 Received: by mail-qk1-f172.google.com with SMTP id 190so6618656qki.1 for ; Thu, 21 May 2020 02:31:08 -0700 (PDT) X-Gm-Message-State: AOAM5320hvamLpUGE0JPb1ZHQ0ZU0FKH5lalHC02uL+lzKfX6AQByVNk 9ahXwTueKjZL5QuK7qc8MreFYRRUeIWN/lqTlqs= X-Google-Smtp-Source: ABdhPJzbgF8kpiHY8jbqJbvHdKF89SdmVVSXNL4nMi/iekVliG7vUiFck8VHCIJH+/J+6YUDtXi2c8Eovdt4IzQ+dlw= X-Received: by 2002:a37:434b:: with SMTP id q72mr9455175qka.352.1590053467616; Thu, 21 May 2020 02:31:07 -0700 (PDT) MIME-Version: 1.0 References: <20200518091222.27467-1-sudeep.holla@arm.com> <158999823818.135150.13263761266508812198.b4-ty@kernel.org> <20200521070629.GB1131@bogus> <20200521075755.GA4668@willie-the-truck> <20200521081055.GD1131@bogus> <20200521091736.GA5091@willie-the-truck> In-Reply-To: <20200521091736.GA5091@willie-the-truck> From: Arnd Bergmann Date: Thu, 21 May 2020 11:30:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support To: Will Deacon X-Provags-ID: V03:K1:ko+MiijbzzeG+nWHbJuUu5AD34qLTbCXggZFsyWzh2XGpv0u3VW GtNM5c/j7rizIuQrgw+ntrI0NOCurS8uD2ufjhR/IRvl7dhQtKt9NbcgMrqGNIuD+JqdTH2 zwW82WjaleY63mppIjTXifJHhSueD7kpCp4j2yl+E22JA1t1uJKvJ6pta5Ms3ENOW0TgTjU FY/BGI1QTaayB+raTdPlw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Fa5ZwnajJKU=:jUE/lNHOTC+NPzNJvYFl6h 2EvRZu83tL5oO3wMJyEV0Ep2yLGk7OIGHoPuWWt7NnLdmCZonrFT5kR7TmVeD4yCdJEneyh7v ea69YMQrR+i1DWWkgLryiVUXVnCBEkBmgHLD/B5wauLUf5Wi0yrINWEuNM4GSRK3JFq7dov+i HpwBtj/TJS3gZ87c7K1uYmFhT4FuzVJGVSJhOGC2oMhneVlnr4uEdFaJfJFRLXsPx/E4RLwir vQXebZVGBXF7Sdhh+DJNHf9Zd7c2BZ+/RJqLHsZ7Nyj201WLX210zWveBmFITwr22d0u9UO5f cyYgtG4s8wssvppPbY4NXv4sqbqzkWmV+PX+ncul22N9UZK/ofvgtH92fK8TFfZCtIpS5Fy6K MsjtDvrslW16S6EiTeTXPUGKm9Qm+lSe/ASUHL4KlXflCXUc5ntPoHHNm9Dub3ftsN5329FwW zR/fRU0pENY5yFGaZqxPSKBLUlRa92odWw5DHuc4AprWAOjjMnbw01sLqfHsojIGnupMv9DU5 9SygAurU0k4bVinFO9eRxwxTcN0tDO602zYSnn5Lil3/HqXeHHEu2Dl8G0Mn4Um89ysTGWKpr NUv+Xxo1d5Ub3kIlVGhB5aSJUUt/sMOD1c+FJYZf7X484aAsuCHMDFxQth0CofjhLfRGLGx6w rdQPuzyF2FOqczWI38TRq/o0eTEJUaMZ4tcWxdUCgCG8npb5feKVORPMIAHmbiEYDur2jp91C waTSMOcidsKoHdIzPDnC2wtORjLhmKGmHRgCZDU0LF0/sJXtjMENPgkEQc+J3xS6EmjO0sZup 5OpKKJagFdn1+ypjWxMkAjA7z9DSxXIAVPSKOsuziUCRzpCsBU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_023111_557677_232A1F63 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , Catalin Marinas , "linux-kernel@vger.kernel.org" , Steven Price , harb@amperecomputing.com, Sudeep Holla , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 21, 2020 at 11:17 AM Will Deacon wrote: > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote: > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla wrote: > > Note that the warning should come up for either W=1 or C=1, and I also > > think that > > new code should generally be written sparse-clean and have no warnings with > > 'make C=1' as a rule. > > Fair enough. Is anybody working on a tree-wide sweep for this, like we've > done for other things such as zero-length arrays? If so, I can start > enforcing this in the arch code as well (I haven't been so far, even though > I do run sparse on every commit). I've done some work on that a few years ago, and there are always some cleanup patches for C=1 and W=1 warnings, most recently with an increase from Huawei's automated build testing + manual patching. I have not looked in a while, but it always seemed to be somewhere between "too much to do by myself" and "small enough that it should really be done" as build warnings go. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel