All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Vitaly Bordug <vitb@kernel.crashing.org>,
	Geoff Levand <geoff@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] powerpc: use time64_t in read_persistent_clock
Date: Mon, 23 Apr 2018 10:28:31 +0200	[thread overview]
Message-ID: <CAK8P3a30fo0mviQMgg3OXivbVCkC9vBp2R7NfuLKq=si_O0X_w@mail.gmail.com> (raw)
In-Reply-To: <20180423081114.1813726-3-arnd@arndb.de>

On Mon, Apr 23, 2018 at 10:10 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> @@ -170,7 +170,6 @@ unsigned long __init maple_get_boot_time(void)
>         request_resource(&ioport_resource, &rtc_iores);
>
>         maple_get_rtc_time(&tm);
> -       return mktime(tm.tm_year+1900, tm.tm_mon+1, tm.tm_mday,
> -                     tm.tm_hour, tm.tm_min, tm.tm_sec);
> +       return rtc_tm_to_time66(&tm);
>  }

No, it's not rtc_tm_to_time66 ;(

I did some build testing over the weekend to make sure I find all the stupid
bugs, but then sent out the version without the two fixes. Please ignore all
five patches, will follow up with v2 that fixes this one and another equally
trivial bug.

       Arnd

  reply	other threads:[~2018-04-23  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23  8:10 [PATCH 1/5] powerpc: always enable RTC_LIB Arnd Bergmann
2018-04-23  8:10 ` [PATCH 2/5] powerpc: rtas: clean up time handling Arnd Bergmann
2018-04-23  8:32   ` Arnd Bergmann
2018-04-23  8:10 ` [PATCH 3/5] powerpc: use time64_t in read_persistent_clock Arnd Bergmann
2018-04-23  8:28   ` Arnd Bergmann [this message]
2018-04-24  5:29   ` kbuild test robot
2018-04-23  8:10 ` [PATCH 4/5] powerpc: use time64_t in update_persistent_clock Arnd Bergmann
2018-04-23  8:10 ` [PATCH 5/5] powerpc: remove unused to_tm() helper Arnd Bergmann
2018-04-23  8:36 [PATCH 1/5] powerpc: always enable RTC_LIB Arnd Bergmann
2018-04-23  8:36 ` [PATCH 3/5] powerpc: use time64_t in read_persistent_clock Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a30fo0mviQMgg3OXivbVCkC9vBp2R7NfuLKq=si_O0X_w@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=geoff@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=vitb@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.