From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEA8C433EF for ; Thu, 28 Oct 2021 14:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A132761040 for ; Thu, 28 Oct 2021 14:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbhJ1PBg (ORCPT ); Thu, 28 Oct 2021 11:01:36 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52731 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbhJ1PBb (ORCPT ); Thu, 28 Oct 2021 11:01:31 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Msqty-1mvQnW0MtU-00tAYh; Thu, 28 Oct 2021 16:59:02 +0200 Received: by mail-wr1-f46.google.com with SMTP id d13so10704486wrf.11; Thu, 28 Oct 2021 07:59:01 -0700 (PDT) X-Gm-Message-State: AOAM532SwI6udJz6WZLv67lJt5mtcN2AsgaRV25SarliJ1L/wZrQ6Yn4 ksVXtEIsZGBcXLDYMHlOJbRowBHAn9lhxY8I2o8= X-Google-Smtp-Source: ABdhPJw1mral72Qddmd3GHMk122V+V5lr3a2+Rc1twCjQmgIEQujpYyDHdDkNkrUj9xJwnLyI7GiYnIxws+p/FRx9Gw= X-Received: by 2002:a05:6000:18c7:: with SMTP id w7mr6244203wrq.411.1635433141663; Thu, 28 Oct 2021 07:59:01 -0700 (PDT) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-14-lukas.bulwahn@gmail.com> In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com> From: Arnd Bergmann Date: Thu, 28 Oct 2021 16:58:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment To: Lukas Bulwahn Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , Linux ARM , OpenBMC Maillist , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:2/+7UmnatUJXWnHAJa13tySNx5MdO+XhZAMXq6vAd/7Y+XG6D4u ybcnF8mPiuEMkps4vtWF+fE4e7riUbjAUxLxCLMNAOhCxzfCCnMiabl6GKpdiSF19yoS1gb QlsXCiwd1rrGda4NriR5rPI00DdfMXjr23MD5WR/122DAJN8K0Rj0lJgXyVK7wOyWKP0M8/ F7jjCGHx2oJ9nFVkESDZw== X-UI-Out-Filterresults: notjunk:1;V03:K0:zDzVpMcYESQ=:jOLa73LwPcVO+JcvBiJ8FS cblIUIJM6ocecSP/RvJzcaP/Er2jA4kgOp+JKVzuAupJ/eh3fEhhpWFG3RuWxZ7tx/q2RpYxj fhMMLMFDY3WGXps7O0qcVVVHBgeeq3EGt+CBIwrIs5AXPKAdJhVuffzMJzIcTYAyjOdGhSn2l UjhI/0R1SB6JTE9McDOieSjBnk2mVcQg4Lp3ql8/Cf51KWIcGAdigqUguEW7U3V+aL5NYYzdL wJ/aDHVK8d36Wn7qliFujTBC+rb3FeRwXJxGjM2/l9hyP7QYh3H1gTALqYQAVFdcHMZ1hK5oe kXzGjfGVz+KbSeqJXzUEYEt2iawkZqER0m5AU/fAlPftdh+vIU8/qY5xapVTewFqKdGbyAiY3 IX6riq3mASjG3viQ03+hGrx+xLlxx6dlSU3bt3BMPzxj1SELQK69BE3XSo9E2zcW7566RURq3 z6b2pT8r34qkJAdRB0hCGCtR41m+aBbBX/7SQymJKxcV89plc6LeviHVdh2vLdjNQGT0g4v1G L6KUN+xpteuYlQoX2tdRBH2c5pLmArYmoeqDdGB/VyMyzBadbOkw+bzXo91GjOmBEnEtZbzSl 74jFv2Y4qTSycAPkYr6Z9Ji2jGbCvp6HJNzRGeOF+cGmGtynzCQ2H8xYWXJUkkenkji32ezqO mEjzH8X/y0t4J4OZdjOFPw6NUXVSTdDHfUwQWYIQQfGyqKu10pURjnBFb95gQDMOQoTrCilmr 920x3wOR9UDWQhOJy5CS91KutvkPWpZY1QrtOlL4USMdNkchlkLwY0eRQKaJMMpK5hoJ/WnDA iZa8QGTp+XjftlU5NeN2GX4fXso/9zJOxQPWfbTiL2KmXSFF4V3D/gBKQ+qko2d+8MokzMSj5 I8jGEKBRW/e6SMn9zLbWVu47hEAB8o1IQJk3xjmpbxSkUR2f7d1ijlgLs1XqvZc+0zDLxFAKn FqSXwLhXqzQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow > memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the > good practice to annotate the endif's with a comment to indicate the > corresponding ifdef condition. > > One comment annotation refers to CONFIG_LPAE, whereas the config is > actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably > tolerable for all human readers. > > However, the script ./scripts/checkkconfigsymbols.py, which checks the > kernel tree for references to non-existing Kconfig symbols, identifies and > reports that the reference to CONFIG_LPAE is invalid. > > The script ./scripts/checkkconfigsymbols.py has been quite useful to > identify a number of bugs with Kconfig symbols and deserves to be executed > and checked regularly. > > So, repair the comment to reduce the reports from this script and simplify > to use this script, as new issues are easier to spot when the list of > reports is shorter. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DD9C433EF for ; Thu, 28 Oct 2021 14:59:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8327561040 for ; Thu, 28 Oct 2021 14:59:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8327561040 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hg7xt6Pp8z3c59 for ; Fri, 29 Oct 2021 01:59:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=212.227.17.24; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hg7xP3szDz2xDr for ; Fri, 29 Oct 2021 01:59:04 +1100 (AEDT) Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MxUfn-1mrI3o4AaP-00xpWc for ; Thu, 28 Oct 2021 16:59:02 +0200 Received: by mail-wr1-f50.google.com with SMTP id m22so10817123wrb.0 for ; Thu, 28 Oct 2021 07:59:01 -0700 (PDT) X-Gm-Message-State: AOAM531YpTMNKfwnOKArk2Ev87bQfRN9wWDSMuRiuVgMGBi5NttM01B8 u8YjSS603VOrtM4IMFcst96n7Cx5ffuuiKQPRPU= X-Google-Smtp-Source: ABdhPJw1mral72Qddmd3GHMk122V+V5lr3a2+Rc1twCjQmgIEQujpYyDHdDkNkrUj9xJwnLyI7GiYnIxws+p/FRx9Gw= X-Received: by 2002:a05:6000:18c7:: with SMTP id w7mr6244203wrq.411.1635433141663; Thu, 28 Oct 2021 07:59:01 -0700 (PDT) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-14-lukas.bulwahn@gmail.com> In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com> From: Arnd Bergmann Date: Thu, 28 Oct 2021 16:58:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment To: Lukas Bulwahn Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:nOBSFF3duElTPGoVy0G+2HwQ6byia5zSxNNWM+/y8RzRHlL33dg VVphG+XwQvha/8z55HC2n+pznvSdX90r4Rb8gcI1q0wi4OfaaWxNnAeaL6v0PJYqjcYOBQR oIFo2yzM/O/611aCwbeiHzNMkxyVWlrSvPnHBwQ2L5rBMTTcmniwhQ9LNKLhOHbtxxywgcC LIHih5Pkc38fqaLEFTTfg== X-UI-Out-Filterresults: notjunk:1;V03:K0:PQMezIM4XZM=:mP0tfSOl/Zj6RyzKj/AMuN vxKlGWCedEGdmSnCxT6B5v+dyiO1jenw6PGFJdu7WViUTBR3uQT+cWCi26FZ/m2+ETVcAH0O4 DrYcsTtdRcJvOk7WYZ81cuh2GPZqq0RrqrDFGcFizhXuSlgddX67DXaSGSd/t8Mjswb3Isuq0 wY3o0aCK7dNyxcGIleIyNiPlQbvsa37pETOdfSGc8U5mz9UI0mz/dP+Z/nHWqaUaDHGmWQUXo lkCl60W9Pc2jIdA0j+IMKorvNW3mIxHk+ItyB5As9K87wQg1UMSESHA7/2Mp3VIzF7qUafbw/ gOFhW9sgrdGCM/yPk6/dtOunABE5Y6Ra4UmtuPswBzs9COCSui0s/O5vuXOJUU5Ijk89gPMc5 yYAbnNiPflpy6LvyHFXBIbfY61qlNjL6snJGsSyzijRXhbMfwmIoQ94MMgEM74WmahqAbRXp2 yEJd0YeVgp5+RzqwL/J3kiYbX37APwFePUd8z+5nAkTs/mrUoGmgt/GenF/HQhdXlyhO9Mjs8 gwvGQNDIKovcFwh5s2TUTJq6KGfgsWRORiG2FpIPs7mhgznagh5lxsPyaILxkgmNp4SQFtH3I T7IVOKCYUHN7OR1/ZNYHwUgaWp+3TfCe2zUKAbYOWDrmWrH5KH+6zPUnk7mDiOItCZfNRfzKp oDXtHrGctOqK7CAV6sGYdw6R+WuGA2FWJHzj1Or1l9N2S8MTMkSqy1M45IQx11UCnXYE+ehCM nS8PkjQo2hL7s/vKWcIAwi0QTfmNAgkFiOWgo8pY27RX9TcP+6ozkFpuShnt8EiDiuzr3MMsP GBhTbZF2dAZKdTVcU3w4ElVMAg4BojPGVmCbnyKiqqYIDtM+oHImKlnbQkegVXlpPWctak95Q P5eP2+DLbg3/Uxs7HDNO3k96O+c4iByYIkd5DHis5/LHOCMtenlprhxkXDK7yvzwRAgpnVumm 3CYIJ1udgyA== X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomer Maimon , kernel-janitors@vger.kernel.org, Tali Perry , Fabio Estevam , Benjamin Fair , OpenBMC Maillist , Russell King , Arnd Bergmann , Sekhar Nori , Sascha Hauer , Krzysztof Halasa , Linux ARM , Avi Fishman , Patrick Venture , Linus Walleij , Linux Kernel Mailing List , Dinh Nguyen , Pengutronix Kernel Team , Imre Kaloz , Shawn Guo , Bartosz Golaszewski Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow > memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the > good practice to annotate the endif's with a comment to indicate the > corresponding ifdef condition. > > One comment annotation refers to CONFIG_LPAE, whereas the config is > actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably > tolerable for all human readers. > > However, the script ./scripts/checkkconfigsymbols.py, which checks the > kernel tree for references to non-existing Kconfig symbols, identifies and > reports that the reference to CONFIG_LPAE is invalid. > > The script ./scripts/checkkconfigsymbols.py has been quite useful to > identify a number of bugs with Kconfig symbols and deserves to be executed > and checked regularly. > > So, repair the comment to reduce the reports from this script and simplify > to use this script, as new issues are easier to spot when the list of > reports is shorter. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973A9C433EF for ; Thu, 28 Oct 2021 15:01:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C1AE61040 for ; Thu, 28 Oct 2021 15:01:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C1AE61040 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vTNAQa7ArBvBmIIqEx1g3EjXxEq7h8KWAFiPblQ4vjo=; b=hLzsEYlCJHb932 f3flIs7eLpqje8MOc9vWPX6gbgC51R8BD/1mQW02j9H6z49Be/VJ5qZdlTDyDvRsqRg6oyYV1Pyio bjva4kOwFdggOemxBtIKNmH/m36ZQ8b3l7qa/lL1zTCBpWxYfefXP4SqjXeJ0N+SBKLVdOzLYqIDd r+BanIIjHb2bdRGxykRte+iqA+BAOWPP99uY6/lc6Hz4eJS8cOxmVwXnnfQ0h1iKGWCxzkVqzDvhs Zsohf1iZmFXQpPrcPQMe1jGJT2B41/RuomrlzCF/2s3WD8NVvzWI0oHtZvLlZEJQQ+bwaYEhHuN16 T0RLLc/XWAkzmxDitWFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg6sW-008Kc9-P4; Thu, 28 Oct 2021 14:59:41 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg6rv-008KKl-Mg for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 14:59:05 +0000 Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MvJjz-1mxupo42aX-00rFWN for ; Thu, 28 Oct 2021 16:59:02 +0200 Received: by mail-wr1-f50.google.com with SMTP id z14so10729243wrg.6 for ; Thu, 28 Oct 2021 07:59:01 -0700 (PDT) X-Gm-Message-State: AOAM531p7lIOyARnSwAsQfjAEYmy7rTB/QDYo4oIeP+XmnJ8cT9Lbpic AV0flGwfMcLddCcHBpfh+/DAr1SpfFEzJycstsw= X-Google-Smtp-Source: ABdhPJw1mral72Qddmd3GHMk122V+V5lr3a2+Rc1twCjQmgIEQujpYyDHdDkNkrUj9xJwnLyI7GiYnIxws+p/FRx9Gw= X-Received: by 2002:a05:6000:18c7:: with SMTP id w7mr6244203wrq.411.1635433141663; Thu, 28 Oct 2021 07:59:01 -0700 (PDT) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-14-lukas.bulwahn@gmail.com> In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com> From: Arnd Bergmann Date: Thu, 28 Oct 2021 16:58:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment To: Lukas Bulwahn Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , Linux ARM , OpenBMC Maillist , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List X-Provags-ID: V03:K1:bhifbICt3C/AXV5xXbGVOmAa7NTVVcK7bUco0hVamDR0/x76Bb5 rpvE5Ws8ibBfJSY1JdsGPZdQGNE1mpinyYhnZuIVrkqqJ1npi5xq6MEH5bBaj7/YvYzsjdy bTZiyRBID0BwP/9BdM8qt0iRl/Vr7ADKlFmZQTrAqb8GcTaUOzUQUOC4hqfGoKV1ARTwDiA UI5/YN0bkk+2CMTL9sb7A== X-UI-Out-Filterresults: notjunk:1;V03:K0:6MhejEmNin4=:vFnwY1Coq8h7UkpxbjijCY FOT5sM86IZuUIn9vZgUv0DXXPrgyAx3nZVhdFqbS2LSPMeVkJaxvJppSDrjwqFBwQMz0EJ5ov 7pJrzkVKUfm7mWUUP6iCRmqQADT7p0LlBFiZEqHObW2PYwTqLt1Y0uv93W+KXwjhPdtKr4Iey 9Fm/+XHl11qWU/tztewpinuRWS1IzkwHzhbdxkBuxOTBH+6wuA4OvTzImwW6W4qcPJzolOJjm T40N7nvJgw4EpHTyF3CedRVbmLlCZQHlHy+mjV9ehNq/4sjaRuO6QDQfpmUmILExeGwjW7Umv qOgpte/yMNPiQLxo/ECUfRgugbvCCOqSGWr1NvLF6HUO0JnE2Agw4sMbcqhez+sz9JM6gKDxq FQfyaLi7fJj+MUWOUWVP3yn0C8h6dALSjtPZCUBZGS0llfUWn9FnToF2Of5wqEwCbEZujHdu5 CP86rgCV6Mx/qsZz6fVpAi/med8QyzBzhOvbjpPU6Gq44p+9gt3ExZGDcEVx/716w+u9xJURd n7IJI+dD0T/dO6y0t3JXeC28pNlFhyarsnAZhU/ge8sWUadVPEwlWeRa2BKmZKpaKjeiZMGSM LvS8ndj3WxpsYgXhU723h4iYyhomFctLhpC8B7D/g2Y/HcFWJ3NEzZVN4dgidXPK6OQ3DhEFm lsL5tiqVsnGUpO1D7tvCd+krAN9oYcryTU8HMThaMqWy0YML/BdiSztxPwnG9ICe18VjZFL+C u5ljhNecV6b7UICVb0faYqWa4TkToHVpp4ZrG0AjghcaKEmw2DNGqmnjDs3Laj89lzP4E4fSa BNTEcGZ0YV7LBK+QADPkMsIsttC8QgEcnCV5U1w7Zh/FyJFCl0+Gf2mjCwjYkZaSuZGw6tN58 V5gzNvjaz+MoBTwRwQL7ro2AwoZt5gUKYOClxCN0u/8Q5+vOv//gFKY7y6/dVkfvqiB4n2CxF +Mkf90tDFXA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_075904_074827_A7F7E5B6 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow > memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the > good practice to annotate the endif's with a comment to indicate the > corresponding ifdef condition. > > One comment annotation refers to CONFIG_LPAE, whereas the config is > actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably > tolerable for all human readers. > > However, the script ./scripts/checkkconfigsymbols.py, which checks the > kernel tree for references to non-existing Kconfig symbols, identifies and > reports that the reference to CONFIG_LPAE is invalid. > > The script ./scripts/checkkconfigsymbols.py has been quite useful to > identify a number of bugs with Kconfig symbols and deserves to be executed > and checked regularly. > > So, repair the comment to reduce the reports from this script and simplify > to use this script, as new issues are easier to spot when the list of > reports is shorter. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel