From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EF8C433ED for ; Wed, 7 Apr 2021 17:55:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) id AB2FC6138B; Wed, 7 Apr 2021 17:55:37 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06E386128D; Wed, 7 Apr 2021 17:55:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06E386128D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=arnd@arndb.de Received: from mail-ot1-f54.google.com ([209.85.210.54]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MIxFi-1lAt8H0GXC-00KRQL; Wed, 07 Apr 2021 19:55:35 +0200 Received: by mail-ot1-f54.google.com with SMTP id v24-20020a9d69d80000b02901b9aec33371so18952232oto.2; Wed, 07 Apr 2021 10:55:34 -0700 (PDT) X-Gm-Message-State: AOAM5308nNqAClCqMzfw2rEmQJw3cOv279h54nonxNZXepkG9wc3ExBB Gsin5usGI4lQ04dlTePHINDdBQSd1bUNP+FleP0= X-Google-Smtp-Source: ABdhPJzFae5o2sDZdv1GTYiLdAFDJ0G3fZf1iRlU0eP5yGtTc46bhdPOIwOQIpCMXbLmu9KXnz8t04DTE8yeXQij0sE= X-Received: by 2002:a9d:316:: with SMTP id 22mr3925495otv.210.1617818133281; Wed, 07 Apr 2021 10:55:33 -0700 (PDT) MIME-Version: 1.0 References: <22814673-e9fe-f65b-cc0f-b02be4f90d1a@gmail.com> <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> In-Reply-To: <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> From: Arnd Bergmann Date: Wed, 7 Apr 2021 19:55:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] arm64: dts: mediatek: changes for v5.13 (second round) To: Matthias Brugger List-Id: Cc: SoC Team , arm-soc , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Fabien Parent , Irui Wang , Rob Herring , DTML , Chun-Kuang Hu Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:6aeBsoBsj4SZqDZrql5XuRTimHp0XyWC9QFhQuQiFTc58RkE3jz Gt1v6vu0PBa4aLMujEskCwrFQJHqQOv7uLUuuWdkCqoJ1c08XmdSZZ+ZQAmIZG+AzB0x7eG pTT+9yBQuYqME0o6dJkQpunhsqUQEpSkcKoIR3MxzmVQwQns0dj+Tg95WCqW2Vlh/JFWaam plGgDBgQIJItXXH2APrfg== X-UI-Out-Filterresults: notjunk:1;V03:K0:3gYn3ytXC1M=:UPRchqKc1fWnr8wCOarTsT VFZLKPUjr7qYu9DUFrmZX/gzmZ/J52NP6tEEKvdhHJntHeMDdeQWH/X7qfeRgigymjFOk0PDd Pn9gyP2P1f9Ub5Pq4Jwl07kfe2/QVi48Hym7eMXn+lA+KRnysjBob9xvgHCC+pfj14N5psZIy YitsJZXzhfYC3AZb4zFsiKQN6GCLhwzRqlDuv17A1AlSzhgEdv1GxziE8G0O22WkZ3jFwIqKN oVmbbWLlaroVyN/Nm9ssc2QSf/cO4ZCYo5UwNMB3/S7CFHs84xBOy7qegXO/A9al79NyLtbXh ofpz6EduLUPHGqwxLRLj7cKKHyHLDDRnIycHsBPtpmKgSLQwDQPOEAYSmJfcpJtraaTv1l4P7 Gv8S3cyH++mw9QBRxKAJ/kVYObAFEN7gqNLE3HrvvggR4Q1RJ4p8Q5dpMIRYcQYHNDRaNdDYQ 73yKnaCB4VrtBUdZwP06aYMv7chToVQ= On Wed, Apr 7, 2021 at 6:34 PM Matthias Brugger wrote: > On 07/04/2021 18:06, Arnd Bergmann wrote: > > On Wed, Apr 7, 2021 at 1:00 PM Matthias Brugger wrote: > >> > >> Hi Olof and Arnd, > >> > >> Here comes the second round of arm64 DT patches. Hope I'm not too late. > >> Basically we add several node to MT8167. > >> ---------------------------------------------------------------- > >> Fabien Parent (6): > > > >> arm64: dts: mediatek: mt8167: add some DRM nodes > > > > I stumbled over this patch adding a lot of aliases: > > > > + aliases { > > + aal0 = &aal; > > + ccorr0 = &ccorr; > > + color0 = &color; > > + dither0 = &dither; > > + dsi0 = &dsi; > > + ovl0 = &ovl0; > > + pwm0 = &disp_pwm; > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > + wdma0 = &wdma; > > + }; > > > > > > Something doesn't quite feel right about this, and I checked with Rob, > > who also thinks this looks wrong. I suppose we need to have a set of > > well documented alias types rather than just having drivers make up > > new ones on the spot. > > These are needed in the DRM driver, see drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > I added Chun-Kuang who is the maintainer of the driver. I think it's a good idea > to have this alias described in the binding. Maybe a good excuse to move to yaml > as well :) The aliases certainly need to be described in the binding, I think someone would likely have complained earlier if that was part of the binding. Moving it to yaml is also a good idea, and required for any new devices. > > I also noticed that some of the referenced nodes are missing a DT > > binding file, so those need to be added and reviewed as well. > > I suppose you are talking about "mediatek,mt8173-vcodec-enc-vp8". The binding > patches are in the media tree [1]. Maybe I supposed wrongly that they will land > in v5.13? Or perhaps I should have mentioned that in the pull request. > > If it wasn't about this compatible and you can still remember, please let me > know so that we can fix that :) > > I double checked and didn't find any missing binding. Some of them only have the > fallback binding described, maybe that's what you are referring to. Here is what I see for all compatible strings of the added device nodes in this patch, as of linux-next-20210407: $ for i in mediatek,mt8167-disp-mutex mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-pwm mediatek,mt8173-disp-pwn mediatek,mt8167-dsi mediatek,mt2701-dsi mediatek,mt8167-mipi-tx mediatek,mt2701-mipi-tx mediatek,mt8167-disp-ovl mediatek,mt8173-disp-ovl mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-color mediatek,mt8173-disp-color mediatek,mt8167-disp-ccorr mediatek,mt8183-disp-ccorr mediatek,mt8167-disp-aal mediatek,mt8167-disp-gamma mediatek,mt8173-disp-gamma mediatek,mt8167-disp-dither mediatek,mt8167-disp-wdma ; do echo === $i ; git grep -wl $i Documentation/devicetree/ ; done === mediatek,mt8167-disp-mutex === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-pwm Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt === mediatek,mt8173-disp-pwn === mediatek,mt8167-dsi === mediatek,mt2701-dsi === mediatek,mt8167-mipi-tx === mediatek,mt2701-mipi-tx Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml === mediatek,mt8167-disp-ovl === mediatek,mt8173-disp-ovl Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-color === mediatek,mt8173-disp-color Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-ccorr === mediatek,mt8183-disp-ccorr === mediatek,mt8167-disp-aal === mediatek,mt8167-disp-gamma === mediatek,mt8173-disp-gamma Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-dither === mediatek,mt8167-disp-wdma So five of the strings are documented, the others are missing. I did not check the other patches in your branch. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B47EC433B4 for ; Wed, 7 Apr 2021 17:55:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33FC061363 for ; Wed, 7 Apr 2021 17:55:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236222AbhDGRzr (ORCPT ); Wed, 7 Apr 2021 13:55:47 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:34847 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354987AbhDGRzp (ORCPT ); Wed, 7 Apr 2021 13:55:45 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mn2eH-1ltbX72Mch-00k95U for ; Wed, 07 Apr 2021 19:55:34 +0200 Received: by mail-ot1-f43.google.com with SMTP id w31-20020a9d36220000b02901f2cbfc9743so18899069otb.7 for ; Wed, 07 Apr 2021 10:55:34 -0700 (PDT) X-Gm-Message-State: AOAM530YHz/N6RT9KdHKjwa4cG1uf0VPZcxy9Yf/Bybmf7PQ39Pv8nKu s7hnfWLvQ78okjjbC34Eiec4wl1wasW70qC9iqk= X-Google-Smtp-Source: ABdhPJzFae5o2sDZdv1GTYiLdAFDJ0G3fZf1iRlU0eP5yGtTc46bhdPOIwOQIpCMXbLmu9KXnz8t04DTE8yeXQij0sE= X-Received: by 2002:a9d:316:: with SMTP id 22mr3925495otv.210.1617818133281; Wed, 07 Apr 2021 10:55:33 -0700 (PDT) MIME-Version: 1.0 References: <22814673-e9fe-f65b-cc0f-b02be4f90d1a@gmail.com> <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> In-Reply-To: <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> From: Arnd Bergmann Date: Wed, 7 Apr 2021 19:55:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] arm64: dts: mediatek: changes for v5.13 (second round) To: Matthias Brugger List-Id: Cc: SoC Team , arm-soc , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Fabien Parent , Irui Wang , Rob Herring , DTML , Chun-Kuang Hu Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:XWWkTaLhr/k2PYPonNnO7WuVuXePoKBfHGV16xPW0SI58jtM/Pq 3AaAadA5vCSVCZUsvULFzgWDWazC35dtIqmJTzYMdW5w+mv2Ii2Te+UybM2XPY/WBBAkwgT NFGFQXBjyjqkDLzWXv3X5cFTCcz1vQglmlW8/uRGqU5chsbuxWMKGCuwZYrmsD0bRPmtp4B csQEiPrxDRrhJTbiKcOAQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:aXeHEdam0IQ=:0z1h6N5Yj8q4dc1hB2lygY 8XzDOb/PuZ//UG4UF+gYDs/Khw3UdaqrU4Ifvpq2MsvRTNP3yckzbIesK1Zda8t8DIJtcYY3U eA6aDu1dENjotCl70BJZ9JmUsBfOuSKXIgGdoNYCreO1z5LWrVkwbYUCg/cQXf13urJR9aDSY qnbTo26ZXLume/oTQunHW2+rq5xAXyNMgsdrg+R7vnvPeBo6jqbbMR5LL3TxHl8dLGRgPTEfh bMay4xIEPZjj7rd3D/6RdyKgSx0tnzpGjykbMZjiaRc0QodvLDKt8hdkZrNW0CoMTZBcI3v5F TehiTWsvRkzrym/+tJWsIbkvzCIBpSWhaBKrnIdPsq6u4DdXB7m3Q99f3SxO6A0OrOMQvgbp0 jK8vUOrgAclMheYRar2wbg496XT8P6HBXJmRGIEffD4kWivqsz/Ifc5ssxvSKGVEMZsTphrav POCgzB2c/zaTo0XSxkffy9xrB/DdvSs= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Message-ID: <20210407175517.4_P2I_hedLPOZZbnMqX2TAwJdGv1xrojaI8M9qj9ncY@z> On Wed, Apr 7, 2021 at 6:34 PM Matthias Brugger wrote: > On 07/04/2021 18:06, Arnd Bergmann wrote: > > On Wed, Apr 7, 2021 at 1:00 PM Matthias Brugger wrote: > >> > >> Hi Olof and Arnd, > >> > >> Here comes the second round of arm64 DT patches. Hope I'm not too late. > >> Basically we add several node to MT8167. > >> ---------------------------------------------------------------- > >> Fabien Parent (6): > > > >> arm64: dts: mediatek: mt8167: add some DRM nodes > > > > I stumbled over this patch adding a lot of aliases: > > > > + aliases { > > + aal0 = &aal; > > + ccorr0 = &ccorr; > > + color0 = &color; > > + dither0 = &dither; > > + dsi0 = &dsi; > > + ovl0 = &ovl0; > > + pwm0 = &disp_pwm; > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > + wdma0 = &wdma; > > + }; > > > > > > Something doesn't quite feel right about this, and I checked with Rob, > > who also thinks this looks wrong. I suppose we need to have a set of > > well documented alias types rather than just having drivers make up > > new ones on the spot. > > These are needed in the DRM driver, see drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > I added Chun-Kuang who is the maintainer of the driver. I think it's a good idea > to have this alias described in the binding. Maybe a good excuse to move to yaml > as well :) The aliases certainly need to be described in the binding, I think someone would likely have complained earlier if that was part of the binding. Moving it to yaml is also a good idea, and required for any new devices. > > I also noticed that some of the referenced nodes are missing a DT > > binding file, so those need to be added and reviewed as well. > > I suppose you are talking about "mediatek,mt8173-vcodec-enc-vp8". The binding > patches are in the media tree [1]. Maybe I supposed wrongly that they will land > in v5.13? Or perhaps I should have mentioned that in the pull request. > > If it wasn't about this compatible and you can still remember, please let me > know so that we can fix that :) > > I double checked and didn't find any missing binding. Some of them only have the > fallback binding described, maybe that's what you are referring to. Here is what I see for all compatible strings of the added device nodes in this patch, as of linux-next-20210407: $ for i in mediatek,mt8167-disp-mutex mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-pwm mediatek,mt8173-disp-pwn mediatek,mt8167-dsi mediatek,mt2701-dsi mediatek,mt8167-mipi-tx mediatek,mt2701-mipi-tx mediatek,mt8167-disp-ovl mediatek,mt8173-disp-ovl mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-color mediatek,mt8173-disp-color mediatek,mt8167-disp-ccorr mediatek,mt8183-disp-ccorr mediatek,mt8167-disp-aal mediatek,mt8167-disp-gamma mediatek,mt8173-disp-gamma mediatek,mt8167-disp-dither mediatek,mt8167-disp-wdma ; do echo === $i ; git grep -wl $i Documentation/devicetree/ ; done === mediatek,mt8167-disp-mutex === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-pwm Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt === mediatek,mt8173-disp-pwn === mediatek,mt8167-dsi === mediatek,mt2701-dsi === mediatek,mt8167-mipi-tx === mediatek,mt2701-mipi-tx Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml === mediatek,mt8167-disp-ovl === mediatek,mt8173-disp-ovl Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-color === mediatek,mt8173-disp-color Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-ccorr === mediatek,mt8183-disp-ccorr === mediatek,mt8167-disp-aal === mediatek,mt8167-disp-gamma === mediatek,mt8173-disp-gamma Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-dither === mediatek,mt8167-disp-wdma So five of the strings are documented, the others are missing. I did not check the other patches in your branch. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31962C433B4 for ; Wed, 7 Apr 2021 17:55:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B952D6128D for ; Wed, 7 Apr 2021 17:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B952D6128D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8KoA6hkEjgWQJzfdAuaG1bv5iumRcBVpjYF/7tABa84=; b=WVtmgcN7THbIl7pt7NQTuEU7p DiketHSFgm/18J4GheXvXn99liATmWOvSh3fYKqjISpaJGqXlVZWasiMQu/evjxswHfGaCzOxKdwR yYW3LpFad4VeHqXC0jURIn+mmEAx74Arkgu7pQvokH8RMUH8Lkeir1dnQ+e64wMJx9m3hbflkbyS5 EFng1L2JgvG4Gl6oVwI3WrIhRwsU2lWAfAaHN6hp59Gh8VBrgxb1kZblnTRT0E7iMVjlr5JraPrys t4kB6GUp8RKhCpF+cbssa7p24j7DT9+fCFBv0hZ0WFTireP/JM1j6Qy/caf0HY3GTK7rN/+tYyJQ7 ei1Omyiqg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUCP3-005h7b-DX; Wed, 07 Apr 2021 17:55:45 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUCOv-005h6r-Ve; Wed, 07 Apr 2021 17:55:39 +0000 Received: from mail-ot1-f53.google.com ([209.85.210.53]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MCXhr-1lLdh73AP5-009hCj; Wed, 07 Apr 2021 19:55:35 +0200 Received: by mail-ot1-f53.google.com with SMTP id w21-20020a9d63950000b02901ce7b8c45b4so18898971otk.5; Wed, 07 Apr 2021 10:55:34 -0700 (PDT) X-Gm-Message-State: AOAM533RUv5ZqXp78Bkti1xvFSAxkyVHHs4sITm9HHTkVDkDpTmuXXos Dw/f1RYTs/KPkSXTy5gAdzxdSmOVEWwYaawqFfI= X-Google-Smtp-Source: ABdhPJzFae5o2sDZdv1GTYiLdAFDJ0G3fZf1iRlU0eP5yGtTc46bhdPOIwOQIpCMXbLmu9KXnz8t04DTE8yeXQij0sE= X-Received: by 2002:a9d:316:: with SMTP id 22mr3925495otv.210.1617818133281; Wed, 07 Apr 2021 10:55:33 -0700 (PDT) MIME-Version: 1.0 References: <22814673-e9fe-f65b-cc0f-b02be4f90d1a@gmail.com> <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> In-Reply-To: <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> From: Arnd Bergmann Date: Wed, 7 Apr 2021 19:55:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] arm64: dts: mediatek: changes for v5.13 (second round) To: Matthias Brugger List-Id: Cc: SoC Team , arm-soc , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Fabien Parent , Irui Wang , Rob Herring , DTML , Chun-Kuang Hu X-Provags-ID: V03:K1:SbY1cRD1lpqjZrXT9mOUTzVzmPjA/Z21EcqTRF5gXQr54BrPLcx BD3UD3SsBDeF33MyPhT90W9vl1gL5JO0Bg5GhzmbtRXQzXlkDqfS6SkLpDTFjERF2sNDwhL gbhnGeu6BIYjDo91Y5wO2uf8fLKZs4x5O2zKLrEpR1HlBdamAP++DwcPYen4AfJ3FjHKpIh wAHE5PH0b0b9d3VK+yPLQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:bSoGLQBZCew=:DaxU9mJb6kgANQyNLHgoF5 cCJXF3acdv4z2rNW/2WIUjLiyi7A1pw3v/2V9CrUPxD6xwGZeuaPnN4M/x40oThgXkOV/aCER GQC48X9cgyUkpaFZTsEA30tUk28wAHK//G8P+HaRoygwQdj3MiymCAtD2KIYZ+MTFi+HHWMFF tHsC80awQlEV/GF8mdaLstY8r91gDsXCMmeb1qdiTUkLMLqNq+2BKae5VNky4fSBByx+t8Rye gJ1clH/7e+75hxbvHehtRIgv5g4MvMmiJ/zssROaHVAWoGO5S9jIcuHW/fAsPA9OPbf2ij4VU suwwd0dFSXHYeIq3fXr/PjBq7RIT21ct6YK3AM1FPrlrlX0b8RcVSosB1kvS3RWPqIqJM//NC U6BANIAGP0IL0zL1mUYPxYSsjzyplx5vHf9fl6a7nYGBNH0QtiIVnm39dHurwbqrfKIcvuJPZ Jitask2G2cizztCSU1MBJtW1GOzPLPU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_185538_148312_97A1E9FE X-CRM114-Status: GOOD ( 29.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Message-ID: <20210407175517.uIrX5-l2qbOyClquMCeLkRCTAXJR-TyxEVNdPJjm5Iw@z> On Wed, Apr 7, 2021 at 6:34 PM Matthias Brugger wrote: > On 07/04/2021 18:06, Arnd Bergmann wrote: > > On Wed, Apr 7, 2021 at 1:00 PM Matthias Brugger wrote: > >> > >> Hi Olof and Arnd, > >> > >> Here comes the second round of arm64 DT patches. Hope I'm not too late. > >> Basically we add several node to MT8167. > >> ---------------------------------------------------------------- > >> Fabien Parent (6): > > > >> arm64: dts: mediatek: mt8167: add some DRM nodes > > > > I stumbled over this patch adding a lot of aliases: > > > > + aliases { > > + aal0 = &aal; > > + ccorr0 = &ccorr; > > + color0 = &color; > > + dither0 = &dither; > > + dsi0 = &dsi; > > + ovl0 = &ovl0; > > + pwm0 = &disp_pwm; > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > + wdma0 = &wdma; > > + }; > > > > > > Something doesn't quite feel right about this, and I checked with Rob, > > who also thinks this looks wrong. I suppose we need to have a set of > > well documented alias types rather than just having drivers make up > > new ones on the spot. > > These are needed in the DRM driver, see drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > I added Chun-Kuang who is the maintainer of the driver. I think it's a good idea > to have this alias described in the binding. Maybe a good excuse to move to yaml > as well :) The aliases certainly need to be described in the binding, I think someone would likely have complained earlier if that was part of the binding. Moving it to yaml is also a good idea, and required for any new devices. > > I also noticed that some of the referenced nodes are missing a DT > > binding file, so those need to be added and reviewed as well. > > I suppose you are talking about "mediatek,mt8173-vcodec-enc-vp8". The binding > patches are in the media tree [1]. Maybe I supposed wrongly that they will land > in v5.13? Or perhaps I should have mentioned that in the pull request. > > If it wasn't about this compatible and you can still remember, please let me > know so that we can fix that :) > > I double checked and didn't find any missing binding. Some of them only have the > fallback binding described, maybe that's what you are referring to. Here is what I see for all compatible strings of the added device nodes in this patch, as of linux-next-20210407: $ for i in mediatek,mt8167-disp-mutex mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-pwm mediatek,mt8173-disp-pwn mediatek,mt8167-dsi mediatek,mt2701-dsi mediatek,mt8167-mipi-tx mediatek,mt2701-mipi-tx mediatek,mt8167-disp-ovl mediatek,mt8173-disp-ovl mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-color mediatek,mt8173-disp-color mediatek,mt8167-disp-ccorr mediatek,mt8183-disp-ccorr mediatek,mt8167-disp-aal mediatek,mt8167-disp-gamma mediatek,mt8173-disp-gamma mediatek,mt8167-disp-dither mediatek,mt8167-disp-wdma ; do echo === $i ; git grep -wl $i Documentation/devicetree/ ; done === mediatek,mt8167-disp-mutex === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-pwm Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt === mediatek,mt8173-disp-pwn === mediatek,mt8167-dsi === mediatek,mt2701-dsi === mediatek,mt8167-mipi-tx === mediatek,mt2701-mipi-tx Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml === mediatek,mt8167-disp-ovl === mediatek,mt8173-disp-ovl Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-color === mediatek,mt8173-disp-color Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-ccorr === mediatek,mt8183-disp-ccorr === mediatek,mt8167-disp-aal === mediatek,mt8167-disp-gamma === mediatek,mt8173-disp-gamma Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-dither === mediatek,mt8167-disp-wdma So five of the strings are documented, the others are missing. I did not check the other patches in your branch. Arnd _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C2BC433B4 for ; Wed, 7 Apr 2021 17:57:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BF136128A for ; Wed, 7 Apr 2021 17:57:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BF136128A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VwrCTiDJAp1RwtBY1+Ifb1BlYYZZiS6NVSs/20zUh9M=; b=cRWGND6dm166h7GOGhfBsc67y zuotbieLOphRdLrcKJYef3qYtuopNg/kBlFsuGh8VIbd5Qnq81xrcdpsvqO2D+RBIVrEruHyB5ND5 LYpkj7szt1xy0lhtc4kEFDRp2I7wEHxJUQC7IXxuwGVXAbRv65vZl5LF3uGA8sBkhcR8RdJwk3bkF 4v+Idn7GSr6RSk9U35m8CkhBhKa0m38kNRE/boDDncfXORGJ6MKh16xtCqdzE8hwVYeV35rg0S/XG yq/3IQgvVdFEsiM7hjcPMgH4E5q+9X/sYrwGi2vb1BV+voTIiDBKKmoHt3c54FYp1b+KtEpCdR41U IQaqqToEA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUCP4-005h7m-Lp; Wed, 07 Apr 2021 17:55:46 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUCOv-005h6r-Ve; Wed, 07 Apr 2021 17:55:39 +0000 Received: from mail-ot1-f53.google.com ([209.85.210.53]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MCXhr-1lLdh73AP5-009hCj; Wed, 07 Apr 2021 19:55:35 +0200 Received: by mail-ot1-f53.google.com with SMTP id w21-20020a9d63950000b02901ce7b8c45b4so18898971otk.5; Wed, 07 Apr 2021 10:55:34 -0700 (PDT) X-Gm-Message-State: AOAM533RUv5ZqXp78Bkti1xvFSAxkyVHHs4sITm9HHTkVDkDpTmuXXos Dw/f1RYTs/KPkSXTy5gAdzxdSmOVEWwYaawqFfI= X-Google-Smtp-Source: ABdhPJzFae5o2sDZdv1GTYiLdAFDJ0G3fZf1iRlU0eP5yGtTc46bhdPOIwOQIpCMXbLmu9KXnz8t04DTE8yeXQij0sE= X-Received: by 2002:a9d:316:: with SMTP id 22mr3925495otv.210.1617818133281; Wed, 07 Apr 2021 10:55:33 -0700 (PDT) MIME-Version: 1.0 References: <22814673-e9fe-f65b-cc0f-b02be4f90d1a@gmail.com> <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> In-Reply-To: <01c82108-64a8-33ee-3984-5bd7056a0002@gmail.com> From: Arnd Bergmann Date: Wed, 7 Apr 2021 19:55:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] arm64: dts: mediatek: changes for v5.13 (second round) To: Matthias Brugger List-Id: Cc: SoC Team , arm-soc , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Fabien Parent , Irui Wang , Rob Herring , DTML , Chun-Kuang Hu X-Provags-ID: V03:K1:SbY1cRD1lpqjZrXT9mOUTzVzmPjA/Z21EcqTRF5gXQr54BrPLcx BD3UD3SsBDeF33MyPhT90W9vl1gL5JO0Bg5GhzmbtRXQzXlkDqfS6SkLpDTFjERF2sNDwhL gbhnGeu6BIYjDo91Y5wO2uf8fLKZs4x5O2zKLrEpR1HlBdamAP++DwcPYen4AfJ3FjHKpIh wAHE5PH0b0b9d3VK+yPLQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:bSoGLQBZCew=:DaxU9mJb6kgANQyNLHgoF5 cCJXF3acdv4z2rNW/2WIUjLiyi7A1pw3v/2V9CrUPxD6xwGZeuaPnN4M/x40oThgXkOV/aCER GQC48X9cgyUkpaFZTsEA30tUk28wAHK//G8P+HaRoygwQdj3MiymCAtD2KIYZ+MTFi+HHWMFF tHsC80awQlEV/GF8mdaLstY8r91gDsXCMmeb1qdiTUkLMLqNq+2BKae5VNky4fSBByx+t8Rye gJ1clH/7e+75hxbvHehtRIgv5g4MvMmiJ/zssROaHVAWoGO5S9jIcuHW/fAsPA9OPbf2ij4VU suwwd0dFSXHYeIq3fXr/PjBq7RIT21ct6YK3AM1FPrlrlX0b8RcVSosB1kvS3RWPqIqJM//NC U6BANIAGP0IL0zL1mUYPxYSsjzyplx5vHf9fl6a7nYGBNH0QtiIVnm39dHurwbqrfKIcvuJPZ Jitask2G2cizztCSU1MBJtW1GOzPLPU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_185538_148312_97A1E9FE X-CRM114-Status: GOOD ( 29.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20210407175517.KYUjTyKAC4mZsHhRdVbR5TOtloKBlzbO0vbWboueVPw@z> On Wed, Apr 7, 2021 at 6:34 PM Matthias Brugger wrote: > On 07/04/2021 18:06, Arnd Bergmann wrote: > > On Wed, Apr 7, 2021 at 1:00 PM Matthias Brugger wrote: > >> > >> Hi Olof and Arnd, > >> > >> Here comes the second round of arm64 DT patches. Hope I'm not too late. > >> Basically we add several node to MT8167. > >> ---------------------------------------------------------------- > >> Fabien Parent (6): > > > >> arm64: dts: mediatek: mt8167: add some DRM nodes > > > > I stumbled over this patch adding a lot of aliases: > > > > + aliases { > > + aal0 = &aal; > > + ccorr0 = &ccorr; > > + color0 = &color; > > + dither0 = &dither; > > + dsi0 = &dsi; > > + ovl0 = &ovl0; > > + pwm0 = &disp_pwm; > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > + wdma0 = &wdma; > > + }; > > > > > > Something doesn't quite feel right about this, and I checked with Rob, > > who also thinks this looks wrong. I suppose we need to have a set of > > well documented alias types rather than just having drivers make up > > new ones on the spot. > > These are needed in the DRM driver, see drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > I added Chun-Kuang who is the maintainer of the driver. I think it's a good idea > to have this alias described in the binding. Maybe a good excuse to move to yaml > as well :) The aliases certainly need to be described in the binding, I think someone would likely have complained earlier if that was part of the binding. Moving it to yaml is also a good idea, and required for any new devices. > > I also noticed that some of the referenced nodes are missing a DT > > binding file, so those need to be added and reviewed as well. > > I suppose you are talking about "mediatek,mt8173-vcodec-enc-vp8". The binding > patches are in the media tree [1]. Maybe I supposed wrongly that they will land > in v5.13? Or perhaps I should have mentioned that in the pull request. > > If it wasn't about this compatible and you can still remember, please let me > know so that we can fix that :) > > I double checked and didn't find any missing binding. Some of them only have the > fallback binding described, maybe that's what you are referring to. Here is what I see for all compatible strings of the added device nodes in this patch, as of linux-next-20210407: $ for i in mediatek,mt8167-disp-mutex mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-pwm mediatek,mt8173-disp-pwn mediatek,mt8167-dsi mediatek,mt2701-dsi mediatek,mt8167-mipi-tx mediatek,mt2701-mipi-tx mediatek,mt8167-disp-ovl mediatek,mt8173-disp-ovl mediatek,mt8167-disp-rdma mediatek,mt2701-disp-rdma mediatek,mt8167-disp-color mediatek,mt8173-disp-color mediatek,mt8167-disp-ccorr mediatek,mt8183-disp-ccorr mediatek,mt8167-disp-aal mediatek,mt8167-disp-gamma mediatek,mt8173-disp-gamma mediatek,mt8167-disp-dither mediatek,mt8167-disp-wdma ; do echo === $i ; git grep -wl $i Documentation/devicetree/ ; done === mediatek,mt8167-disp-mutex === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-pwm Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt === mediatek,mt8173-disp-pwn === mediatek,mt8167-dsi === mediatek,mt2701-dsi === mediatek,mt8167-mipi-tx === mediatek,mt2701-mipi-tx Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml === mediatek,mt8167-disp-ovl === mediatek,mt8173-disp-ovl Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-rdma === mediatek,mt2701-disp-rdma === mediatek,mt8167-disp-color === mediatek,mt8173-disp-color Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-ccorr === mediatek,mt8183-disp-ccorr === mediatek,mt8167-disp-aal === mediatek,mt8167-disp-gamma === mediatek,mt8173-disp-gamma Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt === mediatek,mt8167-disp-dither === mediatek,mt8167-disp-wdma So five of the strings are documented, the others are missing. I did not check the other patches in your branch. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel