From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9228C433E2 for ; Tue, 9 Jun 2020 09:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DA78207ED for ; Tue, 9 Jun 2020 09:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728153AbgFIJPa convert rfc822-to-8bit (ORCPT ); Tue, 9 Jun 2020 05:15:30 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:55037 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbgFIJP2 (ORCPT ); Tue, 9 Jun 2020 05:15:28 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1N2m7O-1ixPAe2F7E-0132Hu; Tue, 09 Jun 2020 11:15:24 +0200 Received: by mail-qt1-f172.google.com with SMTP id z1so17033042qtn.2; Tue, 09 Jun 2020 02:15:24 -0700 (PDT) X-Gm-Message-State: AOAM530RS4NuecT0s1oQr4x5f7MC0L6huT56ymvbTGx6JeZJh5qu27pn lQOZlupwS82j3k6qHBlk9tTZB4uQOL4CgcrbNuY= X-Google-Smtp-Source: ABdhPJwLEIiew7LT85XJ7YMwfJX7yhLUFVtBnCDqoIKOxdCKDHjqNlOaWp8DLPqmET9skm0FQ81wStwRswqY7BJG62c= X-Received: by 2002:ac8:4742:: with SMTP id k2mr27989059qtp.304.1591694122865; Tue, 09 Jun 2020 02:15:22 -0700 (PDT) MIME-Version: 1.0 References: <20200608164148.GA1394249@bjorn-Precision-5520> In-Reply-To: From: Arnd Bergmann Date: Tue, 9 Jun 2020 11:15:06 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU To: Zhangfei Gao Cc: Bjorn Helgaas , Joerg Roedel , Bjorn Helgaas , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , jean-philippe , Greg Kroah-Hartman , Herbert Xu , kenneth-lee-2012@foxmail.com, Wangzhou , "linux-kernel@vger.kernel.org" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "open list:IOMMU DRIVERS" , ACPI Devel Maling List , Linux ARM , linux-pci Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:kGYb3jMmETbHk7ETfChJPcg/kM3FCJJZyPXx2XC8g5Ud8G3UIHU xevtugFVfk44vd4itd6CeUSdhZ1TR+dMXfGOdfYN8RFRs0t2r3J7BtVJRhJasrZihguscsm TtxP+C2qRGuRL/nPub9KTWp9a/JVDQqUdXz+RMVjRKDW9tPyM8C55HldJstRePmeIPeHqDO A9fsJQT/cC7nc471uW3jQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:QGEsjw7JNoI=:qdRg51FIcOUv/GbrX7H8NU du6LH6NLpibryVn24IY3CrezHYu8HbUwKgMnamWMKV5Ntqwy148m/mbIv8mUBPRbNlRZHf6sF Qw3tYHvhV25Y99dTHUj1JrGTZj8m/Qh2kVzgMj06tPNJ4mFHKvFxGbEFEKuk/bxKZGQ4JdJzB 6vBGIHT6UvmRqALLZNgfEVvAWcWHuR7fIAwcAkzSqXIPGZQNKhmnMIfltPQ5xbFz+20IMUk7T E25RJNPZ1CO3+1pbZIaN8ZvcjVrjYQti647DdUfsCfboku7bJY4jFVbPD/u4mWquoz3sug7Ve xFWXqGW0EvAYinaE5IdIB7dAn4Wjk3Xo6cZKPq7RPK+2WIsT1QAxQn76hUN1afVjftxFPDXFv OsIveDASndAX/kKKR+nSnCSC8H65BlRrqcvNr700bS7S6wPES0bqO2FP3fVzy0/WZbE0plOE3 pyywpEWtC02Pdnzu3sW/ftCMaHZgDALBYj6fwh4PdwMkKL3qmxtMkJ0OIpC/DsylQQomuHTdy wWgIp9BtzAQwzLAxiXBtXl07VZsjEODDFzxITnAt9JnPXI8ybZQ1GyvoYLB26rE1atxHOZA2z dKIHB5i9IANvwJrgwE79cc6RBdOrvbbzxRw/sPQeZZ96Mr3g3IYnjiWEvZc0eqmKln1wNUKHC dMRIVTtgnsllyrjESTy6ms3bLXh150dpetTWGamRv6aa6xNJEcEPnUlH8OdBk135xA/NKTBju C1VItJ6DSwqiJDIZUO9aDZkY16oRCdMYuoErBv23z1xc0hc9mwICqf6KFawbPVpR98NDybRhF 4aMjJNXE7j11IKWW8KxlBuuqgB8Xba5FMLCd/HPrSUtZy2Sklo= Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 9, 2020 at 6:02 AM Zhangfei Gao wrote: > On 2020/6/9 上午12:41, Bjorn Helgaas wrote: > > On Mon, Jun 08, 2020 at 10:54:15AM +0800, Zhangfei Gao wrote: > >> On 2020/6/6 上午7:19, Bjorn Helgaas wrote: > >>>> +++ b/drivers/iommu/iommu.c > >>>> @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct > >>>> fwnode_handle *iommu_fwnode, > >>>> fwspec->iommu_fwnode = iommu_fwnode; > >>>> fwspec->ops = ops; > >>>> dev_iommu_fwspec_set(dev, fwspec); > >>>> + > >>>> + if (dev_is_pci(dev)) > >>>> + pci_fixup_device(pci_fixup_final, to_pci_dev(dev)); > >>>> + > >>>> > >>>> Then pci_fixup_final will be called twice, the first in pci_bus_add_device. > >>>> Here in iommu_fwspec_init is the second time, specifically for iommu_fwspec. > >>>> Will send this when 5.8-rc1 is open. > >>> Wait, this whole fixup approach seems wrong to me. No matter how you > >>> do the fixup, it's still a fixup, which means it requires ongoing > >>> maintenance. Surely we don't want to have to add the Vendor/Device ID > >>> for every new AMBA device that comes along, do we? > >>> > >> Here the fake pci device has standard PCI cfg space, but physical > >> implementation is base on AMBA > >> They can provide pasid feature. > >> However, > >> 1, does not support tlp since they are not real pci devices. > >> 2. does not support pri, instead support stall (provided by smmu) > >> And stall is not a pci feature, so it is not described in struct pci_dev, > >> but in struct iommu_fwspec. > >> So we use this fixup to tell pci system that the devices can support stall, > >> and hereby support pasid. > > This did not answer my question. Are you proposing that we update a > > quirk every time a new AMBA device is released? I don't think that > > would be a good model. > > Yes, you are right, but we do not have any better idea yet. > Currently we have three fake pci devices, which support stall and pasid. > We have to let pci system know the device can support pasid, because of > stall feature, though not support pri. > Do you have any other ideas? It sounds like the best way would be to allocate a PCI capability for it, so detection can be done through config space, at least in future devices, or possibly after a firmware update if the config space in your system is controlled by firmware somewhere. Once there is a proper mechanism to do this, using fixups to detect the early devices that don't use that should be uncontroversial. I have no idea what the process or timeline is to add new capabilities into the PCIe specification, or if this one would be acceptable to the PCI SIG at all. If detection cannot be done through PCI config space, the next best alternative is to pass auxiliary data through firmware. On DT based machines, you can list non-hotpluggable PCIe devices and add custom properties that could be read during device enumeration. I assume ACPI has something similar, but I have not done that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF4DC433E0 for ; Tue, 9 Jun 2020 09:15:33 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9063A207ED for ; Tue, 9 Jun 2020 09:15:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9063A207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 613848869E; Tue, 9 Jun 2020 09:15:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MZGQ+NSCnUhU; Tue, 9 Jun 2020 09:15:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 3CE3388622; Tue, 9 Jun 2020 09:15:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1E00DC0863; Tue, 9 Jun 2020 09:15:31 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4869AC016F for ; Tue, 9 Jun 2020 09:15:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 36970878A4 for ; Tue, 9 Jun 2020 09:15:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XNOdfyAll1+s for ; Tue, 9 Jun 2020 09:15:28 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by whitealder.osuosl.org (Postfix) with ESMTPS id BB46B87899 for ; Tue, 9 Jun 2020 09:15:27 +0000 (UTC) Received: from mail-qt1-f176.google.com ([209.85.160.176]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MrPRB-1jC1DX27F9-00oWT1 for ; Tue, 09 Jun 2020 11:15:24 +0200 Received: by mail-qt1-f176.google.com with SMTP id g62so13484869qtd.5 for ; Tue, 09 Jun 2020 02:15:24 -0700 (PDT) X-Gm-Message-State: AOAM533motmXgHAG/SnKNF8oU5X4KDfkMVPSAlV9IMbI7jgRieWOMpi9 LlHtfBGSAn+8wfdzhFQg1WHwOnzotx8zvmckPtI= X-Google-Smtp-Source: ABdhPJwLEIiew7LT85XJ7YMwfJX7yhLUFVtBnCDqoIKOxdCKDHjqNlOaWp8DLPqmET9skm0FQ81wStwRswqY7BJG62c= X-Received: by 2002:ac8:4742:: with SMTP id k2mr27989059qtp.304.1591694122865; Tue, 09 Jun 2020 02:15:22 -0700 (PDT) MIME-Version: 1.0 References: <20200608164148.GA1394249@bjorn-Precision-5520> In-Reply-To: From: Arnd Bergmann Date: Tue, 9 Jun 2020 11:15:06 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU To: Zhangfei Gao X-Provags-ID: V03:K1:Z7QDHkjtvTeWRlAca7ZNzesocwpIy6CNSrWwKfwAfBCh8/o2gPc 3RVLi3AnZxd4tNYL52EiN55b24LEDzF20Iu8RNAZuSvYSG2BMlZPvPAYQzC0SzOoWhPLvVU iM1begJdoYS2jEkQPg2SLunBC8hkIF19Q0liY8y56R9BDX4IjlKvcmBYkHatP9Pe21mjaWb 57+/xJN765DOipG2Azoow== X-UI-Out-Filterresults: notjunk:1;V03:K0:bGZ4/34oayk=:4QFv0pd412jYEvVxJEIGhJ bASZiOjviRZF0ILvOOtX97mQUfftF8zSPL2Mo6AmL96okQkLNNLp2x0UsZDW37y7Mbs7OP+yI Omy/O/VxCLJBRaxb8yP+Nkxi+tKc+1s6e3qSBTUPEbUT2/JnGaGG1HAGIzfd3cNdwvuZiHL+h U/fWVfPVLe5Canqtbqfl/0u2UqS46WWT2PEogNPHNX4Q35sMbu2BZlhaUz7I2uAZtO65LIqlL nanPuSeWxQd17YHp7ArBjWCdtG1yK6p/2JHHocLV6tFWqaWTPVXxUxCv3XXIIhaOmBIdagWT0 D7T9V6r3sl/hfw9cajKR7iclMmFO9tXdM11s+G4zZWAFkImRB6UWFYNuTN6Pf3JRtYQWIBXqt RCiRcx10EwxoHiYZlO9kSIYnefUDeZII/TYJePzuKQYojokIs10mDNONWbzFln8OGEuVMb2Om JR8scL2E4gwdRO7NXgdDoEFWBEcGe2HMZUBnP0JQ7Wz4BYuRq06/s329O1d1TYDWzRZifuiWT bzznB4ReAWQ0SZoz7+4hve0NxcjQCpA0ROdruKraiGwhMSP1faJ42KvVbP/yf+MqgkFwlmAPl CkUozjVIAyJYFwyqEuzwhMl8pedwz3vnyXq4n5/QSVtUSA2eJDJXQha1zapHLhi1VcSavfX2s tZEZIduFmQMDuDb1tULEUoI1ZalVIpWz7Eml1Ib1WBPJo2cFJBUf4y9G7Vfj7lmtdGtR0aoHT 6cVgv+43ktILfGC9n/5VzgUFllKYW+8smNDUOd2ZIuSF0IHzZuGy23NfgvN4E5VE61HzRZJWT 20sOo+ZFptKbl41hr/pu+lswZqZKifwhSkPayRBgLnCfWnBk/k= Cc: jean-philippe , Herbert Xu , linux-pci , Greg Kroah-Hartman , Hanjun Guo , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:IOMMU DRIVERS" , ACPI Devel Maling List , Bjorn Helgaas , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Sudeep Holla , Bjorn Helgaas , kenneth-lee-2012@foxmail.com, Linux ARM , Len Brown X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gVHVlLCBKdW4gOSwgMjAyMCBhdCA2OjAyIEFNIFpoYW5nZmVpIEdhbyA8emhhbmdmZWkuZ2Fv QGxpbmFyby5vcmc+IHdyb3RlOgo+IE9uIDIwMjAvNi85IOS4iuWNiDEyOjQxLCBCam9ybiBIZWxn YWFzIHdyb3RlOgo+ID4gT24gTW9uLCBKdW4gMDgsIDIwMjAgYXQgMTA6NTQ6MTVBTSArMDgwMCwg WmhhbmdmZWkgR2FvIHdyb3RlOgo+ID4+IE9uIDIwMjAvNi82IOS4iuWNiDc6MTksIEJqb3JuIEhl bGdhYXMgd3JvdGU6Cj4gPj4+PiArKysgYi9kcml2ZXJzL2lvbW11L2lvbW11LmMKPiA+Pj4+IEBA IC0yNDE4LDYgKzI0MTgsMTAgQEAgaW50IGlvbW11X2Z3c3BlY19pbml0KHN0cnVjdCBkZXZpY2Ug KmRldiwgc3RydWN0Cj4gPj4+PiBmd25vZGVfaGFuZGxlICppb21tdV9md25vZGUsCj4gPj4+PiAg ICAgICAgICAgZndzcGVjLT5pb21tdV9md25vZGUgPSBpb21tdV9md25vZGU7Cj4gPj4+PiAgICAg ICAgICAgZndzcGVjLT5vcHMgPSBvcHM7Cj4gPj4+PiAgICAgICAgICAgZGV2X2lvbW11X2Z3c3Bl Y19zZXQoZGV2LCBmd3NwZWMpOwo+ID4+Pj4gKwo+ID4+Pj4gKyAgICAgICBpZiAoZGV2X2lzX3Bj aShkZXYpKQo+ID4+Pj4gKyAgICAgICAgICAgICAgIHBjaV9maXh1cF9kZXZpY2UocGNpX2ZpeHVw X2ZpbmFsLCB0b19wY2lfZGV2KGRldikpOwo+ID4+Pj4gKwo+ID4+Pj4KPiA+Pj4+IFRoZW4gcGNp X2ZpeHVwX2ZpbmFsIHdpbGwgYmUgY2FsbGVkIHR3aWNlLCB0aGUgZmlyc3QgaW4gcGNpX2J1c19h ZGRfZGV2aWNlLgo+ID4+Pj4gSGVyZSBpbiBpb21tdV9md3NwZWNfaW5pdCBpcyB0aGUgc2Vjb25k IHRpbWUsIHNwZWNpZmljYWxseSBmb3IgaW9tbXVfZndzcGVjLgo+ID4+Pj4gV2lsbCBzZW5kIHRo aXMgd2hlbiA1LjgtcmMxIGlzIG9wZW4uCj4gPj4+IFdhaXQsIHRoaXMgd2hvbGUgZml4dXAgYXBw cm9hY2ggc2VlbXMgd3JvbmcgdG8gbWUuICBObyBtYXR0ZXIgaG93IHlvdQo+ID4+PiBkbyB0aGUg Zml4dXAsIGl0J3Mgc3RpbGwgYSBmaXh1cCwgd2hpY2ggbWVhbnMgaXQgcmVxdWlyZXMgb25nb2lu Zwo+ID4+PiBtYWludGVuYW5jZS4gIFN1cmVseSB3ZSBkb24ndCB3YW50IHRvIGhhdmUgdG8gYWRk IHRoZSBWZW5kb3IvRGV2aWNlIElECj4gPj4+IGZvciBldmVyeSBuZXcgQU1CQSBkZXZpY2UgdGhh dCBjb21lcyBhbG9uZywgZG8gd2U/Cj4gPj4+Cj4gPj4gSGVyZSB0aGUgZmFrZSBwY2kgZGV2aWNl IGhhcyBzdGFuZGFyZCBQQ0kgY2ZnIHNwYWNlLCBidXQgcGh5c2ljYWwKPiA+PiBpbXBsZW1lbnRh dGlvbiBpcyBiYXNlIG9uIEFNQkEKPiA+PiBUaGV5IGNhbiBwcm92aWRlIHBhc2lkIGZlYXR1cmUu Cj4gPj4gSG93ZXZlciwKPiA+PiAxLCBkb2VzIG5vdCBzdXBwb3J0IHRscCBzaW5jZSB0aGV5IGFy ZSBub3QgcmVhbCBwY2kgZGV2aWNlcy4KPiA+PiAyLiBkb2VzIG5vdCBzdXBwb3J0IHByaSwgaW5z dGVhZCBzdXBwb3J0IHN0YWxsIChwcm92aWRlZCBieSBzbW11KQo+ID4+IEFuZCBzdGFsbCBpcyBu b3QgYSBwY2kgZmVhdHVyZSwgc28gaXQgaXMgbm90IGRlc2NyaWJlZCBpbiBzdHJ1Y3QgcGNpX2Rl diwKPiA+PiBidXQgaW4gc3RydWN0IGlvbW11X2Z3c3BlYy4KPiA+PiBTbyB3ZSB1c2UgdGhpcyBm aXh1cCB0byB0ZWxsIHBjaSBzeXN0ZW0gdGhhdCB0aGUgZGV2aWNlcyBjYW4gc3VwcG9ydCBzdGFs bCwKPiA+PiBhbmQgaGVyZWJ5IHN1cHBvcnQgcGFzaWQuCj4gPiBUaGlzIGRpZCBub3QgYW5zd2Vy IG15IHF1ZXN0aW9uLiAgQXJlIHlvdSBwcm9wb3NpbmcgdGhhdCB3ZSB1cGRhdGUgYQo+ID4gcXVp cmsgZXZlcnkgdGltZSBhIG5ldyBBTUJBIGRldmljZSBpcyByZWxlYXNlZD8gIEkgZG9uJ3QgdGhp bmsgdGhhdAo+ID4gd291bGQgYmUgYSBnb29kIG1vZGVsLgo+Cj4gWWVzLCB5b3UgYXJlIHJpZ2h0 LCBidXQgd2UgZG8gbm90IGhhdmUgYW55IGJldHRlciBpZGVhIHlldC4KPiBDdXJyZW50bHkgd2Ug aGF2ZSB0aHJlZSBmYWtlIHBjaSBkZXZpY2VzLCB3aGljaCBzdXBwb3J0IHN0YWxsIGFuZCBwYXNp ZC4KPiBXZSBoYXZlIHRvIGxldCBwY2kgc3lzdGVtIGtub3cgdGhlIGRldmljZSBjYW4gc3VwcG9y dCBwYXNpZCwgYmVjYXVzZSBvZgo+IHN0YWxsIGZlYXR1cmUsIHRob3VnaCBub3Qgc3VwcG9ydCBw cmkuCj4gRG8geW91IGhhdmUgYW55IG90aGVyIGlkZWFzPwoKSXQgc291bmRzIGxpa2UgdGhlIGJl c3Qgd2F5IHdvdWxkIGJlIHRvIGFsbG9jYXRlIGEgUENJIGNhcGFiaWxpdHkgZm9yIGl0LCBzbwpk ZXRlY3Rpb24gY2FuIGJlIGRvbmUgdGhyb3VnaCBjb25maWcgc3BhY2UsIGF0IGxlYXN0IGluIGZ1 dHVyZSBkZXZpY2VzLApvciBwb3NzaWJseSBhZnRlciBhIGZpcm13YXJlIHVwZGF0ZSBpZiB0aGUg Y29uZmlnIHNwYWNlIGluIHlvdXIgc3lzdGVtCmlzIGNvbnRyb2xsZWQgYnkgZmlybXdhcmUgc29t ZXdoZXJlLiAgT25jZSB0aGVyZSBpcyBhIHByb3BlciBtZWNoYW5pc20KdG8gZG8gdGhpcywgdXNp bmcgZml4dXBzIHRvIGRldGVjdCB0aGUgZWFybHkgZGV2aWNlcyB0aGF0IGRvbid0IHVzZSB0aGF0 CnNob3VsZCBiZSB1bmNvbnRyb3ZlcnNpYWwuIEkgaGF2ZSBubyBpZGVhIHdoYXQgdGhlIHByb2Nl c3Mgb3IgdGltZWxpbmUKaXMgdG8gYWRkIG5ldyBjYXBhYmlsaXRpZXMgaW50byB0aGUgUENJZSBz cGVjaWZpY2F0aW9uLCBvciBpZiB0aGlzIG9uZQp3b3VsZCBiZSBhY2NlcHRhYmxlIHRvIHRoZSBQ Q0kgU0lHIGF0IGFsbC4KCklmIGRldGVjdGlvbiBjYW5ub3QgYmUgZG9uZSB0aHJvdWdoIFBDSSBj b25maWcgc3BhY2UsIHRoZSBuZXh0IGJlc3QKYWx0ZXJuYXRpdmUgaXMgdG8gcGFzcyBhdXhpbGlh cnkgZGF0YSB0aHJvdWdoIGZpcm13YXJlLiBPbiBEVCBiYXNlZAptYWNoaW5lcywgeW91IGNhbiBs aXN0IG5vbi1ob3RwbHVnZ2FibGUgUENJZSBkZXZpY2VzIGFuZCBhZGQgY3VzdG9tCnByb3BlcnRp ZXMgdGhhdCBjb3VsZCBiZSByZWFkIGR1cmluZyBkZXZpY2UgZW51bWVyYXRpb24uIEkgYXNzdW1l CkFDUEkgaGFzIHNvbWV0aGluZyBzaW1pbGFyLCBidXQgSSBoYXZlIG5vdCBkb25lIHRoYXQuCgog ICAgICBBcm5kCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRw czovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF12C433E1 for ; Tue, 9 Jun 2020 09:15:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 642DB207ED for ; Tue, 9 Jun 2020 09:15:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y0dHFR8u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 642DB207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2fwqOezvdHfaO3TJfSbpKxcoxARoEOzqzGE+Z5grKXk=; b=Y0dHFR8uckBv4A yf72oN1maLv2C9xHn4FfyJPa4SIPllG4Kn6HUAutefBY96Os3L/hJxVkUyTz2FPDHHrXsj8l4HZej xgAc5G2SDW+BFVNT4z2h1Q+S932fsGJe74T6fw9yY3fw5AxhR3Z88R6wucz7K49xxVNR0e9+jwQBp zo0ytPvxibgQ4CzRjWYWN7j1zFWqxqrkxj3UW3INCa3X3Ot21xxPpfCYkjwzN/XSoNJeEhjwPXQGJ o25NixfDEkRehsGV1qEyGP2u8cSDsyWqOImZpWcinzVHmVPkEm2Z2Wt9xQqdOLs6Iiz57hsApl7yZ yLj8S7HO8tprY6Sj7MdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiaLz-0001Ox-E0; Tue, 09 Jun 2020 09:15:31 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiaLw-0001Nb-Cl for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 09:15:30 +0000 Received: from mail-qt1-f181.google.com ([209.85.160.181]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MAPBF-1joOpj0zoR-00BrNY for ; Tue, 09 Jun 2020 11:15:24 +0200 Received: by mail-qt1-f181.google.com with SMTP id u17so17037723qtq.1 for ; Tue, 09 Jun 2020 02:15:24 -0700 (PDT) X-Gm-Message-State: AOAM530T4OLHHp5uOE3bV0JWXUUiyXgaD3oqQDwOzGYnydxRu6rqiUni MvespUxvfE8eKmA2/BXDhGB45Yp8dWrHU1qR8Sw= X-Google-Smtp-Source: ABdhPJwLEIiew7LT85XJ7YMwfJX7yhLUFVtBnCDqoIKOxdCKDHjqNlOaWp8DLPqmET9skm0FQ81wStwRswqY7BJG62c= X-Received: by 2002:ac8:4742:: with SMTP id k2mr27989059qtp.304.1591694122865; Tue, 09 Jun 2020 02:15:22 -0700 (PDT) MIME-Version: 1.0 References: <20200608164148.GA1394249@bjorn-Precision-5520> In-Reply-To: From: Arnd Bergmann Date: Tue, 9 Jun 2020 11:15:06 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU To: Zhangfei Gao X-Provags-ID: V03:K1:6FrNM7tyqHwQYrfPcZgh+gS54Zyz88gh+1Auw1B8agl0ia4tCr2 W7LmTlJNSmDf10IXt8M9DsskVaY/oUy8mwhcI4ANvBvF9ZdWcSMBC25SA9vl1Dv9Di+IIfE /gTDRK3/OrWN94M0G1hQOdnpOIxb3GJPH9QIv/ZIqHXW+AMnt8p/S8a4WJqj127SiJorpat hOtv5nQ7A9RzpTygDYDAg== X-UI-Out-Filterresults: notjunk:1;V03:K0:rH70ZZS3CnE=:ObzMiSRzTLCP6BWMVszkC2 bxjFK/HVCudWaL21smHahcnWNv7a0D0hDZge8WIbNYc7y6WKcwd5q3frqpJBFMk0QuAAAVVRG nCA1pyrG0kaMjc4gOvIY8BMDFbz5ALl2aFReGDs/6bFOcolT5Ijyf1afBh4mrXem3N2rxR5o8 6JkynXR6ujYi4wBx30h8m86kmyD3CE0mVC13/KjbhUToXHhqZFnOw8JHwERK5MKbFT5SuXt7Y qCq5NW77pY8a/+TRjgvdHNSD+EBYuexfavc2n5+HgtdMzFTJN7D8p/ibRq7JD2tckHj0s71Ls VsmG60fQ7yZ7gfr4tcYsECl1Rrm62mK9tB1rkLQPIogaBN9gFdIcJzOfKky9ZpuYKRD1tkHl6 4w6t4QA148WvnZEANOhQkFN9QWT2JcHDhVx/rpzZoakgez4iSmpGTJiv7wSErWHzp5nw16EJw nYm1nyushHXZgnimQwVqndSYR+mnLMpWopSQtNi13bACCz+7y+0UbGW49MhOnMT9w02aCW9F1 PlyuO8sicZ0mPDDE5ZNXGqi+svFaSaa1rLkeFuuHF+zPEDOUb+8RbYp3YUnvAR79+xj4Apig8 7JAtnkDVqXHjiIwJOHEp9nPnhDJYcq+vY7JeJtND7MMYso5J+8cFSgBp+66uKVaFx2ufJfinO J4wUw8CaaAQgk77P0FZqK+TGJ5eH/Xh7CeDIWg8vbnBOnNgSlOLLliz6lPgtleTDVy+wuRpCn JBS+3DWlzpn0f94gJFiZxFzOrUlBXidx+q10UxxLE1HSyQL5mZAyzIUBMOgcJHBDoe8sc7Dw/ lMbdZaXyRSgPdV/KieUDRuKlmJcRTNZ42Ngs0u/dnlkdvFaqSQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_021528_727857_1B6FAE74 X-CRM114-Status: GOOD ( 22.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe , Lorenzo Pieralisi , Herbert Xu , linux-pci , Greg Kroah-Hartman , Joerg Roedel , Hanjun Guo , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:IOMMU DRIVERS" , ACPI Devel Maling List , Wangzhou , Bjorn Helgaas , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Sudeep Holla , Bjorn Helgaas , kenneth-lee-2012@foxmail.com, Linux ARM , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gOSwgMjAyMCBhdCA2OjAyIEFNIFpoYW5nZmVpIEdhbyA8emhhbmdmZWkuZ2Fv QGxpbmFyby5vcmc+IHdyb3RlOgo+IE9uIDIwMjAvNi85IOS4iuWNiDEyOjQxLCBCam9ybiBIZWxn YWFzIHdyb3RlOgo+ID4gT24gTW9uLCBKdW4gMDgsIDIwMjAgYXQgMTA6NTQ6MTVBTSArMDgwMCwg WmhhbmdmZWkgR2FvIHdyb3RlOgo+ID4+IE9uIDIwMjAvNi82IOS4iuWNiDc6MTksIEJqb3JuIEhl bGdhYXMgd3JvdGU6Cj4gPj4+PiArKysgYi9kcml2ZXJzL2lvbW11L2lvbW11LmMKPiA+Pj4+IEBA IC0yNDE4LDYgKzI0MTgsMTAgQEAgaW50IGlvbW11X2Z3c3BlY19pbml0KHN0cnVjdCBkZXZpY2Ug KmRldiwgc3RydWN0Cj4gPj4+PiBmd25vZGVfaGFuZGxlICppb21tdV9md25vZGUsCj4gPj4+PiAg ICAgICAgICAgZndzcGVjLT5pb21tdV9md25vZGUgPSBpb21tdV9md25vZGU7Cj4gPj4+PiAgICAg ICAgICAgZndzcGVjLT5vcHMgPSBvcHM7Cj4gPj4+PiAgICAgICAgICAgZGV2X2lvbW11X2Z3c3Bl Y19zZXQoZGV2LCBmd3NwZWMpOwo+ID4+Pj4gKwo+ID4+Pj4gKyAgICAgICBpZiAoZGV2X2lzX3Bj aShkZXYpKQo+ID4+Pj4gKyAgICAgICAgICAgICAgIHBjaV9maXh1cF9kZXZpY2UocGNpX2ZpeHVw X2ZpbmFsLCB0b19wY2lfZGV2KGRldikpOwo+ID4+Pj4gKwo+ID4+Pj4KPiA+Pj4+IFRoZW4gcGNp X2ZpeHVwX2ZpbmFsIHdpbGwgYmUgY2FsbGVkIHR3aWNlLCB0aGUgZmlyc3QgaW4gcGNpX2J1c19h ZGRfZGV2aWNlLgo+ID4+Pj4gSGVyZSBpbiBpb21tdV9md3NwZWNfaW5pdCBpcyB0aGUgc2Vjb25k IHRpbWUsIHNwZWNpZmljYWxseSBmb3IgaW9tbXVfZndzcGVjLgo+ID4+Pj4gV2lsbCBzZW5kIHRo aXMgd2hlbiA1LjgtcmMxIGlzIG9wZW4uCj4gPj4+IFdhaXQsIHRoaXMgd2hvbGUgZml4dXAgYXBw cm9hY2ggc2VlbXMgd3JvbmcgdG8gbWUuICBObyBtYXR0ZXIgaG93IHlvdQo+ID4+PiBkbyB0aGUg Zml4dXAsIGl0J3Mgc3RpbGwgYSBmaXh1cCwgd2hpY2ggbWVhbnMgaXQgcmVxdWlyZXMgb25nb2lu Zwo+ID4+PiBtYWludGVuYW5jZS4gIFN1cmVseSB3ZSBkb24ndCB3YW50IHRvIGhhdmUgdG8gYWRk IHRoZSBWZW5kb3IvRGV2aWNlIElECj4gPj4+IGZvciBldmVyeSBuZXcgQU1CQSBkZXZpY2UgdGhh dCBjb21lcyBhbG9uZywgZG8gd2U/Cj4gPj4+Cj4gPj4gSGVyZSB0aGUgZmFrZSBwY2kgZGV2aWNl IGhhcyBzdGFuZGFyZCBQQ0kgY2ZnIHNwYWNlLCBidXQgcGh5c2ljYWwKPiA+PiBpbXBsZW1lbnRh dGlvbiBpcyBiYXNlIG9uIEFNQkEKPiA+PiBUaGV5IGNhbiBwcm92aWRlIHBhc2lkIGZlYXR1cmUu Cj4gPj4gSG93ZXZlciwKPiA+PiAxLCBkb2VzIG5vdCBzdXBwb3J0IHRscCBzaW5jZSB0aGV5IGFy ZSBub3QgcmVhbCBwY2kgZGV2aWNlcy4KPiA+PiAyLiBkb2VzIG5vdCBzdXBwb3J0IHByaSwgaW5z dGVhZCBzdXBwb3J0IHN0YWxsIChwcm92aWRlZCBieSBzbW11KQo+ID4+IEFuZCBzdGFsbCBpcyBu b3QgYSBwY2kgZmVhdHVyZSwgc28gaXQgaXMgbm90IGRlc2NyaWJlZCBpbiBzdHJ1Y3QgcGNpX2Rl diwKPiA+PiBidXQgaW4gc3RydWN0IGlvbW11X2Z3c3BlYy4KPiA+PiBTbyB3ZSB1c2UgdGhpcyBm aXh1cCB0byB0ZWxsIHBjaSBzeXN0ZW0gdGhhdCB0aGUgZGV2aWNlcyBjYW4gc3VwcG9ydCBzdGFs bCwKPiA+PiBhbmQgaGVyZWJ5IHN1cHBvcnQgcGFzaWQuCj4gPiBUaGlzIGRpZCBub3QgYW5zd2Vy IG15IHF1ZXN0aW9uLiAgQXJlIHlvdSBwcm9wb3NpbmcgdGhhdCB3ZSB1cGRhdGUgYQo+ID4gcXVp cmsgZXZlcnkgdGltZSBhIG5ldyBBTUJBIGRldmljZSBpcyByZWxlYXNlZD8gIEkgZG9uJ3QgdGhp bmsgdGhhdAo+ID4gd291bGQgYmUgYSBnb29kIG1vZGVsLgo+Cj4gWWVzLCB5b3UgYXJlIHJpZ2h0 LCBidXQgd2UgZG8gbm90IGhhdmUgYW55IGJldHRlciBpZGVhIHlldC4KPiBDdXJyZW50bHkgd2Ug aGF2ZSB0aHJlZSBmYWtlIHBjaSBkZXZpY2VzLCB3aGljaCBzdXBwb3J0IHN0YWxsIGFuZCBwYXNp ZC4KPiBXZSBoYXZlIHRvIGxldCBwY2kgc3lzdGVtIGtub3cgdGhlIGRldmljZSBjYW4gc3VwcG9y dCBwYXNpZCwgYmVjYXVzZSBvZgo+IHN0YWxsIGZlYXR1cmUsIHRob3VnaCBub3Qgc3VwcG9ydCBw cmkuCj4gRG8geW91IGhhdmUgYW55IG90aGVyIGlkZWFzPwoKSXQgc291bmRzIGxpa2UgdGhlIGJl c3Qgd2F5IHdvdWxkIGJlIHRvIGFsbG9jYXRlIGEgUENJIGNhcGFiaWxpdHkgZm9yIGl0LCBzbwpk ZXRlY3Rpb24gY2FuIGJlIGRvbmUgdGhyb3VnaCBjb25maWcgc3BhY2UsIGF0IGxlYXN0IGluIGZ1 dHVyZSBkZXZpY2VzLApvciBwb3NzaWJseSBhZnRlciBhIGZpcm13YXJlIHVwZGF0ZSBpZiB0aGUg Y29uZmlnIHNwYWNlIGluIHlvdXIgc3lzdGVtCmlzIGNvbnRyb2xsZWQgYnkgZmlybXdhcmUgc29t ZXdoZXJlLiAgT25jZSB0aGVyZSBpcyBhIHByb3BlciBtZWNoYW5pc20KdG8gZG8gdGhpcywgdXNp bmcgZml4dXBzIHRvIGRldGVjdCB0aGUgZWFybHkgZGV2aWNlcyB0aGF0IGRvbid0IHVzZSB0aGF0 CnNob3VsZCBiZSB1bmNvbnRyb3ZlcnNpYWwuIEkgaGF2ZSBubyBpZGVhIHdoYXQgdGhlIHByb2Nl c3Mgb3IgdGltZWxpbmUKaXMgdG8gYWRkIG5ldyBjYXBhYmlsaXRpZXMgaW50byB0aGUgUENJZSBz cGVjaWZpY2F0aW9uLCBvciBpZiB0aGlzIG9uZQp3b3VsZCBiZSBhY2NlcHRhYmxlIHRvIHRoZSBQ Q0kgU0lHIGF0IGFsbC4KCklmIGRldGVjdGlvbiBjYW5ub3QgYmUgZG9uZSB0aHJvdWdoIFBDSSBj b25maWcgc3BhY2UsIHRoZSBuZXh0IGJlc3QKYWx0ZXJuYXRpdmUgaXMgdG8gcGFzcyBhdXhpbGlh cnkgZGF0YSB0aHJvdWdoIGZpcm13YXJlLiBPbiBEVCBiYXNlZAptYWNoaW5lcywgeW91IGNhbiBs aXN0IG5vbi1ob3RwbHVnZ2FibGUgUENJZSBkZXZpY2VzIGFuZCBhZGQgY3VzdG9tCnByb3BlcnRp ZXMgdGhhdCBjb3VsZCBiZSByZWFkIGR1cmluZyBkZXZpY2UgZW51bWVyYXRpb24uIEkgYXNzdW1l CkFDUEkgaGFzIHNvbWV0aGluZyBzaW1pbGFyLCBidXQgSSBoYXZlIG5vdCBkb25lIHRoYXQuCgog ICAgICBBcm5kCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==