From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CE9C4338F for ; Mon, 26 Jul 2021 19:00:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FB9D60F8F for ; Mon, 26 Jul 2021 19:00:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9FB9D60F8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5F7511AE3; Mon, 26 Jul 2021 20:59:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5F7511AE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627326047; bh=plFmCRvggw85dmXN5e0xuta8Z9I/gmxaScYHMY+CHdk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iJw2dxFvlWkRKAUsgAwcpVCZmbvYlbTZ+N0JFAmAIdGCX7Gg+/u96UpTr9IjC1YgF nG+/3d16NSjpkQBP+sVX5tLT7I/1SikKaVr2GWMavQdetwmXQbemYZO/rqWI2TKmzy LD4QXErgrmX857QcxbGsHxwtwVsej1mIEYrMPgcs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D472DF80253; Mon, 26 Jul 2021 20:59:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D67C2F8025A; Mon, 26 Jul 2021 20:59:55 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D4439F80132 for ; Mon, 26 Jul 2021 20:59:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D4439F80132 Received: from mail-wr1-f52.google.com ([209.85.221.52]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M7auL-1m08oT0UqD-0085j8 for ; Mon, 26 Jul 2021 20:59:48 +0200 Received: by mail-wr1-f52.google.com with SMTP id l18so4625105wrv.5 for ; Mon, 26 Jul 2021 11:59:47 -0700 (PDT) X-Gm-Message-State: AOAM530AGevfmLEDxe1/lZ5ooSq7rZtSejNnVwhI3hBG87GMQDkSZIzV 4l8lsgfANHlmJSOGntAocGpWxbsJx4zGUzcs+XU= X-Google-Smtp-Source: ABdhPJxY2Msxg10GQvXzi7iOXfW5B9LxrsADv4U+iggka3WOIJFd2TpVLEeNQgwDubTiO6YXhpkea5oFDkxJcEOewH0= X-Received: by 2002:adf:e107:: with SMTP id t7mr20722060wrz.165.1627325987583; Mon, 26 Jul 2021 11:59:47 -0700 (PDT) MIME-Version: 1.0 References: <20210302003125.1178419-1-pierre-louis.bossart@linux.intel.com> In-Reply-To: <20210302003125.1178419-1-pierre-louis.bossart@linux.intel.com> From: Arnd Bergmann Date: Mon, 26 Jul 2021 20:59:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] ALSA/ASoC/SOF/SoundWire: fix Kconfig issues To: Pierre-Louis Bossart Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:tIq1e8YoXRJwGsJ7G3myqGwiyuvgqEZQiRO6yiTQo5+CwxqM92/ mhkNWVga3XDvcKDTvXyByYadcQXs89AgyX6/C868S1dfuYPkdzNEwEae2omung9j1munik6 aXVASllw+b73xFdWNMuITTCRG5CyPkeLPawkV6nOPIxl4CziFFpvNTu7caXyNaCv3blxo/d 4ouKUpxWci2f116dory9g== X-UI-Out-Filterresults: notjunk:1;V03:K0:4msdzEaQKBc=:taotD+240Q4ZbRBlFXl0+a Nd2imWv/DhvtVyT17sjXrRbaejgBZ4hmnHmRMaapdgUgAcDxOQGCKo6RJgbd5tTndYzjroscK ZI7oSk7nyTuOBKr9ypo8/ys2LSAYRClbmrDFumjkx2L6rm0T91dc74t9QZVwnBrVuzD3vLZ/i Lvrtgrc4anQ1pSzv79nUiq7AAMkKTlgwPsHw/SoeS108z2NPX9sZ561LEYdJl4jBuBSAS/j7Y TxwwxMLxePrD+0gKcZJKRyHLFvgf1whdrmYjFLuOve9dekeVWwkwCOCST0dRV7E5s/95zugKR eyYtjIB0pXOtIhS4TocpLEn3aJAhxBNnXPz1x/PmAnc/FaSXZ2YfSZk6d1ExhuaOWncqKg2Ny VIwQWWYdR8Esu1OqK4tDTIIDZKz7UsizPbdOF+zR7aF4fV1uWPbDhx7V1IfgxbOjcUklhg81r PwD8QeoWb1Ss1V5zKtSmmxtZdSqI/KAFNu+opBSZRi4bf2OJ2wk2X7NrJF1cujwlijevnUt/k BWPVfA7Mf2d+QN2zNCTiiHrjUOgE1yc3R5uC3lKrEQtdun9qUaJTQTyTCKK3no6VuIyqwlfox suHMvWXX8QBIy2okJwr5y1xn1/QP5m+WHBUr33A4InmzvXN/fU4bheybJLwcouJcJwFgp/Rmf RpudWTJBSGckm8ufZp/x5BxKj5ClfMJ/c+loALHQb8GwbCZB3AxZgqRnhLAJMo6iZKjBbB/uH woqAcK1FUFkZ6EMaGXTroAmXTw4glatKi7cUq5VzLgM7oR8djc4WgfApAbEMFDfczZPNQLt8P 7K1rWHEbtVOwJ7Uf9Fmm97+ykoDWM1rl+5oxrPfJ8GcalXeDNjL7mPAm4aJqrnhKi66GMMbi4 fpeU2LViSSfnRB4iPsUvdlvcZ+p7+QOA5hoDx8fmeYpJSgQfJOV5iGJPuC7ovic+M/cIrmFmR PXlItuX1JYdqoktyF4U6FpDcbvjBcWbot1xF7oi4l+/69Zepjy4cg Cc: ALSA Development Mailing List , Arnd Bergmann , Takashi Iwai , Vinod Koul , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Mar 2, 2021 at 1:31 AM Pierre-Louis Bossart wrote: > > In January, Intel kbuild bot and Arnd Bergmann reported multiple > issues with randconfig. This patchset builds on Arnd's suggestions to > > a) expose ACPI and PCI devices in separate modules, while sof-acpi-dev > and sof-pci-dev become helpers. This will result in minor changes > required for developers/testers, i.e. modprobe snd-sof-pci will no > longer result in a probe. The SOF CI was already updated to deal with > this module dependency change and introduction of new modules. > > b) Fix SOF/SoundWire/DSP_config dependencies by moving the code > required to detect SoundWire presence in ACPI tables to sound/hda. > > Integration note: > This patchset touches directories maintained by Vinod, Takashi and > Mark in separate trees, and will impact additional changes to use the > auxiliary bus in drivers/soundwire/. > I can think of two options, both of which are fine: > 1. Mark merges the patches with Vinod and Takashi Acked-by tags, then > Mark provides an immutable tag to Vinod. > 2. Vinod merges the patches with Mark and Takashi Acked-by tags, then > Vinod provides an immutable tag to Mark > > Acknowledgements: > Thanks to Arnd for suggesting fixes and testing these patches with > more randconfigs. > Thanks to Vinod Koul for his feedback on the move of this common > helper to sound/hda/ Hi Pierre-Louis, I have not done as much randconfig tested recently as I used to, but since I ramped up the rate again after the merge window, I have unfortunately once more run into a variation of this problem, with CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE=m and CONFIG_SND_SOC_SOF_HDA_COMMON=y: x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_interrupt_thread': hda.c:(.text+0x739): undefined reference to `sdw_intel_thread' x86_64-linux-ld: hda.c:(.text+0x764): undefined reference to `sdw_intel_process_wakeen_event' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_int_enable': hda.c:(.text+0x782): undefined reference to `sdw_intel_enable_irq' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_startup': hda.c:(.text+0x7ac): undefined reference to `sdw_intel_startup' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_process_wakeen': hda.c:(.text+0x7dc): undefined reference to `sdw_intel_process_wakeen_event' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_probe': hda.c:(.text+0xee1): undefined reference to `sdw_intel_probe' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_remove': hda.c:(.text+0xf7f): undefined reference to `sdw_intel_enable_irq' x86_64-linux-ld: hda.c:(.text+0xf8e): undefined reference to `sdw_intel_exit' This only seems to appear very rarely, as I still did around 25000 randconfig builds since you merged the series, but this config does show the problem for any kernel version between the fix and the latest linux-next: https://pastebin.com/raw/VCjcB3EU I have only done the quick bisection but no analysis regarding what we may have missed back in March. I hope you can figure this out. Arnd