From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEDAC433E0 for ; Mon, 27 Jul 2020 07:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EA4820738 for ; Mon, 27 Jul 2020 07:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbgG0Htl (ORCPT ); Mon, 27 Jul 2020 03:49:41 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:49773 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbgG0Htk (ORCPT ); Mon, 27 Jul 2020 03:49:40 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MmU9R-1ki8LS0GDx-00iQrk for ; Mon, 27 Jul 2020 09:49:39 +0200 Received: by mail-qt1-f171.google.com with SMTP id b25so11538091qto.2 for ; Mon, 27 Jul 2020 00:49:38 -0700 (PDT) X-Gm-Message-State: AOAM531x8u5CXtQTSfWSDrreOdb0juCJhNPaphjFiz8wO4S3OBXLW0/d zspr+RSjtzmXBxNxlPeY5fznhx5d9Ho+H2DD8rs= X-Google-Smtp-Source: ABdhPJyqvtFtc9EeRn23Z++9snt24Adrey6DZY0MGaUrfMzSaEFa1Rx5bauVO7MVoNlBp10B/WVA2Ld+bxrUKqWk8nE= X-Received: by 2002:aed:2946:: with SMTP id s64mr614510qtd.204.1595836177987; Mon, 27 Jul 2020 00:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20200726043948.1357573-1-daniel@0x0f.com> <20200726043948.1357573-7-daniel@0x0f.com> In-Reply-To: <20200726043948.1357573-7-daniel@0x0f.com> From: Arnd Bergmann Date: Mon, 27 Jul 2020 09:49:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] ARM:mstar: Add syscon node for "pmsleep" area To: Daniel Palmer List-Id: Cc: SoC Team , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:BIN1nKwO5OyDJZP5VcffJDmmkyLkZJ27LEzfx9XapM2fEemNskh wLhRObCNnuVEsrUaLlyZcB99Yo7JemJrNxnN/qjCIijSHgNGPa4P7W243s2Ag6qG2R6aMIV HtmI/MGMsMNyGLowsA6bk8WM0JrKlI+ThP3IX9ByY1mTtQhqU7pyBjjAOV9PvZe+ueBVdjz FSVNCpGflgB370noq7/3A== X-UI-Out-Filterresults: notjunk:1;V03:K0:DcSsac6gRNs=:MKtDngoHSRyVWOyNjPRL5E mPAoMDsJOBQdKwpIcwOg7QFvvrzFKgHy09xa5rPsxkfh7KlYbaH2Dlp8LKVP3LOPs/XN6TYQg u2JHG4c9hmjZpJyHQekrmubujBUftjcVxD3pkUafMYULMXGhW3sb3grKbowu0hvopy8mcyboQ i9eNQLclquPBEe5lr9xp/V566QFGDdyPt4qwT88o3ZKV22c7Uskd5qN+fASbE4MN4KmXQTSnz 29zWlIHaWMZF72oojMRxUiNINTJ4RLyvBYm3CxzZCKAxu2RDMKwHaseu+GfhKFNEt0db8J/oi pL+nxW5AROQQL1m3xrc9wq/K+3k2U7zGrlFpP5nDdhUBR8BeYo0A857wdChjjIs0YWcuxQ3z/ YUsrqWiLR8dzx9ydwys0T+T7j+WfIWjXUNzpi7F/+DeVrcc3GvbSpnkBaexzXHMPXW2ldZ6/B AQ1ZL7YbA6PHo8vLUEKg1Ombpf5L/JJTGTjcVxTL6bSc43CiTtnptSmH2pzOlMhC0pP4FhR2t r1S+DAQFDPXwzRzaHep1wIUa/ByApNfc+TzLN/jqRVMS1szyQk0oM3FgsS+p6JCaBHHmqA2hS uAn0UywcQNQjBFHVRNEgqYDPZgFzX0uGZAo+KAWULxtJWf3ES+TSEKjGhHxM7DYWiJUq422rb hokBW9G4zLfFg/X8y2ZP3UAH9DB65rV67KQ7tS1I1+Yd1dNZyFtNZF7uQSaGZYa3Dv+TmciEB aaKY4IBoEWAPLIO6V/e+FBmwc+fpFR/5FPL0nlyy3zZNjcF1IbLmzNUDO1aB1QnvSKYYtiTpZ 6EIYYKPqyZeVRaAExswAaO3Z4sC+NW6VdmlVmYX/nLtOHnq5QKuuw/6o4Q1lx+tfudoi+YR8t YU4o4uetOu1zUioWgeYDa6wnKwdPBD72q/uJ3XMYcW7JXjQ3NVAgeWu2yRen2exxUiLQ4arJD cAdbbeyPSgf1BwN07o2S2gsYwhxguFkxiaW3DrFIJpKx+jUvqO3uY Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2020 at 6:40 AM Daniel Palmer wrote: > > MStar v7 SoCs contain a region of registers that are in the always on > domain that the vendor code calls the "pmsleep" area. > > This area contains registers for a broad range of functionality and > needs to be shared between drivers. > > This patch adds a syscon node for the pmsleep area so that other > drivers can access registers in the area. > > Signed-off-by: Daniel Palmer I think it would be better to add a more specific compatible string in addition to the "syscon" one, to make it possible to later add a proper driver for this area, in case there is a need for that. Arnd > --- > arch/arm/boot/dts/mstar-v7.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi > index a73b1d162dfd..c8b192569d05 100644 > --- a/arch/arm/boot/dts/mstar-v7.dtsi > +++ b/arch/arm/boot/dts/mstar-v7.dtsi > @@ -73,6 +73,11 @@ riu: bus@1f000000 { > #size-cells = <1>; > ranges = <0x0 0x1f000000 0x00400000>; > > + pmsleep: syscon@1c00 { > + compatible = "syscon"; > + reg = <0x1c00 0x100>; > + }; > + > l3bridge: l3bridge@204400 { > compatible = "mstar,l3bridge"; > reg = <0x204400 0x200>; > -- > 2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C61C433E0 for ; Mon, 27 Jul 2020 07:51:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0121620672 for ; Mon, 27 Jul 2020 07:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b7PxdLBQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0121620672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lOY2WzXe0Dlsdak3U2Gf//iloJpv6nnYJ6FAL3agI30=; b=b7PxdLBQoL7HR4XsxNC78ZH7q n2kCkpa1xrTPXcN4GmyG2pemWgTfneEwzzsOyrRvV5NmGi7SrCtGcvzj+HqUkwdtB0Y1bcm+VUGYw aMJKzhtUg6TYwtaq8LOga6HCprLVuZCoJCmGUISLQzjuWebtfYlNRBtkloWMzp943LP5ISExERdCg dgo/iAsq7MDYrsWuMYhMC2mo2qTimE/h5/+9z6TDE1V2Mxypwy0KPzThsSJhcrQZxqT+2PZyfPfiQ wSQ3Zb0ZKitKCnd8sWp14FIMBuU7miA5PdPFVaQ91iqPdysB5ETSNT2Q8Hzjnvd1zF0fvwfdWlkEs IyMS7OU4g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzxtN-00054J-BK; Mon, 27 Jul 2020 07:49:49 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzxtK-00053s-Po for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 07:49:47 +0000 Received: from mail-qt1-f169.google.com ([209.85.160.169]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MplPh-1kaSJ40wqz-00q7XE for ; Mon, 27 Jul 2020 09:49:39 +0200 Received: by mail-qt1-f169.google.com with SMTP id o22so11290536qtt.13 for ; Mon, 27 Jul 2020 00:49:38 -0700 (PDT) X-Gm-Message-State: AOAM533XBr/NVsSGColr3t+SSgKd1tvqhydjMwiCS+17KPlKOK73G6Zh QRZvLrHLAPla/WjmI1N+j1VqgCglPFNl1vf6Xj0= X-Google-Smtp-Source: ABdhPJyqvtFtc9EeRn23Z++9snt24Adrey6DZY0MGaUrfMzSaEFa1Rx5bauVO7MVoNlBp10B/WVA2Ld+bxrUKqWk8nE= X-Received: by 2002:aed:2946:: with SMTP id s64mr614510qtd.204.1595836177987; Mon, 27 Jul 2020 00:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20200726043948.1357573-1-daniel@0x0f.com> <20200726043948.1357573-7-daniel@0x0f.com> In-Reply-To: <20200726043948.1357573-7-daniel@0x0f.com> From: Arnd Bergmann Date: Mon, 27 Jul 2020 09:49:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] ARM:mstar: Add syscon node for "pmsleep" area To: Daniel Palmer X-Provags-ID: V03:K1:qaYxqGCtZRIiquX/Io14u/1fkYeksGYfuuNfD0cHLSqlVnDcHpa LSsGmDLryhsboJ4pcZ+35rztPj/lE3gtvBpWG0wlvUPE2vlQ1v+1YH+DlTVlJycmTC69mQh krK2v8nExqh29Kc2UQy446ZYqErVMrb64MX5Uw1lbUA/BrxGL0kHj7jAxyQ+ti3UNj9QZg6 MrJRd7+pNT0ze8gmCE2oQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Upww8iKcCOo=:LptBaw2somwlDxfUKkRZVv VHGADIGdw0v8mMxbx6tXZKunjnuduhD9B/b8YPafeIVSEE1oOMx7pDI3F72CyEZUN7kIxSYSr E/9Z2Ek3q6u4rEtfasZPwC2uviv/A970julviHE5S1nrkwUlrEJyMKswMQEsV+TsxBbdOrQuG v9SP8ZawgJGEPSyDjePfDxUOeUyhJiuJLmD6eZ3mgy77uS6QDJkT3B1azT+1DDZ7mA9jujedx KfoDTnEcXMA4/QLbp7bptUxaFrXbj9vg+OWD91hUSRECmvZShFOzJM1CPAz936AlweKI5eWoc puJO6/ATwy2EfCaf5YxGqzSru2V0k2xBrLrYNBLsHoBsTw7UDzmx7+BHZNmehxyiFrsMB6lej kSVgg4PoLDkl4HA0PvKKEraH4w/DgqI8YFcBNafwOzR1Ij5G8LK3ytmlQz7r1pMXuPjUA3mHo 1t+Ij7hGf4zXcfMFHe8VfzYq6y8ch6nZq4WTNt31nHKu/VpoyPKY7rWgAYp3Sc/8o7hQv9/0/ Iy6OJDllGSCEC2ZyBrKS+U+nw5F5DWbrsX38SsG7NvUhgmmgk2LYoB7rdpxMTHWVRPpv78h0a RTXdQE5iH2/y2tOuzRPnBRJhAFRVXJPMkxOCIMNCMKF6wkYKF4BYpZeczF6VKR+2WVzf8w/Xs BSG/mWbzBu0v/c9FOOxD+qsviMD/4YF96hUGGPuZjwLiKNNJj1yGZpEkrb6A5owsfXJmXW4Td FcOd+PQfgF1+td1it9RUoqlcpv+KHUBayZAT7V+gKFrwIqYRN/nK/oKMGbX9NCFf2Y2KC4DZ0 ti8RVLI5tUYv/5a1LnMchpMmJZEKMkKYS1QpUw5STZ82dnWWF5XBddcH9RkB9N2ldTPuqp9g1 6+89H2+ttJVXrAMdVohctSnS8yWhnnYLVZFRzAM6gziwQz03iPtyHvync22A9Myty4+aOM/ij uprs0xCy4Ssyb+n2vIk2UE+r3ymfl4ln4r+kZraU6jzfEbuzeDgM3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_034947_056852_B8852E6D X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: SoC Team , "linux-kernel@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 26, 2020 at 6:40 AM Daniel Palmer wrote: > > MStar v7 SoCs contain a region of registers that are in the always on > domain that the vendor code calls the "pmsleep" area. > > This area contains registers for a broad range of functionality and > needs to be shared between drivers. > > This patch adds a syscon node for the pmsleep area so that other > drivers can access registers in the area. > > Signed-off-by: Daniel Palmer I think it would be better to add a more specific compatible string in addition to the "syscon" one, to make it possible to later add a proper driver for this area, in case there is a need for that. Arnd > --- > arch/arm/boot/dts/mstar-v7.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi > index a73b1d162dfd..c8b192569d05 100644 > --- a/arch/arm/boot/dts/mstar-v7.dtsi > +++ b/arch/arm/boot/dts/mstar-v7.dtsi > @@ -73,6 +73,11 @@ riu: bus@1f000000 { > #size-cells = <1>; > ranges = <0x0 0x1f000000 0x00400000>; > > + pmsleep: syscon@1c00 { > + compatible = "syscon"; > + reg = <0x1c00 0x100>; > + }; > + > l3bridge: l3bridge@204400 { > compatible = "mstar,l3bridge"; > reg = <0x204400 0x200>; > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel