From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F6AC433FE for ; Sat, 18 Sep 2021 09:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F15960F45 for ; Sat, 18 Sep 2021 09:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238800AbhIRJm3 (ORCPT ); Sat, 18 Sep 2021 05:42:29 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:34963 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238420AbhIRJm2 (ORCPT ); Sat, 18 Sep 2021 05:42:28 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MGyl3-1mexEi2OBv-00E894; Sat, 18 Sep 2021 11:41:03 +0200 Received: by mail-wr1-f45.google.com with SMTP id d21so19168349wra.12; Sat, 18 Sep 2021 02:41:03 -0700 (PDT) X-Gm-Message-State: AOAM5333rzB5ir+X0d5Gt9bT5adFqMlnJEXGClhPEBDShKRZ5IQL2aTw RAHIas0baG949VVU7TvmG+fyqz/TYWp6cyEYzeg= X-Google-Smtp-Source: ABdhPJx9yqI+1/9/BGcNvj+UPWnFAxrQw73U1HxZSwhNOnNNiyPOuaYL8RQiCFPVaYCRRHWPncR7qh7DTzY4XWN92IQ= X-Received: by 2002:a05:6000:1561:: with SMTP id 1mr7487499wrz.369.1631958063252; Sat, 18 Sep 2021 02:41:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Sat, 18 Sep 2021 11:40:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] mei: Remove usage of the deprecated "pci-dma-compat.h" API To: Christophe JAILLET Cc: "Winkler, Tomas" , Arnd Bergmann , gregkh , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:aRHOdbpH6fsglEmrF1NTwMM2llsFNWYF2GO1h2C24KAvivt0VFC lf7RvzIgimM7txwOXL29U62pUX2WnwDwA9KEoUq59AhYg6ohTvUUagBI5GV1/Cw4bHxoztp uA9lBCeeszkupgUhJ5Z9Pabeo0huk5IPKC5TVzbOGRhYKL5YlwDHqXzrSMAlURtVhGLHjdp A0q55Nk4mqkHu1ay7MbYw== X-UI-Out-Filterresults: notjunk:1;V03:K0:rzKSYP4C1fY=:48v6u8SUodSB8u4efnR1kg Z2tMe3uj/ENKOIUQ25M9haukuRBGDr/6jx+E+xe0FhYPB+80HyvTIQaJ+2lohhsarAZj892Y/ B5c3mbSCyP4Rq9IxJxJ0oI+vd19zehA7o08B6vPpemqMSfLf/Nu6XMBV24RI5Kjf4oPZZSWez KgtEHTFkEatWT12NJQ2JGNKYLF41hWFWNjrFnwV5ftwxepNadVqrRrQbSlw5GY4g7zuWNEltA QxHgBcpOZkzgZL/4poheJ/I4Cvn8VAO4RONRhiPD6k8kdmujgU0St7FohxCo3LP9+pmordGV+ sahQFdpHEOGMPNOMgByrt+a3d3dYUzEOBU0GSApOLiL8HsRK6U8E2QTw698UlBWY1TJrcp0TS 9VbsNAyFIU4ZaTCfYyIn2WC1XP0cOYl8syPK1qeI8QoMFovr3uvVGfIztJrY7sGgt9tSl8B64 A9jx1EngWpHTnfFI67bg9ymd46QMDapjxWIodKCFLUPBipwB479/lLku9c15XxHjymsbHQ1PT sfNRB8/sgPJ2s9K+vzxjfukRYj37thikAjXdpIRZztMxtI8hAv6Oxvswe1WZaeCXugh3YsYPm GSWIiXUP1+vnAUpF3Z6r61S4ECNKwVFuawh4nyHjmSRD3+rjEa7t17mAtGePQpovMNmSiRMw9 QaTbsHXSaE52GEQhsaSjS1QuAjwkaPmrR8mvnQigab0PDY19z88gdt8ufCwPopJVchs+p3bBr yQhG2Rk0tS6MgxXqPzzHb6yI72MVMiXFHxUUM/zdq6oCEp53xorUCkhqH0pRBkWXHTaeQDbG2 B5fNHn9/wkkj3zckpvb09qjAlmNA2jwyQTj8qu48wi8KTXTaUptzUVzq6w/WPfV4XCgapdEfJ Tm0tuqkcsV5Vdt0lH8mQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 18, 2021 at 7:36 AM Christophe JAILLET wrote: > > In [1], Christoph Hellwig has proposed to remove the wrappers in > include/linux/pci-dma-compat.h. > > Some reasons why this API should be removed have been given by Julia > Lawall in [2]. > > Finally, Arnd Bergmann reminded that the documentation was updated 11 years > ago to only describe the modern linux/dma-mapping.h interfaces and mark the > old bus-specific ones as no longer recommended, see commit 216bf58f4092 > ("Documentation: convert PCI-DMA-mapping.txt to use the generic DMA API"). > > A coccinelle script has been used to perform the needed transformation > Only relevant parts are given below. > > @@ > expression e1, e2; > @@ > - pci_set_dma_mask(e1, e2) > + dma_set_mask(&e1->dev, e2) > > [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/ > [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ > > Signed-off-by: Christophe JAILLET > --- > v2: Change Subject to be more explicit > Keep only relevant part of the coccinelle script > Try to improve the commit message to give some reason of why this change is done Reviewed-by: Arnd Bergmann