All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Xiaolong Huang <butterflyhuangxx@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>,
	David Miller <davem@davemloft.net>, Arnd Bergmann <arnd@arndb.de>,
	Networking <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] isdn: cpai: check ctr->cnr to avoid array index out of bound
Date: Fri, 8 Oct 2021 09:02:14 +0200	[thread overview]
Message-ID: <CAK8P3a3A+CxJVt79ogxQn3NuRB01TsFchr-zu30E57xBut_=NQ@mail.gmail.com> (raw)
In-Reply-To: <20211008065830.305057-1-butterflyhuangxx@gmail.com>

On Fri, Oct 8, 2021 at 8:58 AM Xiaolong Huang
<butterflyhuangxx@gmail.com> wrote:
>
> The cmtp_add_connection() would add a cmtp session to a controller
> and run a kernel thread to process cmtp.
>
>         __module_get(THIS_MODULE);
>         session->task = kthread_run(cmtp_session, session, "kcmtpd_ctr_%d",
>                                                                 session->num);
>
> During this process, the kernel thread would call detach_capi_ctr()
> to detach a register controller. if the controller
> was not attached yet, detach_capi_ctr() would
> trigger an array-index-out-bounds bug.
>
> [   46.866069][ T6479] UBSAN: array-index-out-of-bounds in
> drivers/isdn/capi/kcapi.c:483:21
> [   46.867196][ T6479] index -1 is out of range for type 'capi_ctr *[32]'
> [   46.867982][ T6479] CPU: 1 PID: 6479 Comm: kcmtpd_ctr_0 Not tainted
> 5.15.0-rc2+ #8
> [   46.869002][ T6479] Hardware name: QEMU Standard PC (i440FX + PIIX,
> 1996), BIOS 1.14.0-2 04/01/2014
> [   46.870107][ T6479] Call Trace:
> [   46.870473][ T6479]  dump_stack_lvl+0x57/0x7d
> [   46.870974][ T6479]  ubsan_epilogue+0x5/0x40
> [   46.871458][ T6479]  __ubsan_handle_out_of_bounds.cold+0x43/0x48
> [   46.872135][ T6479]  detach_capi_ctr+0x64/0xc0
> [   46.872639][ T6479]  cmtp_session+0x5c8/0x5d0
> [   46.873131][ T6479]  ? __init_waitqueue_head+0x60/0x60
> [   46.873712][ T6479]  ? cmtp_add_msgpart+0x120/0x120
> [   46.874256][ T6479]  kthread+0x147/0x170
> [   46.874709][ T6479]  ? set_kthread_struct+0x40/0x40
> [   46.875248][ T6479]  ret_from_fork+0x1f/0x30
> [   46.875773][ T6479]
>
> Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

  reply	other threads:[~2021-10-08  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  6:58 [PATCH] isdn: cpai: check ctr->cnr to avoid array index out of bound Xiaolong Huang
2021-10-08  7:02 ` Arnd Bergmann [this message]
2021-10-09  0:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a3A+CxJVt79ogxQn3NuRB01TsFchr-zu30E57xBut_=NQ@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=butterflyhuangxx@gmail.com \
    --cc=davem@davemloft.net \
    --cc=isdn@linux-pingi.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.