From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F894C433F5 for ; Fri, 17 Sep 2021 07:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A05260ED7 for ; Fri, 17 Sep 2021 07:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240901AbhIQHWJ (ORCPT ); Fri, 17 Sep 2021 03:22:09 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:51335 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245232AbhIQHVn (ORCPT ); Fri, 17 Sep 2021 03:21:43 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MZTua-1mMAcs3LDK-00WS52; Fri, 17 Sep 2021 09:20:20 +0200 Received: by mail-wr1-f48.google.com with SMTP id q11so13518569wrr.9; Fri, 17 Sep 2021 00:20:20 -0700 (PDT) X-Gm-Message-State: AOAM532SPEcujl2QPc8IMXQq+pB0k0jfbvK/SuBo2KwYcL6z46u4ZTEU xZ8eNS4N/QpJ3cY/qjfn7bH78RuNQjyhLtIhNT8= X-Google-Smtp-Source: ABdhPJzdJSJ6F33yjr0CdyRsW+lkSspPGo4OPRsF+cxt6MZwRHtL6vt7o+1q/fpUCntoF20xXvSiehvIPKe8B/Avb6s= X-Received: by 2002:adf:f884:: with SMTP id u4mr9944710wrp.411.1631863220417; Fri, 17 Sep 2021 00:20:20 -0700 (PDT) MIME-Version: 1.0 References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> <3bad5d2f-8ce7-d0b9-19ad-def68d4193dd@linuxfoundation.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 17 Sep 2021 09:20:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Brendan Higgins Cc: Arnd Bergmann , Shuah Khan , Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , KUnit Development Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:NuzFJeT2aMzpmFAJp2FWhBboQZtDkCJ3CsY9dMo64jXv+b3OlFO wLArjBrjhW+OJ6FkE/gZgAKM4enM8I+N3MR4ao459xLvY/pbqzn0zvKvag8xyjibulHxBA5 eCfYC8wESoyP3lNqK16uLh4fYcHErIK27l7I3FIMY+SVI5aVlR8ia2+bm/nCu4hKqh1BXZ1 D0A83fVvDm6UFhBVafoVQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:1zdVGf48HAA=:uqg8nAYAAgG2DJ6eK2U1fU S9FS1ttaogLXKnWho96HiNIzqXi8cl5eq3RB0S0gzvqHsnZivEUhrzQ4fAF3pRnwOyYaPUEnZ 3V3wLgcv5HMKzVGa/xRDM6PmFehpH0I1lPNRVdtIBaMaHVR0pxMPjtG/arVCMpWwo/9SGoCUW 2HxRzAs/t3ijopGxrruoayi2Bq+1BSv+pjR8EGwH886LQUW19tzIlbm57PkV7/KWdypAMGqaE rlCPwJk+IdVO3tfXRHaZxjFHZDhtlqKO1RKalHhpZnDefatkD4MT3FWlFjypcOiaz6YxX9YL2 T5PVJraRMhE5jkFjW+pJwSBUo4pMOE2eruFr+mz+e6Pb+OzZV6ulhkph3I1pFazb7TNZGw3Op xGvqIWhYzls6etVv5IPTbzTYp+WJvnkCcK7r330pKMpK40qNEC9Cb4OHT80IK+7Xg1//kReWP nAGrVP5W1OZwZXCc8HMYAf/d4hzqX96BRN4VDswiLFHMr9OZCpXN7hl+TLjBivSFx7sfguOoJ KaYsT9hsx/rQQnFRCFjoweCDw1YvDUkSqiZEcYZwuSSWEAhjdPdKeF6Jh6eUATbgo691Tq3ZM QNa1u2Zyc7SYqc4uTcHxIoygcBJjHvpUKuGPStrkus8WC1sm0+7XqK8hT4dxMb5n1zLIFr8uR B1EH9Ge6m1uWuKmB4Cnere0NXtJCuTQN1rfInS/0MX+KyAsnwSKPXd7p2ik/zMq6rxjvwhSKo OfM1vp8443ilWaSzcL8HzHxfZzZNSY/hVZsXW3u954nP7iATFbhEKw7ANIqDOA0j7yHWeJHk7 pM3/7xUWsddCoIMM4rkxo3MgsOAz/MhUj0LY6COw8zImYOBme784tEtaBJyvqk/UkKT/2wnju v5Rx/d1IxiucLtUFAFnw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2021 at 8:16 AM Brendan Higgins wrote: > > On Thu, Sep 16, 2021 at 10:39 PM Brendan Higgins > wrote: > > > > On Tue, Sep 14, 2021 at 3:04 PM Arnd Bergmann wrote: > > > > > > On Tue, Sep 14, 2021 at 10:48 PM Brendan Higgins > > > wrote: > > > > > > > > On Mon, Sep 13, 2021 at 1:55 PM Shuah Khan wrote: > > > > > > > > > > On 9/8/21 3:24 PM, Brendan Higgins wrote: > [...] > > Alright, I incorporated all the above into a patchset that I think is > > ready to send out, but I had a couple of issues with the above > > suggestions: Thanks a lot for those suggestions. > > - I could not find a config which causes a stacksize warning for > > sdhci-of-aspeed. I keep a history of my randconfig builds. This one only happened once before I fixed it, it may depend on some other combination of options. See my original defconfig file at https://pastebin.com/raw/XJxjVGYa rand/0xAB2DD5A0-failure:/git/arm-soc/drivers/mmc/host/sdhci-of-aspeed-test.c:47:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > > - test_scanf is not a KUnit test. I have three defconfigs for this one, all on x86-64: rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c: In function 'numbers_list_field_width_val_width': rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c:530:1: error: the frame size of 2488 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c: In function 'numbers_list_field_width_typemax': rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c:488:1: error: the frame size of 2968 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c: In function 'numbers_list': rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c:437:1: error: the frame size of 2488 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] https://pastebin.com/raw/jUdY6d3G is the worst one of those > > - Linus already fixed the thunderbolt test by breaking up the test cases. Ok. > > I am going to send out patches for the thunderbolt test and for the > > sdhci-of-aspeed test for the sake of completeness, but I am not sure > > if we should merge those two. I'll let y'all decide on the patch > > review. > > Just in case I missed any interested parties on this thread, I posted > my patches here: > > https://lore.kernel.org/linux-kselftest/20210917061104.2680133-1-brendanhiggins@google.com/T/#t Thanks! I'll reply to the particular patch as well, but I don't think that this is sufficient here: +CFLAGS_bitfield_kunit.o := $(call cc-option,-Wframe-larger-than=10240) $(DISABLE_STRUCTLEAK_PLUGIN) If 10KB is actually needed, this definitely overflows the 8KB stack on 32-bit architectures. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BDBC433EF for ; Fri, 17 Sep 2021 07:21:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C8EF60F21 for ; Fri, 17 Sep 2021 07:21:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C8EF60F21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bHX//JLQsH9+rZVRKXW0+p/PeEKPg/s7jRoDwQ1cGTA=; b=2AAXXxkbX6uRPD QZ+DXCCwlCwbhPCqprOL1mqRmfpJ3VWEXbcnJRiezI28uqT7qJJB63X0MAiyMTuGY5S9c023FZcZO LAtxLob2cSZHJBi1eofO8vGo+PHZzbHQjT/AZs5uqVO1HKS5Hja+dy39hykgs/Iw6scQW4/KUbVYA Q/Xsx9NbkWKN3Xsc+wKNqVk9GZeG4NZNmdm928SEvj5VjanROZgf3x9cInonUxoEq5KSlWwfNEU8O NQPFJr/0fk1ChQnzfFVHVQfiBye6PiHDtnBxPNc8vPfH5haW6GBUmf4pPW9pltxjEobFWqIoB976d Hgz3Z84YPKJ7VlLJPaug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR8Ad-00DNtK-Lx; Fri, 17 Sep 2021 07:20:27 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR8AZ-00DNro-1K for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 07:20:25 +0000 Received: from mail-wr1-f53.google.com ([209.85.221.53]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MEVJq-1mh8rG3Wqw-00FzFh for ; Fri, 17 Sep 2021 09:20:20 +0200 Received: by mail-wr1-f53.google.com with SMTP id t8so13535637wrq.4 for ; Fri, 17 Sep 2021 00:20:20 -0700 (PDT) X-Gm-Message-State: AOAM530UECwLlL6W5lPQFAaHzc8TPaz3jNBIHx/Mc0O2eodikFJCp8u5 jgf08eiE0kZcWEFKFJtIE3Me8uPBNi4npPQg8iE= X-Google-Smtp-Source: ABdhPJzdJSJ6F33yjr0CdyRsW+lkSspPGo4OPRsF+cxt6MZwRHtL6vt7o+1q/fpUCntoF20xXvSiehvIPKe8B/Avb6s= X-Received: by 2002:adf:f884:: with SMTP id u4mr9944710wrp.411.1631863220417; Fri, 17 Sep 2021 00:20:20 -0700 (PDT) MIME-Version: 1.0 References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> <3bad5d2f-8ce7-d0b9-19ad-def68d4193dd@linuxfoundation.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 17 Sep 2021 09:20:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Brendan Higgins Cc: Arnd Bergmann , Shuah Khan , Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , KUnit Development X-Provags-ID: V03:K1:M5tbJ5HQZBMp8b0Sev3vupePwZCVzX8obXkrIdiZxeIh/XEMmdy g1ilzFvrEt6deTTlt8KUYQ4EDqF+AZ75rm++s+f+xizkQM7RKyIUjaU6MMGOx1l8jtKvzh9 WAHKEbCmTAkADr6+0Vd6GJiOvLjq4zkbXqwG2Yvl/k+4ov6UlNZ41aJma80SdcmxbRIgDW6 h3cq4oQmV86ilNooknRmQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:It/OJTrFASw=:+WF0cSqTj/UqBaz5wbu+Ul YLfuIaAFmRe53SVhXLXmoAuWgNQ+zb/trOJ5r5XJA5iLlER0Ar7WAOZt7mYgW0N0nvFzelfwL CY7Fe275IljRvryqQR84FwwjBwFLJCZvmhhh1TqCHoP7tUZXCXGu+kr78SHeNzOkdXg8fpDbD r1kT+Cx3rMvpFWT7byKoMJLCcwhuEYIKkLwqdE6nxzzfiwkoSqY3sy++CKMn79vXpScW9OBTu Wh5FHj/UwUGvDLP4jFAbthP55nAGuSI2CH5gk4aLt2UdBZfFL1+/LombP8jYWoaLIgg883jBO INF3d5eoJZwQRlmUJhKEZRHRkWyWH27dO9kXyDe1386xNuL08zWq4p4oIwZr59qXr3mbvAcLR O7rZmqtO4eIrbQlZieunyaOvDkFhfvvBekYiq81Up1piKDbvJMsSQW6y0Q0DeV41Na/yCc5CC rUm9xTLR5GDiODu5gvcLUIOgV8IddJm0UtsjxfJUQxzhKYWfVyXjkeZWksL+W6uYaoc9RhBMZ aJnxW3jZCirARvTv8W3aF9BTA+p5iXI4bFDAymptkbpTXDK+jh0e+Zl/fZTH3JzB1yhfzUA6N aMrSCSL+buwjy7LUanbnYeXv+qLtTSD4B97Yhw2QRCeZi6qLTp8rY1tGGdpLySlM7fyDyoP7C P5QaCehktxuH8tv8aXSQFMUI2aF5ejTuIkJEeazjSWUdyndwkfYi9xitSqONlWDHpDvL3HXKQ 9Q9zEO9sv+h5BllLZFRgAOTOqOIIvHkRC8s9dYFTes61+Gup5uBh05f/yCK4CCZ4lHCwTUYH7 sRJFXm+euKbpzhCkCWGTly6PtJv6gnFNknkAMAy6GL6yENOjc/2QRF4/A7In31rRG7t7p4pjO PxLIQN17zOUpBytU/wrA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_002023_432586_91811294 X-CRM114-Status: GOOD ( 28.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 17, 2021 at 8:16 AM Brendan Higgins wrote: > > On Thu, Sep 16, 2021 at 10:39 PM Brendan Higgins > wrote: > > > > On Tue, Sep 14, 2021 at 3:04 PM Arnd Bergmann wrote: > > > > > > On Tue, Sep 14, 2021 at 10:48 PM Brendan Higgins > > > wrote: > > > > > > > > On Mon, Sep 13, 2021 at 1:55 PM Shuah Khan wrote: > > > > > > > > > > On 9/8/21 3:24 PM, Brendan Higgins wrote: > [...] > > Alright, I incorporated all the above into a patchset that I think is > > ready to send out, but I had a couple of issues with the above > > suggestions: Thanks a lot for those suggestions. > > - I could not find a config which causes a stacksize warning for > > sdhci-of-aspeed. I keep a history of my randconfig builds. This one only happened once before I fixed it, it may depend on some other combination of options. See my original defconfig file at https://pastebin.com/raw/XJxjVGYa rand/0xAB2DD5A0-failure:/git/arm-soc/drivers/mmc/host/sdhci-of-aspeed-test.c:47:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > > - test_scanf is not a KUnit test. I have three defconfigs for this one, all on x86-64: rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c: In function 'numbers_list_field_width_val_width': rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c:530:1: error: the frame size of 2488 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c: In function 'numbers_list_field_width_typemax': rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c:488:1: error: the frame size of 2968 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c: In function 'numbers_list': rand86/0x30AD57FB-failure:/git/arm-soc/lib/test_scanf.c:437:1: error: the frame size of 2488 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] https://pastebin.com/raw/jUdY6d3G is the worst one of those > > - Linus already fixed the thunderbolt test by breaking up the test cases. Ok. > > I am going to send out patches for the thunderbolt test and for the > > sdhci-of-aspeed test for the sake of completeness, but I am not sure > > if we should merge those two. I'll let y'all decide on the patch > > review. > > Just in case I missed any interested parties on this thread, I posted > my patches here: > > https://lore.kernel.org/linux-kselftest/20210917061104.2680133-1-brendanhiggins@google.com/T/#t Thanks! I'll reply to the particular patch as well, but I don't think that this is sufficient here: +CFLAGS_bitfield_kunit.o := $(call cc-option,-Wframe-larger-than=10240) $(DISABLE_STRUCTLEAK_PLUGIN) If 10KB is actually needed, this definitely overflows the 8KB stack on 32-bit architectures. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel