From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC PATCH 02/12] soc: qcom: ipa: DMA helpers Date: Wed, 7 Nov 2018 13:17:29 +0100 Message-ID: References: <20181107003250.5832-1-elder@linaro.org> <20181107003250.5832-3-elder@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181107003250.5832-3-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Alex Elder Cc: David Miller , Bjorn Andersson , Ilias Apalodimas , Networking , DTML , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Linux ARM , Linux Kernel Mailing List , syadagir@codeaurora.org, mjavid@codeaurora.org, Rob Herring , Mark Rutland List-Id: linux-arm-msm@vger.kernel.org On Wed, Nov 7, 2018 at 1:33 AM Alex Elder wrote: > > This patch includes code implementing the IPA DMA module, which > defines a structure to represent a DMA allocation for the IPA device. > It's used throughout the IPA code. > > Signed-off-by: Alex Elder I looked through all the users of this and couldn't fine one that actually benefits from it. I'd say better drop this patch entirely and open-code the contents in the callers. That will help readability since the dma API is well understood by many people. Generally speaking, try not to wrap Linux interfaces into driver specific helper functions. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 7 Nov 2018 13:17:29 +0100 Subject: [RFC PATCH 02/12] soc: qcom: ipa: DMA helpers In-Reply-To: <20181107003250.5832-3-elder@linaro.org> References: <20181107003250.5832-1-elder@linaro.org> <20181107003250.5832-3-elder@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 7, 2018 at 1:33 AM Alex Elder wrote: > > This patch includes code implementing the IPA DMA module, which > defines a structure to represent a DMA allocation for the IPA device. > It's used throughout the IPA code. > > Signed-off-by: Alex Elder I looked through all the users of this and couldn't fine one that actually benefits from it. I'd say better drop this patch entirely and open-code the contents in the callers. That will help readability since the dma API is well understood by many people. Generally speaking, try not to wrap Linux interfaces into driver specific helper functions. Arnd