From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257CAC3815B for ; Tue, 14 Apr 2020 13:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B0832075E for ; Tue, 14 Apr 2020 13:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387630AbgDNNiP (ORCPT ); Tue, 14 Apr 2020 09:38:15 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59075 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502806AbgDNNPa (ORCPT ); Tue, 14 Apr 2020 09:15:30 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MxmJs-1j3uc50aLu-00zIi1; Tue, 14 Apr 2020 15:15:27 +0200 Received: by mail-qk1-f179.google.com with SMTP id w70so8841819qkb.7; Tue, 14 Apr 2020 06:15:26 -0700 (PDT) X-Gm-Message-State: AGi0PuaZ5opB60kucpaK2dxIo1LPh1vIWAMOIHqNxBnuUvLBiuht7WaX l68Q8QjBWHmvRfWsPKpNrMC7cLC7CqoXhfmHQ/Q= X-Google-Smtp-Source: APiQypKOQ+PuEkXGp7Hz6/dS0o0rdKdh/QEInnUOkTVAVIiLqxS184q6+DgOArKrPli8Cwrbt3SJu+aKb3Opir5v4iw= X-Received: by 2002:a37:9d08:: with SMTP id g8mr13992637qke.138.1586870125394; Tue, 14 Apr 2020 06:15:25 -0700 (PDT) MIME-Version: 1.0 References: <20200414070142.288696-1-hch@lst.de> <20200414070142.288696-5-hch@lst.de> In-Reply-To: <20200414070142.288696-5-hch@lst.de> From: Arnd Bergmann Date: Tue, 14 Apr 2020 15:15:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer To: Christoph Hellwig Cc: Andrew Morton , Alexander Viro , Jeremy Kerr , "Eric W . Biederman" , linuxppc-dev , Linux FS-devel Mailing List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:niGzd+JIMAutrTQXi6aKMm7ZjyhZV08h5hlKZzx03Gb3lOmqT6z 7i9vKEXvzYnwIGk8z3AGZjTgK2evm1jqoj8C/KsTN2Ng17n0WzNRUfAttBxm+cyLxzHRCbd ZgmOELgyTQmtDGKM9c0uepxXWGPrNEb5DvfV8rBFyumfuu2aoBGFr67kqa4kjgCo6DImAZb fC212L394gbLr8KoeHrRg== X-UI-Out-Filterresults: notjunk:1;V03:K0:In4NPF/T4tQ=:D5Hh2GBE1UE4cO2sq1wZiv RC3T/YjsyxZv/Ps3c4TABpyGM0qA6CTNR2x4Rks4MoHbc7ZaTIf5R4s61VqPYspc/1nq1v5ul e6iKT3tPdL8wn3bTuJp5SqO6ncMhuC2n8ukLKcCkkKdIvd/XjcKdcMr0bmfw3xX17IlLVxwqD PcsmOzadW/bIy5VFJFWI8NDupqMlKM8Cxmp+XdqwPmlBSEqTwtUBDT6rl7EEIi6E9Y+IE8iG8 a8vQNskKzM+Vo1MqAfhXJyxMu1CkvY7xoikclgJ0BAnNSaAAwpgnAcFTj9YAxkcd424JMuTVk +bmNAyEQshYaZ4wQBK1cs+mypFEa1q38cWAgCOLcGJqVSLFse6iWTQklWw/3Db2EFxAT8d+f+ BxcRj4dBk9Cahs+kIctVw9mz7mdBKOZtI5sDIxKv96lWFo16sL5o7jJJBBXTTphXqb6m0ICrV frTKlzZnN4qNCGvTrUGSgkxekj/y0XhlnG9vGDX3fsCxw9H7Semf4n8JhdijAWCbEm3auYWMO JgY7Gu64sj1PqqvdO52ZIbz0CGPP391WCRIRQkdhvXvqgD6SS9pdncyT4tjohGVM0jQCDnb1w DCoK9zdPjPGAahfo3JRZjNtebuHMhMDbI1LN1zci9H8uNZBRvqt6alrXlj6Z9ZJw8BkIaoR+n tpOj6W213m7vpp5e5NxGkQB9wdpCUrWQFcS6tvZJqUiy4GXXXvHIUtkJOGjo/qNZWHJH4Oo/N 7WyaUiDFlGuBzv+rPC9/aKBgh1ndpMJvQW5Yqoby+LyBpS83Yj70Y0QtBjD45AThagnWckzBU db9XVwsjcezC3Zga9uFW8Spn9Jk6s+D3epsJDdiSY3kyhSi/7M= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 9:02 AM Christoph Hellwig wrote: > > Instead of messing with the address limit just open code the trivial > memcpy + memset logic for the native version, and a call to > to_compat_siginfo for the compat version. > > Signed-off-by: Christoph Hellwig Nice! > */ > #define user_long_t compat_long_t > #define user_siginfo_t compat_siginfo_t > -#define copy_siginfo_to_user copy_siginfo_to_user32 > +#define fill_siginfo_note(note, csigdata, siginfo) \ > +do { \ > + to_compat_siginfo(csigdata, siginfo, compat_siginfo_flags()); \ > + fill_note(note, "CORE", NT_SIGINFO, sizeof(*csigdata), csigdata); \ > +} while (0) I don't think you are changing the behavior here, but I still wonder if it is in fact correct for x32: is in_x32_syscall() true here when dumping an x32 compat elf process, or should this rather be set according to which binfmt_elf copy is being used? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30087C2BA19 for ; Tue, 14 Apr 2020 14:44:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC71A2076D for ; Tue, 14 Apr 2020 14:44:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC71A2076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 491pCN1JNxzDq7F for ; Wed, 15 Apr 2020 00:44:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=217.72.192.74; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 491mFL3847zDqQk for ; Tue, 14 Apr 2020 23:15:31 +1000 (AEST) Received: from mail-qk1-f170.google.com ([209.85.222.170]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MUXlG-1jomD91BPk-00QUEr for ; Tue, 14 Apr 2020 15:15:27 +0200 Received: by mail-qk1-f170.google.com with SMTP id j4so13016728qkc.11 for ; Tue, 14 Apr 2020 06:15:26 -0700 (PDT) X-Gm-Message-State: AGi0PuY/poXBEywe2nEjauQGQYgcjyQ3FyiMRaxhQPgclRYEwGFrUvjE sxwwuSn1gZfu4j8gbWzypi6YiRrGqQdVBaNOVDk= X-Google-Smtp-Source: APiQypKOQ+PuEkXGp7Hz6/dS0o0rdKdh/QEInnUOkTVAVIiLqxS184q6+DgOArKrPli8Cwrbt3SJu+aKb3Opir5v4iw= X-Received: by 2002:a37:9d08:: with SMTP id g8mr13992637qke.138.1586870125394; Tue, 14 Apr 2020 06:15:25 -0700 (PDT) MIME-Version: 1.0 References: <20200414070142.288696-1-hch@lst.de> <20200414070142.288696-5-hch@lst.de> In-Reply-To: <20200414070142.288696-5-hch@lst.de> From: Arnd Bergmann Date: Tue, 14 Apr 2020 15:15:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:6J3AYC5un6DK7hPQGY4I8gjgiK6qkm7MYRXf6tRNGjv+nKHlwvb iKWbIM1hR7qYn/5Oec7IHWPUfOKpMTbygBlLUlAM8E88lxopA+zq+uOQnEYWS0Axts+t7D+ pynhtE3hxJ8xI1171CAe+libeLj8ndPedaAZ8FW1ioi6lchwJVA94U/ISwZ6ibzsNmcoPCx lUEGaD/h5/UKnuyJClDOA== X-UI-Out-Filterresults: notjunk:1;V03:K0:9sdtSQAvPEk=:qjNBAe+eKd6KU/9eMkOd/4 aIkjTApSSO1jCPgKuGDYSXKh2nBVL3qEr7I6bzzNZb8x8qLNhdpxmdA2Z9zgUu8R+OJBxUEl4 Uy7r8vGfjraAkR1hhWy95VnwpmiPQJPeSvOmnutQzCQcYbDjCuuaXy23ENr/oIoyzB1I/0whI JZIa/1WvhS6Jz+ttQlHSpFQXBH6l1aBWk53D+ny4WlQPKJX+dXhasPMjYLYKL/552zBrWw0un 2HmrhxY2CJwdHK1g0wbB99KymXHZ2uYZKVFPWo+PdHx5tTTqE3EXxsy8JyF9/Pe5t9g9Ez+qM BaOB2mI5x+eVutwD5s6btZPJHdeAGtPvXuUFZfaWu2E+80v6FYbMuaHA+iz8uzRJIyznfo0wH cnFqtIbw8cWlgFeBcdkduBdCVXkPUhJC8qqrKSuhHet2OHe674uFnrTc8Enl0zY4SiErXAJ9y fikw+LYaYqhh+QpJiLhRbPhmSU0uYXvoOmbNOAlb/aHeAmJKSBkUhtOty94KBRt20MWDaZARZ gxHPHOE5/5oaCCSA4fYDFQBbkfD+zj6FKlCbP59Vn1Iu8025gqIJ/qcRNGuSe2y63oB0i62lV N/K7FulyfbiX/3SexNlX1f6as2BT/M82eGgFbMC/tQwDpevBxuW8jcXG4JXzew20b/WlJV+RF sc/xtl6gh49IQ+rL5nIeXhZ0hilrLDwi7+Q2aRAbpGd6YWl/qBQ3QUlmPYtONhZKri1V6oanW ruqrEd2Nwa23O5bRU3SCHjcOcfpHc8G2wgx8y13fY7jEk+7EBHcvN8DsDvfCRuJ3m9t0GQeV2 8Xr2LZExBCyyatGt5Fhn9DE5bzQaLHByp6PS9ak9niBLiMD3GA= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jeremy Kerr , "linux-kernel@vger.kernel.org" , "Eric W . Biederman" , Linux FS-devel Mailing List , Andrew Morton , linuxppc-dev , Alexander Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 14, 2020 at 9:02 AM Christoph Hellwig wrote: > > Instead of messing with the address limit just open code the trivial > memcpy + memset logic for the native version, and a call to > to_compat_siginfo for the compat version. > > Signed-off-by: Christoph Hellwig Nice! > */ > #define user_long_t compat_long_t > #define user_siginfo_t compat_siginfo_t > -#define copy_siginfo_to_user copy_siginfo_to_user32 > +#define fill_siginfo_note(note, csigdata, siginfo) \ > +do { \ > + to_compat_siginfo(csigdata, siginfo, compat_siginfo_flags()); \ > + fill_note(note, "CORE", NT_SIGINFO, sizeof(*csigdata), csigdata); \ > +} while (0) I don't think you are changing the behavior here, but I still wonder if it is in fact correct for x32: is in_x32_syscall() true here when dumping an x32 compat elf process, or should this rather be set according to which binfmt_elf copy is being used? Arnd