From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F72C433EF for ; Thu, 21 Apr 2022 07:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385997AbiDUHlC (ORCPT ); Thu, 21 Apr 2022 03:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385966AbiDUHkr (ORCPT ); Thu, 21 Apr 2022 03:40:47 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 907B91B7AD for ; Thu, 21 Apr 2022 00:37:04 -0700 (PDT) Received: from mail-wm1-f53.google.com ([209.85.128.53]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MLiPA-1nPuWM2jZY-00Hda4 for ; Thu, 21 Apr 2022 09:37:02 +0200 Received: by mail-wm1-f53.google.com with SMTP id l62-20020a1c2541000000b0038e4570af2fso2771692wml.5 for ; Thu, 21 Apr 2022 00:37:02 -0700 (PDT) X-Gm-Message-State: AOAM532NMEu6Zd2deFTMOYOLvZNfVornnIyqk+TBUpUV2o6n+daIv0W4 ayIqs1DFCBM9XGLEFfzA2OZKB94Uv37r4lrWkjA= X-Google-Smtp-Source: ABdhPJwHFANIhlSxRKH9yHfX8gB2Ane77t+Nbt2ag7w+sIPoSWj1s9wj3aJHPT4PYoCntWM2lk8INTR7f05YbnZQfyw= X-Received: by 2002:a05:600c:4e4a:b0:392:88e1:74a7 with SMTP id e10-20020a05600c4e4a00b0039288e174a7mr7297619wmq.174.1650526622334; Thu, 21 Apr 2022 00:37:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 21 Apr 2022 09:36:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN To: Christoph Hellwig Cc: Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Herbert Xu , Will Deacon , Marc Zyngier , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:d6W7v/3igwX/zZm34omNjccVPDecVuaklHaUXH1wdujkgAdcT/2 ABiDP1z+AtMpoG3Zl2MTVgp4bCjp8JQ3ASv9XaNTmT5m2Fexs3P0HO9xVWoTC8gLQCtyAyU m5tv7Llu6VWx0Ebyp75DxjaAj9O1DkeHh7dEN6RoDswdX6nfha/fmtuIcAgMYMs6nEJe3U0 pa1tG/WUB2eWQGoQ2UVOA== X-UI-Out-Filterresults: notjunk:1;V03:K0:QkUimz+hco0=:KyCd3bMtxlvq7krKCVuLFZ ubpPcegUrKMnuIOCYZtifZVmNB6dqsQoNa33M6Q221q0vvszH+XRFJCskrv6RnHyVQ142HiLX Glq3k7+XNtYoWFZO+16gGQrPsoA/c+P7Li3AqsZcY7BXQ8j0V2us89V7vy2AKUS3SNjL01CZV ksCg5zRExXnZgpcczkWYXgKIQiuM0rtf+Hu38m9M/bE07GuSwPJvQMA5bf/WQVSVK5mL7WwU8 H8phCtUN2iJYHuWgPOIO6X5NBMyY1Wc7ZMGRd/JfIOTWzwXgvx791YXXdeBns5VQlX4YwwlGa RwPBFbjqJW+ZmNTL4LNt5rGMp80RtL7jCcOOnIOr74xsrxDiy7i3RyEyOETVnurM2RCthtA0s 937hvvBuQ8yJ9ukc5Gt7yOV+7HyB4/vYL2ZqUqPjqDNsb+8lHT1NhI01AeDjTl/Jt49nuAkQu HJkxi6gKX+GvkrfaQ+rCTBJdUrbsoSmrzc3FeO9JQeKqINdqLc6m91ZG7sr1qtAJzDJAJTgDK TEs2zam5iPyZQELZ7LAv2PJCzIzEbJb1R5eFP9leZ3lZlvHEcyl6hleKmhHg/5y1xD2mnpM9c H0IONps0a8WVTr9F4OuvvH4FBBvctifLGObNUdkiH9U5X88S6qRP5BbTPPItZeQkFsVOYx+Py +dDjOUSdwXbqsGQyoLVbIRD0VHZ8QRGxT204WjIvZXIX2XMaW4p/5oiA4aN24OdpuF/FfIC/b UjFXnrjI2zTwNnvxwTU7G3tiktkDvKYe700I8oofu/QRmUtjatrPHiABj05kYEUCxswxs2fvb NB1DERlQuyIKdtsOp4rcEkWOFWtaoFWDB0yMOXY2vdBjSSXjuc= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 9:20 AM Christoph Hellwig wrote: > > Btw, there is another option: Most real systems already require having > swiotlb to bounce buffer in some cases. We could simply force bounce > buffering in the dma mapping code for too small or not properly aligned > transfers and just decrease the dma alignment. I like the idea because these days we already rely on bounce buffering for sub-page buffers in many iommu based cases for strict isolation purposes, as well as most 64-bit machines that lack an iommu. Does this work on all 32-bit architectures as well? I see that you added swiotlb for ARM LPASE systems in 2019, but I don't know if that has any additional requirements for the other 32-bit architectures that don't select SWIOTLB today. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 473C4C4332F for ; Thu, 21 Apr 2022 07:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2RWxzShhicB7d4XdpVck1WD47v5E/tOtZ9idyUyc0Ng=; b=duyy9MKYrZNUmu j02jYV3vIMu3M7evzwupstLJ2XeoImxxgQaR/Ft7n+qIi2YYwu3+8MdVRBp/8pYr18rK57wkYIzsO n7LThxixybV+R0Q81Ke6pLULEADF1rChynW5pxfN1cdYMn3DYjrjhHjUZQKF86FhalZGNtLEZV7XB fxG6jQb2HSQL7e5SGTbjWT/60wb/FWgwz1m48Elul/nIrih8qe8Wx36yIjMAiBmWanjXkxpiHKCXl SmxQfqNCDVsZ7Pt6LXlrWOZzTuaw7Cyq/MUxQhRgjo9Mz+lttsB9DzWrVnTMirW99FceDBqtMCBev bDfpKbNG65Hv4UwEzXhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhRPK-00C5Tf-1i; Thu, 21 Apr 2022 07:39:18 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhRNC-00C3vm-6g for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 07:37:07 +0000 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MuDTn-1o2GTT407x-00uaHM for ; Thu, 21 Apr 2022 09:37:02 +0200 Received: by mail-wm1-f52.google.com with SMTP id u17-20020a05600c211100b0038eaf4cdaaeso5269163wml.1 for ; Thu, 21 Apr 2022 00:37:02 -0700 (PDT) X-Gm-Message-State: AOAM531jO6CyPFe+NCHnBYpGGKAWvL7zFmB8nF/tL7XykZmqqOp1R7nI vTZbtTzlf1+p6y3msRmGAr5ijRLIYqooUsUQARk= X-Google-Smtp-Source: ABdhPJwHFANIhlSxRKH9yHfX8gB2Ane77t+Nbt2ag7w+sIPoSWj1s9wj3aJHPT4PYoCntWM2lk8INTR7f05YbnZQfyw= X-Received: by 2002:a05:600c:4e4a:b0:392:88e1:74a7 with SMTP id e10-20020a05600c4e4a00b0039288e174a7mr7297619wmq.174.1650526622334; Thu, 21 Apr 2022 00:37:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 21 Apr 2022 09:36:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN To: Christoph Hellwig Cc: Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Herbert Xu , Will Deacon , Marc Zyngier , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" X-Provags-ID: V03:K1:R/hiMMdcW6S83Npf0YsCCVZjNZ2QBY8GnMjcu7yQmbcbea5O7ax 56aJGu60rdkdgoR4Pvb8RHx0oi0SUlfS55IlSSa6QcQgsIuJNSlwmGvQzblTBZVb9KZIlcB UJvsQltt18FTdLscg9heKXVT1JYtL/LkTWTRZw1xEI15Mwg8lbVoVxdPxPkk4JyZCOoWpM2 kw2HbzoFrYVFiquw0WRlw== X-UI-Out-Filterresults: notjunk:1;V03:K0:jiaHCNdgS5A=:y9OqvFVHS7YgIUveydO4/2 jAy6eoFFdlq6MvyHrpB63nNLS927xJ4gHuEBrsJ5Gnp1Oytju4Ng6cOKH2oJMxEUkAsRL/Xs0 d8T81k9PMPNc97G82QmCFXOXWOgme6JjLVi6I+ZjYXGuceet9tq+hwo6slgW/RuCXT9qpSngv x3e/zBK2MRrPfFF+PaxhaK+ht2bx4/mqwpG/6OyVy7+afnMJVg8HdGJLcNkFrqFkffzrOXMeT lZDCFIe3X2sooaSA32KUNo3NApW2g8rTFGDbVk7KbRh0dPvaAnRO6izy1CagKbCx1llNB/IP0 jifFq6zqPY1IEgkGM2+JSOmdAslzLm7a3TPcUVntMQ3Az9QX45eSwUZX+WYsGnZcpBB2VsTH0 KdGoJJOeoe6X03/1Du2V1yEiV7mp51xcPsjhFlcnS15Nf2s7H6aUQwwNCaeEV0AxCxfVG3eRi fQzaAWeqPbTih9alPDnGwlhwZNWX8t64fErSATHjVKkMnAvvRXwsaf/Qi+dw02fjVyg0yF/QR nNpwrcMnTTuSTtgODv2szSzxLrH8Af4BrRDPZf6sc5HVX8rGu4Q8msGw2O0MSwfZJ3AmFTpB+ yaH4RWmbOKUA+4SYSZ0+vs7J2iVErbSaftKgkOfd9Y6gQjL9SWCsAxOb6xYmI0Suj4Nj2A5C9 wIHP2XeOikLE428Dzpb9KjRlvZzAG4xsYUjzFHKewIUAQDX/JEG7Q3mLeJglrFVT1xrGdwTiZ xqGs9iLQacc4jomChy1j5Ulv/QiwtwuT0RcOOn+mSo9vIeJiXdIoSLEZrvwyU62nc8AsG+PX+ KrIxP3+rzOrCq3zowBYeqDT7NYQGV6Npil5FkSnq35HlqK9Ad8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_003706_567119_C120F9EF X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 21, 2022 at 9:20 AM Christoph Hellwig wrote: > > Btw, there is another option: Most real systems already require having > swiotlb to bounce buffer in some cases. We could simply force bounce > buffering in the dma mapping code for too small or not properly aligned > transfers and just decrease the dma alignment. I like the idea because these days we already rely on bounce buffering for sub-page buffers in many iommu based cases for strict isolation purposes, as well as most 64-bit machines that lack an iommu. Does this work on all 32-bit architectures as well? I see that you added swiotlb for ARM LPASE systems in 2019, but I don't know if that has any additional requirements for the other 32-bit architectures that don't select SWIOTLB today. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel