All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Liang He <windhl@126.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	 bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: [PATCH v2] soc: brcmstb: pm-arm: Fix refcount leak and __iomem leak bugs
Date: Wed, 6 Jul 2022 16:51:50 +0200	[thread overview]
Message-ID: <CAK8P3a3MwZaqPu2aLGBwMCZcwhpr0vznqd+RocvUiHnXf7X+Og@mail.gmail.com> (raw)
In-Reply-To: <56e84ee6.7abf.181d3ebcbfe.Coremail.windhl@126.com>

On Wed, Jul 6, 2022 at 4:30 PM Liang He <windhl@126.com> wrote:
> >
> >I think the driver is confusing because it only supports a single instance and
> >stores the data in a global 'ctrl' structure. When you get into the probe
> >function, the value here should always be '0'. This also means it won't
> >work correctly when it runs across deferred probing (you can ignore that
> >bug, but maybe someone else should address this).
> >
> >Removing the 'j' variable from the function would make this more readable.
>
> >
>
> Hi, Arnd,
>
> Based on your explaination, removing 'j' also means following patch 'for (i = j; i < ctrl.num_memc; i++)' to release
> 'ctrl.memcs[i].ddr_shimphy_base' should start from i=0, right?
>

Yes, exactly.

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2022-07-06 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  8:34 [PATCH v2] soc: brcmstb: pm-arm: Fix refcount leak and __iomem leak bugs Liang He
2022-07-06 14:16 ` Arnd Bergmann
2022-07-06 14:30   ` Liang He
2022-07-06 14:51     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3MwZaqPu2aLGBwMCZcwhpr0vznqd+RocvUiHnXf7X+Og@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=windhl@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.