From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C24C433DB for ; Wed, 10 Feb 2021 19:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37F5564EE8 for ; Wed, 10 Feb 2021 19:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232306AbhBJT4g (ORCPT ); Wed, 10 Feb 2021 14:56:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:41232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232614AbhBJT42 (ORCPT ); Wed, 10 Feb 2021 14:56:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F4A364EEA; Wed, 10 Feb 2021 19:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612986947; bh=ySOGh/LfDfk0EzIqZMt+l+18yGYgMtEtuEXYBi5g4TA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NZ6ZYISXE7p99BEUvfNFWg2og56folXbUeOyoZ8+kVzAgtDJZ03+I89uh4iqrlRRy wM2C9l4aWJRzKKmf+ok848J0AJTyWwt6ew8vnqxJu1GlFrcUUaE9TUtK94YXdsNHCJ 8yySFz0SyNzlod+AzBQBWQPyjbm7HOIHMGF6VDYlea6MdSW+8HVeFO2Edf7fRjQwOV Nj6pRFBYyT+aDuCael3O1mDT42s3EMVULHPdrlyNP+9QKLaIjrKkANbOF5yd3aMh8E QpDbZWI82gbDPsSARpuVP3x+QlX+rv4nc5QxC9gLrojopDQJtijBc1PAZSxbBHpouq 6Bc1tai7xcQCQ== Received: by mail-ot1-f46.google.com with SMTP id l23so2968977otn.10; Wed, 10 Feb 2021 11:55:47 -0800 (PST) X-Gm-Message-State: AOAM531WjL7YeecWllIsaLrmfoH5pgyWCQJvDwA8FervTAIi+m0l0r4k gJ+hNPcq6kk3vOB9mPjreYO3GFOZ6vHDqfaT1qI= X-Google-Smtp-Source: ABdhPJzFbtRr/UiFKse9DDFj7qK/D6leqlSGTX/krNy8dk6itAmmGB+6zN0Q1h8IBj4DQy1pe/Nkq+znMh4FLhb764M= X-Received: by 2002:a05:6830:18e6:: with SMTP id d6mr3452163otf.251.1612986946460; Wed, 10 Feb 2021 11:55:46 -0800 (PST) MIME-Version: 1.0 References: <20210209134115.4d933d446165cd0ed8977b03@linux-foundation.org> <20210209214217.gRa4Jmu1g%akpm@linux-foundation.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 10 Feb 2021 20:55:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 09/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha To: Linus Torvalds Cc: Heiko Carstens , Andrew Morton , Christian Borntraeger , Vasily Gorbik , Amir Goldstein , Chris Down , Hugh Dickins , Ivan Kokshaysky , Linux-MM , Matt Turner , mm-commits@vger.kernel.org, Richard Henderson , Seth Forshee , stable , Arnd Bergmann , Ulrich Weigand , Tuan Hoang1 , Debian Content-Type: text/plain; charset="UTF-8" Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org On Wed, Feb 10, 2021 at 8:17 PM Linus Torvalds wrote: > > On Wed, Feb 10, 2021 at 5:39 AM Heiko Carstens wrote: > > > > I couldn't spot any and also gave the patch below a try and my system > > still boots without any errors. > > So, as far as I can tell it _should_ be ok to change this. > > So your patch (with the fix on top) looks sane to me. > > I'm not entirely sure it is worth it, but the fact that we've had bugs > wrt this before does seem to imply that we should do this. > > I'd remove the __kernel_ino_t type entirely, but I wonder if user > space might depend on it. I do find > > #ifndef __kernel_ino_t > typedef __kernel_ulong_t __kernel_ino_t; > #endif > > in the GNU libc headers I have, but then I don't find any actual use > of that, so it looks like it may be jyst a "we copied things for other > reasons". I checked debian codesearch to see if there are any users in distro source code and found exactly one instance that will definitely break at compile time: https://sources.debian.org/src/nfs-utils/1:1.3.4-4/support/include/nfs/nfs.h/?hl=99#L99 This is a copy of a kernel header that was removed ten years ago with commit c152292f9ee7 ("nfsd: remove include/linux/nfsd/syscall.h"). The mainline version of that package removed the contents in 2016 in the following release (2.1.1), but debian is still on the previous version (1.3.4) http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=fc1127d754578cd1 Someone will have to update the package for Debian, but it seems that would be a good idea anyway. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD8EC433DB for ; Wed, 10 Feb 2021 19:55:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51E9B64EED for ; Wed, 10 Feb 2021 19:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51E9B64EED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 873496B0095; Wed, 10 Feb 2021 14:55:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FD2B6B0096; Wed, 10 Feb 2021 14:55:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69CA78D0005; Wed, 10 Feb 2021 14:55:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id 512686B0095 for ; Wed, 10 Feb 2021 14:55:49 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 11468160BE for ; Wed, 10 Feb 2021 19:55:49 +0000 (UTC) X-FDA: 77803413618.15.ant29_4612eb627612 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id E5602180E74E1 for ; Wed, 10 Feb 2021 19:55:48 +0000 (UTC) X-HE-Tag: ant29_4612eb627612 X-Filterd-Recvd-Size: 4575 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 19:55:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2833E64EF0 for ; Wed, 10 Feb 2021 19:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612986947; bh=ySOGh/LfDfk0EzIqZMt+l+18yGYgMtEtuEXYBi5g4TA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NZ6ZYISXE7p99BEUvfNFWg2og56folXbUeOyoZ8+kVzAgtDJZ03+I89uh4iqrlRRy wM2C9l4aWJRzKKmf+ok848J0AJTyWwt6ew8vnqxJu1GlFrcUUaE9TUtK94YXdsNHCJ 8yySFz0SyNzlod+AzBQBWQPyjbm7HOIHMGF6VDYlea6MdSW+8HVeFO2Edf7fRjQwOV Nj6pRFBYyT+aDuCael3O1mDT42s3EMVULHPdrlyNP+9QKLaIjrKkANbOF5yd3aMh8E QpDbZWI82gbDPsSARpuVP3x+QlX+rv4nc5QxC9gLrojopDQJtijBc1PAZSxbBHpouq 6Bc1tai7xcQCQ== Received: by mail-ot1-f52.google.com with SMTP id a5so1830140otq.4 for ; Wed, 10 Feb 2021 11:55:47 -0800 (PST) X-Gm-Message-State: AOAM533+ciH/FVqnwlLql8wb30MXShNyzjWUQSrRiMuiccT8nu8LkOOa 6QKRwGP0y8Zt0DZXWYfY9UwGQGHmx0nW8IU7kIo= X-Google-Smtp-Source: ABdhPJzFbtRr/UiFKse9DDFj7qK/D6leqlSGTX/krNy8dk6itAmmGB+6zN0Q1h8IBj4DQy1pe/Nkq+znMh4FLhb764M= X-Received: by 2002:a05:6830:18e6:: with SMTP id d6mr3452163otf.251.1612986946460; Wed, 10 Feb 2021 11:55:46 -0800 (PST) MIME-Version: 1.0 References: <20210209134115.4d933d446165cd0ed8977b03@linux-foundation.org> <20210209214217.gRa4Jmu1g%akpm@linux-foundation.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 10 Feb 2021 20:55:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 09/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha To: Linus Torvalds Cc: Heiko Carstens , Andrew Morton , Christian Borntraeger , Vasily Gorbik , Amir Goldstein , Chris Down , Hugh Dickins , Ivan Kokshaysky , Linux-MM , Matt Turner , mm-commits@vger.kernel.org, Richard Henderson , Seth Forshee , stable , Arnd Bergmann , Ulrich Weigand , Tuan Hoang1 , Debian Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 8:17 PM Linus Torvalds wrote: > > On Wed, Feb 10, 2021 at 5:39 AM Heiko Carstens wrote: > > > > I couldn't spot any and also gave the patch below a try and my system > > still boots without any errors. > > So, as far as I can tell it _should_ be ok to change this. > > So your patch (with the fix on top) looks sane to me. > > I'm not entirely sure it is worth it, but the fact that we've had bugs > wrt this before does seem to imply that we should do this. > > I'd remove the __kernel_ino_t type entirely, but I wonder if user > space might depend on it. I do find > > #ifndef __kernel_ino_t > typedef __kernel_ulong_t __kernel_ino_t; > #endif > > in the GNU libc headers I have, but then I don't find any actual use > of that, so it looks like it may be jyst a "we copied things for other > reasons". I checked debian codesearch to see if there are any users in distro source code and found exactly one instance that will definitely break at compile time: https://sources.debian.org/src/nfs-utils/1:1.3.4-4/support/include/nfs/nfs.h/?hl=99#L99 This is a copy of a kernel header that was removed ten years ago with commit c152292f9ee7 ("nfsd: remove include/linux/nfsd/syscall.h"). The mainline version of that package removed the contents in 2016 in the following release (2.1.1), but debian is still on the previous version (1.3.4) http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=fc1127d754578cd1 Someone will have to update the package for Debian, but it seems that would be a good idea anyway. Arnd