All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Networking <netdev@vger.kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>
Subject: Re: [PATCH] ptp: ocp: don't allow on S390
Date: Fri, 20 Aug 2021 12:45:42 +0200	[thread overview]
Message-ID: <CAK8P3a3QGF2=WZz6N8wQo2ZQxmVqKToHGmhT4wEtB7tAL+-ruQ@mail.gmail.com> (raw)
In-Reply-To: <20210813203026.27687-1-rdunlap@infradead.org>

On Fri, Aug 13, 2021 at 10:30 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Fix kconfig warning on arch/s390/:
>
> WARNING: unmet direct dependencies detected for SERIAL_8250
>   Depends on [n]: TTY [=y] && HAS_IOMEM [=y] && !S390 [=y]
>   Selected by [m]:
>   - PTP_1588_CLOCK_OCP [=m] && PTP_1588_CLOCK [=m] && HAS_IOMEM [=y] && PCI [=y] && SPI [=y] && I2C [=m] && MTD [=m]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
> There is no 8250 serial on S390. See commit 1598e38c0770.
> Is this driver useful even without 8250 serial?

I think an easier way to do this would be to remove the
'select SERIAL_8250', I don't think that is actually a compile-time
dependency, just something that you normally want to enable
to make the device useful.

I would also suggest removing all the 'imply' statements, they
usually don't do what the original author intended anyway.
If there is a compile-time dependency with those drivers,
it should be 'depends on', otherwise they can normally be
left out.

       Arnd

  parent reply	other threads:[~2021-08-20 10:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 20:30 [PATCH] ptp: ocp: don't allow on S390 Randy Dunlap
2021-08-16 10:20 ` patchwork-bot+netdevbpf
2021-08-16 21:09 ` Jonathan Lemon
2021-08-16 21:15   ` Randy Dunlap
2021-08-16 21:41     ` Jonathan Lemon
2021-08-19 22:58       ` Randy Dunlap
2021-08-20  8:02         ` Christian Borntraeger
2021-08-20  9:59           ` Niklas Schnelle
2021-08-20 10:45 ` Arnd Bergmann [this message]
2021-08-20 15:31   ` Richard Cochran
2021-08-24 21:48     ` Randy Dunlap
2021-08-25 10:55       ` Arnd Bergmann
2021-08-25 17:08         ` Jonathan Lemon
2021-08-25 17:29           ` Randy Dunlap
2021-08-25 18:05             ` Arnd Bergmann
2021-08-25 20:40             ` Jonathan Lemon
2021-08-25 20:45               ` Randy Dunlap
2021-08-25 21:14                 ` Jonathan Lemon
2021-08-25 23:22                   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a3QGF2=WZz6N8wQo2ZQxmVqKToHGmhT4wEtB7tAL+-ruQ@mail.gmail.com' \
    --to=arnd@kernel.org \
    --cc=jonathan.lemon@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.