From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751953AbdIEPLz (ORCPT ); Tue, 5 Sep 2017 11:11:55 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:38706 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdIEPLv (ORCPT ); Tue, 5 Sep 2017 11:11:51 -0400 X-Google-Smtp-Source: ADKCNb5ZtNXNqKq0PpUbuN0Z0ISNrU9H68DPHCxAJvDeZAEDI7njix0faRff/8WR3rt9mlB28fQWD9gabC2YXIFeTG8= MIME-Version: 1.0 In-Reply-To: <20170905112727.13668-1-tklauser@distanz.ch> References: <20170905112727.13668-1-tklauser@distanz.ch> From: Arnd Bergmann Date: Tue, 5 Sep 2017 17:11:50 +0200 X-Google-Sender-Auth: xUwF_Dbc63t0vSpmxouX8QvbX48 Message-ID: Subject: Re: [PATCH] asm-generic/io.h: remove unnecessary include of linux/vmalloc.h To: Tobias Klauser Cc: linux-arch , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 5, 2017 at 1:27 PM, Tobias Klauser wrote: > Including linux/vmalloc.h in asm-generic/io.h isn't necessary since none > of the definitions are used in the header itself. Remove the include in > order to avoid potential header dependency problems if other headers > rely on implict inclusion of linux/vmalloc.h which means that changes > there could break unrelated parts. > > Signed-off-by: Tobias Klauser > --- > include/asm-generic/io.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index b4531e3b2120..d2d3bd163f5f 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -764,7 +764,6 @@ static inline void iowrite64_rep(volatile void __iomem *addr, > > #ifdef __KERNEL__ > > -#include > #define __io_virt(x) ((void __force *)(x)) > > #ifndef CONFIG_GENERIC_IOMAP This seems like a good idea in principle, but I think it needs to be tested well before we apply it, to avoid breaking random drivers that forgot to add their own includes of that header. I've added your patch to my testing queue, but not to the asm-generic tree now. We should see if it leads to any randconfig build regressions on the architectures I normally test. Did you run into a specific problem with the #include, or did it just occur to you that it might help in general? Arnd