From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3EBCC433DF for ; Thu, 2 Jul 2020 11:39:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 968B3207CD for ; Thu, 2 Jul 2020 11:39:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728681AbgGBLja (ORCPT ); Thu, 2 Jul 2020 07:39:30 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:34081 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbgGBLj3 (ORCPT ); Thu, 2 Jul 2020 07:39:29 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MyJx6-1isHMh3GRg-00ykb7; Thu, 02 Jul 2020 13:39:27 +0200 Received: by mail-qk1-f176.google.com with SMTP id e13so25256271qkg.5; Thu, 02 Jul 2020 04:39:27 -0700 (PDT) X-Gm-Message-State: AOAM532z0IHA9N1mAsG65XlCWqo+0pwbShicaHgYkplIDL+zOJ4B9Fdd Gx0V0WAJRgyl1kE6Xf/FAxj82S5DvTjR08HdYBs= X-Google-Smtp-Source: ABdhPJxZnj5versBmr7lWdCxrevvSnrtGz16SQp4OMCvU87jKF+QYKva7czF6a7gzq//AqJiVHDYLYMn/4Cgp3bsm/o= X-Received: by 2002:a37:9dd6:: with SMTP id g205mr30820571qke.352.1593689966522; Thu, 02 Jul 2020 04:39:26 -0700 (PDT) MIME-Version: 1.0 References: <20200630173734.14057-1-will@kernel.org> <20200630173734.14057-5-will@kernel.org> <20200702093239.GA15391@C02TD0UTHF1T.local> <20200702094833.GA16248@willie-the-truck> <20200702111832.GC16418@willie-the-truck> In-Reply-To: <20200702111832.GC16418@willie-the-truck> From: Arnd Bergmann Date: Thu, 2 Jul 2020 13:39:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/18] alpha: Override READ_ONCE() with barriered implementation To: Will Deacon Cc: Mark Rutland , "linux-kernel@vger.kernel.org" , Sami Tolvanen , Nick Desaulniers , Kees Cook , Marco Elver , "Paul E. McKenney" , Josh Triplett , Matt Turner , Ivan Kokshaysky , Richard Henderson , Peter Zijlstra , Alan Stern , "Michael S. Tsirkin" , Jason Wang , Boqun Feng , Catalin Marinas , Linux ARM , alpha , virtualization@lists.linux-foundation.org, Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Z8zyvq6vDbeYzAhJCb6eVc2WB9OLAma8FkNnVfzP5LIPHoG/zM3 H+stHIIcLhAOQVdPGVb+yvmXZS6bZvAlPlPGAb7K3XN/Yf/9tiD+LfyrHyrF2jie4hgS9KZ irhd23yNkSatHVfb8y2fRt4J+qOAfrpIFB+YlKB8CPwZ0m5soww1dXiL+e4/fBrJvO0u51V FIQm29ysC2PM1GqgInKpw== X-UI-Out-Filterresults: notjunk:1;V03:K0:MVQPFMqFHCg=:Mc/Fzv3M0wGaJGNRmiZWUe KhM7kbvbSIBkOSpRLKpn2mQuHZQiboCZGmj68hm2SMimxXdnYI3wYcK7GopZhk+JR3aBa1wbc b1yaKMwUqylhcFZNngxpMvDzlTF1PvFIjy1TTaAhiTRUB9+xeBPFgbS05UWQRwSmi2JAp+DOb w9PpjmmcLdJhOqQzTTiFB20BJKu26jnzomBTvGHtCKhc9ykIackRn29iZzaFfpnZvSRmnkvtQ nRB1TJtCrCSzEq2cuZ3HgSGJM0VJ7lBsDmQcm5XEh8rI8t/0TOOtezYCP2qeHZMi2E7wldego 58hv1Ra6Ath2DLPfjcT9qJbkmo/521T0VPquIdh/1enx7hnlCBxsv8gxG2QnI8BYnZ3fTUTbQ qR3eaMFvTbbNBLDZTj2gNWGUbSrcyEqWPBu76Rmq+UU/d+W1zne8vnaUNyNjsJuIZAAqqnG2b UU8wfrD4HFvkfBctfr/Fi7vwMMXIF3BMSoOp78QP8Qj4tJwVoeCI1Sd1EBvtrBR2wQPmOrS68 eREemZPiU1odDD2L1M3yLfpnjayDnchDXD/nZlp6QVeA6t0OqPfXZm0BQaUv98iolzQP8HxjA 9XW1RGsmMsY/mMjUh2fyz5dymegWy+bpNe76EEzhw7+laAeDZEGO3I15Mx6eE0MRiuUjwffdQ 5It73uUIRMFuiNK89mNjqT2VH+pSxQ4tl28Zqogpjw/CBt72jxVvhtO+89/7RLoZEz1l6X7Gy hdJ0rZ5ohsb3nY2vodf3TGVAKZyMGgO9S+QpihT/Ypet1XCDCqkCdn6XMwIkInXyR4v4dvNJm Y3SqJsvXjFHzffKoa+nDO8VFyuSx0FcmDugZDFctFRy2lf2Cw4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 2, 2020 at 1:18 PM Will Deacon wrote: > On Thu, Jul 02, 2020 at 12:08:41PM +0200, Arnd Bergmann wrote: > > On Thu, Jul 2, 2020 at 11:48 AM Will Deacon wrote: > > > On Thu, Jul 02, 2020 at 10:32:39AM +0100, Mark Rutland wrote: > Not sure I follow you here, but I can confirm that what you're worried > about doesn't happen for the usual case of a pointer-to-volatile scalar. > > For example, ignoring dependency ordering: > > unsigned long foo(volatile unsigned long *p) > { > return smp_load_acquire(p) + 1; > } > > Ends up looking like: > > unsigned long ___p1 = *(const volatile unsigned long *)p; > smp_mb(); > (volatile unsigned long)___p1; > > My understanding is that casting a non-pointer type to volatile doesn't > do anything, so we're good. Right, I mixed up the correct (typeof(*p))___p; with the incorrect *typeof(p)&___p; which would dereference a volatile pointer and cause the problem. The code is all fine then. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 04/18] alpha: Override READ_ONCE() with barriered implementation Date: Thu, 2 Jul 2020 13:39:10 +0200 Message-ID: References: <20200630173734.14057-1-will@kernel.org> <20200630173734.14057-5-will@kernel.org> <20200702093239.GA15391@C02TD0UTHF1T.local> <20200702094833.GA16248@willie-the-truck> <20200702111832.GC16418@willie-the-truck> Mime-Version: 1.0 Return-path: In-Reply-To: <20200702111832.GC16418@willie-the-truck> Sender: linux-alpha-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Will Deacon Cc: Mark Rutland , "linux-kernel@vger.kernel.org" , Sami Tolvanen , Nick Desaulniers , Kees Cook , Marco Elver , "Paul E. McKenney" , Josh Triplett , Matt Turner , Ivan Kokshaysky , Richard Henderson , Peter Zijlstra , Alan Stern , "Michael S. Tsirkin" , Jason Wang , Boqun Feng , Catalin Marinas , Linux ARM , alpha On Thu, Jul 2, 2020 at 1:18 PM Will Deacon wrote: > On Thu, Jul 02, 2020 at 12:08:41PM +0200, Arnd Bergmann wrote: > > On Thu, Jul 2, 2020 at 11:48 AM Will Deacon wrote: > > > On Thu, Jul 02, 2020 at 10:32:39AM +0100, Mark Rutland wrote: > Not sure I follow you here, but I can confirm that what you're worried > about doesn't happen for the usual case of a pointer-to-volatile scalar. > > For example, ignoring dependency ordering: > > unsigned long foo(volatile unsigned long *p) > { > return smp_load_acquire(p) + 1; > } > > Ends up looking like: > > unsigned long ___p1 = *(const volatile unsigned long *)p; > smp_mb(); > (volatile unsigned long)___p1; > > My understanding is that casting a non-pointer type to volatile doesn't > do anything, so we're good. Right, I mixed up the correct (typeof(*p))___p; with the incorrect *typeof(p)&___p; which would dereference a volatile pointer and cause the problem. The code is all fine then. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B0CC433DF for ; Thu, 2 Jul 2020 11:40:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1476520780 for ; Thu, 2 Jul 2020 11:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qyDy3TJS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1476520780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zb7e86ttB/nr8wmzwKrl771gKSYDspARIgqt3QeAiIM=; b=qyDy3TJSoNLuU2MGNIwlxehi2 OhGpPx+bdc/otw1W9pV5wzD65qrtTOVBqGJlqQ9QYP4ja/lFLG4Onv/Ecy55Es2y1pP+nTj0fe626 ZLxkcLEXzlo4LPDUSMvZYrgeWSqrvDdb1AgqG5RWFUHlxKBVRvEeWth/HtFQDUATH7Hl979olgCe/ CiVee0M3jg7YzV/AsXNcDIvGRPOunKKz8nPYPmRYEql3xZdN6hAlIW1qepu0yaZt/NcQcDM2RwczD DyYloR0Fns6n3qzU6RWG5P6VUmhmuOm34DBlqIKoVz2IVXatWUrRH7ttu5EjLWu+TEYHVJvQ2mOTo /wiw2QgPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqxZ0-0005Ww-QN; Thu, 02 Jul 2020 11:39:34 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqxYy-0005W3-NO for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 11:39:33 +0000 Received: from mail-qk1-f171.google.com ([209.85.222.171]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1M26n9-1joUaf3B85-002a4r for ; Thu, 02 Jul 2020 13:39:28 +0200 Received: by mail-qk1-f171.google.com with SMTP id c139so25205311qkg.12 for ; Thu, 02 Jul 2020 04:39:27 -0700 (PDT) X-Gm-Message-State: AOAM533H2mg8js9mRcX2LmeRfhG6ANZH2Pqr6n65BpcXSb/EdQmw8xC7 e7TPslKHora5g9yUZgoW5MmqgJSdKK6T/aioJQM= X-Google-Smtp-Source: ABdhPJxZnj5versBmr7lWdCxrevvSnrtGz16SQp4OMCvU87jKF+QYKva7czF6a7gzq//AqJiVHDYLYMn/4Cgp3bsm/o= X-Received: by 2002:a37:9dd6:: with SMTP id g205mr30820571qke.352.1593689966522; Thu, 02 Jul 2020 04:39:26 -0700 (PDT) MIME-Version: 1.0 References: <20200630173734.14057-1-will@kernel.org> <20200630173734.14057-5-will@kernel.org> <20200702093239.GA15391@C02TD0UTHF1T.local> <20200702094833.GA16248@willie-the-truck> <20200702111832.GC16418@willie-the-truck> In-Reply-To: <20200702111832.GC16418@willie-the-truck> From: Arnd Bergmann Date: Thu, 2 Jul 2020 13:39:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/18] alpha: Override READ_ONCE() with barriered implementation To: Will Deacon X-Provags-ID: V03:K1:vXzhAAyY33wx2UhxNYgD+O54uPnvYCDoG+821aqMtCk/V3lvoQm SEAaa27qoREzC8J/TXitF7b6SFRcgO+EUoez5C0kyX4PFvEaJerox/mpbWnyxLKYsPeRNb8 ASRCJ8LR6hFtGmXqAOSaBNWLUNHieaXfvmRolVtwS7Be//Cebjztm2Buj2MktJg85gieubg Oal5L6J/OxwLAx99iW8ig== X-UI-Out-Filterresults: notjunk:1;V03:K0:T2Zw8GEJ7ko=:hd+LQOI56n9oTo6irSSOmr 5taeDgCTwlawkApTIxaR4VVX7w7nwFglvs40E+yFoq1hNSHvrJNCeoDFUMm+Snia0PY8z8mgQ /OAZEyxIDdSF2E8xMwbBVeOq3NKVyF5CyCbMjFZh4LvzEC2/B6cSmmbu/hGXoE7eFY2azPJxF GfMfAgQgIDyeYecMYPRAmx5SbvJsdF5s3FlnKLpMWmftL4OkwoK7cAm677JF6Fzg5WEhzFXMP NSc5T+VcJ4G+ovd55x3PNh4zdcqqMQrREAGHAcJOO8c5qVYAsxw4Ct1zPsfE2YpQFNjE28iq4 bTIWXk8rA7mPGrpqc2179PktSY/M9dCJvpCnAQmEiBpFOmly3uDdZFGSI7q3COClm+pmty0yI asebsmh/zBZlXeSpW9W0QY5ZNUqcV7ElZQROw1K7KvP2c0R42lQfu5lqDicLfamDVgkuDoMzj 8fVF3GRF1rvBsGleAbgq5wP1EeEKczCVYo11oXo+1oeS6jhNcJqblrMBUsatAe9InYlWOGtw+ QqB/2T4uHEVSYbmD6hZxqDtsshcz5+xLMV3oz2y8COKheLiB9o9M8ZINigeeowqEoKl6EwpS6 pfo16tl5xq2RtHWGnXGkhJsasMqZDnx7huvAvl7OSGAs/RrGR4HLLJoY/SaABeO6S9Bw+rCxD LlOCTUXg7upQ8zYWd6+iLKp9aJsa5ind++PMTyJodG1vpdHNuwH9ZBqYfzWHBiMqtDAFA0PhE n+B7/8zM/SawbAYF3Rh1eN328rlN0hsk4aHOxXGK4gAp/6BAIF8TfFaqRZZ/pwI0BkXh4UVXl OAlNnyzh2AXSW6zI1vAAS+h0RXFzFOCg3yyVhp1ohWQmW9Kj5c= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_073932_998899_342C6CB4 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Marco Elver , Kees Cook , "Paul E. McKenney" , "Michael S. Tsirkin" , Peter Zijlstra , Catalin Marinas , Jason Wang , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Josh Triplett , Ivan Kokshaysky , Sami Tolvanen , alpha , Alan Stern , Matt Turner , virtualization@lists.linux-foundation.org, Android Kernel Team , Boqun Feng , Linux ARM , Richard Henderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 2, 2020 at 1:18 PM Will Deacon wrote: > On Thu, Jul 02, 2020 at 12:08:41PM +0200, Arnd Bergmann wrote: > > On Thu, Jul 2, 2020 at 11:48 AM Will Deacon wrote: > > > On Thu, Jul 02, 2020 at 10:32:39AM +0100, Mark Rutland wrote: > Not sure I follow you here, but I can confirm that what you're worried > about doesn't happen for the usual case of a pointer-to-volatile scalar. > > For example, ignoring dependency ordering: > > unsigned long foo(volatile unsigned long *p) > { > return smp_load_acquire(p) + 1; > } > > Ends up looking like: > > unsigned long ___p1 = *(const volatile unsigned long *)p; > smp_mb(); > (volatile unsigned long)___p1; > > My understanding is that casting a non-pointer type to volatile doesn't > do anything, so we're good. Right, I mixed up the correct (typeof(*p))___p; with the incorrect *typeof(p)&___p; which would dereference a volatile pointer and cause the problem. The code is all fine then. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel