From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618367C for ; Wed, 8 Jun 2022 06:54:30 +0000 (UTC) Received: from mail-oi1-f179.google.com ([209.85.167.179]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1Ml6Zo-1nKJEF3qOa-00lXM8 for ; Wed, 08 Jun 2022 08:54:28 +0200 Received: by mail-oi1-f179.google.com with SMTP id s8so21671729oib.6 for ; Tue, 07 Jun 2022 23:54:27 -0700 (PDT) X-Gm-Message-State: AOAM531VTgiuevcZVi2M9QGiUdZP/iwhi0IvS5aOUU4BIoTxWuqhiHYG 3C23830IA0hUXixs01tunmV704IdK3bQrJHLcX0= X-Google-Smtp-Source: ABdhPJxtc+XXcM8lboPd0HxoO4C4pSgZz+o+2cydLY3T5VirSX+BmYIrJ5qFsX5R6uVftrDQIMIjbwfJ9FBTtFXxwBI= X-Received: by 2002:a05:6808:1a2a:b0:32e:a1bd:368c with SMTP id bk42-20020a0568081a2a00b0032ea1bd368cmr1534573oib.155.1654671266622; Tue, 07 Jun 2022 23:54:26 -0700 (PDT) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Wed, 8 Jun 2022 08:54:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: gcc-12: build errors: arch/arm64/kernel/setup.c:225:56: warning: array subscript -1 is outside array bounds of 'char[]' [-Warray-bounds] To: Mark Rutland Cc: Arnd Bergmann , Naresh Kamboju , Linux ARM , open list , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Catalin Marinas , Will Deacon , Andrew Morton , John Donnelly , Huacai Chen , Bjorn Andersson , Andy Shevchenko , David Hildenbrand , "Guilherme G. Piccoli" , Zhen Lei , Anshuman Khandual , Kefeng Wang Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:hRy8A44cKt4EKG+atdziHlSNHtstPLhvCG2I2pNxlWycSK/HvIy 3gAs1vaN+P3ArCJNlh10eb9cOEqN0f0fN2Mv1utCNWg+1CfKuO2K4x1FQVcF83iwcuvnSmf JhBqs6pgbGrz91HAfYxbKjBmz0KYB/n4MdIX1Y7HdifXLvafY2bjSTCU+vdTw7NMD+mlRXr X/IuYzIptcyyTQBHnuE0Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:PgXAPc4MzS0=:l2R5asAnIhufKY4P4lbo5O tCSTTUX026H7rmDVWULTJC0ZyoMzSFIHfF18hhQdxIbDYAa/IoBjw4LaJOqZPgfNJ80gaRWcl xraU3FwgXFf/s/E2Qq3oHeErTKnGme0vhng7Sa52OURYd/J6uI2KoIKy+3flpNdu466MhUanq SHdHjjObQToKghdOPr1Es9LBrQNa63vvIxmeNxtK7NnMFBcB1qGPdnAP1zRMOowS3avZrKIq9 X85ECrj1Bzntico90irASKEG+G4iVZEeHK3AFLNm1rgNGZkuch3Lqmf1GUz1zsY/fW+cJlWNx 40Qe1WDl7kzAzrpACYoXmj8nznET6XO+B3d8pga6r66FeohsXTuteUL7UgxJXP0SSxuWYGrWR 9CoUGAwKQJItaM4KNjxpVSfhMDpd/FXNLiZIAnbISleW7qX8eZYCrXlSJ2gOoa8vaycFpw+Eo pnOCaFynejNaPt8ZXqyxbO/MA8MXgt8L4E4996IO1JIIhKl2q4U9kFpprl0Yo/Sc84iBdGz9I ngGmHa0kQt8g+o/n87VgYCoc7BmrPmQ7ICukWBrEcQa8o1Ai//PZTCVD/pe/6d0xQYnszm6Ci kTID5Tn35eYnucFRj+elBsS4uPt31UQC3ix/m9NE1vT5XtB0XG/o95DKGAbh1nDMjTOQ3CDly rH5lmgcD8GzTvzwN3GxbkjBiTR7S8Z1uCTYYC2pJ1qjFpaX+Z8G4kyhwoJHsyj7KS4HW8THmB lrILnDndCeIeiaCubf28PUQgZMNsW37Gi4lkYA== On Mon, Jun 6, 2022 at 11:41 AM Mark Rutland wrote: > On Fri, Jun 03, 2022 at 09:40:07AM +0200, Arnd Bergmann wrote: > > #define va_init_begin() RELOC_HIDE((unsigned long)__init_begin) > > ... which'd be a pain, but at least it'd solve this generally. > > > I think the easy fix would be to reword this line to > > > > kernel_code.end = __pa_symbol(__init_begin) - 1; > > > > I agree that'd work for the __pa_symbol() cases. > > For consistency it might be worth using RELOC_HIDE(), e.g. > > kernel_code.end = __pa_symbol(RELOC_HIDE(__init_begin)) - 1); >asm-gener > ... which IIUC should do the trick. > I see we have similar logic on each architecture, and they probably all have the same issue now, so maybe we can just do a helper function in include/linux/ioport.h (which has all the struct resource logic) that can be called like resource_set_pa(&kernel_code, _stext, __init_begin); resource_set_pa(&kernel_data, _sdata, _end); Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41A5AC43334 for ; Wed, 8 Jun 2022 06:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kRNWMh3lbqKsZzViUechbb+W+vv0TOphv4NVSfSPjE0=; b=fMHK4eKbbnid5g b0ONr9mh5ScVC4zJOMPYMUPhPAxflzy5NY0UblS+TVgByP9O1Qjb/BUsvVDVsUDxPXMkGdMJE4thG hULsCNwgpqqOSwcEZpWdQKIi+nECKvMEN71DGrRI/ehinPpC6cIRlRkOfyAnP8kJLHzJfjTOMH5nj vceW546rC7ErvvcDPqEF4H37Ka0xNmm1xh5A0Zdn1nWMKJKFT+aAAW7JZSNEU9ZeAQxygUn9Ut0wk x+JN4SeAibOyK/VFfJhzjmBuuff6dzHTKJSkGpQOP/aX9M2+O/r9U2urDJKH9wzoulHKVKaY/C9FR bgj6Q3xBmL5Acwe2xWmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nypaP-00BMgU-2O; Wed, 08 Jun 2022 06:54:37 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nypaL-00BMef-FU for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 06:54:35 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MVv4X-1o8xw80O05-00RobW for ; Wed, 08 Jun 2022 08:54:29 +0200 Received: by mail-oi1-f175.google.com with SMTP id k11so26882560oia.12 for ; Tue, 07 Jun 2022 23:54:27 -0700 (PDT) X-Gm-Message-State: AOAM531x6uEheEafnpz4zRbK9vNajz1syno3QTNh2In+2wUMPqb+pPoT PJPCW/cJCTTDBKmqrlwgdZADKC9Sc5BiQmgUrY8= X-Google-Smtp-Source: ABdhPJxtc+XXcM8lboPd0HxoO4C4pSgZz+o+2cydLY3T5VirSX+BmYIrJ5qFsX5R6uVftrDQIMIjbwfJ9FBTtFXxwBI= X-Received: by 2002:a05:6808:1a2a:b0:32e:a1bd:368c with SMTP id bk42-20020a0568081a2a00b0032ea1bd368cmr1534573oib.155.1654671266622; Tue, 07 Jun 2022 23:54:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Wed, 8 Jun 2022 08:54:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: gcc-12: build errors: arch/arm64/kernel/setup.c:225:56: warning: array subscript -1 is outside array bounds of 'char[]' [-Warray-bounds] To: Mark Rutland Cc: Arnd Bergmann , Naresh Kamboju , Linux ARM , open list , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Catalin Marinas , Will Deacon , Andrew Morton , John Donnelly , Huacai Chen , Bjorn Andersson , Andy Shevchenko , David Hildenbrand , "Guilherme G. Piccoli" , Zhen Lei , Anshuman Khandual , Kefeng Wang X-Provags-ID: V03:K1:KnKaUNo3mAkADrQXkMU1WipU0oj/eZoVq0b0y6Chd7TTQENQWkR GHEi5VM1+SwnbeBNfc7HuULa9f8Xhk8HeCoXKHV2mONLE7Lk5yfhudph6Z12XkicFa9MzsG Nd/2oOFFBGgxJ8kbhRVNAJF8wfpEYMmjvMd5azceAT5eeTIBERnCqOCKoqd43FljMq2HcGH ISn5ZqvhPbchQfVY5lZLw== X-UI-Out-Filterresults: notjunk:1;V03:K0:tVm8rS2bdPU=:z8UXKePGBazFpiqR8yDpEH Uu7Ltcd6xao+VuJ3iv1CwTJDhZFekaSIYNcsIXXzckiJ6U/oDaecNvvwg3xcaj+BlJrmrIaeW wjnCyTJMKltlLYsr0IpraiMI/k7JtpKwzIWWmnHZlRyWJ9gMJ6/+iisUSk5r+hX25WRM0LyJI o0LOOazLPuwIPDua01npliOV6C11o3dnJa+xgxMdAtBOqTXBJLYwOGDAts0gxFSnyXv/tWZ/z /zxXkefV0QQJ5zFxIVSKdgLBZfvX2lqP3UDqgjdYJLeO+4A3C8H9fsn0YbDjHWGkxkhd+NcpB cgK89aYNrdav12iCIs+I8Ubms7V/RET0l/tUipPj+qLRBN/R1yy4jKLqjxtpkN7vZfziJRb/c GtGG6unhS7R3+UkOoKlHOfuGpphJ57HvaqAdTdD87liQkcQsExmXGjdpTv1WguEBm9zhypiRR DZX0dWbAXsmJP8wsxSHZt4I/4R3JbIXfFKXJwvHTKddmuVtuS7GMrm+LFVQqq9U8AHnXlXN68 303IizjfDLc9MCPsgr2ZGz0YTSNVYLp1bEL7vPSHOmiIMLqrS3iN0swabOomUcbGbOPHqePyR AJHc3unj8pliCQbb/MQyE2JTA9WkCFIjh2nGX7oa6qYoq4hW6jlvmpRPi3CTRMgeAb/YNDbz7 nr4qY7rclWRynNbRyYGmh6jq5hv+s/+ET8EpphJARQ1Os+H+NWG4n5il6KvaGFjK49mY47f1J JYnVNopngh114ZqyKxnRRG/TPAqLhGTv5swujRevmroo12+UMMW7Mj3pI6Ypeux9mg63DiwLF AN+55Cm/tw5WY+xqpbYiS++Kv1iq4i1lQg5R7tIdiyKzHpXBwLRJNJfikhId93L6z0TwQhAbL n3QyQSdB61PkuTCmmKmw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_235433_867336_F323C6A3 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 6, 2022 at 11:41 AM Mark Rutland wrote: > On Fri, Jun 03, 2022 at 09:40:07AM +0200, Arnd Bergmann wrote: > > #define va_init_begin() RELOC_HIDE((unsigned long)__init_begin) > > ... which'd be a pain, but at least it'd solve this generally. > > > I think the easy fix would be to reword this line to > > > > kernel_code.end = __pa_symbol(__init_begin) - 1; > > > > I agree that'd work for the __pa_symbol() cases. > > For consistency it might be worth using RELOC_HIDE(), e.g. > > kernel_code.end = __pa_symbol(RELOC_HIDE(__init_begin)) - 1); >asm-gener > ... which IIUC should do the trick. > I see we have similar logic on each architecture, and they probably all have the same issue now, so maybe we can just do a helper function in include/linux/ioport.h (which has all the struct resource logic) that can be called like resource_set_pa(&kernel_code, _stext, __init_begin); resource_set_pa(&kernel_data, _sdata, _end); Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel