From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F95EC433F5 for ; Thu, 21 Apr 2022 08:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386489AbiDUINf (ORCPT ); Thu, 21 Apr 2022 04:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386526AbiDUIM5 (ORCPT ); Thu, 21 Apr 2022 04:12:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 955FC6398; Thu, 21 Apr 2022 01:10:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E69EB8233C; Thu, 21 Apr 2022 08:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EA53C385B7; Thu, 21 Apr 2022 08:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650528605; bh=/W8IliiCajYPso0oJDKeh6+LCmFpM9Iq4B+vqL+KHZ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UtxzIvoNdabVELeWIz3V4TclK6xXmq9BMhzfujlm+gFWBoT8rY4aF9GfRX2ccT1vn wDcqT+y+x552llxpM0QL7xb0FLdoLZIo54LK520enQwUc0BbOcQrzNYQiwfY0jTUpi 4qNX03YnasClaEAYsxgd8xc9OOZJfmG9mYcvjA+pDQdP70iw48miJ+2lz2WSgyuBbq tmIpimyZgrqkiOqSIOS0XySlX/JLBOUliDNfhAYHogz26OJgf2EClSsKjy3h8/tJZB X4KNgNCuxEid0pr34FAxb4UcPVrvYQRtv4HO3faFNFitLqqrQosV4+qH8YLlMGH9LJ cYb7+DzLwXx7g== Received: by mail-wr1-f41.google.com with SMTP id x18so5538452wrc.0; Thu, 21 Apr 2022 01:10:04 -0700 (PDT) X-Gm-Message-State: AOAM532gQMIQslZvDRR/JDrpCg7+UnB5TuMBR/wPI+cl36iApq4b3aAc 1BMSjNNEWyVyaARlUmKsGksttyissLHt1+hFBjU= X-Google-Smtp-Source: ABdhPJw9RSqdGWpafgMW97qQu7yaTHgV5jKD56P0eBxUAQhkvQ6X95c920XjmeJj56kP8+QCXLYB93ISvku4scoF6r4= X-Received: by 2002:a5d:6389:0:b0:207:a7d8:2b64 with SMTP id p9-20020a5d6389000000b00207a7d82b64mr18151004wru.12.1650528603264; Thu, 21 Apr 2022 01:10:03 -0700 (PDT) MIME-Version: 1.0 References: <20220421074204.1284072-1-hch@lst.de> <20220421074204.1284072-8-hch@lst.de> In-Reply-To: <20220421074204.1284072-8-hch@lst.de> From: Arnd Bergmann Date: Thu, 21 Apr 2022 10:09:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 7/7] ARM: use dma-direct unconditionally To: Christoph Hellwig Cc: Russell King , Linus Walleij , Andre Przywara , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Greg Kroah-Hartman , Alan Stern , Laurentiu Tudor , Marek Szyprowski , Robin Murphy , "open list:IOMMU DRIVERS" , Linux ARM , Linux Kernel Mailing List , USB list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: > > Use dma-direct unconditionally on arm. It has already been used for > some time for LPAE and nommu configurations. > > This mostly changes the streaming mapping implementation and the (simple) > coherent allocator for device that are DMA coherent. The existing > complex allocator for uncached mappings for non-coherent devices is still > used as is using the arch_dma_alloc/arch_dma_free hooks. > > Signed-off-by: Christoph Hellwig > --- > arch/arm/Kconfig | 4 +- > arch/arm/include/asm/dma-mapping.h | 24 -- > arch/arm/mach-highbank/highbank.c | 2 +- > arch/arm/mach-mvebu/coherency.c | 2 +- > arch/arm/mm/dma-mapping.c | 365 ++--------------------------- > 5 files changed, 19 insertions(+), 378 deletions(-) > delete mode 100644 arch/arm/include/asm/dma-mapping.h The diffstat looks really nice! I can't really tell from looking at the code if this is an equivalent conversion, so I have to trust you on that. I did make sure this passes the basic tests on kernelci.org, which tests a large number of machines, which is a good sign. Tested-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2009C433EF for ; Thu, 21 Apr 2022 08:10:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 545784099A; Thu, 21 Apr 2022 08:10:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8p-rMWvhdmIh; Thu, 21 Apr 2022 08:10:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id E005241C29; Thu, 21 Apr 2022 08:10:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A8720C002F; Thu, 21 Apr 2022 08:10:13 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 25316C002C for ; Thu, 21 Apr 2022 08:10:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 04FFA841A9 for ; Thu, 21 Apr 2022 08:10:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T__liOvcBd69 for ; Thu, 21 Apr 2022 08:10:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0F19084194 for ; Thu, 21 Apr 2022 08:10:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B727DCE210B for ; Thu, 21 Apr 2022 08:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08ED0C385AB for ; Thu, 21 Apr 2022 08:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650528605; bh=/W8IliiCajYPso0oJDKeh6+LCmFpM9Iq4B+vqL+KHZ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UtxzIvoNdabVELeWIz3V4TclK6xXmq9BMhzfujlm+gFWBoT8rY4aF9GfRX2ccT1vn wDcqT+y+x552llxpM0QL7xb0FLdoLZIo54LK520enQwUc0BbOcQrzNYQiwfY0jTUpi 4qNX03YnasClaEAYsxgd8xc9OOZJfmG9mYcvjA+pDQdP70iw48miJ+2lz2WSgyuBbq tmIpimyZgrqkiOqSIOS0XySlX/JLBOUliDNfhAYHogz26OJgf2EClSsKjy3h8/tJZB X4KNgNCuxEid0pr34FAxb4UcPVrvYQRtv4HO3faFNFitLqqrQosV4+qH8YLlMGH9LJ cYb7+DzLwXx7g== Received: by mail-wr1-f43.google.com with SMTP id t6so2068170wra.4 for ; Thu, 21 Apr 2022 01:10:04 -0700 (PDT) X-Gm-Message-State: AOAM53152P1ND7eIhACasjQgxDNxSqRJFekXER37Zq7hObFCe+uKKlV5 kd2E1F4Ebf9Ewg26fIEdj12aqpOOLV/OwYhSq7c= X-Google-Smtp-Source: ABdhPJw9RSqdGWpafgMW97qQu7yaTHgV5jKD56P0eBxUAQhkvQ6X95c920XjmeJj56kP8+QCXLYB93ISvku4scoF6r4= X-Received: by 2002:a5d:6389:0:b0:207:a7d8:2b64 with SMTP id p9-20020a5d6389000000b00207a7d82b64mr18151004wru.12.1650528603264; Thu, 21 Apr 2022 01:10:03 -0700 (PDT) MIME-Version: 1.0 References: <20220421074204.1284072-1-hch@lst.de> <20220421074204.1284072-8-hch@lst.de> In-Reply-To: <20220421074204.1284072-8-hch@lst.de> From: Arnd Bergmann Date: Thu, 21 Apr 2022 10:09:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 7/7] ARM: use dma-direct unconditionally To: Christoph Hellwig Cc: Andrew Lunn , Andre Przywara , Linus Walleij , USB list , Russell King , Linux Kernel Mailing List , "open list:IOMMU DRIVERS" , Alan Stern , Greg Kroah-Hartman , Robin Murphy , Gregory Clement , Linux ARM , Sebastian Hesselbarth X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: > > Use dma-direct unconditionally on arm. It has already been used for > some time for LPAE and nommu configurations. > > This mostly changes the streaming mapping implementation and the (simple) > coherent allocator for device that are DMA coherent. The existing > complex allocator for uncached mappings for non-coherent devices is still > used as is using the arch_dma_alloc/arch_dma_free hooks. > > Signed-off-by: Christoph Hellwig > --- > arch/arm/Kconfig | 4 +- > arch/arm/include/asm/dma-mapping.h | 24 -- > arch/arm/mach-highbank/highbank.c | 2 +- > arch/arm/mach-mvebu/coherency.c | 2 +- > arch/arm/mm/dma-mapping.c | 365 ++--------------------------- > 5 files changed, 19 insertions(+), 378 deletions(-) > delete mode 100644 arch/arm/include/asm/dma-mapping.h The diffstat looks really nice! I can't really tell from looking at the code if this is an equivalent conversion, so I have to trust you on that. I did make sure this passes the basic tests on kernelci.org, which tests a large number of machines, which is a good sign. Tested-by: Arnd Bergmann _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 991F2C433EF for ; Thu, 21 Apr 2022 08:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JUh3j1zfFpeU6BpnPdixjcfrjKr45eg+ZwUQgTtIPHs=; b=C4hhp/hxovL/3e knFIJXXGRptbauKyEE94AewIq1GQ2S3HBvvJRCh2rnXyNCEotwlfb9xnTuLzgAw6hmKz+N8tsaJuy 3kR6G0QbObprwg3htlN6snRYaPC41lbO27z6FMeT/zcTX4UhktWxBNgA9Fitng+mZUOK/czmWSGfx HO7qghjbNwY3AyaXDhUhRZ2vn4NDWZJYpguWiNieux2jpI+bUYkjUuhPrHpdIhKbQR17h0glkyWQ2 IsgMRdW0PfDFVAw8SeaZDCKpLMLThMJI5n3CNW43kQWEVWrAosDEeM8Oz96RTPLRVrIR6E8rlkwdF R/Zt/tOvYXCOGLG9YeDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhRua-00CLba-AK; Thu, 21 Apr 2022 08:11:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhRt8-00CKrO-Ps for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 08:10:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB8B661BBE for ; Thu, 21 Apr 2022 08:10:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19711C385B2 for ; Thu, 21 Apr 2022 08:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650528605; bh=/W8IliiCajYPso0oJDKeh6+LCmFpM9Iq4B+vqL+KHZ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UtxzIvoNdabVELeWIz3V4TclK6xXmq9BMhzfujlm+gFWBoT8rY4aF9GfRX2ccT1vn wDcqT+y+x552llxpM0QL7xb0FLdoLZIo54LK520enQwUc0BbOcQrzNYQiwfY0jTUpi 4qNX03YnasClaEAYsxgd8xc9OOZJfmG9mYcvjA+pDQdP70iw48miJ+2lz2WSgyuBbq tmIpimyZgrqkiOqSIOS0XySlX/JLBOUliDNfhAYHogz26OJgf2EClSsKjy3h8/tJZB X4KNgNCuxEid0pr34FAxb4UcPVrvYQRtv4HO3faFNFitLqqrQosV4+qH8YLlMGH9LJ cYb7+DzLwXx7g== Received: by mail-wr1-f52.google.com with SMTP id p18so5506100wru.5 for ; Thu, 21 Apr 2022 01:10:04 -0700 (PDT) X-Gm-Message-State: AOAM530O6nXeK5mtVj9FBIbXEOgb8ZhHsb0IWw+NOcaXWG7kNo1NmsPf tz7cxDy/ZigzezetbTa8Brj7d0tl16m6C6IC0+Q= X-Google-Smtp-Source: ABdhPJw9RSqdGWpafgMW97qQu7yaTHgV5jKD56P0eBxUAQhkvQ6X95c920XjmeJj56kP8+QCXLYB93ISvku4scoF6r4= X-Received: by 2002:a5d:6389:0:b0:207:a7d8:2b64 with SMTP id p9-20020a5d6389000000b00207a7d82b64mr18151004wru.12.1650528603264; Thu, 21 Apr 2022 01:10:03 -0700 (PDT) MIME-Version: 1.0 References: <20220421074204.1284072-1-hch@lst.de> <20220421074204.1284072-8-hch@lst.de> In-Reply-To: <20220421074204.1284072-8-hch@lst.de> From: Arnd Bergmann Date: Thu, 21 Apr 2022 10:09:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 7/7] ARM: use dma-direct unconditionally To: Christoph Hellwig Cc: Russell King , Linus Walleij , Andre Przywara , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Greg Kroah-Hartman , Alan Stern , Laurentiu Tudor , Marek Szyprowski , Robin Murphy , "open list:IOMMU DRIVERS" , Linux ARM , Linux Kernel Mailing List , USB list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_011006_942512_832E9B07 X-CRM114-Status: GOOD ( 22.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: > > Use dma-direct unconditionally on arm. It has already been used for > some time for LPAE and nommu configurations. > > This mostly changes the streaming mapping implementation and the (simple) > coherent allocator for device that are DMA coherent. The existing > complex allocator for uncached mappings for non-coherent devices is still > used as is using the arch_dma_alloc/arch_dma_free hooks. > > Signed-off-by: Christoph Hellwig > --- > arch/arm/Kconfig | 4 +- > arch/arm/include/asm/dma-mapping.h | 24 -- > arch/arm/mach-highbank/highbank.c | 2 +- > arch/arm/mach-mvebu/coherency.c | 2 +- > arch/arm/mm/dma-mapping.c | 365 ++--------------------------- > 5 files changed, 19 insertions(+), 378 deletions(-) > delete mode 100644 arch/arm/include/asm/dma-mapping.h The diffstat looks really nice! I can't really tell from looking at the code if this is an equivalent conversion, so I have to trust you on that. I did make sure this passes the basic tests on kernelci.org, which tests a large number of machines, which is a good sign. Tested-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel