From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EFEC433DF for ; Thu, 25 Jun 2020 15:15:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89DB220767 for ; Thu, 25 Jun 2020 15:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405593AbgFYPPv (ORCPT ); Thu, 25 Jun 2020 11:15:51 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:51741 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405309AbgFYPPv (ORCPT ); Thu, 25 Jun 2020 11:15:51 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MQy0N-1jSFOM2WWd-00NvZl for ; Thu, 25 Jun 2020 17:15:49 +0200 Received: by mail-qk1-f170.google.com with SMTP id b4so5586471qkn.11 for ; Thu, 25 Jun 2020 08:15:49 -0700 (PDT) X-Gm-Message-State: AOAM532P8vLbYzuwYyP+qmgHHZz4jDCUNFPBx4sDPzzPqyD9ZuX2hG5W 9Df+Bwfj2mkWNoEZaNBcBK+VlPTSSixt3st6W4o= X-Google-Smtp-Source: ABdhPJxHxjsEFmMePNDgTA1OfWqFm+2QL2fPNumeTMC0xADs4SGObt+dLYOFgRxYDZNHo3K7rfPjZtPLu+4XVCrZTgE= X-Received: by 2002:a37:9dd6:: with SMTP id g205mr21975447qke.352.1593098148465; Thu, 25 Jun 2020 08:15:48 -0700 (PDT) MIME-Version: 1.0 References: <1593044164-32362-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 25 Jun 2020 17:15:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder To: Anson Huang Cc: Catalin Marinas , Will Deacon , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Bjorn Andersson , Leo Li , Vinod Koul , Geert Uytterhoeven , Olof Johansson , Peng Fan , Aisheng Dong , Daniel Baluta , Franck Lenormand , Krzysztof Kozlowski , Linux ARM , "linux-kernel@vger.kernel.org" , dl-linux-imx Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:26dX5LvC7mCbRHDkcqLoH7zAKXFFBV/RsU6oqax4CibFXcAN6Hl IlhGOw73g56fxy4WY1tHlzfGEvrrthzg16fy6nNrklWI7VvI/PvHW6x4LDVUqLARGuSs5Sa PdVjgkgpw+QrsvnqgGl+h2gl3iWcjUNod+a5r5R8bbF63j050Piqd5ZpRnadgIkJo8+p216 LDoBo6vgX5BVS2pBhrLkg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4aunBoX7j+E=:zLtHpXlEvtWx4Nf+r26MGc TBqZmYh790BE/QAl90aSOIJBP4Qh4VXvvFGsL9lLWjx71BPcut8Oy3sJBL5DRn88pe2pdgsz8 35KuL3/+GvPbT84BBgd+s0vtCWsJAj/sHNPWNikGae+ihoQn8zRKATgoZSpC/qN6KPzgtwoz7 dEnWbvweJjUA4LfmiAJKulvQ1oft3vNZySqdXxOXIWLhc9nU+/29uvpScOyGx/z9Mf1XO8jzL B4e2DbxRWyjHMNjHGxvWxLgcIuAqxpan1AtSs5SFfjuEZknBoCXA9woC5BgcVyfF5fqg/A4zh StaIIDYLFlp49cCU6AVtWNtebJaVyOY3K9qBpZF9PohMD0I3AxAxWmNiEeC/vFtGl02g8pcF8 xeITH8Xg5BFEUzOZdkqCDVgOifB8tZr/Wvpo7VhZthWys/OaKYn+QL0UBN/8GwxNH2kXYE8Nq kieRVzV+69vC++a/p6zVSDl/y6C+YavrQWG83NGbirAQXoUsxVCJ8eqvVZh07xojr+g180dPg od9KMob7CZaTqoJLvtdNJtwJIx/72ADpaHZ+jxfrhlKFVb8M6z1VfSCd8nNL6hBH4RcFKQVrt i1IfeeGUPW+Skju+aUrYsbh8Mus9pv2BddrjXJb8qcpR07yjxpCTBpp6JKwKfcTNxmHUDUV8P BzHhPR/0KmpT3gF+eLPdo8dZ/JZQ4JICKgF6ZFPzEGtrnflh/HaaSpiCDSxB8pL/Gn+A4spTc 6lP56uGazSV0u6TeCup7KtQhKPZfx7BhDP6DO22N6L6yMkGtLUbjvUgVw8Ft8KR3sxzNf5SP2 bViUYHmyzNpvstB7OhGrd8CjLYwMekNDrmgsPQuBzDiNYB6EBQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2020 at 2:54 PM Anson Huang wrote: > > Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder > > On Thu, Jun 25, 2020 at 2:27 AM Anson Huang > > wrote: > > This makes separate loadable modules out of the driver when > > CONFIG_IMX_SCU=m, including the badly named misc.ko and rm.ko modules > > that might conflict with other modules of the same name (module names are a > > global namespace for modprobe). > > > > The way to make this a single module from four files is > > > > obj-$(CONFIG_IMX_SCU) += imx-scu-mod.o > > imx-scu-mod-y := imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o > > I haven't considered the support for loadable module of i.MX SCU firmware yet, > plan to have another patch to do it, so do you think it is good to add the loadable > module support together in this patch? No, I wouldn't do that yet. It was just that adding the EXPORT_SYMBOL() made it look like you were trying loadable module support already, and that would not have been a good idea without changing the way it gets linked. If you just remove the EXPORT_SYMBOL from this patch, it should be fine, you can do the rest when you actually need the driver itself to be loadable, and that in turn requires all drivers depending on it to be loadable modules first. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891D1C433E0 for ; Thu, 25 Jun 2020 15:17:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 589F820775 for ; Thu, 25 Jun 2020 15:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J5+//lpu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589F820775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hVlA043C02PHc90ozrB7zQ2GteR2AGBkt29lygErVs8=; b=J5+//lpuPqZJOsJUlWYSD+iSY hJJxuYw32X49iOazJrcJcoy4E4Zb/ehIwwqEX/tRqWnR26QKAjyTtRJckn7cG0ZausHlJUzpQ7w59 nK1Ii1N0Y5zgpmR/knoIZBWtgg0rGv1oJK1bonieRBJ83znbmkQp+msgBwuG2jBH0HJ+ttQKuPCy7 QPsq4AS0dePtHTMZajZHeF/YadvYM+3i9wmpNSZjXEGytGZbEoyag88bEo4v97Yijz/VO2Je4PLXp S/2kBfF91ujp5Ryj7wsSnOabJgG6Z1Jt3R6aiwVkhQVyaeaZ3q6GInrTDWiA401oMSL+Sa/PkUHxq JWKsrvtPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joTbX-0002Eo-FE; Thu, 25 Jun 2020 15:15:55 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joTbU-0002EQ-Qy for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 15:15:53 +0000 Received: from mail-qk1-f177.google.com ([209.85.222.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N8GhM-1ikMNx2NZg-014D2k for ; Thu, 25 Jun 2020 17:15:49 +0200 Received: by mail-qk1-f177.google.com with SMTP id e13so5605992qkg.5 for ; Thu, 25 Jun 2020 08:15:49 -0700 (PDT) X-Gm-Message-State: AOAM530iJpSf6BDUjlG97YtRk0cyyuFin7z30t/dr5FnljZAbqFq1mIP ufu4lKLpVsccfjY9DtSqakFwcQrwoE/IrnEqiGE= X-Google-Smtp-Source: ABdhPJxHxjsEFmMePNDgTA1OfWqFm+2QL2fPNumeTMC0xADs4SGObt+dLYOFgRxYDZNHo3K7rfPjZtPLu+4XVCrZTgE= X-Received: by 2002:a37:9dd6:: with SMTP id g205mr21975447qke.352.1593098148465; Thu, 25 Jun 2020 08:15:48 -0700 (PDT) MIME-Version: 1.0 References: <1593044164-32362-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 25 Jun 2020 17:15:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder To: Anson Huang X-Provags-ID: V03:K1:lkNq/Prp/+GjgVQYfmRpn/kh6vHnDQJHEbH9cjeK/EcHRy009Fs XZGB6zDyCkSv7YW2R8VMrF9ChnzRSoSZiiggiz8znmWTVS4+KVlu9mpdGsDob7/HnVLm/Ni FTJRKupDTIhybyrqRGMuHx43o0Qpyprxl55RLe3h/glbbpti3mQ3FdGffnzBckodLIFPTHC iVNLKqUO3FgeCcLR+U2aA== X-UI-Out-Filterresults: notjunk:1;V03:K0:kXPM8HJEMks=:rsan8TXIpO8sFquWxYEFca IqvPCl2U1gjd8LqQfyKG3+whL2zuugwEkhVTdXOOSR/G7stSICgBUFn5mYyWXnaO/wcVFnPkH 8qOJAiH5BacuoK2vOPab5UsgWiHY2KsW9vmsnrkTtK4Ljyjv1lU38fjYfLLLhPRb1/dCQBJqT pbWUs30K/xEAhdKxXeDwAqIiiFNRaQYtbjzhC8wFJMqA4/Fj52GMNq6kSYSrl4wpyrOLHtGdl uWvmymTLq2u/zsTSgphDImRGgQKfGxfgsH8WAnw9VUqQV3bHp6oV/uXuQhMmFNzr2dvCkrP4E nOt8rigqGGrzByzmvqN74T3cMBt+iSrIheV3oOkLs8tP75QEmmRiLdex1T1Ujc2PCsGV6x3Aq ct4DSxm5/sM2HBWuMfNFTj+0nFa9iCvtu7uo30U4z+Vn3A8qv/rzliBM1WuSzz3FYje3BxmqF 26/pBGmXLdKHUbulRWvAKioR+tKpbqBH4RZlP5CtVuidbvUQOhpUHlKG8bK9eoFFhlUqBYHFV HitFhN0YAhqUzaYK3lMDIKUxi/InZRVK92dzYWBx/dIkOFg1fKtiWW+ocRpOHqHrAa4eAxTmF JIllp7Btvd+CdxYZpgW9ec1NWwEuPws3UvH8hssaeYTaBTBUh8B32wrx/cLGWzRfzYtZKE40X xSFEXpeTEGGRjV+GRxpzwZvvIp5VJAZOAT91NOQlQwzcvihb/K7N6WWr1TZDBY5KPPR4RhvC4 5CiI/SE/70haCDj6pWTf0psGR4uFa+SYmo+HXEd/3Bh06GYAJ1tN9p+YXr8nzzWtONoLS3vQL cKdaSedNqJyd0ggWAV24sK6GrpgyOR28+vxocAZl3i0FZPlo40= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Peng Fan , Geert Uytterhoeven , Will Deacon , Catalin Marinas , Sascha Hauer , "linux-kernel@vger.kernel.org" , Daniel Baluta , Bjorn Andersson , Franck Lenormand , Vinod Koul , Krzysztof Kozlowski , Sascha Hauer , Olof Johansson , Shawn Guo , Leo Li , Fabio Estevam , Linux ARM , dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 25, 2020 at 2:54 PM Anson Huang wrote: > > Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder > > On Thu, Jun 25, 2020 at 2:27 AM Anson Huang > > wrote: > > This makes separate loadable modules out of the driver when > > CONFIG_IMX_SCU=m, including the badly named misc.ko and rm.ko modules > > that might conflict with other modules of the same name (module names are a > > global namespace for modprobe). > > > > The way to make this a single module from four files is > > > > obj-$(CONFIG_IMX_SCU) += imx-scu-mod.o > > imx-scu-mod-y := imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o > > I haven't considered the support for loadable module of i.MX SCU firmware yet, > plan to have another patch to do it, so do you think it is good to add the loadable > module support together in this patch? No, I wouldn't do that yet. It was just that adding the EXPORT_SYMBOL() made it look like you were trying loadable module support already, and that would not have been a good idea without changing the way it gets linked. If you just remove the EXPORT_SYMBOL from this patch, it should be fine, you can do the rest when you actually need the driver itself to be loadable, and that in turn requires all drivers depending on it to be loadable modules first. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel