From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DB4C433EF for ; Tue, 14 Sep 2021 13:02:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AF946112D for ; Tue, 14 Sep 2021 13:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbhINNDn (ORCPT ); Tue, 14 Sep 2021 09:03:43 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:33377 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232676AbhINNDm (ORCPT ); Tue, 14 Sep 2021 09:03:42 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MmyzH-1n9wgy4Ahr-00kBle for ; Tue, 14 Sep 2021 15:02:24 +0200 Received: by mail-wr1-f50.google.com with SMTP id t18so20131177wrb.0 for ; Tue, 14 Sep 2021 06:02:23 -0700 (PDT) X-Gm-Message-State: AOAM533fqQzacpk+3M06+3bJvKijP7E4N7uiCsTrwCPfYQ+WoroDvGpS 8/RksYp+imctGAkTrBcYsPsTnkYGoThvRX1lwv8= X-Google-Smtp-Source: ABdhPJwm95UM5Q7Av+R9PlqLuMxx0U/oJySlVgb5nUIOOX/MOzSR3VFTVEUXiHX+MRSB+HYEGrwSl61hIAHxwKNWp3I= X-Received: by 2002:a5d:528b:: with SMTP id c11mr18133610wrv.369.1631624543694; Tue, 14 Sep 2021 06:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20210911092139.79607-1-guoren@kernel.org> <20210911092139.79607-7-guoren@kernel.org> <20210913084520.kkbsupogkzv226x3@gilmour> <20210914101327.47baun6mop3mc56j@gilmour> In-Reply-To: From: Arnd Bergmann Date: Tue, 14 Sep 2021 15:02:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V4 6/6] riscv: soc: Add Allwinner SoC kconfig option To: Krzysztof Kozlowski Cc: Maxime Ripard , Arnd Bergmann , Guo Ren , Randy Dunlap , Anup Patel , Atish Patra , Palmer Dabbelt , =?UTF-8?Q?Christoph_M=C3=BCllner?= , philipp.tomsich@vrull.eu, Christoph Hellwig , liush , wefu@redhat.com, =?UTF-8?B?V2VpIFd1ICjlkLTkvJ8p?= , Drew Fustini , linux-riscv , Linux Kernel Mailing List , taiten.peng@canonical.com, aniket.ponkshe@canonical.com, heinrich.schuchardt@canonical.com, gordan.markus@canonical.com, Guo Ren , Chen-Yu Tsai Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:f7u6EBj47ZlT/e8fzz7fBj9GGCTU65TiWvoxCczkll4V5LBg5nb gYmxvWn3E2+6j1m1wTCj68vA0lS1kfbsupiUm3E2VkGFVW5GXZ94Tn0mbOUbOm8TXujaJ9w PQvGlz9cF+w49c1AztfPHw4H0cucwJa2M+xcVMfjrKTvgP/3fB6T73rReuSEYt9jiPBDKR9 FNbemJr2rChSydrQVh4DA== X-UI-Out-Filterresults: notjunk:1;V03:K0:VZiMCxseFrs=:q4vSce1f+OHRm3fWVo+aWW wklUP2xQmHx6iWUPcbYA06nI1GUhxEwsjBS+r4mLBGjuH+Za7QBJn0zgGnyrYJl+h7B1tK1l7 n7rZAhI1/LQh2iNAsT6HXFE5jggLsKP4GqHGpN4pAOOeYnH4BP8l8Ako6fOHjUsOMEtqKlCD4 oV/jpyekppijI9AcaW/8QWpKDY9wrdJiMDJvp7YGzsEExXKfVYcupRSMd4e5XZGDxdZtuj2h4 GXJTUozGwIHnkPRlctklYnzDOBWFJf+fcs8ybMuhPpeKpIdvQqSWXhyU5tvpcQ7cNAQyLeM2U nc/CzzvskAxJ8bpFZS0aO/G7bRnj4OJCLOmGN9bhXIiMsUNcaRUYGCNMycS+dER+cNV7/eRdv xYSsOTUXBPrc2iR1Ivgw8FXEvJx2IENw6zG5+Fc7wzVUjNR+XFHmSPQTnRzTJytIGUq1AqGzp 18hk/CdZACrplPcNVUGe+xU6qxN9M+7tTlE0p8WwJIc9Yv57qxZm2wEsZCmVahFEKQUw0H33m tOZS4YDAtPUhsUtgDlazo5hXR3iBwwkX3UHNGB+0GD3VfwGSXHpjEXx5J6LCD36Bj/s4CZDQC 9UdI/2dknJvRMGGQn0qgbNHazZTHKM9EPGU8jm3lIq+6BnuuNBUB5GwY4L6VtKeTbHmniNV7R g9L3WgTaTrdmRbBMpG8zywTDSHxcq1tH5fdx326u+cLh4nBqINNDfgmbEXcC3BhM964D2vt7c Q0yNZYgpQlGVO7S7pD95DDsz4sS/j4LTIw3vi7wbPx+1ClHjXNgbXpua03zME/GwTFsjnt6a9 bPenoz23NW8ctGnv67DqXW937gjZ71jn2517XdHe3Cyam8nFbllbGQpJMed3XBXGuQreY1a7h fI67zUitkzvlPeFSsigQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 2:11 PM Krzysztof Kozlowski wrote: > > On 14/09/2021 12:13, Maxime Ripard wrote: > > On Tue, Sep 14, 2021 at 12:07:08PM +0200, Krzysztof Kozlowski wrote: > >> On Tue, 14 Sept 2021 at 11:31, Arnd Bergmann wrote: > >>> Some subsystem maintainers want drivers to be selected by the SoC > >>> option, this is why you need the 'select SIFIVE_PLIC', but usually > >>> the drivers are selectable with a 'depends on ARCH_SUNXI || > >>> COMPILE_TEST' and enabled in the defconfig. > >> > >> I would say selecting drivers is even more useful for distros and > >> other downstream users. Especially in the ARM world where we have so > >> many different SoCs - how could a distro person know which driver is > >> necessary, important or useful? Having all main SoC drivers enabled > >> when ARCH_SUNXI=y, helps distro a lot. > > > > Imply, maybe, but select is far too painful for everyone else. > > If we talk about UART driver, then sure - imply makes sense. But if we > talk about core SoC components necessary for boot (e.g. timers, clocks, > pinctrl), then select is appropriate. There is no point to enable > ARCH_XXX without these core components. Please never use 'imply', this is functionally the same as 'default', just the wrong way around, like the infamous 'comefrom' instruction in programming languages ;-) I still prefer using defaults and defconfig files over 'select', but I can see the use of select in some cases, as long as the symbol you are selecting is not already user visible. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BB5C433EF for ; Tue, 14 Sep 2021 13:02:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FFFF610D1 for ; Tue, 14 Sep 2021 13:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FFFF610D1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qqZ5/oAGhJ3dOVJyX8ixfPAyYqHH3y4JqXhAnnu7Ykw=; b=wRB6Oj91iHFY6s GzzV5+RBNF+jsNY4ta+BFIwwfCXXCYoVvaIV+9hx7r2Z/k0C+FH3Djb6Oq5uwSNGUfm6qh5eBHtbJ I9Qg2Ev4G2Cc1nmAQzu+qYKdLXx8CEISW6k1EQJzwJpG581QwvFJAYwVOgltYk5U1+U6HPjraPIHK diaMd4J7XEuMajhHlXMv9q9vH+Sv4ZMbZnapVG4KXbWAssviLOzk4JPqCUlqyaJr+BxC8q49tzz22 fHxI6RvPnjZ4bHsKBC0Obv+i0a3E1cOIJLL4BfsnRLkOlTg63SUk3MezHs9uN5mmOZb+AG6mR5M12 MR1RhVE9xwAZJ6tBArWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ850-005ooV-0J; Tue, 14 Sep 2021 13:02:30 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ84x-005onL-0q for linux-riscv@lists.infradead.org; Tue, 14 Sep 2021 13:02:28 +0000 Received: from mail-wr1-f45.google.com ([209.85.221.45]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N7zW7-1mvhaN1PIx-0153Rm for ; Tue, 14 Sep 2021 15:02:24 +0200 Received: by mail-wr1-f45.google.com with SMTP id d6so20067282wrc.11 for ; Tue, 14 Sep 2021 06:02:23 -0700 (PDT) X-Gm-Message-State: AOAM531/K4wHVqfdPvOH6UVaQlqJgVvuU3HZOCbEBKwIqy/lh40J6GJ7 zEfY4v0JeGVZBezzbPwsTYq1Vr5OaiciO3b+boQ= X-Google-Smtp-Source: ABdhPJwm95UM5Q7Av+R9PlqLuMxx0U/oJySlVgb5nUIOOX/MOzSR3VFTVEUXiHX+MRSB+HYEGrwSl61hIAHxwKNWp3I= X-Received: by 2002:a5d:528b:: with SMTP id c11mr18133610wrv.369.1631624543694; Tue, 14 Sep 2021 06:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20210911092139.79607-1-guoren@kernel.org> <20210911092139.79607-7-guoren@kernel.org> <20210913084520.kkbsupogkzv226x3@gilmour> <20210914101327.47baun6mop3mc56j@gilmour> In-Reply-To: From: Arnd Bergmann Date: Tue, 14 Sep 2021 15:02:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V4 6/6] riscv: soc: Add Allwinner SoC kconfig option To: Krzysztof Kozlowski Cc: Maxime Ripard , Arnd Bergmann , Guo Ren , Randy Dunlap , Anup Patel , Atish Patra , Palmer Dabbelt , =?UTF-8?Q?Christoph_M=C3=BCllner?= , philipp.tomsich@vrull.eu, Christoph Hellwig , liush , wefu@redhat.com, =?UTF-8?B?V2VpIFd1ICjlkLTkvJ8p?= , Drew Fustini , linux-riscv , Linux Kernel Mailing List , taiten.peng@canonical.com, aniket.ponkshe@canonical.com, heinrich.schuchardt@canonical.com, gordan.markus@canonical.com, Guo Ren , Chen-Yu Tsai X-Provags-ID: V03:K1:NjW3fz2pmXXo9XrGPPrb/rvEMFh5Jm654wwjC87bIwsVdYmJbt7 5VL/JKJuotgvasc6JgCDz9mVi5X3oaXFCyCCZI18ttt7G8h85JP97gF2yPf2OI/SJhHginW uIFYlb/S7JHsOiJOaJ7YgshXxRKI7NK/YQjC5Ij9Wi9gGgGFZ7UzHqRhLs/tcaiw2p65fEs ni5XAV9DiAqsBvnk61k2g== X-UI-Out-Filterresults: notjunk:1;V03:K0:oyt6Ytu8DbM=:PhZaioxrZyVt1SaO+PAPI3 Z0bAVC7OilQrCY8VSw7AQIuDi4h85TAVnXZqg7+2orK5qXmc4Jt/xkJkH6Q+UDCM3paiVA8g0 EpLcqc2wClagwTXUvVNkylid8JWbj3wrRg9bMOXbedfDqa28q4+nHAlZ6YstmdwJUWyQClv6M uo8FmTivG14tXrrock+KwCdq2bzTi/pCKBzWOdDtUu8mVPl2zzsXtq5+m0EmhSQeuG983JD8/ vBcM4YRDfnVElW7MziidDSLHoljuNA5msps1glwnTy3czl0cc2laKhbh7Zuw16c5MOdSSkoDq s/zsE13OZwnWdEvBFBpk1g2Yjg0+fp5+2WHHCJw6gxE00KM2jM4mhN5Fh8msVzVAyXcXuiG82 PlOQ+4T5wQNCXqFClNw6uje7MFm+86/7yRWLtJjpnTFDpvfbx0rPTogu/8NtmIZOgq0sCQqKe QqpsJ/B4rjUY4mvTnee/4Q2iye5YfNriZWTFygAKzQifjkcp+gnygfQiUxlIMKXoM8qcmCLkD uiOPWqY9HYw91EodJGctgiLMjABJEWL7rWLAYj9AzYWbk9A0GU0MHrxNzrPufWBmrPKGQNDnx O4sNnhYPf/QBavSslxOthTXj7O1EiR4q7vndEPICoDYdeI7GM1NUz/+JZtGJccd1YmODDYFqR A4HoLtCOubgqEFW+CqPwH2tiKvWlgJa7m+i8US828/TQVGDpEC4sOiMsOBCcWYCotuAwfp56/ sZwwOwebamCpvYjMp+WR8pu8r1uEQ3useYE0Ev9D7ZP3Q8mkBeR1hNin5fyE78HOVHUrCKzHW tsJIGzfdy4X64Z0O9HXt2nQU+QWsP6Nmz3+j5pss4ZfblKATQvcUdAVKvVHlqUGKhDJBfKg/J kePCGv3wy7RmpXkwAWZw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_060227_406676_FA7D9C45 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 2:11 PM Krzysztof Kozlowski wrote: > > On 14/09/2021 12:13, Maxime Ripard wrote: > > On Tue, Sep 14, 2021 at 12:07:08PM +0200, Krzysztof Kozlowski wrote: > >> On Tue, 14 Sept 2021 at 11:31, Arnd Bergmann wrote: > >>> Some subsystem maintainers want drivers to be selected by the SoC > >>> option, this is why you need the 'select SIFIVE_PLIC', but usually > >>> the drivers are selectable with a 'depends on ARCH_SUNXI || > >>> COMPILE_TEST' and enabled in the defconfig. > >> > >> I would say selecting drivers is even more useful for distros and > >> other downstream users. Especially in the ARM world where we have so > >> many different SoCs - how could a distro person know which driver is > >> necessary, important or useful? Having all main SoC drivers enabled > >> when ARCH_SUNXI=y, helps distro a lot. > > > > Imply, maybe, but select is far too painful for everyone else. > > If we talk about UART driver, then sure - imply makes sense. But if we > talk about core SoC components necessary for boot (e.g. timers, clocks, > pinctrl), then select is appropriate. There is no point to enable > ARCH_XXX without these core components. Please never use 'imply', this is functionally the same as 'default', just the wrong way around, like the infamous 'comefrom' instruction in programming languages ;-) I still prefer using defaults and defconfig files over 'select', but I can see the use of select in some cases, as long as the symbol you are selecting is not already user visible. Arnd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv