From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464E2C433F5 for ; Wed, 27 Apr 2022 17:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243672AbiD0RGj convert rfc822-to-8bit (ORCPT ); Wed, 27 Apr 2022 13:06:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243653AbiD0RGj (ORCPT ); Wed, 27 Apr 2022 13:06:39 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2A52AC7 for ; Wed, 27 Apr 2022 10:03:26 -0700 (PDT) Received: from mail-yb1-f178.google.com ([209.85.219.178]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N1xZX-1nq7oj3HmT-012JYu for ; Wed, 27 Apr 2022 19:03:25 +0200 Received: by mail-yb1-f178.google.com with SMTP id m128so4544004ybm.5 for ; Wed, 27 Apr 2022 10:03:24 -0700 (PDT) X-Gm-Message-State: AOAM533Udz99fILBczTSFM1smauVfoD1cg/wJyscrACCw+wv3DHYxphM woeGX0uaHLxtdLdyDrgGk6HG+zbPEEi0N3zu7sQ= X-Google-Smtp-Source: ABdhPJzLjeye9A9OWhShH76hys3ishcYLuK3veH+wxcTEvEyq9x/yk6faCk7GM7cQVbAcpTgBWV2wb3Zfj0ajrT/jKo= X-Received: by 2002:a81:9213:0:b0:2f6:eaae:d22f with SMTP id j19-20020a819213000000b002f6eaaed22fmr25858625ywg.249.1651075171676; Wed, 27 Apr 2022 08:59:31 -0700 (PDT) MIME-Version: 1.0 References: <9c7ff199d826b60e019c0eeeb6aa280abfdb9a82.1644824638.git.quic_saipraka@quicinc.com> In-Reply-To: <9c7ff199d826b60e019c0eeeb6aa280abfdb9a82.1644824638.git.quic_saipraka@quicinc.com> From: Arnd Bergmann Date: Wed, 27 Apr 2022 17:59:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv10 4/6] drm/meson: Fix overflow implicit truncation warnings To: Sai Prakash Ranjan Cc: Will Deacon , Catalin Marinas , Arnd Bergmann , Steven Rostedt , Marc Zyngier , Trilok Soni , quic_psodagud@quicinc.com, gregkh , Linux ARM , Linux Kernel Mailing List , linux-arm-msm , Neil Armstrong , kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:o4N3DdaOsOCzHWpx/ie91UPxK76+P7YAiY9nx4DtDLTxSnM83R/ xwkhFEgGZYHxYNHKA6FuAjj5x2A9yBBLQuv4JqWWQazmC88gKRyjfrL5u1OR5KGdqW2sBJi LMCNZWvtx3SRwc1vcZIHA1Ardo+MhhM+LKnLoex+lkRVa2LTtYu87NxYp/FXtt5ngGtEugU aXfvxIqw7jp3WBNQZRRrQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:SnOym1iCv0U=:4rohQYe8Or3NngCy5Ue+3H Fss0en8z4zm6pTY5kJ+0Qn7owZCR40xJ8h+0/x2SxB7gr+s5R+MzAu7/p+h3BrE04YWiQA2qu QcKQRSiiJjFI7x6gBm5rJ7RnFJD/if30Y5Pa+T+Kcw962VoPtiPwSchzeP9qtsUmBXqZMmWuy YrzhYDxyWWqhFb0NvTzWJOzPQ2yWEhAEiSmuL25C7HGCiDCiNLRuH4NXQBAlR3ZeCNcYBrAuo ueALXitD2fnNGQBW/Vq8ow/Pt300tw3+u+NvYPJcD/kaG2YpYHWe9Futw0oJXXJc4vqx6iJA9 nOdQNl9hsteiYQMULhXYk/94/DMmhM+6Ac4InU9ULIrAK1fdxJXl2jJFBMroUwal/FBJZfk2a E/mfaixFW3bdNef43L4NeaSa9UeBx2QTeemIPdCpaz0BunoWs5RTZpU1VTvp4WFGHIxsz5/zU j9W8mtieUMmTP4MbVEeyQw4p2DFqwsMvNbI+4ZL1qQjS0IhZ/bSydtTEuX8PQ8gcJHa8bvcRd EcfBUUysB8u21H8Q8xgkNK6PYIbqVnytg4cmzHAdlIevv68WDBcKwaFevrwTOpMEdpodgDGPL MZ9P5RahapfNoe7q7ETfRtP+I8qrhzRKQyXVu9E7vPL1RXfaVr0gk23jSFhT28gKUGdOIfxW2 uYjTdZ9Xl4JRiDaFaGjDaYl4YJXU6jRJTpHzMiBwqv/3bbF4AuETDfjLGKx6XmwgACpXnQ30l Cx8qxMkcLjtnQCnPWQVDtZsnLHg1TokU+0mZeleJ8RCxfRNRboNs1j5xaTbmqfaccZD+RPSxE f+JI1vVNK9PbGqE+uv26DGAxtPynC0mYOBpCxcdEIVT5mLjrwQ= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Feb 24, 2022 at 7:07 AM Sai Prakash Ranjan wrote: > > Fix -Woverflow warnings for drm/meson driver which is a result > of moving arm64 custom MMIO accessor macros to asm-generic function > implementations giving a bonus type-checking now and uncovering these > overflow warnings. > > drivers/gpu/drm/meson/meson_viu.c: In function ‘meson_viu_init’: > drivers/gpu/drm/meson/meson_registers.h:1826:48: error: large integer implicitly truncated to unsigned type [-Werror=overflow] > #define VIU_OSD_BLEND_REORDER(dest, src) ((src) << (dest * 4)) > ^ > drivers/gpu/drm/meson/meson_viu.c:472:18: note: in expansion of macro ‘VIU_OSD_BLEND_REORDER’ > writel_relaxed(VIU_OSD_BLEND_REORDER(0, 1) | > ^~~~~~~~~~~~~~~~~~~~~ > > Cc: Arnd Bergmann > Cc: Neil Armstrong > Reported-by: kernel test robot > Signed-off-by: Sai Prakash Ranjan Reviewed-by: Arnd Bergmann It took me a bit to understand why we got the warning in the first place, but I should have just read the patch description, it's all there.... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E467DC433FE for ; Wed, 27 Apr 2022 16:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zAWuSHewLOncBExS70nOjZ59Ihm693ypbJxnNFExtIE=; b=uBfbGn4OtGNGir 6pS76dHhO9u0tNrvqv/yAiimx8UkO9Goe6mG7rL4nM7UsuKzfExpk36ZltqnMWQgZlJSwnU3HHlM9 +f4h/h/9f1mhjXLM1KnUcLZAt7Ls1WkRtq1PlnBVeVvidizCeW2E5oBQfyndBRdf8832jkHChlwsZ IFzpBYRhx+FB09bCKQR9H1NvfkbH7ZBT3hIUTV8LPoK17A/+zyt2QoAgGYLdo7lFi/gH1yRJIBPgD bTVWxaEFTRUdRFQXQQXnW+VVRY6+nt7BbDz1/Rd4VDaIscIZNwE1YbCsNYhCg1rK6oZr+xMBZlOdH avGkw18WDIVMqV1nQZiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njk7c-0029CL-UP; Wed, 27 Apr 2022 16:02:33 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njk4l-0027x5-It for linux-arm-kernel@lists.infradead.org; Wed, 27 Apr 2022 15:59:38 +0000 Received: from mail-yw1-f175.google.com ([209.85.128.175]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N1Ok1-1nqe6h3kYF-012rXZ for ; Wed, 27 Apr 2022 17:59:33 +0200 Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-2ef5380669cso23892877b3.9 for ; Wed, 27 Apr 2022 08:59:32 -0700 (PDT) X-Gm-Message-State: AOAM532u9WnJiUQOtMfvM+1EP5AMNNBqvQTPvLCEDtiBfoKsumDb00kj XFYOLizI4azF3IqjIPGKsQFD6m4v8KY1VGvW+uk= X-Google-Smtp-Source: ABdhPJzLjeye9A9OWhShH76hys3ishcYLuK3veH+wxcTEvEyq9x/yk6faCk7GM7cQVbAcpTgBWV2wb3Zfj0ajrT/jKo= X-Received: by 2002:a81:9213:0:b0:2f6:eaae:d22f with SMTP id j19-20020a819213000000b002f6eaaed22fmr25858625ywg.249.1651075171676; Wed, 27 Apr 2022 08:59:31 -0700 (PDT) MIME-Version: 1.0 References: <9c7ff199d826b60e019c0eeeb6aa280abfdb9a82.1644824638.git.quic_saipraka@quicinc.com> In-Reply-To: <9c7ff199d826b60e019c0eeeb6aa280abfdb9a82.1644824638.git.quic_saipraka@quicinc.com> From: Arnd Bergmann Date: Wed, 27 Apr 2022 17:59:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv10 4/6] drm/meson: Fix overflow implicit truncation warnings To: Sai Prakash Ranjan Cc: Will Deacon , Catalin Marinas , Arnd Bergmann , Steven Rostedt , Marc Zyngier , Trilok Soni , quic_psodagud@quicinc.com, gregkh , Linux ARM , Linux Kernel Mailing List , linux-arm-msm , Neil Armstrong , kernel test robot X-Provags-ID: V03:K1:IxFxLV4iWrZCT+rg0oNEg+9R1N/60XsFEsLkGui1jNfhKV4j2nn 9eNMDmNIOc2Mxyw8NaHBSHMgEiS6FACyPQwhcoStoA8gb8VyCQOnV8cTcL/Z33rH/FylZU2 sEpyMv9HagSF8q73+7zNI8inf0rCibWDMUk9E/rFi4fKitQbiPo6k6/VJAbc9sYxLhRLdAB SNb7R78tlvfGaSS2Vz09A== X-UI-Out-Filterresults: notjunk:1;V03:K0:uA8dcxkm2PQ=:1Al85wRSZhefSPXOwSvuMS bixqsiCp5t7it9sWqPIX9JyG/f3OSyu9MWP/X69jvO0vd53azT7Y//+PBZuTkcgL7NcqQC1IF VWFV/fU9gExrBlb+Dijngkuqz/2cQLdoK2gZgaZ7uOsFgLcc5tfpHBDkCEUBtVo34ohgemqL6 p0xylpds2R4an3mKOkVXnUFV9aizf9NFNtnR+H815Hykk3PxqPwrjbcEiS/ilxX67DqNF7SDY XpnbJJPyPb94pwVFS+IIvtd2JilFi4e9JolVHaZIJ2kYuQQsrC0RHYot2AoiJQAQNEgxB2KvC eFPhoP5pJmYGv3DnW0LXI4P41Mihq0QFxviLPrSbWGNJleK1PK5IViBtiuUWf7N/EwgguDTCq w8B2oCWI2X0awaRNYqhBiSM5I7gfafyYaVuCah6qrHBhzfSjBlXVtnO48VHvk5igb08v1WmaU /ZXEIEjrVjv3L1VvlG5XyFXljt2YO29glbWsDO3n5mado4rJZn5wBFHuhkKQup0UyIcWAZCZE udGCNuCInJHmXSgsVEriHp1MhugGvqJ//0bLmTzoLhF6Pdc/iGirYC9pV9CJZ07JoU3Gvch7T RDwcHuE7BAa3MsQ6YGvKi5acbdctQ2aJDi5t6otd11inIndYyp9s4Yn9eftFIFUyBKLUnRTdb djvl1l5tCNMfOu/9DlMeZBVKdKu6MFmngmJ+SJouNETY2eQ2eosA/1oGz2Vt4O965nY7Ifc2f tjv4vyXILwyNSBotvTgTC2eksiezYUi9uzLMa67lqiSmkmbvKFPN7AJUoA8GSujEPCIFAp4ts bog2ZsGmIpDDJf0N+SqdCzCisLoFUb2tykttB/3sGwsUUlR2P8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_085935_997299_20870416 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMjQsIDIwMjIgYXQgNzowNyBBTSBTYWkgUHJha2FzaCBSYW5qYW4KPHF1aWNf c2FpcHJha2FAcXVpY2luYy5jb20+IHdyb3RlOgo+Cj4gRml4IC1Xb3ZlcmZsb3cgd2FybmluZ3Mg Zm9yIGRybS9tZXNvbiBkcml2ZXIgd2hpY2ggaXMgYSByZXN1bHQKPiBvZiBtb3ZpbmcgYXJtNjQg Y3VzdG9tIE1NSU8gYWNjZXNzb3IgbWFjcm9zIHRvIGFzbS1nZW5lcmljIGZ1bmN0aW9uCj4gaW1w bGVtZW50YXRpb25zIGdpdmluZyBhIGJvbnVzIHR5cGUtY2hlY2tpbmcgbm93IGFuZCB1bmNvdmVy aW5nIHRoZXNlCj4gb3ZlcmZsb3cgd2FybmluZ3MuCj4KPiBkcml2ZXJzL2dwdS9kcm0vbWVzb24v bWVzb25fdml1LmM6IEluIGZ1bmN0aW9uIOKAmG1lc29uX3ZpdV9pbml04oCZOgo+IGRyaXZlcnMv Z3B1L2RybS9tZXNvbi9tZXNvbl9yZWdpc3RlcnMuaDoxODI2OjQ4OiBlcnJvcjogbGFyZ2UgaW50 ZWdlciBpbXBsaWNpdGx5IHRydW5jYXRlZCB0byB1bnNpZ25lZCB0eXBlIFstV2Vycm9yPW92ZXJm bG93XQo+ICAjZGVmaW5lICBWSVVfT1NEX0JMRU5EX1JFT1JERVIoZGVzdCwgc3JjKSAgICAgICgo c3JjKSA8PCAoZGVzdCAqIDQpKQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF4KPiBkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fdml1LmM6NDcyOjE4 OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYVklVX09TRF9CTEVORF9SRU9SREVS4oCZ Cj4gICAgd3JpdGVsX3JlbGF4ZWQoVklVX09TRF9CTEVORF9SRU9SREVSKDAsIDEpIHwKPiAgICAg ICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn4KPgo+IENjOiBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPgo+IENjOiBOZWlsIEFybXN0cm9uZyA8bmFybXN0cm9uZ0BiYXlsaWJy ZS5jb20+Cj4gUmVwb3J0ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IFNhaSBQcmFrYXNoIFJhbmphbiA8cXVpY19zYWlwcmFrYUBxdWljaW5j LmNvbT4KClJldmlld2VkLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKSXQgdG9v ayBtZSBhIGJpdCB0byB1bmRlcnN0YW5kIHdoeSB3ZSBnb3QgdGhlIHdhcm5pbmcgaW4gdGhlIGZp cnN0IHBsYWNlLCBidXQgSQpzaG91bGQgaGF2ZSBqdXN0IHJlYWQgdGhlIHBhdGNoIGRlc2NyaXB0 aW9uLCBpdCdzIGFsbCB0aGVyZS4uLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK