From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754080AbdIFVlD (ORCPT ); Wed, 6 Sep 2017 17:41:03 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33108 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237AbdIFVlA (ORCPT ); Wed, 6 Sep 2017 17:41:00 -0400 X-Google-Smtp-Source: ADKCNb7H4s7+l/rISQFzjOBdiaTdYzCRWeg3dcK5ASonarURb4Tmp37dkzxg8BemjZrm7qgtavMYilMhThFwVNRp61w= MIME-Version: 1.0 In-Reply-To: References: <20170906135628.3513172-1-arnd@arndb.de> From: Arnd Bergmann Date: Wed, 6 Sep 2017 23:40:59 +0200 X-Google-Sender-Auth: uIAD5d-XkyAyYHQOWDQ95A1HHqs Message-ID: Subject: Re: [Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning To: Karol Herbst Cc: Ben Skeggs , David Airlie , ML nouveau , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 6, 2017 at 10:15 PM, Karol Herbst wrote: > On Wed, Sep 6, 2017 at 10:11 PM, Arnd Bergmann wrote: >>> but with a better name for "denominator". >> >> I don't know what M and P actually are in this function, so I couldn't >> come up with a much better name either, how about simply 'divisor'? >> > > what about "MP"? M and P are simply dividers for the PLL configuration > and there are two of them. I think "P" is the post divider. > Fine with me. That was actually what I initially did after your reply and then changed it to divisor. I've changed it back now and sent the new version. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning Date: Wed, 6 Sep 2017 23:40:59 +0200 Message-ID: References: <20170906135628.3513172-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Karol Herbst Cc: ML nouveau , Ben Skeggs , dri-devel , Linux Kernel Mailing List List-Id: nouveau.vger.kernel.org T24gV2VkLCBTZXAgNiwgMjAxNyBhdCAxMDoxNSBQTSwgS2Fyb2wgSGVyYnN0IDxrYXJvbGhlcmJz dEBnbWFpbC5jb20+IHdyb3RlOgo+IE9uIFdlZCwgU2VwIDYsIDIwMTcgYXQgMTA6MTEgUE0sIEFy bmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+IHdyb3RlOgo+Pj4gYnV0IHdpdGggYSBiZXR0ZXIg bmFtZSBmb3IgImRlbm9taW5hdG9yIi4KPj4KPj4gSSBkb24ndCBrbm93IHdoYXQgTSBhbmQgUCBh Y3R1YWxseSBhcmUgaW4gdGhpcyBmdW5jdGlvbiwgc28gSSBjb3VsZG4ndAo+PiBjb21lIHVwIHdp dGggYSBtdWNoIGJldHRlciBuYW1lIGVpdGhlciwgaG93IGFib3V0IHNpbXBseSAnZGl2aXNvcic/ Cj4+Cj4KPiB3aGF0IGFib3V0ICJNUCI/IE0gYW5kIFAgYXJlIHNpbXBseSBkaXZpZGVycyBmb3Ig dGhlIFBMTCBjb25maWd1cmF0aW9uCj4gYW5kIHRoZXJlIGFyZSB0d28gb2YgdGhlbS4gSSB0aGlu ayAiUCIgaXMgdGhlIHBvc3QgZGl2aWRlci4KPgoKRmluZSB3aXRoIG1lLiBUaGF0IHdhcyBhY3R1 YWxseSB3aGF0IEkgaW5pdGlhbGx5IGRpZCBhZnRlciB5b3VyIHJlcGx5IGFuZAp0aGVuIGNoYW5n ZWQgaXQgdG8gZGl2aXNvci4gSSd2ZSBjaGFuZ2VkIGl0IGJhY2sgbm93IGFuZCBzZW50IHRoZSBu ZXcKdmVyc2lvbi4KCiAgICAgIEFybmQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==