From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751783AbeBVWyZ (ORCPT ); Thu, 22 Feb 2018 17:54:25 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:36765 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbeBVWyY (ORCPT ); Thu, 22 Feb 2018 17:54:24 -0500 X-Google-Smtp-Source: AH8x225mgFBAO5SOeosEXgRWrP5+BALESYh5E7AhmAgbHS9zm5bslQp7aRujt3YNGzgj/usgMG347EBSveRoTqwDlck= MIME-Version: 1.0 In-Reply-To: <878tbkaitz.fsf@anholt.net> References: <20180222162420.2825703-1-arnd@arndb.de> <878tbkaitz.fsf@anholt.net> From: Arnd Bergmann Date: Thu, 22 Feb 2018 23:54:23 +0100 X-Google-Sender-Auth: PuKxXby3PYfgeUMzVc2oFnSYtm8 Message-ID: Subject: Re: [PATCH] drm/p[111: add CONFIG_OF dependency To: Eric Anholt Cc: David Airlie , Linus Walleij , Daniel Vetter , Stephen Boyd , Tom Cooksey , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 22, 2018 at 9:08 PM, Eric Anholt wrote: > Arnd Bergmann writes: > >> We cannot select a symbol without meeting its other dependencies: >> >> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) >> drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': >> drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' >> vga->bridge.of_node = pdev->dev.of_node; >> ^ >> >> Here it seems reasonable to depend on CONFIG_OF, as all platforms >> using this driver already require that anyway. > > Looks like we'll be going with > > https://patchwork.freedesktop.org/patch/205580/ Ok, even better! Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] drm/p[111: add CONFIG_OF dependency Date: Thu, 22 Feb 2018 23:54:23 +0100 Message-ID: References: <20180222162420.2825703-1-arnd@arndb.de> <878tbkaitz.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-x242.google.com (mail-qt0-x242.google.com [IPv6:2607:f8b0:400d:c0d::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9C396ECDD for ; Thu, 22 Feb 2018 22:54:24 +0000 (UTC) Received: by mail-qt0-x242.google.com with SMTP id v90so8432129qte.12 for ; Thu, 22 Feb 2018 14:54:24 -0800 (PST) In-Reply-To: <878tbkaitz.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: David Airlie , Daniel Vetter , Stephen Boyd , Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBGZWIgMjIsIDIwMTggYXQgOTowOCBQTSwgRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0 Lm5ldD4gd3JvdGU6Cj4gQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4gd3JpdGVzOgo+Cj4+ IFdlIGNhbm5vdCBzZWxlY3QgYSBzeW1ib2wgd2l0aG91dCBtZWV0aW5nIGl0cyBvdGhlciBkZXBl bmRlbmNpZXM6Cj4+Cj4+IHdhcm5pbmc6IChEUk1fUEwxMTEpIHNlbGVjdHMgRFJNX0RVTUJfVkdB X0RBQyB3aGljaCBoYXMgdW5tZXQgZGlyZWN0IGRlcGVuZGVuY2llcyAoSEFTX0lPTUVNICYmIERS TSAmJiBEUk1fQlJJREdFICYmIE9GKQo+PiBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R1bWItdmdh LWRhYy5jOiBJbiBmdW5jdGlvbiAnZHVtYl92Z2FfcHJvYmUnOgo+PiBkcml2ZXJzL2dwdS9kcm0v YnJpZGdlL2R1bWItdmdhLWRhYy5jOjIwNzoxMzogZXJyb3I6ICdzdHJ1Y3QgZHJtX2JyaWRnZScg aGFzIG5vIG1lbWJlciBuYW1lZCAnb2Zfbm9kZScKPj4gICB2Z2EtPmJyaWRnZS5vZl9ub2RlID0g cGRldi0+ZGV2Lm9mX25vZGU7Cj4+ICAgICAgICAgICAgICBeCj4+Cj4+IEhlcmUgaXQgc2VlbXMg cmVhc29uYWJsZSB0byBkZXBlbmQgb24gQ09ORklHX09GLCBhcyBhbGwgcGxhdGZvcm1zCj4+IHVz aW5nIHRoaXMgZHJpdmVyIGFscmVhZHkgcmVxdWlyZSB0aGF0IGFueXdheS4KPgo+IExvb2tzIGxp a2Ugd2UnbGwgYmUgZ29pbmcgd2l0aAo+Cj4gaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Au b3JnL3BhdGNoLzIwNTU4MC8KCk9rLCBldmVuIGJldHRlciEKCiAgICAgIEFybmQKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==