From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E923C433DB for ; Thu, 21 Jan 2021 10:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 415AE23433 for ; Thu, 21 Jan 2021 10:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729948AbhAUKtf (ORCPT ); Thu, 21 Jan 2021 05:49:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:34212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729685AbhAUKiC (ORCPT ); Thu, 21 Jan 2021 05:38:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 77A602388E for ; Thu, 21 Jan 2021 10:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611225439; bh=ci+gBdKi/HOnJaSdn0sRtPgN5znIPCb11FcQpwgiqnA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SMFjvTlqUFcxmU+0QM5GuyAcu3EbJltc5C36wOCgFZFcaaUrwF/nZzrlBKwn8OEme QhPsilUdLGyb7OP2T/NXiLHETot8cy5zSggrIpEBUUZOgeBYqTMlJ/FoWJLjbfuo5I 0KBFSbXnI0Z/08yPbsLfCYopp7qLgSeS+OuwRAwXFOgeyjssJz8pdu/fa7zADe5Zhl r1xyWVmA+OXo/P+oiEMyLkWBBIiCZ7U918ofnpASa2D1lboougvfUPpzeyZW0Ht2jO rUyogcJ4zG+hj52D5zR9cq1kWYkkCrDlzFLO0ZWh2wzrRB1a/7jLkjPFKosfPwUtBe H4FMgvPzYNyKw== Received: by mail-oi1-f175.google.com with SMTP id 9so1653613oiq.3 for ; Thu, 21 Jan 2021 02:37:19 -0800 (PST) X-Gm-Message-State: AOAM530h7eC1jLufwfNmH3DyCxKmzQSXPXnmc9Isxv/JTB4bPuC7DhRO yfJmSv5T+hLBfTgVvdT4CQjyaEpnZBwO6WVyHCw= X-Google-Smtp-Source: ABdhPJxD096f6VWzSCPQn9FQQeK430o3v0vGLayqn9O0A/FSik1QfxdtgTjl0jSUwRw5UKQzloBLAq/ZQAEGhQdtB9Y= X-Received: by 2002:aca:be54:: with SMTP id o81mr5434123oif.67.1611225438679; Thu, 21 Jan 2021 02:37:18 -0800 (PST) MIME-Version: 1.0 References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-5-mohamed.mediouni@caramail.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 21 Jan 2021 11:37:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC To: Linus Walleij Cc: Mohamed Mediouni , Mark Rutland , Catalin Marinas , Hector Martin , "linux-kernel@vger.kernel.org" , Marc Zyngier , Will Deacon , Linux ARM , Stan Skowronek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij wrote: > > Hi Mohamed, > > thanks for your patch! > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > wrote: > > > +properties: > > + compatible: > > + items: > > + - const: apple,aic > > However weird it may seem, Apple is not in the file > Documentation/devicetree/bindings/vendor-prefixes.yaml > > (I think it's weird because I remember clearly that they have been > using device tree for PPC since ages.) > > Could you add this 2-liner to that file and send it directly to > DT binding maintainers as a single patch as a preparation? Choosing the vendor prefix here is going to be a little tricky and non-obvious. Background: Traditionally, it should have been the stock ticker symbol of the company (clearly only publicly traded companies would be able to produce a Unix capable computer, right?), but there were already inconsistent: IBM used "ibm" (in small letters), Sun used "SUNW" (in capitals) but in 2007 changed the stock ticker symbol to "JAVA", obviously without changing the firmware bindings. Apple traditionally used "AAPL" (also in caps) in the device tree, and there is one remnant of that in the M1 device tree, in the form of the "AAPL,phandle" property in each node, which corresponds to our "linux,phandle". (phandles were introduced as properties in both of the flattened DT formats, .dtb and apple's own format). There are also "AAPL,unit-string properties and some device_type strings (AAPL,display-crossbar, AAPL,atc-dpxbar, ...) in the M1 DT, and the CPU nodes (and only those) use "apple" in small letters as in "apple,icestorm","ARM,v8". The other nodes tend to not have a vendor prefix, but a lot use a subsystem name as the prefix, such as compatible="gpio,t8101" or compatible="tempsensor,t8020". Since Apple are already using both the "AAPL" and the "apple" prefix themselves, I have a bad feeling about reusing either of them for defining the devicetree.org bindings that we add to linux/Documentation/devicetree/bindings. The question is: if not "apple", what else should we use here? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8DAC433DB for ; Thu, 21 Jan 2021 10:39:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA1362137B for ; Thu, 21 Jan 2021 10:39:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA1362137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yk1TpyLl+mHKdG/cyL+IpYfcggWt2v+MqA32w/v45GA=; b=O7S1ClmKm+gZdE0vuBJoKIgMu gkJhVAzhGwV3OsfGgp9hYLZ2OUuMCf+0/UebhQNbezD3h7H52I3VsCCUPxylGwkZd5M8wCtnGPiGa mmPqh+BiM4RYopILPhX401kkhbcr5DOFRdGQ5UvsUqphXsZVvPG6GduMnYbwgWlSPdAaVFPdhY4Yt sH2CeyKL7vV7Pg2xWY52HIFOdPL980KRtFoO2kDO1MFqaQEwqGS7LmszKRsy4ZT0VXtIuVilWUUrN bdWJnA7O595lkKBmhgDOhcF1Nq+sTzxAx64lakFYsp2uiJtZRJT47jYDP7CzBLU30PV9Zq3cAAlka LvX4TVo4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2XL8-0007WD-7H; Thu, 21 Jan 2021 10:37:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2XL6-0007Vm-Bp for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 10:37:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C3EF233EA for ; Thu, 21 Jan 2021 10:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611225439; bh=ci+gBdKi/HOnJaSdn0sRtPgN5znIPCb11FcQpwgiqnA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SMFjvTlqUFcxmU+0QM5GuyAcu3EbJltc5C36wOCgFZFcaaUrwF/nZzrlBKwn8OEme QhPsilUdLGyb7OP2T/NXiLHETot8cy5zSggrIpEBUUZOgeBYqTMlJ/FoWJLjbfuo5I 0KBFSbXnI0Z/08yPbsLfCYopp7qLgSeS+OuwRAwXFOgeyjssJz8pdu/fa7zADe5Zhl r1xyWVmA+OXo/P+oiEMyLkWBBIiCZ7U918ofnpASa2D1lboougvfUPpzeyZW0Ht2jO rUyogcJ4zG+hj52D5zR9cq1kWYkkCrDlzFLO0ZWh2wzrRB1a/7jLkjPFKosfPwUtBe H4FMgvPzYNyKw== Received: by mail-oi1-f182.google.com with SMTP id h192so1664956oib.1 for ; Thu, 21 Jan 2021 02:37:19 -0800 (PST) X-Gm-Message-State: AOAM5311tkd7SIyoN/F+fh3IZ6kxOGw8wtJkL2NRarMjZv2qJVHgn6CP 7bqcUfbPFA/aK40EaCn8RKDBE3pu8XlV9hjz9oY= X-Google-Smtp-Source: ABdhPJxD096f6VWzSCPQn9FQQeK430o3v0vGLayqn9O0A/FSik1QfxdtgTjl0jSUwRw5UKQzloBLAq/ZQAEGhQdtB9Y= X-Received: by 2002:aca:be54:: with SMTP id o81mr5434123oif.67.1611225438679; Thu, 21 Jan 2021 02:37:18 -0800 (PST) MIME-Version: 1.0 References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-5-mohamed.mediouni@caramail.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 21 Jan 2021 11:37:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC To: Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_053720_572011_46175A70 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Marc Zyngier , Hector Martin , "linux-kernel@vger.kernel.org" , Catalin Marinas , Mohamed Mediouni , Will Deacon , Linux ARM , Stan Skowronek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij wrote: > > Hi Mohamed, > > thanks for your patch! > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > wrote: > > > +properties: > > + compatible: > > + items: > > + - const: apple,aic > > However weird it may seem, Apple is not in the file > Documentation/devicetree/bindings/vendor-prefixes.yaml > > (I think it's weird because I remember clearly that they have been > using device tree for PPC since ages.) > > Could you add this 2-liner to that file and send it directly to > DT binding maintainers as a single patch as a preparation? Choosing the vendor prefix here is going to be a little tricky and non-obvious. Background: Traditionally, it should have been the stock ticker symbol of the company (clearly only publicly traded companies would be able to produce a Unix capable computer, right?), but there were already inconsistent: IBM used "ibm" (in small letters), Sun used "SUNW" (in capitals) but in 2007 changed the stock ticker symbol to "JAVA", obviously without changing the firmware bindings. Apple traditionally used "AAPL" (also in caps) in the device tree, and there is one remnant of that in the M1 device tree, in the form of the "AAPL,phandle" property in each node, which corresponds to our "linux,phandle". (phandles were introduced as properties in both of the flattened DT formats, .dtb and apple's own format). There are also "AAPL,unit-string properties and some device_type strings (AAPL,display-crossbar, AAPL,atc-dpxbar, ...) in the M1 DT, and the CPU nodes (and only those) use "apple" in small letters as in "apple,icestorm","ARM,v8". The other nodes tend to not have a vendor prefix, but a lot use a subsystem name as the prefix, such as compatible="gpio,t8101" or compatible="tempsensor,t8020". Since Apple are already using both the "AAPL" and the "apple" prefix themselves, I have a bad feeling about reusing either of them for defining the devicetree.org bindings that we add to linux/Documentation/devicetree/bindings. The question is: if not "apple", what else should we use here? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel