From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967401AbdJRKMO (ORCPT ); Wed, 18 Oct 2017 06:12:14 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:48384 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755520AbdJRKML (ORCPT ); Wed, 18 Oct 2017 06:12:11 -0400 X-Google-Smtp-Source: ABhQp+Rzh8si0iOwHg7w8yAs4CEEPN++c8kOzsNlmb1D60pTBR3IOs3Y3E2C9igVb9LfwUax5S3iFds5J/GVPF65yns= MIME-Version: 1.0 In-Reply-To: <1508292283-140003-1-git-send-email-keescook@chromium.org> References: <1508292283-140003-1-git-send-email-keescook@chromium.org> From: Arnd Bergmann Date: Wed, 18 Oct 2017 12:12:10 +0200 X-Google-Sender-Auth: tEI93vms_31ensJk6xAWCZIOyHo Message-ID: Subject: Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call() To: Kees Cook Cc: Jessica Yu , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 4:04 AM, Kees Cook wrote: > (re-sending to Jessica's @korg address...) > > The module_param_call() macro was explicitly casting the .set and .get > function prototypes away with (void *). This can lead to hard-to-find > type mismatches. Additionally, it creates problems for static checkers > and Control Flow Itegrity compiler features, which depend on clustering > function call sites based on prototype signature. > > This removes the casts and fixes all the incorrect prototypes tree-wide. I've applied the patch to my randconfig test setup, will let you know if I find any regressions today. I did notice that patch 2 has a conflict against the ipmi driver, I had to manuall port that one part. Splitting up patch 2 would help there, but complicates other things. Arnd