From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E46C433E0 for ; Wed, 8 Jul 2020 20:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D83542063A for ; Wed, 8 Jul 2020 20:38:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbgGHUi1 (ORCPT ); Wed, 8 Jul 2020 16:38:27 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:54779 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgGHUi1 (ORCPT ); Wed, 8 Jul 2020 16:38:27 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MXpM2-1kPCu53p3E-00YBdb for ; Wed, 08 Jul 2020 22:38:26 +0200 Received: by mail-qt1-f170.google.com with SMTP id g13so35637209qtv.8 for ; Wed, 08 Jul 2020 13:38:25 -0700 (PDT) X-Gm-Message-State: AOAM532w0UeP0WwBpw/zrbmSv7F14jdVTJTTiUunqsEMm2gFejB7kl/i DvlUrvrOyEnhQ04zJQLF0tWJ6uASNymNlEtyW6I= X-Google-Smtp-Source: ABdhPJz68h0QI29GgcNujCOHJJRLRxCryNllMMt7XOrct3Fz9NvPE7S9FBlPpZcCU/WKTQVPVEde++p5gb0kEQ7QGxY= X-Received: by 2002:ac8:7587:: with SMTP id s7mr62150452qtq.304.1594240704805; Wed, 08 Jul 2020 13:38:24 -0700 (PDT) MIME-Version: 1.0 References: <20200708122248.52771-1-cristian.marussi@arm.com> <20200708122248.52771-3-cristian.marussi@arm.com> In-Reply-To: <20200708122248.52771-3-cristian.marussi@arm.com> From: Arnd Bergmann Date: Wed, 8 Jul 2020 22:38:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing To: Cristian Marussi Cc: "linux-kernel@vger.kernel.org" , Linux ARM , Sudeep Holla Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:xKvUOf6eoq16hD9HbdtXx1MDQmDNpfPUg3XZB6jOB6YCnvdToTt QtUFHLSdMAfwP+er5U+PyHE03lA7JTdaTwvyAdyOLc/27eEwZHcf8EbV3uXM/61OBMXJ2h5 htoslGBKrKfiQvHC/wT/3VQoN3GFGcAyTG0iIictrxp1UdalWpPkO8JhtF6e/L0swZcaCge 4FvOhJaFCctEwyE0OEafQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:igD6fevkCF8=:4zr/6OYLQ0wUYpU54A1GTn 8TnLo7h8MrJwfV0Rffv7t0A2Hl3hC3s8l58EyzKgNRxJyO+Cz0HhbEWg/V0yyxkReo6p+nhK+ WawDLBHF0jKiXEvkuD+6IjpwbXBFssJ9kfM0PoPCNRiZACEZdLE+HknLXOCwnbOm6WdZ7qX8z Y3ZuH1rkcq9xVX6hmViCbMvfWc6nFpL/PNOay4MTOC5O0iFWGx/xs64ugukWoBExJoq9d9Et4 jzeFP62/HQbUaZvBCYk4lBCuPvXrcUf2qLiDaB6gXPhxdOBKSBWzNTKJp7exCNhUTv5lE3E3K zLmQ9x3bzrLQ1+ljkgvRRZ9mPmd3H6lKy5FsEFWIefz+7imz+Ydnxwu6vAGv95/J0QR66XmuV pkVNfeNlZYYWERdPMHJAA9OQ77ALvU8/wvZ3Rza9Ta/U3myuDxIOPZORerWVAeBGHqfm/X4/C gR4goAktl7mJKzCR7gHVLguCOyi3rJSM7UwXMvmYWavsqVeFDZUveMOsugrl8Gj2JHpJwwJrv MisEcJQqmaGxwXwE4wwe5AWK0ByqSm2he7zDD5jwiasfsNrs20QIOQO1ZJzVB6JP+rk1SkSDj Ku4gBU7y8lwAck+7RuTDlEjIla5SqTSrHSYPV6t1v9NdLefY7VyxQp7XXBppn4ONi+1VOIFev lE7uyrZiR1QPxchcxCvnykP05wHGYa1mVuQSKll0iELjQfNZ2Yq5VQ2LoPP+wEqznKuYO31wG jML1sGfZ4FUVh8PB2dv/hxc6tDJ0euwCkelRmyxasiLqjLRGQ/E081DJm71slv1HFITCQcCta Idoa+EjqRsKfF58XZXaZj6yBO195ZBWrDlpwl5z+K72VbjatqUDawt8rufKk3fosVavcqKR Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 8, 2020 at 2:24 PM Cristian Marussi wrote: > > Drop size_t in favour of fixed size u32 for consistency and shuffle > around fields definitions to minimize implicit padding. > > Signed-off-by: Cristian Marussi As you still have implicit padding at the end, I'd either make that explicit now, or leave the __packed attribute. The payld_sz is not actually force to be misaligned with the reordered layout, which is what's most important. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7766C433DF for ; Wed, 8 Jul 2020 20:39:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C3FC2063A for ; Wed, 8 Jul 2020 20:39:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dlwBPyYc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C3FC2063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yJUQ4DUqi54eIgaPJSLqVrJ36j5e6LwWsBULHYDYkD8=; b=dlwBPyYc5U20dJiMkjNyDCpEx gG7jaTOYuAod1uc0ZMbU/25kU3xF7jJ8uxahhcgJbIBhezJrm46MWsHbVldNYdg/XYTnv/VPkNm7z Dh8Yhuy6dfs13TTYwJ34G317mEKdS9tq5jHaYevOu2qU3a3WJ3K/UM4NzH9PR3evUqQYRMNlMxwiF B40f0En+urpiljPitO1QHVwFL8/YOL8lAZVwdhzqrklfh0mnVPDBmNmuvL7YAvIawJvb8M97YLJEG yJU8hDqtur9nbZvcIpWecVBp9yVj6u35UkKlj5vmiS3ntEe/6LK/+eoJJ0S5o5wn4VAnJa31cEipN DwtXvJkww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtGpv-0000f3-91; Wed, 08 Jul 2020 20:38:35 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtGpt-0000dN-5o for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 20:38:34 +0000 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MZAvp-1kOOcX0xMn-00VAnD for ; Wed, 08 Jul 2020 22:38:28 +0200 Received: by mail-qt1-f171.google.com with SMTP id u12so35626893qth.12 for ; Wed, 08 Jul 2020 13:38:25 -0700 (PDT) X-Gm-Message-State: AOAM530HSAh0Qv51tkgKX9H7zIbiNxYVifd64z4Cw/Sq+Xi7na6nqwR2 7O/XLJACIBruBxuaBC/sTnnwizzSigJ5D5WT7ag= X-Google-Smtp-Source: ABdhPJz68h0QI29GgcNujCOHJJRLRxCryNllMMt7XOrct3Fz9NvPE7S9FBlPpZcCU/WKTQVPVEde++p5gb0kEQ7QGxY= X-Received: by 2002:ac8:7587:: with SMTP id s7mr62150452qtq.304.1594240704805; Wed, 08 Jul 2020 13:38:24 -0700 (PDT) MIME-Version: 1.0 References: <20200708122248.52771-1-cristian.marussi@arm.com> <20200708122248.52771-3-cristian.marussi@arm.com> In-Reply-To: <20200708122248.52771-3-cristian.marussi@arm.com> From: Arnd Bergmann Date: Wed, 8 Jul 2020 22:38:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing To: Cristian Marussi X-Provags-ID: V03:K1:0qMANfLX4A89zwhTvalaU1Mwe5Q9ZOaDIlCkWKA+Ntf4HBV1C/e J5AkATg2K+JhwXa1FxT4AHN53dvnDndITzzTRjNmRu4NWK7N76lVRfSb1efWbSNMmtH+Q37 D6Xnsf6Q2qxKk3wJAhn+keD+Wm4IL+BxNBF8sWVoJpDNzeXHtqLzmghVhB7ZHniZ/KWT7k0 EIby8EDgTZc5TEsIl4YJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:yXOPS4YSyQk=:JLwQnktsiHx08hAGXXHdwt XquPuwLOh3DOLV6HDFdEo7tiabH+bP96GAyMS/Arar7+CWFnac+YE2dZMlr7z5GDGxA6uEBpZ i9zZTgY0am96rG28wSi0ow4s0KYBjcNAUOI4nkU3QgMESsGtsWKB+JN7MeiUuSYQXJcDMvkKm J84hHAdJ8aJY4K0Hey4H9cd94ZODhrrxi9tl/aYPteKHaeOXrVQqIUGgNQ2XGfK4vgKtdLTa5 SeXKd0GXpVebD9ZBsTgHQq8nKrslduxm1SZRzJbCzM+CLET85OjT8g+Ohbgz7EkrkAprmoPln IajK7naqdFmQQoNCZchgCuW5EQ33QPKgAvB+eaWCZsDwv51aRqN1+P4E3VDRo6wUMjX1TEe68 h1L/sIBO5L1Dc63kI6029fqdvvMhN05E+lVfpGm6crWvlqwVowD8mRs93bgOchMQ/bzopL2qv 1c6eb8U/j52+8riIOI5/vs8v/GcpevC0eHmdS9mCr3v1u/yy5bTinOf6vUjoYbFgvIKi1ajPw pRaWBp7XtCGJWlIfccPPXNKEFWLjCr/j3KCZmRSlTgB9EtKxuSaZlYPBu+FCe69WfZDgtfAUC MX2DC1h6GTJAi/y1sTF66gAwoyBWUFmu2RtaDvYAUey5yCZ+L/oDPL62REIknqIO/Gsbg6hj8 VTKg0QNftMX4eCi8ytsTr+yfjixR4QGzDxlP36ecNsCaadshAkiMcoyXpDlambOnVk3jHm3K8 /Og+aWkLS5puepoQUErPp1/HOFdpqM0oGvXS03O8e6nU2n51NszR5p73eEZP2JslBj3ZaSoOf cR5bsPtlyvgjFS6g+Mz3ApB297DpXOd9YVCW6YVYKMVVA1PYgnPdaiVVQoHKbeuSSXbG5Q4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_163833_448658_929F0184 X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Linux ARM , Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 8, 2020 at 2:24 PM Cristian Marussi wrote: > > Drop size_t in favour of fixed size u32 for consistency and shuffle > around fields definitions to minimize implicit padding. > > Signed-off-by: Cristian Marussi As you still have implicit padding at the end, I'd either make that explicit now, or leave the __packed attribute. The payld_sz is not actually force to be misaligned with the reordered layout, which is what's most important. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel