From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751199AbdBWINp (ORCPT ); Thu, 23 Feb 2017 03:13:45 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:36609 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbdBWINo (ORCPT ); Thu, 23 Feb 2017 03:13:44 -0500 MIME-Version: 1.0 In-Reply-To: <1487829507.2961.5.camel@intel.com> References: <1487156981-4550-1-git-send-email-user@thloh-VirtualBox> <20170215171732.GA4548@kroah.com> <1487829507.2961.5.camel@intel.com> From: Arnd Bergmann Date: Thu, 23 Feb 2017 09:05:43 +0100 X-Google-Sender-Auth: WieQIj9YRwRXTxQVjzKCWDTOntY Message-ID: Subject: Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver To: "Loh, Tien Hock" Cc: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "Nguyen, Dinh" , "thloh85@gmail.com" , "Gerlach, Matthew" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock wrote: > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: >> On Wed, Feb 15, 2017 at 6:17 PM, Greg KH >> wrote: >> > >> > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: >> > > >> > > From: "Loh, Tien Hock" >> > > >> > > This patch is to add Altera System ID driver. >> > > User can obtain the system ID and timestamp of the system by >> > > reading the sysfs entry. >> > > >> > > Usage: >> > > cat /sys/bus/platform/devices/[addr].sysid/sysid/id >> > > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp >> > If you add new sysfs attributes, you need to also add a >> > Documentation/ABI/ description as well. >> >> Maybe we could pretend that this is for a SoC and use the standard >> soc_device >> attributes as well as moving the driver into drivers/soc/?> Sorry for the late reply. > > This driver can currently be used by ARM and Nios II, so moving it into > drivers/soc might not be the best idea. Why not? drivers/soc/ was specifically introduced for stuff that is used on some SoC but across more than one architecture (otherwise it would be in arch/foo/). This seems to fit perfectly. Arnd