From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FC70C433EF for ; Tue, 8 Feb 2022 12:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G2YVA1rdpbXmli8N1/yQ1ZfgQt3Jp+Ef03jqEtFXxYU=; b=yXZIPbG5VSVWAz 2JhJO5RdnWI9cS1AqqbHH4PQkK7ZIvSrhBP+tRJWJv2La8ZEvkbCCweLQdVxr/Bp80uR2pDKZn0Sf K0nzLlE1wDdhzyL5Gwx+6Lo/zDgNUttntBseS/6kpBAmGwPyV31FDsOoTiv+NOHOJtaKuOl/P1KlF L8XJsNqjG/36Mb6K+MpIAD6X+tECtWQWEf9U4Pi1P8JMytigbWBAWvg1sPO22/fU/2UwJKFdqAyOx cWOuwkhsiTQG5tBu3aXh4hPS30f5zNfO3LTPIbvg1qGKKpOSN+sMURM0nIBntE6mjt94UhqA3VLh+ FjrS7RvcQeFm+HVLXzTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHPed-00DkfD-NA; Tue, 08 Feb 2022 12:31:31 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHPeZ-00Dke0-NB; Tue, 08 Feb 2022 12:31:29 +0000 Received: from mail-wr1-f46.google.com ([209.85.221.46]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M9npT-1nND4b40kH-005n6B; Tue, 08 Feb 2022 13:31:25 +0100 Received: by mail-wr1-f46.google.com with SMTP id e3so16494372wra.0; Tue, 08 Feb 2022 04:31:24 -0800 (PST) X-Gm-Message-State: AOAM530gq3cWPH0sBTzK7nd1s2j8284lPQ2RpdcY1+8yna+DzKJfunHS JFmrnNruI90lnZbr5InzuuZM7bcYyNuO55EapCE= X-Google-Smtp-Source: ABdhPJwjh+iPDutKVoomV+unhCPIxYaBfo3+/C6V9s9/YsnzEY7RKbIpI3TmFrilYu/3zyKr/YPI7OskgWVLlPCf7Is= X-Received: by 2002:a05:6000:3c6:: with SMTP id b6mr3354375wrg.12.1644323484543; Tue, 08 Feb 2022 04:31:24 -0800 (PST) MIME-Version: 1.0 References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <042a2183-3f04-088c-1861-656de870337d@gmail.com> In-Reply-To: <042a2183-3f04-088c-1861-656de870337d@gmail.com> From: Arnd Bergmann Date: Tue, 8 Feb 2022 13:31:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Sergei Shtylyov Cc: Geert Uytterhoeven , Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel , Linux ARM , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Linux-sh list X-Provags-ID: V03:K1:zZhEbIB/B6xYhcY4mgLVSfIPs3JAALkvqCEheup4OZyFP2cGQvn MmCXeNCAvqQxHqPov1VZy6UEJq3unW8nfgMrALD4lQsO/mHT6gtkew5rE8UZ1QCfdLeY3ls aY1d317nC04catimrNh2A2vwxobAKyDzhH+TTOy8BY1Upto3kNQj9SRi2Spy6U7AjPyokwm af8SnkhlJOMOgsjDcM7IQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:xz5ewlpMqaM=:Oe7whcVNvmkBCTeCKs0ukB xUg6QEG1NP3iYuHc1iXRohCXxoJOnpSBEo6Y+AL0o5714II2tYys9Il+zu40QmLk7pU0YMEHO 4+gJJI7KhnVlGab+mRFtT0EK0xPGzk0vfpd91rXxaCq2/bqBzTI4G4MkzqoTjnLmKt8eCk0Po CRk5eZ+ljoZgUGaobRv5qYJf4M7oO4VN1duirqMUREatTjjESlecVh0QBHF4hLte8Z6552ega JuvJIUUTRRdHscoQC8BUmU5W5O9tKRw+hqPGuNBXYlu2dGe06WyEglSIHNg1BoW0mQym1OJax bCauGMzs7nu4ToDOB4g1hKbTUq4clYbvo4eaaR42gvTotjADRfBVlvr2JAxHcUsnRGDo3CoUW 2z6RC1mc6fbhLI+QBva4iyXOtR7mrtnsKCPA5eMf0EWubPKLLxOAf22klg+n+kkRgrZl83X6Y xPBLJ0gpWQF5Pb+J+tEaWtGw8XYiJyQBs5jpSvMdrqQLOqPH+UjktQ70rkHbYUdLWDA64YlO5 LMG2eQoCpd9RDkj8prxVc2L7pSqz+muvPB9s8Vyua1j0zIwdWXFq+77P742SztHXxpPME27G5 vGqYZ1dRFFzUfbXiMcuRmALLLQxeX9KIlbC2BUFyPUZgm67c1vLI0M+MDGiRage0eT7iT2oQv jZIBsyRTBSZQPISI1zDDzyBvufPrUHTNUdlIp4qyvtLLajMfPDL+EsCSHJ4GI2Bd1KEw= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_043128_070994_3DC48C7F X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 20, 2021 at 12:53 PM Sergei Shtylyov wrote: > On 20.12.2021 13:17, Geert Uytterhoeven wrote: > > > I might have missed something, but it seems the only user of IRQ 0 on > > SuperH is smsc911x Ethernet in arch/sh/boards/board-apsh4a3a.c and > > arch/sh/boards/board-apsh4ad0a.c, which use evt2irq(0x200). > > These should have been seeing the "0 is an invalid IRQ number" > > warning splat since it was introduced in commit a85a6c86c25be2d2 > > ("driver core: platform: Clarify that IRQ 0 is invalid"). Or not: > > Warning or no warning, 0 is still returned. :-/ > My attempt to put an end to this has stuck waiting a review from the IRQ > people... I had another look at this after you asked about it on IRC. I don't know much SH assembly, but I suspect IRQ 0 has not been delivered since 2009 after 1e1030dccb10 ("sh: nmi_debug support."). On a related note, CONFIG_INTC_BALANCING was broken in 2be6bb0c79c7 ("sh: intc: Split up the INTC code.") by inadvertently removing the Kconfig symbol. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A97C4707E for ; Tue, 8 Feb 2022 13:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350103AbiBHNQK (ORCPT ); Tue, 8 Feb 2022 08:16:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347086AbiBHMgh (ORCPT ); Tue, 8 Feb 2022 07:36:37 -0500 X-Greylist: delayed 306 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 08 Feb 2022 04:36:32 PST Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A163CC03FEC0; Tue, 8 Feb 2022 04:36:32 -0800 (PST) Received: from mail-wr1-f54.google.com ([209.85.221.54]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MeCd5-1nrZkY0I59-00bKxJ; Tue, 08 Feb 2022 13:31:25 +0100 Received: by mail-wr1-f54.google.com with SMTP id i15so8045233wrb.3; Tue, 08 Feb 2022 04:31:24 -0800 (PST) X-Gm-Message-State: AOAM533fnZdpP2AwchPqGk1Dbv8V5VnCruO3LQjkRqZX4uJOuWdES+Ae x3QtpAS4A7jKgoPGlnzmPhCQkD0GVWPC5FFv6is= X-Google-Smtp-Source: ABdhPJwjh+iPDutKVoomV+unhCPIxYaBfo3+/C6V9s9/YsnzEY7RKbIpI3TmFrilYu/3zyKr/YPI7OskgWVLlPCf7Is= X-Received: by 2002:a05:6000:3c6:: with SMTP id b6mr3354375wrg.12.1644323484543; Tue, 08 Feb 2022 04:31:24 -0800 (PST) MIME-Version: 1.0 References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <042a2183-3f04-088c-1861-656de870337d@gmail.com> In-Reply-To: <042a2183-3f04-088c-1861-656de870337d@gmail.com> From: Arnd Bergmann Date: Tue, 8 Feb 2022 13:31:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Sergei Shtylyov Cc: Geert Uytterhoeven , Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel , Linux ARM , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Linux-sh list Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:OW1Lh6CTJ007cKq7X22hpR29N5b9uv6n+9VwIxZK1DM7wwzUNob vPVIWoa3wrrTa/U0a+QDJvjUjmfBvH3QI+oUIxVpqyP5XAbeqLNhIGhbj6/jF6RwHTnt3sW gkYhtJcZvLODUNSzoR9lWTr31flYOPvSjfokiNaC0uwvG+OAhqdc8QiBX8K2YRCPEY4TPd0 58TB51npdbZ5KDSlCb25w== X-UI-Out-Filterresults: notjunk:1;V03:K0:vRHoiAS8jqE=:xYejVhw5wpobxIC1gYyBRA ER0znej4HBEw1Xan1dD8GNvpukMTiBKmAhJZqtdaCfgufrI7t8ysgoFyUWZqDhOprip2wqSl5 3Sj+7aeKCCG2VmGAG228oo5CzSp6w9owFrYIR1Cfk8dfSnZMIeeu3hHXLX5KupFMNtBRsoYPJ fK0L1pNx/QldLHdYdBUnfcBOKNApG06EKAhlly3up/4D/S9ddjr0/BCCV0e95sTqemx4OB++F 5jV6XMX4djyYwKap9lYRtXAiqZaUr559nSX/QpTSnshKSBKiQzZhRkCYOwdOTj1d+xWsDM/By X5b6UxwCo7oxQMwNuY6g9NeK4+1aspGYDepcCKWcbo7AwkuE9bdmSzrUr+63RADdBB8Q83huk j/sYeD0v0sYFrWnGrYtkCiXUi1rbF+GRm0rwYws/XMKd4Y7yYTdvGvDZjY6fzyEW4JToBkkI2 erQ5/AtuIPr5xuIJPwIJT18sH6PhAA8PX3KhEOX6N2SBOiJuDOu74J0LfGz2o6zydulbvWX/k xJlVrD25cfMXmRh31e2tAbKiKsR6W/hK2lobL5GP+Jz7L6GhnJ+jpzqgtarjv4xCCBzlSXoLR YFzkEMWgBiLXlD/ZG4/PXRPZ7tkuTLjFmmLilbvlFejOGOd2o4SYJQRSnPSxHACJMmwvT0spo ClCbn9S3zbEHHajGzZZuZeyzDvYtyhPnVHz9IsO+MzhGTuz7Jm4qd01qE3cmYQnSclcSMyjfq QlysV+lrVSTDfKETnhveMZpRVZcmBYWUwciuQHGQkJaDP/ZouMgKE8Zh1PzXlIaH2cYK8c6ts tqsCSQpWReHj+OBbNCb2dWs8wOB8H+dNosmOpt4QbZwKKhwFqE= Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Mon, Dec 20, 2021 at 12:53 PM Sergei Shtylyov wrote: > On 20.12.2021 13:17, Geert Uytterhoeven wrote: > > > I might have missed something, but it seems the only user of IRQ 0 on > > SuperH is smsc911x Ethernet in arch/sh/boards/board-apsh4a3a.c and > > arch/sh/boards/board-apsh4ad0a.c, which use evt2irq(0x200). > > These should have been seeing the "0 is an invalid IRQ number" > > warning splat since it was introduced in commit a85a6c86c25be2d2 > > ("driver core: platform: Clarify that IRQ 0 is invalid"). Or not: > > Warning or no warning, 0 is still returned. :-/ > My attempt to put an end to this has stuck waiting a review from the IRQ > people... I had another look at this after you asked about it on IRC. I don't know much SH assembly, but I suspect IRQ 0 has not been delivered since 2009 after 1e1030dccb10 ("sh: nmi_debug support."). On a related note, CONFIG_INTC_BALANCING was broken in 2be6bb0c79c7 ("sh: intc: Split up the INTC code.") by inadvertently removing the Kconfig symbol. Arnd